githubris 0.0.4 → 0.0.5

data/spec/githubris/gist_spec.rb

@@ -1,92 +1,37 @@
 require 'spec_helper'
 
 describe Githubris::Gist do
+  let(:id) { 1 }
+  subject { described_class.new :id => id }
 
-  context 'when passed a specific gist' do
-    subject { Githubris::Gist.new gist_attributes }
-    let(:gist_attributes) { Githubris::Builder.new.build gist_data }
-    let(:gist_data) { Githubris::SpecHelper.gist_data }
+  context 'on a gist with an id' do
+    use_vcr_cassette
 
-
-    it 'is public' do
-      subject.should be_public
-    end
-
-    its(:id) { should eql 1 }
-
-    its(:description) { should eql 'the meaning of gist' }
-
-    it 'was created at 6:17:13 on July 15, 2008' do
-      subject.created_at.should eql DateTime.new(2008, 7, 15, 18, 17, 13)
-    end
-
-    it 'was updated at 2:58:22 on Feburary 22, 2011' do
-      subject.updated_at.should eql DateTime.new(2011, 2, 22, 2, 58, 22)
-    end
-
-    its(:url)         { should be_kind_of URI }
-    its(:id)          { should be_instance_of Fixnum }
-    its(:description) { should be_instance_of String }
-    it                { should be_public }
-    its(:created_at)  { should be_instance_of DateTime }
-    its(:updated_at)  { should be_instance_of DateTime }
-    its(:comments)    { should be_instance_of Array }
-    its(:files)       { should be_instance_of Array }
-
-  end
-
-  it 'new gists are created now' do
-    DateTime.stub(:now => DateTime.new(2012))
-    subject.created_at.should eql DateTime.now
-  end
-
-  context 'Gist owned by Isaac' do
-    subject { Githubris::Gist.new :user => user }
-    let(:user) { Githubris::User.new }
-    its(:user) { should eql user }
-  end
-
-  describe 'a gist without files' do
-    subject { Githubris::Gist.new }
-    its(:files) { should be_empty }
-  end
-
-  describe 'a gist created with a file' do
-    subject do
-      Githubris::Gist.new(:files => {:stub => stub})
-    end
-
-    its(:files) { should have(1).items }
-  end
-
-  describe '#==' do
-    it 'checks the attributes of each object' do
-      subject.should == Githubris::Gist.new
-      subject.should_not == stub
+    describe '#reload' do
+      it 'returns the same object' do
+        obj_id = subject.object_id
+        subject.reload.object_id.should == obj_id
+      end
     end
   end
 
-  describe '#reload' do
+  context 'given a gist full of data' do
+    use_vcr_cassette
 
-    it 'errors without an id' do
-      lambda do
+    describe '#user' do
+      it 'returns a user' do
         subject.reload
-      end.should raise_error
+        subject.user.should be_instance_of Githubris::User
+      end
     end
+  end
 
-    context 'on a gist with an id' do
-      subject { Githubris::Gist.new :id => id }
-      let(:id) { 1 }
-
-      it 'hits the API' do
-        Githubris::API.any_instance.should_receive(:get_gist).with(id)
-        subject.reload
-      end
+  describe '#save' do
+    use_vcr_cassette
 
-      it 'returns the same object' do
-        obj_id = subject.object_id
-        subject.reload.object_id.should == obj_id
-      end
+    it 'it must have be public or not, and it must have files' do
+      gist = described_class.new :public => true, :files => {'gistfile.txt' => {:content => 'foobar'}}
+      lambda { gist.save }.should_not raise_error
     end
   end
 end

data/spec/githubris/oauth_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+
+describe Githubris::OAuth do
+  let(:oauth) { described_class.new(client_id, client_secret) }
+  let(:client_id) { 'client_id' }
+  let(:client_secret) { 'client_secret' }
+
+  before do
+    access_token_response =<<-RESPONSE
+HTTP/1.1 200 OK
+Server: nginx/1.0.13
+Date: Wed, 21 Mar 2012 12:54:41 GMT
+Content-Type: application/x-www-form-urlencoded; charset=utf-8
+Connection: keep-alive
+Status: 200 OK
+ETag: "fa6a87d35864200004d1eff50d685301"
+X-Frame-Options: deny
+X-Runtime: 14
+Content-Length: 71
+Cache-Control: private, max-age=0, must-revalidate
+Strict-Transport-Security: max-age=2592000
+
+access_token=ACCESSCODE&token_type=bearer
+RESPONSE
+    FakeWeb.register_uri(:post, /github.com\/login\/oauth\/access_token/, :response => access_token_response)
+  end
+
+  after do
+    FakeWeb.clean_registry
+  end
+
+  describe '#initialize' do
+    it 'requires a client_id and a client_secret' do
+      lambda do
+        described_class.new(client_id, client_secret)
+      end.should_not raise_error
+    end
+  end
+
+  describe '#request_access_url' do
+    subject { oauth.request_access_url }
+    let(:request_access_url_pattern) do
+      /https:\/\/github.com\/login\/oauth\/authorize\?.*client_id=#{client_id}/
+    end
+
+    it { should match request_access_url_pattern }
+
+    it 'takes a list of scopes and a redirect_uri, optionally' do
+      redirect_uri = 'https://isaacbfsanders.com'
+      url = oauth.request_access_url(:scopes => [:user, :public_repo, :repo, :gist],
+                                     :redirect_uri => redirect_uri)
+      url.should match request_access_url_pattern
+      url.should match /scopes=user,public_repo,repo,gist/
+      url.should match /redirect_uri=#{URI.encode(redirect_uri)}/
+    end
+  end
+
+  describe '#access_token' do
+    use_vcr_cassette
+
+    it 'requires a code parameter' do
+      lambda do
+        oauth.access_token('code')
+      end.should_not raise_error
+    end
+
+    it 'returns a string' do
+      oauth.access_token('code').should be_kind_of String
+    end
+  end
+end

data/spec/githubris/publicity_spec.rb

@@ -0,0 +1,22 @@
+
+describe Githubris::Publicity do
+  subject do
+    Githubris::Base.new(:public => true).extend Githubris::Publicity
+  end
+
+  it                { should be_public }
+
+  describe '#publicize' do
+    it 'makes the gist public' do
+      subject.publicize
+      subject.should be_public
+    end
+  end
+
+  describe '#privatize' do
+    it 'makes the gist private' do
+      subject.privatize
+      subject.should_not be_public
+    end
+  end
+end

data/spec/githubris/user_spec.rb

@@ -1,24 +1,61 @@
 require 'spec_helper'
 
 describe Githubris::User do
-  it 'is initialized with an attributes hash' do
-    attributes = {foo: 'bar'}
-    lambda { Githubris::User.new attributes }.should_not raise_error
+  describe '#gists' do
+    use_vcr_cassette
+
+    it 'gets a list of gists' do
+      gists = described_class.new(:login => 'GithubrisTestUser').gists
+      gists.each do |gist|
+        gist.should be_instance_of Githubris::Gist
+      end
+    end
   end
 
-  describe '#public_gists' do
-    it 'hits the API' do
-      Githubris::API.any_instance.should_receive(:get_user_public_gists)
-      user = Githubris::User.new
-      user.public_gists
+  describe '#starred_gists' do
+
+    context 'on an authenticated user' do
+
+      subject do
+        ghr = Githubris.new
+        ghr.basic_auth 'GithubrisTestUser', 'password'
+        VCR.use_cassette 'Githubris_API/_authenticated_/when_authenticated_with_good_credentials' do
+          ghr.authenticated_user
+        end
+      end
+
+      use_vcr_cassette
+
+      it 'returns a list of starred gists' do
+        subject.starred_gists.each do |gist|
+          gist.should be_instance_of Githubris::Gist
+        end
+      end
     end
   end
 
-  describe '#==' do
-    it 'matches based on attributes' do
-      user1 = Githubris::User.new({foo: 'bar'})
-      user2 = Githubris::User.new({foo: 'bar'})
-      user1.should == user2
+  describe '#reload' do
+
+    context 'on a user with a login' do
+      use_vcr_cassette
+
+      subject { described_class.new :login => login }
+      let(:login) { 'GithubrisTestUser' }
+
+      it 'returns the same object' do
+        obj_id = subject.object_id
+        subject.reload.object_id.should == obj_id
+      end
+    end
+
+    context 'on a user without a login' do
+      use_vcr_cassette
+
+      it 'raises an error' do
+        lambda do
+          subject.reload
+        end.should raise_error Githubris::Error::NotFound
+      end
     end
   end
 end

data/spec/githubris_spec.rb

@@ -1,78 +1,72 @@
 require 'spec_helper'
 
 describe Githubris do
-  describe '#authenticate' do
-    before do
-      Githubris::API.stub(:basic_auth => Githubris::User.new)
-      subject.authenticate('username', 'password')
+  describe '#basic_auth' do
+    let(:password) { 'password' }
+
+    context 'with valid credentials' do
+      let(:username) { 'GithubrisTestUser' }
+
+      it 'authenticates via the API' do
+        Githubris::API.any_instance.should_receive(:basic_auth).with(username, password)
+        subject.basic_auth(username, password)
+      end
     end
+  end
+
+  describe '#oauth' do
+    let(:client_id) { 'client_id' }
+    let(:client_secret) { 'client_secret' }
 
-    it 'authenticates via Basic Auth' do
-      Githubris::API.should have_received(:basic_auth).with('username', 'password')
+    it 'creates an Githubris::OAuth object' do
+      subject.oauth(client_id, client_secret).should be_instance_of Githubris::OAuth
     end
+  end
 
-    it 'sets the authenticated user' do
-      subject.authenticated_user.should_not be_nil
+  describe '#authenticated?' do
+    it 'delegates to the API' do
+      Githubris::API.any_instance.should_receive :authenticated?
+      subject.authenticated?
     end
   end
 
   describe '#find_user' do
+    use_vcr_cassette
+
     it 'requests gets user from githubris api' do
-      user = Githubris::User.new(:login => "frank")
+      user = Githubris::User.new(:login => 'GithubrisTestUser')
       Githubris::API.any_instance.stub(:get_user).and_return(user)
-      subject.find_user("frank").should == user
+      subject.find_user('GithubrisTestUser').should == user
     end
 
     it 'returns a user' do
-      subject.find_user('frank').should be_instance_of Githubris::User
+      subject.find_user('GithubrisTestUser').should be_instance_of Githubris::User
     end
   end
 
   describe '#public_gists' do
+    use_vcr_cassette
+
     it 'should contain only gists' do
       subject.public_gists.each do |gist|
         gist.should be_instance_of Githubris::Gist
       end
     end
 
-    it 'can take an options hash' do
-      lambda { subject.public_gists(:foo => 'bar') }.should_not raise_error
-    end
-
     it 'delegates and passes the options hash to the API' do
       Githubris::API.any_instance.stub(:get_public_gists)
       subject.public_gists({:foo => 'bar'})
-      subject.instance_variable_get(:@api).should have_received(:get_public_gists).with({foo: 'bar'})
+      subject.instance_variable_get(:@api).should have_received(:get_public_gists).with({:foo => 'bar'})
     end
   end
 
   describe '#find_gist' do
     let(:id) { 1 }
+    subject { Githubris.new.find_gist(id) }
+    use_vcr_cassette
 
-    it 'takes a gist\'s id' do
-      lambda do
-        subject.find_gist(id)
-      end.should_not raise_error
-    end
-
-    it 'hits the API' do
-      Githubris::API.any_instance.should_receive(:get_gist).with(id)
-      subject.find_gist(id)
-    end
-
-    context 'the gist it returns' do
-      subject { Githubris.new.find_gist(id) }
-
-      it 'has the same id that was passed in' do
-        subject.should be_instance_of Githubris::Gist
-        subject.id.should == id
-      end
-
-      it 'has a user' do
-        lambda do
-          subject.user.should be_instance_of Githubris::User
-        end.should_not raise_error
-      end
+    it 'returns a gist' do
+      subject.should be_instance_of Githubris::Gist
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,15 +1,18 @@
 require 'rspec-spies'
-require 'fakeweb'
-require 'simplecov'
 require 'githubris'
+require 'simplecov'
+require 'fakeweb'
+require 'pry'
 
 require 'support/fixtures'
-require 'support/fakeweb_responses'
-require 'support/custom_matchers'
+require 'support/vcr'
+
+RSpec.configure do |config|
+  config.extend VCR::RSpec::Macros
+end
 
 SimpleCov.start do
   add_filter '/spec/'
-  add_filter '/features/'
   add_filter '/pkg/'
   add_filter '/coverage/'
-end
+end if ENV['COVERAGE']

data/spec/support/fixtures.rb

@@ -1,112 +1,128 @@
-class Githubris
-  module SpecHelper
-    def self.gist_collection_data
-      [
-        {
-          "created_at" => "2008-07-20T22:54:53Z",
-          "git_push_url" => "git@gist.github.com:36.git",
-          "user" => {
-            "avatar_url" => "https://secure.gravatar.com/avatar/fcafc7eab67d34d48b14f9d70bc05713?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
-            "url" => "https://api.github.com/users/adamwiggins",
-            "gravatar_id" => "fcafc7eab67d34d48b14f9d70bc05713",
-            "id" => 177,
-            "login" => "adamwiggins"
-          },
-          "public" => true,
-          "url" => "https://api.github.com/gists/36",
-          "description" => nil,
-          "updated_at" => "2009-10-14T10:23:21Z",
-          "comments" => 0,
-          "files" => {
-            "gistfile1.diff" => {
-              "type" => "text/plain",
-              "filename" => "gistfile1.diff",
-              "language" => "Diff",
-              "raw_url" => "https://gist.github.com/raw/36/588da740399b34cf9ab649c5198954aadc6e36ff/gistfile1.diff",
-              "size" => 5467
-            }
-          },
-          "id" => "36",
-          "html_url" => "https://gist.github.com/36",
-          "git_pull_url" => "git://gist.github.com/36.git"
+class Githubris::SpecHelper
+  def self.gist_collection_data
+    [
+      {
+        "created_at" => "2008-07-20T22:54:53Z",
+        "git_push_url" => "git@gist.github.com:36.git",
+        "user" => {
+          "avatar_url" => "https://secure.gravatar.com/avatar/fcafc7eab67d34d48b14f9d70bc05713?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
+          "url" => "https://api.github.com/users/adamwiggins",
+          "gravatar_id" => "fcafc7eab67d34d48b14f9d70bc05713",
+          "id" => 177,
+          "login" => "adamwiggins"
         },
-        {
-          "created_at" => "2008-07-17T09:01:22Z",
-          "git_push_url" => "git@gist.github.com:10.git",
-          "user" => {
-            "avatar_url" => "https://secure.gravatar.com/avatar/b8dbb1987e8e5318584865f880036796?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
-            "url" => "https://api.github.com/users/defunkt",
-            "gravatar_id" => "b8dbb1987e8e5318584865f880036796",
-            "id" => 2,
-            "login" => "defunkt"
-          },
-          "public" => true,
-          "url" => "https://api.github.com/gists/10",
-          "description" => "asd",
-          "updated_at" => "2009-10-14T10:23:15Z",
-          "comments" => 0,
-          "files" => {
-            "Imp_pomocu_pokazivaca" => {
-              "type" => "text/plain",
-              "filename" => "Imp_pomocu_pokazivaca",
-              "language" => nil,
-              "raw_url" => "https://gist.github.com/raw/10/ce5e83b3d8ed83c5a950f116e07505dfd2cb608a/Imp_pomocu_pokazivaca",
-              "size" => 1347
-            }
-          },
-          "id" => "10",
-          "html_url" => "https://gist.github.com/10",
-          "git_pull_url" => "git://gist.github.com/10.git"
-        }
-      ]
-    end
-
-    def self.gist_data
+        "public" => true,
+        "url" => "https://api.github.com/gists/36",
+        "description" => nil,
+        "updated_at" => "2009-10-14T10:23:21Z",
+        "comments" => 0,
+        "files" => {
+          "gistfile1.diff" => {
+            "type" => "text/plain",
+            "filename" => "gistfile1.diff",
+            "language" => "Diff",
+            "raw_url" => "https://gist.github.com/raw/36/588da740399b34cf9ab649c5198954aadc6e36ff/gistfile1.diff",
+            "size" => 5467
+          }
+        },
+        "id" => "36",
+        "html_url" => "https://gist.github.com/36",
+        "git_pull_url" => "git://gist.github.com/36.git"
+      },
       {
-        "created_at" => "2008-07-15T18:17:13Z",
-        "git_push_url" => "git@gist.github.com:1.git",
+        "created_at" => "2008-07-17T09:01:22Z",
+        "git_push_url" => "git@gist.github.com:10.git",
         "user" => {
-          "avatar_url" => "https://secure.gravatar.com/avatar/9375a9529679f1b42b567a640d775e7d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
-          "url" => "https://api.github.com/users/schacon",
-          "gravatar_id" => "9375a9529679f1b42b567a640d775e7d",
-          "id" => 70,
-          "login" => "schacon"
+          "avatar_url" => "https://secure.gravatar.com/avatar/b8dbb1987e8e5318584865f880036796?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
+          "url" => "https://api.github.com/users/defunkt",
+          "gravatar_id" => "b8dbb1987e8e5318584865f880036796",
+          "id" => 2,
+          "login" => "defunkt"
         },
         "public" => true,
-        "url" => "https://api.github.com/gists/1",
-        "description" => "the meaning of gist",
-        "updated_at" => "2011-02-22T02:58:22Z",
-        "comments" => 5,
+        "url" => "https://api.github.com/gists/10",
+        "description" => "asd",
+        "updated_at" => "2009-10-14T10:23:15Z",
+        "comments" => 0,
         "files" => {
-          "gistfile1.txt" => {
+          "Imp_pomocu_pokazivaca" => {
             "type" => "text/plain",
-            "filename" => "gistfile1.txt",
-            "language" => "Text",
-            "raw_url" => "https://gist.github.com/raw/1/9b2ac7c792209f19e157ddaf00f8946edc306a6b/gistfile1.txt",
-            "size" => 178
+            "filename" => "Imp_pomocu_pokazivaca",
+            "language" => nil,
+            "raw_url" => "https://gist.github.com/raw/10/ce5e83b3d8ed83c5a950f116e07505dfd2cb608a/Imp_pomocu_pokazivaca",
+            "size" => 1347
           }
         },
-        "id" => "1",
-        "html_url" => "https://gist.github.com/1",
-        "git_pull_url" => "git://gist.github.com/1.git"
+        "id" => "10",
+        "html_url" => "https://gist.github.com/10",
+        "git_pull_url" => "git://gist.github.com/10.git"
       }
-    end
+    ]
+  end
 
-    def self.user_data
-      {
-        "public_gists" => 2,
-        "type" => "User",
-        "following" => 0,
-        "login" => "GithubrisTestUser",
-        "avatar_url" => "https://secure.gravatar.com/avatar/20de3fd01e285d14de84067c34ab74d2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
-        "public_repos" => 1,
-        "followers" => 0,
-        "html_url" => "https://github.com/GithubrisTestUser",
-        "url" => "https://api.github.com/users/GithubrisTestUser",
-        "created_at" => "2012-02-24T12:23:28Z",
-        "gravatar_id" => "20de3fd01e285d14de84067c34ab74d2",
-        "id" => 1469392
-      }
-    end
+  def self.gist_data
+    {
+      "created_at" => "2008-07-15T18:17:13Z",
+      "git_push_url" => "git@gist.github.com:1.git",
+      "user" => {
+        "avatar_url" => "https://secure.gravatar.com/avatar/9375a9529679f1b42b567a640d775e7d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
+        "url" => "https://api.github.com/users/schacon",
+        "gravatar_id" => "9375a9529679f1b42b567a640d775e7d",
+        "id" => 70,
+        "login" => "schacon"
+      },
+      "public" => true,
+      "url" => "https://api.github.com/gists/1",
+      "description" => "the meaning of gist",
+      "updated_at" => "2011-02-22T02:58:22Z",
+      "comments" => 5,
+      "files" => {
+        "gistfile1.txt" => {
+          "type" => "text/plain",
+          "filename" => "gistfile1.txt",
+          "language" => "Text",
+          "raw_url" => "https://gist.github.com/raw/1/9b2ac7c792209f19e157ddaf00f8946edc306a6b/gistfile1.txt",
+          "size" => 178
+        }
+      },
+      "id" => "1",
+      "html_url" => "https://gist.github.com/1",
+      "git_pull_url" => "git://gist.github.com/1.git"
+    }
+  end
+
+  def self.user_data
+    {
+      "public_gists" => 2,
+      "type" => "User",
+      "following" => 0,
+      "login" => "GithubrisTestUser",
+      "avatar_url" => "https://secure.gravatar.com/avatar/20de3fd01e285d14de84067c34ab74d2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
+      "public_repos" => 1,
+      "followers" => 0,
+      "html_url" => "https://github.com/GithubrisTestUser",
+      "url" => "https://api.github.com/users/GithubrisTestUser",
+      "created_at" => "2012-02-24T12:23:28Z",
+      "gravatar_id" => "20de3fd01e285d14de84067c34ab74d2",
+      "id" => 1469392
+    }
+  end
+
+  def self.not_found_error_data
+    {
+      "message" => "Not Found"
+    }
+  end
+
+  def self.bad_credentials_error_data
+    {
+      "message" => "Bad credentials"
+    }
+  end
+
+  def self.requires_authentication_error_data
+    {
+      "message" => "Requires authentication"
+    }
   end
 end