githubris 0.0.1 → 0.0.2

data/githubris.gemspec

@@ -1,6 +1,5 @@
 # -*- encoding: utf-8 -*-
 $:.push File.expand_path("../lib", __FILE__)
-$:.push File.expand_path("../config", __FILE__)
 require "githubris/version"
 
 Gem::Specification.new do |s|

data/lib/githubris/api.rb

@@ -1,26 +1,44 @@
 require 'httparty'
 
-module Githubris
-  class API
-    include HTTParty
-    base_uri(Githubris::Config[:base_uri])
-
-    def self.call(data, *args)
-
-      options = {data: data}
-      unless args.empty?
-        options.merge! args.inject(Githubris::Config) {|config, key|
-          config[key]
-        }
-      end
-      Githubris::API.resolve options
-    end
+class Githubris::API
+  include HTTParty
+  base_uri 'https://api.github.com'
+  format :json
+
+  GISTS_PER_PAGE = 30
+  PUBLIC_GISTS_PATH = '/gists/public'
+
+  def initialize
+    @builder = Githubris::Builder.new
+  end
+
+  def authenticate!(options={})
+    Githubris::API.basic_auth options[:login], options[:password]
+  end
 
-    def self.resolve options
-      method = options[:method].intern
-      path = URI.parse(options[:path])
-      puts "#{method} #{path}"
-      Githubris::API.send(method, path)
+  def get_public_gists(options={})
+    quantity = options.delete(:quantity) || 30
+    number_of_overflow_gists = quantity % GISTS_PER_PAGE
+    if quantity > GISTS_PER_PAGE
+      max_page_number = (quantity / GISTS_PER_PAGE) +
+        (number_of_overflow_gists > 0 ? 1 : 0)
+
+      data = Githubris::API.get public_gists_path_for_page(max_page_number)
+      gists = @builder.build(data).
+        concat(get_public_gists(quantity: quantity - GISTS_PER_PAGE))
+    else
+      url = PUBLIC_GISTS_PATH
+      data = Githubris::API.get(url)
+      gists = @builder.build(data)
     end
+    gists.shift(quantity)
+  end
+
+  def get_user(options={})
+    Githubris::User.new
+  end
+
+  def public_gists_path_for_page page_number
+    "#{PUBLIC_GISTS_PATH}?page=#{page_number}"
   end
 end

data/lib/githubris/builder.rb

@@ -1,26 +1,35 @@
-module Githubris
-  class GistBuilder
-    class << self
-      def build data
-        return data if data.instance_of? Githubris::Gist
-        if data.instance_of? Array
-          data.map do |gist_data|
-            self.build gist_data
-          end
-        else
-          data[:user] = Githubris::User.build data.delete('user')
-          data[:public] = data.delete('public')
-          data[:description] = data.delete('description')
-          data[:files] = data.delete('files').values
-          data[:url] = URI.parse data.delete('url')
-          data[:created_at] = DateTime.parse data.delete('created_at')
-          data[:updated_at] = DateTime.parse data.delete('updated_at')
-          tmp_arr = []
-          data.delete('comments').times { tmp_arr << Githubris::Comment.new }
-          data[:comments] = tmp_arr
-          Githubris::Gist.new data
-        end
+class Githubris
+  class Builder
+    def build data
+      if data.instance_of? Array
+        build_gists data
+      else
+        build_gist data
       end
     end
+
+    def build_gists(data)
+      data.map do |gist|
+        build_gist gist
+      end
+    end
+
+    def build_gist(data)
+      data[:user] = build_user(data.delete 'user' )
+      data[:public] = data.delete('public')
+      data[:description] = data.delete('description')
+      data[:files] = data.delete('files').values
+      data[:url] = URI.parse data.delete('url')
+      data[:created_at] = DateTime.parse data.delete('created_at')
+      data[:updated_at] = DateTime.parse data.delete('updated_at')
+      tmp_arr = []
+      data.delete('comments').times { tmp_arr << Githubris::Comment.new }
+      data[:comments] = tmp_arr
+      Githubris::Gist.new data
+    end
+
+    def build_user data
+      Githubris::User.new
+    end
   end
 end

data/lib/githubris/comment.rb

@@ -1,4 +1,4 @@
-module Githubris
+class Githubris
   class Comment
     def self.build comment_data
     end

data/lib/githubris/gist/file.rb

@@ -1,4 +1,4 @@
-module Githubris
+class Githubris
   class Gist
     class File
       def self.build data

data/lib/githubris/gist.rb

@@ -1,15 +1,10 @@
-module Githubris
+class Githubris
   class Gist
     autoload :File, 'githubris/gist/file'
 
     class << self
-      def public_gists
-        Githubris::API.call(:gists, :list_public)
-      end
-
       def default_options
         {
-          user: Githubris.authenticated_user,
           files: [],
           created_at: DateTime.now,
           updated_at: DateTime.now
@@ -51,10 +46,6 @@ module Githubris
       @options[:url]
     end
 
-    def save
-      Githubris::API.save_gist(self)
-    end
-
     def public?
       @options[:public]
     end

data/lib/githubris/issue.rb

@@ -1,4 +1,4 @@
-module Githubris
+class Githubris
   class Issue
     autoload :Label, 'githubris/issue/label'
     autoload :Milestone, 'githubris/issue/milestone'

data/lib/githubris/organization.rb

@@ -1,4 +1,4 @@
-module Githubris
+class Githubris
   class Organization
     autoload :Team, 'githubris/organization/team'
   end

data/lib/githubris/repository.rb

@@ -1,4 +1,4 @@
-module Githubris
+class Githubris
   class Repository
     autoload :Download, 'githubris/repository/download'
     autoload :Fork, 'githubris/repository/fork'

data/lib/githubris/user.rb

@@ -1,11 +1,10 @@
-module Githubris
+class Githubris
   class User
-    def self.build user_data
-      if user_data.instance_of? Githubris::User
-        return user_data
-      else
-        self.new
-      end
+    def initialize data={}
     end
+
+    def public_gists
+    end
+
   end
 end

data/lib/githubris/version.rb

@@ -1,3 +1,3 @@
-module Githubris
-  VERSION = "0.0.1"
+class Githubris
+  VERSION = "0.0.2"
 end

data/lib/githubris.rb

@@ -1,12 +1,12 @@
 $:.push File.expand_path("../../config", __FILE__)
 require_relative "githubris/version"
 
-module Githubris
+class Githubris
   autoload :API, 'githubris/api'
   autoload :Blob, 'githubris/blob'
+  autoload :Builder, 'githubris/builder'
   autoload :Comment, 'githubris/comment'
   autoload :Commit, 'githubris/commit'
-  autoload :Config, 'githubris/config'
   autoload :Event, 'githubris/event'
   autoload :Gist, 'githubris/gist'
   autoload :Issue, 'githubris/issue'
@@ -18,21 +18,22 @@ module Githubris
   autoload :Tree, 'githubris/tree'
   autoload :User, 'githubris/user'
 
-  class << self
-    def login(user_name, api_key)
-      @@authenticated_user = Githubris::User.new
-    end
+  attr_reader :authenticated_user
 
-    def logout
-      @@authenticated_user = nil
-    end
+  def initialize
+    @api = Githubris::API.new
+  end
+
+  def authenticate(username, password)
+    @api.authenticate! login: username, password: password
+    @authenticated_user = Githubris::User.new
+  end
+
+  def find_user(login)
+    @api.get_user(login: login)
+  end
 
-    def authenticated_user
-      begin
-        @@authenticated_user
-      rescue
-        nil
-      end
-    end
+  def public_gists(options={})
+    @api.get_public_gists options
   end
 end

data/spec/githubris/api_spec.rb

@@ -1,30 +1,28 @@
 require 'spec_helper'
 
 describe Githubris::API do
-  describe 'making calls' do
-    subject { Githubris::API }
-
-    before do
-      Githubris::API.stub(:resolve)
-    end
-
-    it 'takes a single required data requirement' do
-      lambda { subject.call({}) }.should_not raise_error
+  describe '#get_public_gists' do
+    it 'returns an array of gists' do
+      subject.get_public_gists.should be_instance_of Array
+      subject.get_public_gists.each do |gist|
+        gist.should be_instance_of Githubris::Gist
+      end
     end
 
-    it 'takes multiple arguments' do
-      Githubris::Config.stub(:[] => {:bar => {:baz => {}}})
-      lambda {
-        subject.call({}, :foo)
-        subject.call({}, :foo, :bar)
-        subject.call({}, :foo, :bar, :baz)
-      }.should_not raise_error
+    it 'accepts an options hash' do
+      lambda do
+        subject.get_public_gists({foo: 'bar'})
+      end.should_not raise_error
     end
 
-    it 'uses the config' do
-      Githubris::Config.stub(:[] => {})
-      subject.call({}, :foo)
-      Githubris::Config.should have_received(:[]).with(:foo)
+    context 'given a quantity option' do
+      it 'returns an array of gists with that quantity' do
+        subject.get_public_gists(quantity: 10).should have(10).items
+        subject.get_public_gists(quantity: 30).should have(30).items
+        subject.get_public_gists(quantity: 31).should have(31).items
+        subject.get_public_gists(quantity: 45).should have(45).items
+        subject.get_public_gists(quantity: 61).should have(61).items
+      end
     end
   end
 end

data/spec/githubris/builder_spec.rb

@@ -1,26 +1,42 @@
-require 'githubris/builder'
 require 'spec_helper'
 
-describe Githubris::GistBuilder do
-  describe 'build' do
-    let(:gist_data) { Githubris::SpecHelper.gist_data }
+describe Githubris::Builder do
+  let(:gist_collection_data) { Githubris::SpecHelper.gist_collection_data }
+  let(:gist_data) { Githubris::SpecHelper.gist_data }
+
+  describe '#build' do
 
     context 'when passed a collection of gist data' do
-      subject do
-        Githubris::GistBuilder.build Githubris::SpecHelper.gist_collection_data
+      it 'delegates to #build_gists' do
+        Githubris::Builder.any_instance.stub(:build_gists)
+        subject.build gist_collection_data
+        subject.should have_received(:build_gists).with gist_collection_data
       end
+    end
 
-      it { should be_instance_of Array }
+    context 'when passed the data for a single gist' do
+      it 'delegates to #build_gist' do
+        Githubris::Builder.any_instance.stub(:build_gist)
+        subject.build gist_data
+        subject.should have_received(:build_gist).with gist_data
+      end
+    end
+  end
 
-      it 'is an array of gists' do
-        subject.each do |gist|
-          gist.should be_instance_of Githubris::Gist
-        end
+  describe '#build_gists' do
+    it 'is an array of gists' do
+      gists = subject.build_gists(gist_collection_data)
+      gists.should be_instance_of Array
+      gists.each do |gist|
+        gist.should be_instance_of Githubris::Gist
       end
     end
+  end
 
-    context 'when passed the data for a single gist' do
-      subject { Githubris::GistBuilder.build gist_data }
+
+  describe '#build_gist' do
+    context 'schema' do
+      subject { Githubris::Builder.new.build gist_data }
 
       it                { should be_instance_of Githubris::Gist }
       it                { should be_public }
@@ -34,7 +50,7 @@ describe Githubris::GistBuilder do
     end
 
     context 'when passed a specific gist' do
-      subject { Githubris::GistBuilder.build gist_data }
+      subject { Githubris::Builder.new.build gist_data }
 
       it 'is public' do
         subject.should be_public

data/spec/githubris/gist_spec.rb

@@ -1,16 +1,6 @@
 require 'spec_helper'
 
 describe Githubris::Gist do
-  describe '.public_gists' do
-    context 'when there are a few gists' do
-      it 'is an array of gists' do
-        Githubris::API.stub(:call => [Githubris::Gist.new, Githubris::Gist.new])
-        Githubris::Gist.public_gists.each do |gist|
-          gist.should be_instance_of Githubris::Gist
-        end
-      end
-    end
-  end
 
   context 'instance methods' do
     subject { gist }
@@ -20,18 +10,6 @@ describe Githubris::Gist do
       DateTime.stub(:now => DateTime.new(2012, 12, 21, 12, 0, 0))
       gist.created_at.should eql DateTime.now
     end
-    context "with a user is authenticated" do
-      it 'new gists belong to the authenticated user' do
-        Githubris.stub(:authenticated_user => Githubris::User.new )
-        gist.user.should eql Githubris.authenticated_user
-      end
-    end
-
-    context 'with no authenticated user' do
-      it 'is nil' do
-        gist.user.should be_nil
-      end
-    end
 
     context 'Gist owned by Isaac' do
       subject { Githubris::Gist.new user: user }
@@ -50,14 +28,6 @@ describe Githubris::Gist do
       end
 
       its(:files) { should have(1).items }
-
-      describe 'saving' do
-        it 'gets sent to github' do
-          Githubris::API.stub(:save_gist)
-          subject.save
-          Githubris::API.should have_received(:save_gist).with(subject)
-        end
-      end
     end
   end
 end

data/spec/githubris_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe Githubris do
+  describe '#authenticate' do
+    before do
+      Githubris::API.stub(:basic_auth => Githubris::User.new)
+      subject.authenticate('username', 'password')
+    end
+
+    it 'authenticates via Basic Auth' do
+      Githubris::API.should have_received(:basic_auth).with('username', 'password')
+    end
+
+    it 'sets the authenticated user' do
+      subject.authenticated_user.should_not be_nil
+    end
+  end
+
+  describe '#find_user' do
+    it 'requests gets user from githubris api' do
+      user = Githubris::User.new(login: "frank")
+      Githubris::API.any_instance.stub(:get_user).and_return(user)
+      subject.find_user("frank").should == user
+    end
+
+    it 'returns a user' do
+      subject.find_user('frank').should be_instance_of Githubris::User
+    end
+  end
+
+  describe '#public_gists' do
+    it 'should contain only gists' do
+      subject.public_gists.each do |gist|
+        gist.should be_instance_of Githubris::Gist
+      end
+    end
+
+    it 'can take an options hash' do
+      lambda { subject.public_gists(foo: 'bar') }.should_not raise_error
+    end
+
+    it 'delegates and passes the options hash to the API' do
+      Githubris::API.any_instance.stub(:get_public_gists)
+      subject.public_gists({foo: 'bar'})
+      subject.instance_variable_get(:@api).should have_received(:get_public_gists).with({foo: 'bar'})
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,8 +1,15 @@
 require 'rspec-spies'
-require 'pry'
 require 'fakeweb'
+require 'simplecov'
 require 'githubris'
 
 require 'support/fixtures'
 require 'support/fakeweb_responses'
 require 'support/custom_matchers'
+
+SimpleCov.start do
+  add_filter '/spec/'
+  add_filter '/features/'
+  add_filter '/pkg/'
+  add_filter '/coverage/'
+end

data/spec/support/fakeweb_responses.rb

@@ -2,60 +2,5 @@ require 'fakeweb'
 
 FakeWeb.allow_net_connect = false
 FakeWeb.register_uri(:get, 'https://api.github.com/', :body => '{}')
-FakeWeb.register_uri(:get, 'https://api.github.com/gists', :body => <<-BODY
-[
-  {
-    "url": "https://api.github.com/gists/2",
-    "id": "2",
-    "description": "description of gist number two",
-    "public": true,
-    "user": {
-      "login": "rocktocat",
-      "id": 1,
-      "avatar_url": "https://github.com/images/error/octocat_happy.gif",
-      "gravatar_id": "somehexcode",
-      "url": "https://api.github.com/users/octocat"
-    },
-    "files": {
-      "ring.erl": {
-        "size": 932,
-        "filename": "ring.erl",
-        "raw_url": "https://gist.github.com/raw/365370/8c4d2d43d178df44f4c03a7f2ac0ff512853564e/ring.erl",
-        "content": "contents of gist"
-      }
-    },
-    "comments": 0,
-    "html_url": "https://gist.github.com/1",
-    "git_pull_url": "git://gist.github.com/1.git",
-    "git_push_url": "git@gist.github.com:1.git",
-    "created_at": "2010-04-14T02:15:15Z"
-  },
-  {
-    "url": "https://api.github.com/gists/1",
-    "id": "1",
-    "description": "description of gist",
-    "public": true,
-    "user": {
-      "login": "octocat",
-      "id": 1,
-      "avatar_url": "https://github.com/images/error/octocat_happy.gif",
-      "gravatar_id": "somehexcode",
-      "url": "https://api.github.com/users/octocat"
-    },
-    "files": {
-      "ring.erl": {
-        "size": 932,
-        "filename": "ring.erl",
-        "raw_url": "https://gist.github.com/raw/365370/8c4d2d43d178df44f4c03a7f2ac0ff512853564e/ring.erl",
-        "content": "contents of gist"
-      }
-    },
-    "comments": 0,
-    "html_url": "https://gist.github.com/1",
-    "git_pull_url": "git://gist.github.com/1.git",
-    "git_push_url": "git@gist.github.com:1.git",
-    "created_at": "2010-04-14T02:15:15Z"
-  }
-]
-BODY
-)
+FakeWeb.register_uri(:get, /gists\/public(?:[^?]*\?page=(\d+))?/,
+                     :body => File.open("spec/support/public_gists_page_#{$1 || 1}.json", 'r') {|f| f.read })

data/spec/support/fixtures.rb

@@ -1,4 +1,4 @@
-module Githubris
+class Githubris
   module SpecHelper
     def self.gist_collection_data
       [