github_metadata 0.2.0 → 0.2.1

data/github_metadata.gemspec

@@ -19,8 +19,6 @@ Gem::Specification.new do |s|
   s.add_dependency 'i18n'
   s.add_development_dependency 'rspec', '>= 2.0.0'
   s.add_development_dependency 'simplecov', ">= 0.4.1"
-  s.add_development_dependency 'vcr'
-  s.add_development_dependency 'webmock'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

data/lib/github_metadata.rb

@@ -139,9 +139,9 @@ class GithubMetadata
   # Returns the average date of recent commits (by default all (max 20), can be modified
   # by giving the optional argument)
   def average_recent_committed_at(num=100)
-    commit_times = recent_commits[0..num].map {|c| c.committed_at.to_f }
+    commit_times = recent_commits[0...num].map {|c| c.committed_at.to_f }
     average_time = commit_times.inject(0) {|s, i| s + i} / commit_times.length
-    Time.at(average_time)
+    Time.at(average_time).utc
   end
   
   private
@@ -153,7 +153,13 @@ class GithubMetadata
     end
     
     def commits_feed
-      @commits_feed ||= Feedzirra::Feed.fetch_and_parse(commits_feed_url)
+      return @commits_feed if @commits_feed
+      response = Feedzirra::Feed.fetch_and_parse(commits_feed_url)
+      if response.kind_of?(Fixnum)
+        return nil
+      else
+        @commits_feed = response
+      end
     end
     
     def load_contributors

data/lib/github_metadata/version.rb

@@ -1,3 +1,3 @@
 class GithubMetadata
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/github_metadata_spec.rb

@@ -1,21 +1,23 @@
 # encoding: utf-8
 require 'spec_helper'
 describe GithubMetadata do
-  context "initialized with aslakhellesoy/cucumber" do
+  context "initialized with cucumber/cucumber" do
     before(:all) do
-      @metadata = GithubMetadata.new('aslakhellesoy', 'cucumber')
+      @metadata = GithubMetadata.new('cucumber', 'cucumber')
       @raw = open("https://github.com/#{@metadata.user}/#{@metadata.repo}/contributors").read
     end
     subject { @metadata }
 
-    its(:user) { should == 'aslakhellesoy' }
+    its(:user) { should == 'cucumber' }
     its(:repo) { should == 'cucumber' }
   
     specify { should have_wiki }
     its(:wiki_pages) { should == @raw.match(/Wiki \((\d+)\)/)[1].to_i }
     
-    specify { should_not have_issues }
-    its(:issues) { should be_nil }
+    # specify { should_not have_issues }
+    # its(:issues) { should be_nil }
+    it { should have_issues }
+    its(:issues) { should == @raw.match(/Issues \((\d+)\)/)[1].to_i }
     
     its(:pull_requests) { should == @raw.match(/Pull Requests \((\d+)\)/)[1].to_i }
     
@@ -30,13 +32,14 @@ describe GithubMetadata do
       
     its(:default_branch) { should == 'master' }
     
-    its(:commits_feed_url) { should == 'https://github.com/aslakhellesoy/cucumber/commits/master.atom' }
+    its(:commits_feed_url) { should == 'https://github.com/cucumber/cucumber/commits/master.atom' }
   end
   
   context "initialized with colszowka/simplecov" do
     before(:all) do
       @metadata = GithubMetadata.new('colszowka', 'simplecov')
       @raw = open("https://github.com/#{@metadata.user}/#{@metadata.repo}/contributors").read
+      @feed = Nokogiri::XML(open(@metadata.commits_feed_url))
     end
     subject { @metadata }
 
@@ -49,7 +52,7 @@ describe GithubMetadata do
     it { should have_issues }
     its(:issues) { should == @raw.match(/Issues \((\d+)\)/)[1].to_i }
     
-    its(:pull_requests) { should == 0 }
+    its(:pull_requests) { should == @raw.match(/Pull Requests \((\d+)\)/)[1].to_i }
     
     its("contributors.length") { should == @raw.match(/(\d+) contributors/)[1].to_i}
     its(:contributors) { should be_all {|c| c.instance_of?(GithubMetadata::Contributor)} }
@@ -65,9 +68,7 @@ describe GithubMetadata do
     
     context "recent_commits" do
       before(:all) do
-        VCR.use_cassette('simplecov') do
-          @metadata.recent_commits
-        end
+        @metadata.recent_commits
       end
       subject { @metadata.recent_commits }
 
@@ -77,18 +78,35 @@ describe GithubMetadata do
         subject { @metadata.recent_commits.first }
         
         it { should be_a(GithubMetadata::Commit)}
-        its(:title) { should == 'Require simplecov-html ~> 0.4.3' }
-        its(:author) { should == 'Christoph Olszowka' }
-        its(:url) { should == 'https://github.com/colszowka/simplecov/commit/5ec4ca01255135234fe5b771ec3dd743a2b4ea1a' }
-        its("committed_at.utc") { should == Time.mktime(2011, 2, 25, 16, 26, 16).utc }
+        its(:title) { should == @feed.css('entry').first.children.css('title').first.content }
+        its(:author) { should == @feed.css('entry').first.children.css('author name').first.content }
+        its(:url) { should == @feed.css('entry').first.children.css('link').first['href'] }
+        its("committed_at.utc") { should == Time.parse(@feed.css('entry').first.children.css('updated').first.content).utc }
       end
     end
     
     it("should return last commit date for average_recent_committed_at(1)") do 
-      subject.average_recent_committed_at(1).should == Time.mktime(2011, 2, 25, 16, 25, 44).utc
+      subject.average_recent_committed_at(1).should == Time.parse(@feed.css('entry').first.children.css('updated').first.content).utc
     end
     
-    its("average_recent_committed_at.to_i") { should == Time.mktime(2011, 2, 11, 1, 49, 14).to_i }
+    its("average_recent_committed_at.to_i") do 
+      expected_date = @feed.css('entry updated').map {|u| Time.parse(u.content).to_f}.inject(0){|a,b| a+b} / 20
+      should == expected_date.to_i
+    end
+  end
+  
+  context "initialized with jquery/jquery" do
+    before(:all) do
+      @metadata = GithubMetadata.new('jquery', 'jquery')
+      @raw = open("https://github.com/#{@metadata.user}/#{@metadata.repo}/contributors").read
+    end
+    subject { @metadata }
+
+    specify { should_not have_wiki }
+    its(:wiki_pages) { should be_nil }
+    
+    specify { should_not have_issues }
+    its(:issues) { should be_nil }
   end
 
   context "initialized with an invalid repo path" do
@@ -97,9 +115,17 @@ describe GithubMetadata do
     end
     subject { @metadata }
     
-    it "should raise GithubMetadata::RepoNotFound" do
+    it "should raise GithubMetadata::RepoNotFound when accessing .issues" do
       lambda { subject.issues }.should raise_error(GithubMetadata::RepoNotFound)
     end
+    
+    it "should raise GithubMetadata::RepoNotFound when accessing .recent_commits" do
+      lambda { subject.recent_commits }.should raise_error(GithubMetadata::RepoNotFound)
+    end
+    
+    it "should raise GithubMetadata::RepoNotFound when accessing .average_recent_committed_at" do
+      lambda { subject.average_recent_committed_at }.should raise_error(GithubMetadata::RepoNotFound)
+    end
   end
   
   describe "fetch with invalid repo path" do

data/spec/spec_helper.rb

@@ -6,13 +6,4 @@ require 'github_metadata'
 
 RSpec.configure do |config|
   # some (optional) config here
-end
-
-require 'vcr'
-
-VCR.config do |c|
-  c.allow_http_connections_when_no_cassette = true
-  c.default_cassette_options = { :record => :new_episodes }
-  c.cassette_library_dir = 'fixtures/vcr_cassettes'
-  c.stub_with :webmock # or :fakeweb
-end
+end

metadata

@@ -2,7 +2,7 @@
 name: github_metadata
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors: 
 - Christoph Olszowka
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-11 00:00:00 +01:00
+date: 2011-05-23 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -68,28 +68,6 @@ dependencies:
         version: 0.4.1
   type: :development
   version_requirements: *id005
-- !ruby/object:Gem::Dependency 
-  name: vcr
-  prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
-  type: :development
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
-  name: webmock
-  prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
-  type: :development
-  version_requirements: *id007
 description: Extracts additional information like amount of committers, issues and wiki pages from Github repos
 email: 
 - christoph at olszowka de
@@ -135,7 +113,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: github_metadata
-rubygems_version: 1.5.3
+rubygems_version: 1.6.1
 signing_key: 
 specification_version: 3
 summary: Extracts additional information from Github repos that isn't available via API