github_deprecations 0.0.2 → 0.0.3

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.0.3
+
+* improve error messages
+* fail gracefully when redis unavailable
+
 ## 0.0.2
 
 * errors in configuration will warn, but not raise errors

data/lib/github_deprecations.rb

@@ -11,7 +11,7 @@ module GithubDeprecations
     blk.call(config) if blk
     config
   rescue ArgumentError => e
-    $stderr.puts "Missing config parameters for GithubDeprecations"
+    $stderr.puts "WARNING: Missing config parameters for GithubDeprecations"
     Noop.new
   end
   module_function :configure
@@ -35,13 +35,21 @@ module GithubDeprecations
     # For each deprecation, enqueue a background job
     # to create or update an issue.
     def register!
+      @original_behavior = ActiveSupport::Deprecation.behavior
       ActiveSupport::Deprecation.behavior = :notify
       @subscriber = ActiveSupport::Notifications.subscribe(@subscribe) do |*args|
-        Resque.enqueue Worker, self, args
+        begin
+          Resque.enqueue Worker, self, args
+        rescue Errno::ECONNREFUSED => e
+          # unable to connect to redis, revert to default behavior
+          $stderr.puts "WARNING: Unable to connect to redis for GithubDeprecations"
+          reset!
+        end
       end
     end
 
     def reset!
+      ActiveSupport::Deprecation.behavior = @original_behavior if @original_behavior
       ActiveSupport::Notifications.unsubscribe(@subscriber) if @subscriber
     end
   end

data/lib/github_deprecations/version.rb

@@ -1,3 +1,3 @@
 module GithubDeprecations
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/test/github_deprecations_test.rb

@@ -15,11 +15,26 @@ class GithubDeprecationsTest < Test::Unit::TestCase
     output = capture_stderr do
       GithubDeprecations.configure
     end
-    assert_equal output, "Missing config parameters for GithubDeprecations\n"
+    assert_equal output, "WARNING: Missing config parameters for GithubDeprecations\n"
   end
 
   def test_configure_fails_noop
     # shouldn't raise no method error
-    GithubDeprecations.configure.register!
+    capture_stderr do
+      GithubDeprecations.configure.register!
+    end
+  end
+
+  def test_redis_unavailable_resets
+    Resque.expects(:enqueue).raises(Errno::ECONNREFUSED)
+    output = capture_stderr do
+      GithubDeprecations.configure({
+        :login       => 'some_login',
+        :oauth_token => 'some_token',
+        :repo        => 'some/repo'
+      }).register!
+      ActiveSupport::Deprecation.warn "Roh oh"
+    end
+    assert_equal output, "WARNING: Unable to connect to redis for GithubDeprecations\n"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_deprecations
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-31 00:00:00.000000000 Z
+date: 2012-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport