github_api 0.8.6 → 0.8.7

data/spec/github/pull_requests/commits_spec.rb

@@ -0,0 +1,51 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PullRequests, '#commits' do
+  let(:repo) { 'github' }
+  let(:user) { 'peter-murach' }
+  let(:number) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/pulls/#{number}/commits" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context 'resource found' do
+    let(:body) { fixture('pull_requests/commits.json') }
+    let(:status) { 200 }
+
+    it "throws error if pull_request_id not provided" do
+      expect { subject.commits user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resources" do
+      subject.commits user, repo, number
+      a_get(request_path).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.commits user, repo, number }
+    end
+
+    it "should get pull request information" do
+      pull_requests = subject.commits user, repo, number
+      pull_requests.first.committer.name.should == 'Scott Chacon'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.commits(user, repo, number) { |obj| yielded << obj }
+      yielded.should == result
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.commits user, repo, number }
+  end
+
+end # commits

data/spec/github/pull_requests/create_spec.rb

@@ -0,0 +1,52 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PullRequests, '#create' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:request_path) { "/repos/#{user}/#{repo}/pulls" }
+  let(:inputs) {
+    {
+      "title" => "Amazing new feature",
+      "body" => "Please pull this in!",
+      "head" => "octocat:new-feature",
+      "base" => "master",
+      "state" => "open",
+      'unrelated' => 'giberrish'
+    }
+  }
+
+  before {
+    stub_post(request_path).with(inputs.except('unrelated')).
+      to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce created" do
+    let(:body) { fixture('pull_requests/pull_request.json') }
+    let(:status) { 201 }
+
+    it "should create resource successfully" do
+      subject.create user, repo, inputs
+      a_post(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      pull_request = subject.create user, repo, inputs
+      pull_request.should be_a Hashie::Mash
+    end
+
+    it "should get the request information" do
+      pull_request = subject.create user, repo, inputs
+      pull_request.title.should eql "new-feature"
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.create user, repo, inputs }
+  end
+
+end # create

data/spec/github/pull_requests/files_spec.rb

@@ -0,0 +1,47 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PullRequests, '#files' do
+  let(:repo) { 'github' }
+  let(:user) { 'peter-murach' }
+  let(:number) { 1 }
+  let(:request_path) {  "/repos/#{user}/#{repo}/pulls/#{number}/files" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context 'resource found' do
+    let(:body) { fixture('pull_requests/files.json') }
+    let(:status) { 200 }
+
+    it "should get the resources" do
+      subject.files user, repo, number
+      a_get(request_path).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.files user, repo, number }
+    end
+
+    it "should get pull request information" do
+      pull_requests = subject.files user, repo, number
+      pull_requests.first.filename.should == 'file1.txt'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.files(user, repo, number) { |obj| yielded << obj }
+      yielded.should == result
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.files user, repo, number }
+  end
+
+end # files

data/spec/github/pull_requests/get_spec.rb

@@ -0,0 +1,49 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PullRequests, '#get' do
+  let(:user)   { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:number) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/pulls/#{number}" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context 'resource found' do
+    let(:body) { fixture('pull_requests/pull_request.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :find }
+
+    it "should fail to get resource without pull_request id" do
+      expect { subject.get nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.get user, repo, number
+      a_get(request_path).should have_been_made
+    end
+
+    it "should get pull_request information" do
+      pull_request = subject.get user, repo, number
+      pull_request.number.should eq number
+      pull_request.head.user.login.should == 'octocat'
+    end
+
+    it "should return mash" do
+      pull_request = subject.get user, repo, number
+      pull_request.should be_a Hashie::Mash
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo, number }
+  end
+
+end # get

data/spec/github/pull_requests/list_spec.rb

@@ -0,0 +1,54 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PullRequests, '#list' do
+  let(:repo) { 'github' }
+  let(:user) { 'peter-murach' }
+  let(:inputs) { { 'state'=> 'closed', 'unrelated' => true } }
+  let(:request_path) { "/repos/#{user}/#{repo}/pulls" }
+
+  before {
+    stub_get(request_path).with(:query => inputs.except('unrelated')).
+    to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context 'resource found' do
+    let(:body) { fixture('pull_requests/pull_requests.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :all }
+
+    it "throws error if pull_request id not provided" do
+      expect { subject.list nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resources" do
+      subject.list user, repo, inputs
+      a_get(request_path).with(:query => inputs).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo, inputs }
+    end
+
+    it "should get pull request information" do
+      pull_requests = subject.list user, repo, inputs
+      pull_requests.first.title.should == 'new-feature'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.list(user, repo, inputs) { |obj| yielded << obj }
+      yielded.should == result
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list user, repo, inputs }
+  end
+
+end # list

data/spec/github/pull_requests/merge_spec.rb

@@ -0,0 +1,42 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PullRequests, '#merge' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:number) { 1347 }
+  let(:request_path) { "/repos/#{user}/#{repo}/pulls/#{number}/merge" }
+
+  before {
+    stub_put(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context 'successful' do
+    let(:body) { fixture('pull_requests/merge_success.json') }
+    let(:status) { 200 }
+
+    it 'performs request' do
+      subject.merge user, repo, number
+      a_put(request_path).should have_been_made
+    end
+
+    it 'response contains merge success flag' do
+      response = subject.merge(user, repo, number)
+      response.merged.should be_true
+    end
+  end
+
+  context 'cannot be performed' do
+    let(:body) { fixture('pull_requests/merge_failure.json') }
+    let(:status) { 200 }
+
+    it 'response contains merge failure flag' do
+      response = subject.merge(user, repo, number)
+      response.merged.should be_false
+    end
+  end
+end # merge

data/spec/github/pull_requests/merged_spec.rb

@@ -0,0 +1,37 @@
+
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PullRequests, '#merged?' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:number) { 1347 }
+  let(:request_path) { "/repos/#{user}/#{repo}/pulls/#{number}/merge" }
+
+  before { reset_authentication_for(subject) }
+  after  { reset_authentication_for(subject) }
+
+  context "checks whetehr pull request has been merged" do
+    before {
+      stub_get(request_path).to_return(:body => "[]", :status => 404,
+        :headers => {:user_agent => subject.user_agent})
+    }
+
+    it "should fail validation " do
+      expect { subject.merged?(nil, nil, number) }.to raise_error(ArgumentError)
+    end
+
+    it "should return false if resource not found" do
+      merged = subject.merged? user, repo, number
+      merged.should be_false
+    end
+
+    it "should return true if resoure found" do
+      stub_get(request_path).to_return(:body => "[]", :status => 200,
+        :headers => {:user_agent => subject.user_agent})
+      merged = subject.merged? user, repo, number
+      merged.should be_true
+    end
+  end
+end # merged?

data/spec/github/pull_requests/pull_requests_spec.rb

@@ -0,0 +1,13 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PullRequests, 'integration' do
+
+  after { reset_authentication_for subject }
+
+  it_should_behave_like 'api interface'
+
+  its(:comments) { should be_a Github::PullRequests::Comments }
+
+end # Github::PullRequests

data/spec/github/pull_requests/update_spec.rb

@@ -0,0 +1,51 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PullRequests, '#update' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:number) { 1347 }
+  let(:request_path) { "/repos/#{user}/#{repo}/pulls/#{number}" }
+  let(:inputs) {
+    {
+      "title" => "new title",
+      "body" => "updated body",
+      "state" => "open",
+      "unrelated" => true
+    }
+  }
+
+  before {
+    stub_patch(request_path).with(inputs.except('unrelated')).
+      to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce updateed" do
+    let(:body)   { fixture('pull_requests/pull_request.json') }
+    let(:status) { 201 }
+
+    it "should create resource successfully" do
+      subject.update user, repo, number, inputs
+      a_patch(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      pull_request = subject.update user, repo, number, inputs
+      pull_request.should be_a Hashie::Mash
+    end
+
+    it "should get the pull_request information" do
+      pull_request = subject.update user, repo, number, inputs
+      pull_request.title.should == 'new-feature'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.update user, repo, number, inputs }
+  end
+
+end # update

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_api
 version: !ruby/object:Gem::Version
-  version: 0.8.6
+  version: 0.8.7
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-02 00:00:00.000000000Z
+date: 2013-01-15 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &2152507880 !ruby/object:Gem::Requirement
+  requirement: &2152561220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 1.2.0
   type: :runtime
   prerelease: false
-  version_requirements: *2152507880
+  version_requirements: *2152561220
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &2152438200 !ruby/object:Gem::Requirement
+  requirement: &2152560660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *2152438200
+  version_requirements: *2152560660
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &2152437500 !ruby/object:Gem::Requirement
+  requirement: &2152560040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '1.4'
   type: :runtime
   prerelease: false
-  version_requirements: *2152437500
+  version_requirements: *2152560040
 - !ruby/object:Gem::Dependency
   name: oauth2
-  requirement: &2152436880 !ruby/object:Gem::Requirement
+  requirement: &2152559520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152436880
+  version_requirements: *2152559520
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2152436280 !ruby/object:Gem::Requirement
+  requirement: &2152558760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 1.5.2
   type: :runtime
   prerelease: false
-  version_requirements: *2152436280
+  version_requirements: *2152558760
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2152435780 !ruby/object:Gem::Requirement
+  requirement: &2152521820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152435780
+  version_requirements: *2152521820
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &2152435260 !ruby/object:Gem::Requirement
+  requirement: &2152520480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152435260
+  version_requirements: *2152520480
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2152434700 !ruby/object:Gem::Requirement
+  requirement: &2152519500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: 1.9.0
   type: :development
   prerelease: false
-  version_requirements: *2152434700
+  version_requirements: *2152519500
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2152434220 !ruby/object:Gem::Requirement
+  requirement: &2152517700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 2.3.0
   type: :development
   prerelease: false
-  version_requirements: *2152434220
+  version_requirements: *2152517700
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &2152433700 !ruby/object:Gem::Requirement
+  requirement: &2152515940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 0.7.1
   type: :development
   prerelease: false
-  version_requirements: *2152433700
+  version_requirements: *2152515940
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2152433180 !ruby/object:Gem::Requirement
+  requirement: &2152514200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -131,10 +131,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152433180
+  version_requirements: *2152514200
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2152432620 !ruby/object:Gem::Requirement
+  requirement: &2152511420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -142,10 +142,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152432620
+  version_requirements: *2152511420
 - !ruby/object:Gem::Dependency
   name: guard-cucumber
-  requirement: &2152432040 !ruby/object:Gem::Requirement
+  requirement: &2152509720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -153,10 +153,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152432040
+  version_requirements: *2152509720
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2152414660 !ruby/object:Gem::Requirement
+  requirement: &2152507700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -164,10 +164,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152414660
+  version_requirements: *2152507700
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2152414180 !ruby/object:Gem::Requirement
+  requirement: &2152506840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -175,7 +175,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152414180
+  version_requirements: *2152506840
 description: ! ' Ruby wrapper that supports all of the GitHub API v3 methods(nearly
   200). It''s build in a modular way, that is, you can either instantiate the whole
   api wrapper Github.new or use parts of it e.i. Github::Repos.new if working solely
@@ -650,8 +650,17 @@ files:
 - spec/github/page_links_spec.rb
 - spec/github/paged_request_spec.rb
 - spec/github/parameter_filter_spec.rb
+- spec/github/pull_requests/comments/list_spec.rb
 - spec/github/pull_requests/comments_spec.rb
-- spec/github/pull_requests_spec.rb
+- spec/github/pull_requests/commits_spec.rb
+- spec/github/pull_requests/create_spec.rb
+- spec/github/pull_requests/files_spec.rb
+- spec/github/pull_requests/get_spec.rb
+- spec/github/pull_requests/list_spec.rb
+- spec/github/pull_requests/merge_spec.rb
+- spec/github/pull_requests/merged_spec.rb
+- spec/github/pull_requests/pull_requests_spec.rb
+- spec/github/pull_requests/update_spec.rb
 - spec/github/repos/branch_spec.rb
 - spec/github/repos/branches_spec.rb
 - spec/github/repos/collaborators/add_spec.rb