github_api 0.8.1 → 0.8.2

data/spec/github/repos/list_spec.rb

@@ -24,11 +24,12 @@ describe Github::Repos, '#list' do
         to_return(:body => fixture('repos/repos_sorted_by_pushed.json'), :status => 200,:headers => {:content_type => "application/json; charset=utf-8"} )
     }
 
-    it "fails if user is unauthenticated" do
+    it "falls back to all if user is unauthenticated" do
       subject.oauth_token = nil
-      stub_get("/user/repos").to_return(:body => '', :status => 401,
+      stub_get("/repositories").to_return(:body => '[]', :status => 200,
         :headers => {:content_type => "application/json; charset=utf-8"} )
-      expect { subject.list }.to raise_error(Github::Error::Unauthorized)
+      subject.list
+      a_get('/repositories').should have_been_made
     end
 
     it "should get the resources" do
@@ -57,6 +58,21 @@ describe Github::Repos, '#list' do
     end
   end
 
+  context 'all repositories' do
+    let(:request_path) { '/repositories' }
+
+    before {
+      stub_get(request_path).to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"} )
+    }
+
+    it "should get the resources" do
+      subject.list
+      a_get(request_path).should have_been_made
+    end
+
+  end
+
   context "resource found for organization" do
     let(:org) { '37signals' }
     let(:request_path) { "/orgs/#{org}/repos" }

data/spec/github/repos/merging/merge_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe Github::Repos::Merging, '#merge' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:request_path) { "/repos/#{user}/#{repo}/merges" }
+  let(:inputs) do
+    {
+      "base" => "master",
+      "head" => "cool_feature",
+      "commit_message" => "Shipped cool_feature!"
+    }
+  end
+
+  before {
+    stub_post(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce merged" do
+    let(:body) { fixture('repos/merge.json') }
+    let(:status) { 201 }
+
+    it "should fail to merge resource if 'base' input is missing" do
+      expect {
+        subject.merge user, repo, inputs.except('base')
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should fail to create resource if 'head' input is missing" do
+      expect {
+        subject.merge user, repo, inputs.except('head')
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should merge resource successfully" do
+      subject.merge user, repo, inputs
+      a_post(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      merge = subject.merge user, repo, inputs
+      merge.should be_a Hashie::Mash
+    end
+
+    it "should get the commit comment information" do
+      merge = subject.merge user, repo, inputs
+      merge.commit.author.login.should == 'octocat'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.merge user, repo, inputs }
+  end
+
+end # merge

data/spec/github/repos/pub_sub_hubbub_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Github::Repos::PubSubHubbub do
-  let(:github) { Github.new }
   let(:topic)  { "https://github.com/peter-murach/github/events/push"}
   let(:callback) { "github://campfire?subdomain=github&room=Commits&token=abc123" }
   let(:hub_inputs) {
@@ -14,32 +13,34 @@ describe Github::Repos::PubSubHubbub do
     }
   }
 
-  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+  after { reset_authentication_for subject }
 
   describe "subscribe" do
     context "success" do
       before do
-        github.oauth_token = OAUTH_TOKEN
+        subject.oauth_token = OAUTH_TOKEN
         stub_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).
-          to_return(:body => '', :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => '[]', :status => 200,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should subscribe to hub" do
-        github.repos.pubsubhubbub.subscribe topic, callback
+        subject.subscribe topic, callback
         a_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).should have_been_made
       end
     end
 
     context "failure" do
       before do
-        github.oauth_token = OAUTH_TOKEN
+        subject.oauth_token = OAUTH_TOKEN
         stub_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).
-          to_return(:body => '', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => '[]', :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to subscribe to hub" do
         expect {
-          github.repos.pubsubhubbub.subscribe topic, callback
+          subject.subscribe topic, callback
         }.to raise_error(Github::Error::NotFound)
       end
     end
@@ -48,27 +49,28 @@ describe Github::Repos::PubSubHubbub do
   describe "unsubscribe" do
     context "success" do
       before do
-        github.oauth_token = OAUTH_TOKEN
+        subject.oauth_token = OAUTH_TOKEN
         stub_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs.merge("hub.mode" => 'unsubscribe')).
-          to_return(:body => '', :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+        to_return(:body => '[]', :status => 200,
+          :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should subscribe to hub" do
-        github.repos.pubsubhubbub.unsubscribe topic, callback
+        subject.unsubscribe topic, callback
         a_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).should have_been_made
       end
     end
 
     context "failure" do
       before do
-        github.oauth_token = OAUTH_TOKEN
+        subject.oauth_token = OAUTH_TOKEN
         stub_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs.merge("hub.mode" => 'unsubscribe')).
-          to_return(:body => '', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => '[]', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to subscribe to hub" do
         expect {
-          github.repos.pubsubhubbub.unsubscribe topic, callback
+          subject.unsubscribe topic, callback
         }.to raise_error(Github::Error::NotFound)
       end
     end

data/spec/github/repos/statuses/create_spec.rb

@@ -0,0 +1,54 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Statuses, '#create' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:sha) { 'f5f71ce1b7295c31f091be1654618c7ec0cc6b71' }
+  let(:request_path) { "/repos/#{user}/#{repo}/statuses/#{sha}" }
+  let(:inputs) {
+    {
+      'state' => 'success'
+    }
+  }
+
+  before {
+    stub_post(request_path).with(inputs.except('unrelated')).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource created" do
+    let(:body) { fixture('repos/status.json') }
+    let(:status) { 201 }
+
+    it "should fail to create resource if 'state' input is missing" do
+      expect {
+        subject.create user, repo, sha, inputs.except('state')
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should create resource successfully" do
+      subject.create user, repo, sha, inputs
+      a_post(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      status = subject.create user, repo, sha, inputs
+      status.should be_a Hashie::Mash
+    end
+
+    it "should get the status information" do
+      status = subject.create user, repo, sha, inputs
+      status.state.should == 'success'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.create user, repo, sha, inputs }
+  end
+
+end # create

data/spec/github/repos/statuses/list_spec.rb

@@ -0,0 +1,53 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Statuses, '#list' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:sha) { 'f5f71ce1b7295c31f091be1654618c7ec0cc6b71' }
+  let(:request_path) { "/repos/#{user}/#{repo}/statuses/#{sha}" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body) { fixture('repos/statuses.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :all }
+
+    it "should fail to get resource without sha" do
+      expect { subject.list user, repo }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resources" do
+      subject.list user, repo, sha
+      a_get(request_path).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo, sha }
+    end
+
+    it "should get status information" do
+      statuses = subject.list user, repo, sha
+      statuses.first.state.should == 'success'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.list(user, repo, sha) { |obj| yielded << obj }
+      yielded.should == result
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list user, repo, sha }
+  end
+
+end # list

data/spec/github/repos/statuses_spec.rb

@@ -3,122 +3,9 @@
 require 'spec_helper'
 
 describe Github::Repos::Statuses do
-  let(:github) { Github.new }
-  let(:user) { 'peter-murach' }
-  let(:repo) { 'github' }
-  let(:sha) { 'f5f71ce1b7295c31f091be1654618c7ec0cc6b71' }
-
-  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
 
   it { described_class::VALID_STATUS_PARAM_NAMES.should_not be_nil }
-  it { described_class::REQUIRED_PARAMS.should_not be_nil }
-
-  describe "#list" do
-    it { github.repos.statuses.should respond_to :all }
-
-    context "resource found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/statuses/#{sha}").
-          to_return(:body => fixture('repos/statuses.json'), :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without sha" do
-        expect { github.repos.statuses.list }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resources" do
-        github.repos.statuses.list user, repo, sha
-        a_get("/repos/#{user}/#{repo}/statuses/#{sha}").should have_been_made
-      end
-
-      it "should return array of resources" do
-        statuses = github.repos.statuses.list user, repo, sha
-        statuses.should be_an Array
-        statuses.should have(1).items
-      end
-
-      it "should be a mash type" do
-        statuses = github.repos.statuses.list user, repo, sha
-        statuses.first.should be_a Hashie::Mash
-      end
-
-      it "should get status information" do
-        statuses = github.repos.statuses.list user, repo, sha
-        statuses.first.state.should == 'success'
-      end
-
-      it "should yield to a block" do
-        github.repos.statuses.should_receive(:list).with(user, repo, sha).and_yield('web')
-        github.repos.statuses.list(user, repo, sha) { |param| 'web' }
-      end
-    end
 
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/statuses/#{sha}").
-          to_return(:body => "", :status => [404, "Not Found"])
-      end
-
-      it "should return 404 with a message 'Not Found'" do
-        expect {
-          github.repos.statuses.list user, repo, sha
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # list
-
-  describe "#create" do
-    let(:inputs) {
-      {
-        'state' => 'success'
-      }
-    }
-
-    context "resource created" do
-      before do
-        stub_post("/repos/#{user}/#{repo}/statuses/#{sha}").
-          with(inputs.except('unrelated')).
-          to_return(:body => fixture('repos/status.json'),
-            :status => 201,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to create resource if 'state' input is missing" do
-        expect {
-          github.repos.statuses.create user, repo, sha, inputs.except('state')
-        }.to raise_error(Github::Error::RequiredParams)
-      end
-
-      it "should create resource successfully" do
-        github.repos.statuses.create user, repo, sha, inputs
-        a_post("/repos/#{user}/#{repo}/statuses/#{sha}").with(inputs).should have_been_made
-      end
-
-      it "should return the resource" do
-        status = github.repos.statuses.create user, repo, sha, inputs
-        status.should be_a Hashie::Mash
-      end
-
-      it "should get the status information" do
-        status = github.repos.statuses.create user, repo, sha, inputs
-        status.state.should == 'success'
-      end
-    end
-
-    context "fail to create resource" do
-      before do
-        stub_post("/repos/#{user}/#{repo}/statuses/#{sha}").with(inputs).
-          to_return(:body => fixture('repos/status.json'), :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrieve resource" do
-        expect {
-          github.repos.statuses.create user, repo, sha, inputs
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # create
+  it { described_class::REQUIRED_PARAMS.should_not be_nil }
 
 end # Github::Repos::Statuses

data/spec/github/users/emails/add_spec.rb

@@ -0,0 +1,33 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Users::Emails, '#add' do
+  let(:email) { "octocat@github.com" }
+  let(:request_path) { "/user/emails" }
+
+  before {
+    subject.oauth_token = OAUTH_TOKEN
+    stub_post(request_path).with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  let(:params) { { :per_page => 21, :page => 1 }}
+  let(:body) { fixture('users/emails.json') }
+  let(:status) { 200 }
+
+  it 'extracts request parameters and email data' do
+    subject.should_receive(:post_request).
+      with(request_path, { "per_page" => 21, "page" => 1, "data" => [email] })
+    subject.add email, params
+  end
+
+  it 'submits request successfully' do
+    subject.add email
+    a_post(request_path).with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+      should have_been_made
+  end
+end # add