github_api 0.7.0 → 0.7.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (63) hide show
  1. data/README.md +11 -5
  2. data/Rakefile +2 -0
  3. data/features/repos/statuses.feature +12 -12
  4. data/lib/github_api/api.rb +1 -1
  5. data/lib/github_api/authorizations.rb +3 -3
  6. data/lib/github_api/events.rb +7 -7
  7. data/lib/github_api/gists.rb +7 -7
  8. data/lib/github_api/gists/comments.rb +4 -4
  9. data/lib/github_api/git_data/blobs.rb +2 -3
  10. data/lib/github_api/git_data/commits.rb +2 -3
  11. data/lib/github_api/git_data/references.rb +10 -17
  12. data/lib/github_api/git_data/tags.rb +2 -3
  13. data/lib/github_api/git_data/trees.rb +2 -3
  14. data/lib/github_api/issues.rb +4 -6
  15. data/lib/github_api/issues/assignees.rb +5 -4
  16. data/lib/github_api/issues/comments.rb +5 -10
  17. data/lib/github_api/issues/events.rb +2 -3
  18. data/lib/github_api/issues/labels.rb +11 -20
  19. data/lib/github_api/issues/milestones.rb +5 -8
  20. data/lib/github_api/orgs.rb +2 -2
  21. data/lib/github_api/orgs/members.rb +7 -7
  22. data/lib/github_api/orgs/teams.rb +13 -13
  23. data/lib/github_api/page_iterator.rb +3 -1
  24. data/lib/github_api/pull_requests.rb +8 -16
  25. data/lib/github_api/pull_requests/comments.rb +5 -10
  26. data/lib/github_api/repos.rb +27 -8
  27. data/lib/github_api/repos/collaborators.rb +4 -7
  28. data/lib/github_api/repos/commits.rb +9 -16
  29. data/lib/github_api/repos/downloads.rb +5 -7
  30. data/lib/github_api/repos/forks.rb +3 -3
  31. data/lib/github_api/repos/hooks.rb +10 -13
  32. data/lib/github_api/repos/keys.rb +5 -8
  33. data/lib/github_api/repos/pub_sub_hubbub.rb +4 -4
  34. data/lib/github_api/repos/starring.rb +4 -4
  35. data/lib/github_api/repos/statuses.rb +2 -2
  36. data/lib/github_api/repos/watching.rb +4 -4
  37. data/lib/github_api/users/followers.rb +3 -3
  38. data/lib/github_api/users/keys.rb +3 -3
  39. data/lib/github_api/validations/presence.rb +16 -17
  40. data/lib/github_api/version.rb +1 -1
  41. data/spec/fixtures/repos/repos_sorted_by_pushed.json +56 -0
  42. data/spec/github/git_data_spec.rb +5 -7
  43. data/spec/github/issues_spec.rb +12 -12
  44. data/spec/github/orgs_spec.rb +2 -4
  45. data/spec/github/pull_requests_spec.rb +1 -1
  46. data/spec/github/repos/branch_spec.rb +48 -0
  47. data/spec/github/repos/branches_spec.rb +62 -0
  48. data/spec/github/repos/contributors_spec.rb +62 -0
  49. data/spec/github/repos/create_spec.rb +77 -0
  50. data/spec/github/repos/delete_spec.rb +43 -0
  51. data/spec/github/repos/downloads_spec.rb +51 -45
  52. data/spec/github/repos/edit_spec.rb +66 -0
  53. data/spec/github/repos/forks/create_spec.rb +49 -0
  54. data/spec/github/repos/forks/list_spec.rb +65 -0
  55. data/spec/github/repos/get_spec.rb +57 -0
  56. data/spec/github/repos/languages_spec.rb +61 -0
  57. data/spec/github/repos/list_spec.rb +99 -0
  58. data/spec/github/repos/tags_spec.rb +59 -0
  59. data/spec/github/repos/teams_spec.rb +59 -0
  60. data/spec/github/repos_spec.rb +13 -578
  61. data/spec/github/validations/presence_spec.rb +23 -4
  62. metadata +48 -42
  63. data/spec/github/repos/forks_spec.rb +0 -106
data/lib/github_api/issues/assignees.rb CHANGED
@@ -8,10 +8,11 @@ module Github
8
8
  #
9
9
  # = Examples
10
10
  #
11
- # Github.repos.assignees.list 'user', 'repo'
12
- # Github.repos.assignees.list 'user', 'repo' { |assignee| ... }
11
+ # Github.issues.assignees.list 'user', 'repo'
12
+ # Github.issues.assignees.list 'user', 'repo' { |assignee| ... }
13
13
  #
14
14
  def list(user_name, repo_name, params={})
15
+ assert_presence_of user_name, repo_name
15
16
  normalize! params
16
17
 
17
18
  response = get_request("/repos/#{user_name}/#{repo_name}/assignees", params)
@@ -23,10 +24,10 @@ module Github
23
24
  #
24
25
  # = Examples
25
26
  #
26
- # Github.repos.assignees.check 'user', 'repo', 'assignee'
27
+ # Github.issues.assignees.check 'user', 'repo', 'assignee'
27
28
  #
28
29
  def check(user_name, repo_name, assignee, params={})
29
- _validate_presence_of assignee
30
+ assert_presence_of user_name, repo_name, assignee
30
31
  normalize! params
31
32
 
32
33
  get_request("/repos/#{user_name}/#{repo_name}/assignees/#{assignee}",params)
data/lib/github_api/issues/comments.rb CHANGED
@@ -23,8 +23,7 @@ module Github
23
23
  #
24
24
  def list(user_name, repo_name, issue_id, params={})
25
25
  _update_user_repo_params(user_name, repo_name)
26
- _validate_user_repo_params(user, repo) unless user? && repo?
27
- _validate_presence_of issue_id
26
+ assert_presence_of user, repo, issue_id
28
27
 
29
28
  normalize! params
30
29
  # _merge_mime_type(:issue_comment, params)
@@ -43,8 +42,7 @@ module Github
43
42
  #
44
43
  def get(user_name, repo_name, comment_id, params={})
45
44
  _update_user_repo_params(user_name, repo_name)
46
- _validate_user_repo_params(user, repo) unless user? && repo?
47
- _validate_presence_of comment_id
45
+ assert_presence_of user, repo, comment_id
48
46
 
49
47
  normalize! params
50
48
  # _merge_mime_type(:issue_comment, params)
@@ -65,8 +63,7 @@ module Github
65
63
  #
66
64
  def create(user_name, repo_name, issue_id, params={})
67
65
  _update_user_repo_params(user_name, repo_name)
68
- _validate_user_repo_params(user, repo) unless user? && repo?
69
- _validate_presence_of issue_id
66
+ assert_presence_of user, repo, issue_id
70
67
 
71
68
  normalize! params
72
69
  # _merge_mime_type(:issue_comment, params)
@@ -88,8 +85,7 @@ module Github
88
85
  #
89
86
  def edit(user_name, repo_name, comment_id, params={})
90
87
  _update_user_repo_params(user_name, repo_name)
91
- _validate_user_repo_params(user, repo) unless user? && repo?
92
- _validate_presence_of comment_id
88
+ assert_presence_of user, repo, comment_id
93
89
 
94
90
  normalize! params
95
91
  # _merge_mime_type(:issue_comment, params)
@@ -107,8 +103,7 @@ module Github
107
103
  #
108
104
  def delete(user_name, repo_name, comment_id, params={})
109
105
  _update_user_repo_params(user_name, repo_name)
110
- _validate_user_repo_params(user, repo) unless user? && repo?
111
- _validate_presence_of comment_id
106
+ assert_presence_of user, repo, comment_id
112
107
 
113
108
  normalize! params
114
109
  # _merge_mime_type(:issue_comment, params)
data/lib/github_api/issues/events.rb CHANGED
@@ -22,7 +22,7 @@ module Github
22
22
  #
23
23
  def list(user_name, repo_name, issue_id=nil, params={})
24
24
  _update_user_repo_params(user_name, repo_name)
25
- _validate_user_repo_params(user, repo) unless user? && repo?
25
+ assert_presence_of user, repo
26
26
  normalize! params
27
27
 
28
28
  response = if issue_id
@@ -43,8 +43,7 @@ module Github
43
43
  #
44
44
  def get(user_name, repo_name, event_id, params={})
45
45
  _update_user_repo_params(user_name, repo_name)
46
- _validate_user_repo_params(user, repo) unless user? && repo?
47
- _validate_presence_of event_id
46
+ assert_presence_of user, repo, event_id
48
47
  normalize! params
49
48
 
50
49
  get_request("/repos/#{user}/#{repo}/issues/events/#{event_id}")
data/lib/github_api/issues/labels.rb CHANGED
@@ -10,8 +10,6 @@ module Github
10
10
  super(options)
11
11
  end
12
12
 
13
- # TODO Merge repository, issues and milesonte labels insdie one query
14
-
15
13
  # List all labels for a repository
16
14
  #
17
15
  # = Examples
@@ -21,7 +19,7 @@ module Github
21
19
  #
22
20
  def list(user_name, repo_name, params={})
23
21
  _update_user_repo_params(user_name, repo_name)
24
- _validate_user_repo_params(user, repo) unless user? && repo?
22
+ assert_presence_of user, repo
25
23
  normalize! params
26
24
 
27
25
  response = get_request("/repos/#{user}/#{repo}/labels", params)
@@ -38,8 +36,7 @@ module Github
38
36
  #
39
37
  def get(user_name, repo_name, label_id, params={})
40
38
  _update_user_repo_params(user_name, repo_name)
41
- _validate_user_repo_params(user, repo) unless user? && repo?
42
- _validate_presence_of label_id
39
+ assert_presence_of user, repo, label_id
43
40
  normalize! params
44
41
 
45
42
  get_request("/repos/#{user}/#{repo}/labels/#{label_id}", params)
@@ -58,7 +55,7 @@ module Github
58
55
  #
59
56
  def create(user_name, repo_name, params={})
60
57
  _update_user_repo_params(user_name, repo_name)
61
- _validate_user_repo_params(user, repo) unless user? && repo?
58
+ assert_presence_of user, repo
62
59
 
63
60
  normalize! params
64
61
  filter! VALID_LABEL_INPUTS, params
@@ -80,8 +77,7 @@ module Github
80
77
  #
81
78
  def update(user_name, repo_name, label_id, params={})
82
79
  _update_user_repo_params(user_name, repo_name)
83
- _validate_user_repo_params(user, repo) unless user? && repo?
84
- _validate_presence_of label_id
80
+ assert_presence_of user, repo, label_id
85
81
 
86
82
  normalize! params
87
83
  filter! VALID_LABEL_INPUTS, params
@@ -99,9 +95,9 @@ module Github
99
95
  #
100
96
  def delete(user_name, repo_name, label_id, params={})
101
97
  _update_user_repo_params(user_name, repo_name)
102
- _validate_user_repo_params(user, repo) unless user? && repo?
98
+ assert_presence_of user, repo
103
99
 
104
- _validate_presence_of label_id
100
+ assert_presence_of label_id
105
101
  normalize! params
106
102
 
107
103
  delete_request("/repos/#{user}/#{repo}/labels/#{label_id}", params)
@@ -115,8 +111,7 @@ module Github
115
111
  #
116
112
  def issue(user_name, repo_name, issue_id, params={})
117
113
  _update_user_repo_params(user_name, repo_name)
118
- _validate_user_repo_params(user, repo) unless user? && repo?
119
- _validate_presence_of(issue_id)
114
+ assert_presence_of user, repo, issue_id
120
115
  normalize! params
121
116
 
122
117
  get_request("/repos/#{user}/#{repo}/issues/#{issue_id}/labels", params)
@@ -133,8 +128,7 @@ module Github
133
128
  params['data'] = args unless args.empty?
134
129
 
135
130
  _update_user_repo_params(user_name, repo_name)
136
- _validate_user_repo_params(user, repo) unless user? && repo?
137
- _validate_presence_of(issue_id)
131
+ assert_presence_of user, repo, issue_id
138
132
  normalize! params
139
133
 
140
134
  post_request("/repos/#{user}/#{repo}/issues/#{issue_id}/labels", params)
@@ -154,8 +148,7 @@ module Github
154
148
  #
155
149
  def remove(user_name, repo_name, issue_id, label_id=nil, params={})
156
150
  _update_user_repo_params(user_name, repo_name)
157
- _validate_user_repo_params(user, repo) unless user? && repo?
158
- _validate_presence_of issue_id
151
+ assert_presence_of user, repo, issue_id
159
152
  normalize! params
160
153
 
161
154
  if label_id
@@ -178,8 +171,7 @@ module Github
178
171
  params['data'] = args unless args.empty?
179
172
 
180
173
  _update_user_repo_params(user_name, repo_name)
181
- _validate_user_repo_params(user, repo) unless user? && repo?
182
- _validate_presence_of issue_id
174
+ assert_presence_of user, repo, issue_id
183
175
  normalize! params
184
176
 
185
177
  put_request("/repos/#{user}/#{repo}/issues/#{issue_id}/labels", params)
@@ -193,8 +185,7 @@ module Github
193
185
  #
194
186
  def milestone(user_name, repo_name, milestone_id, params={})
195
187
  _update_user_repo_params(user_name, repo_name)
196
- _validate_user_repo_params(user, repo) unless user? && repo?
197
- _validate_presence_of milestone_id
188
+ assert_presence_of user, repo, milestone_id
198
189
  normalize! params
199
190
 
200
191
  response = get_request("/repos/#{user}/#{repo}/milestones/#{milestone_id}/labels", params)
data/lib/github_api/issues/milestones.rb CHANGED
@@ -40,7 +40,7 @@ module Github
40
40
  #
41
41
  def list(user_name, repo_name, params={})
42
42
  _update_user_repo_params(user_name, repo_name)
43
- _validate_user_repo_params(user, repo) unless user? && repo?
43
+ assert_presence_of user, repo
44
44
 
45
45
  normalize! params
46
46
  filter! VALID_MILESTONE_OPTIONS.keys, params
@@ -60,8 +60,7 @@ module Github
60
60
  #
61
61
  def get(user_name, repo_name, milestone_id, params={})
62
62
  _update_user_repo_params(user_name, repo_name)
63
- _validate_user_repo_params(user, repo) unless user? && repo?
64
- _validate_presence_of milestone_id
63
+ assert_presence_of user, repo, milestone_id
65
64
  normalize! params
66
65
 
67
66
  get_request("/repos/#{user}/#{repo}/milestones/#{milestone_id}", params)
@@ -85,7 +84,7 @@ module Github
85
84
  #
86
85
  def create(user_name, repo_name, params={})
87
86
  _update_user_repo_params(user_name, repo_name)
88
- _validate_user_repo_params(user, repo) unless user? && repo?
87
+ assert_presence_of user, repo
89
88
 
90
89
  normalize! params
91
90
  filter! VALID_MILESTONE_INPUTS, params
@@ -112,8 +111,7 @@ module Github
112
111
  #
113
112
  def update(user_name, repo_name, milestone_id, params={})
114
113
  _update_user_repo_params(user_name, repo_name)
115
- _validate_user_repo_params(user, repo) unless user? && repo?
116
- _validate_presence_of milestone_id
114
+ assert_presence_of user, repo, milestone_id
117
115
 
118
116
  normalize! params
119
117
  filter! VALID_MILESTONE_INPUTS, params
@@ -130,8 +128,7 @@ module Github
130
128
  #
131
129
  def delete(user_name, repo_name, milestone_id, params={})
132
130
  _update_user_repo_params(user_name, repo_name)
133
- _validate_user_repo_params(user, repo) unless user? && repo?
134
- _validate_presence_of milestone_id
131
+ assert_presence_of user, repo, milestone_id
135
132
  normalize! params
136
133
 
137
134
  delete_request("/repos/#{user}/#{repo}/milestones/#{milestone_id}", params)
data/lib/github_api/orgs.rb CHANGED
@@ -64,7 +64,7 @@ module Github
64
64
  # github.orgs.get 'github'
65
65
  #
66
66
  def get(org_name, params={})
67
- _validate_presence_of org_name
67
+ assert_presence_of org_name
68
68
  normalize! params
69
69
  get_request("/orgs/#{org_name}", params)
70
70
  end
@@ -90,7 +90,7 @@ module Github
90
90
  # "name" => "github"
91
91
  #
92
92
  def edit(org_name, params={})
93
- _validate_presence_of org_name
93
+ assert_presence_of org_name
94
94
  normalize! params
95
95
  filter! VALID_ORG_PARAM_NAMES, params
96
96
 
data/lib/github_api/orgs/members.rb CHANGED
@@ -17,7 +17,7 @@ module Github
17
17
  # github.orgs.members.list 'org-name' { |memb| ... }
18
18
  #
19
19
  def list(org_name, params={})
20
- _validate_presence_of org_name
20
+ assert_presence_of org_name
21
21
  normalize! params
22
22
  response = get_request("/orgs/#{org_name}/members", params)
23
23
  return response unless block_given?
@@ -32,7 +32,7 @@ module Github
32
32
  # github.orgs.members.member? 'org-name', 'member-name'
33
33
  #
34
34
  def member?(org_name, member_name, params={})
35
- _validate_presence_of org_name, member_name
35
+ assert_presence_of org_name, member_name
36
36
  normalize! params
37
37
  get_request("/orgs/#{org_name}/members/#{member_name}", params)
38
38
  true
@@ -49,7 +49,7 @@ module Github
49
49
  # github.orgs.members.remove 'org-name', 'member-name'
50
50
  #
51
51
  def delete(org_name, member_name, params={})
52
- _validate_presence_of org_name, member_name
52
+ assert_presence_of org_name, member_name
53
53
  normalize! params
54
54
  delete_request("/orgs/#{org_name}/members/#{member_name}", params)
55
55
  end
@@ -63,7 +63,7 @@ module Github
63
63
  # github.orgs.members.list_public 'org-name' { |memb| ... }
64
64
  #
65
65
  def list_public(org_name, params={})
66
- _validate_presence_of org_name
66
+ assert_presence_of org_name
67
67
  normalize! params
68
68
  response = get_request("/orgs/#{org_name}/public_members", params)
69
69
  return response unless block_given?
@@ -78,7 +78,7 @@ module Github
78
78
  # github.orgs.members.public_member? 'org-name', 'member-name'
79
79
  #
80
80
  def public_member?(org_name, member_name, params={})
81
- _validate_presence_of org_name, member_name
81
+ assert_presence_of org_name, member_name
82
82
  normalize! params
83
83
  get_request("/orgs/#{org_name}/public_members/#{member_name}", params)
84
84
  true
@@ -93,7 +93,7 @@ module Github
93
93
  # github.orgs.members.publicize 'org-name', 'member-name'
94
94
  #
95
95
  def publicize(org_name, member_name, params={})
96
- _validate_presence_of org_name, member_name
96
+ assert_presence_of org_name, member_name
97
97
  normalize! params
98
98
  put_request("/orgs/#{org_name}/public_members/#{member_name}", params)
99
99
  end
@@ -107,7 +107,7 @@ module Github
107
107
  # github.orgs.members.conceal 'org-name', 'member-name'
108
108
  #
109
109
  def conceal(org_name, member_name, params={})
110
- _validate_presence_of org_name, member_name
110
+ assert_presence_of org_name, member_name
111
111
  normalize! params
112
112
  delete_request("/orgs/#{org_name}/public_members/#{member_name}", params)
113
113
  end
data/lib/github_api/orgs/teams.rb CHANGED
@@ -18,7 +18,7 @@ module Github
18
18
  # github.orgs.teams.list 'org-name'
19
19
  #
20
20
  def list(org_name, params={})
21
- _validate_presence_of org_name
21
+ assert_presence_of org_name
22
22
  normalize! params
23
23
 
24
24
  response = get_request("/orgs/#{org_name}/teams", params)
@@ -34,7 +34,7 @@ module Github
34
34
  # github.orgs.teams.get 'team-id'
35
35
  #
36
36
  def get(team_id, params={})
37
- _validate_presence_of team_id
37
+ assert_presence_of team_id
38
38
  normalize! params
39
39
 
40
40
  get_request("/teams/#{team_id}", params)
@@ -62,7 +62,7 @@ module Github
62
62
  # ]
63
63
  #
64
64
  def create(org_name, params={})
65
- _validate_presence_of org_name
65
+ assert_presence_of org_name
66
66
  normalize! params
67
67
  filter! VALID_TEAM_PARAM_NAMES, params
68
68
  assert_valid_values(VALID_TEAM_PARAM_VALUES, params)
@@ -88,7 +88,7 @@ module Github
88
88
  # "permission" => "push"
89
89
  #
90
90
  def edit(team_id, params={})
91
- _validate_presence_of team_id
91
+ assert_presence_of team_id
92
92
  normalize! params
93
93
  filter! VALID_TEAM_PARAM_NAMES, params
94
94
  assert_valid_values(VALID_TEAM_PARAM_VALUES, params)
@@ -105,7 +105,7 @@ module Github
105
105
  # github.orgs.teams.delete 'team-id'
106
106
  #
107
107
  def delete(team_id, params={})
108
- _validate_presence_of team_id
108
+ assert_presence_of team_id
109
109
  normalize! params
110
110
  delete_request("/teams/#{team_id}", params)
111
111
  end
@@ -120,7 +120,7 @@ module Github
120
120
  # github.orgs.teams.list_members 'team-id' { |member| ... }
121
121
  #
122
122
  def list_members(team_id, params={})
123
- _validate_presence_of team_id
123
+ assert_presence_of team_id
124
124
  normalize! params
125
125
 
126
126
  response = get_request("/teams/#{team_id}/members", params)
@@ -136,7 +136,7 @@ module Github
136
136
  # github.orgs.teams.team_member? 'team-id', 'user-name'
137
137
  #
138
138
  def team_member?(team_id, member_name, params={})
139
- _validate_presence_of team_id, member_name
139
+ assert_presence_of team_id, member_name
140
140
  normalize! params
141
141
  get_request("/teams/#{team_id}/members/#{member_name}", params)
142
142
  true
@@ -152,7 +152,7 @@ module Github
152
152
  # github.orgs.teams.add_member 'team-id', 'user-name'
153
153
  #
154
154
  def add_member(team_id, member_name, params={})
155
- _validate_presence_of team_id, member_name
155
+ assert_presence_of team_id, member_name
156
156
  normalize! params
157
157
  put_request("/teams/#{team_id}/members/#{member_name}", params)
158
158
  end
@@ -169,7 +169,7 @@ module Github
169
169
  # github.orgs.teams.remove_member 'team-id', 'member-name'
170
170
  #
171
171
  def remove_member(team_id, member_name, params={})
172
- _validate_presence_of team_id, member_name
172
+ assert_presence_of team_id, member_name
173
173
  normalize! params
174
174
  delete_request("/teams/#{team_id}/members/#{member_name}", params)
175
175
  end
@@ -182,7 +182,7 @@ module Github
182
182
  # github.orgs.teams.list_repos 'team-id'
183
183
  #
184
184
  def list_repos(team_id, params={})
185
- _validate_presence_of team_id
185
+ assert_presence_of team_id
186
186
  normalize! params
187
187
 
188
188
  response = get_request("/teams/#{team_id}/repos", params)
@@ -198,7 +198,7 @@ module Github
198
198
  # github.orgs.teams.team_repo? 'team-id', 'user-name', 'repo-name'
199
199
  #
200
200
  def team_repo?(team_id, user_name, repo_name, params={})
201
- _validate_presence_of team_id, user_name, repo_name
201
+ assert_presence_of team_id, user_name, repo_name
202
202
  normalize! params
203
203
  get_request("/teams/#{team_id}/repos/#{user_name}/#{repo_name}", params)
204
204
  true
@@ -219,7 +219,7 @@ module Github
219
219
  # github.orgs.teams.add_repo 'team-id', 'user-name', 'repo-name'
220
220
  #
221
221
  def add_repo(team_id, user_name, repo_name, params={})
222
- _validate_presence_of team_id, user_name, repo_name
222
+ assert_presence_of team_id, user_name, repo_name
223
223
  normalize! params
224
224
  put_request("/teams/#{team_id}/repos/#{user_name}/#{repo_name}", params)
225
225
  end
@@ -236,7 +236,7 @@ module Github
236
236
  # github.orgs.teams.remove_repo 'team-id', 'user-name', 'repo-name'
237
237
  #
238
238
  def remove_repo(team_id, user_name, repo_name, params={})
239
- _validate_presence_of team_id, user_name, repo_name
239
+ assert_presence_of team_id, user_name, repo_name
240
240
  normalize! params
241
241
  delete_request("/teams/#{team_id}/repos/#{user_name}/#{repo_name}", params)
242
242
  end
data/lib/github_api/page_iterator.rb CHANGED
@@ -1,4 +1,6 @@
1
- # encoding: utf-8 require 'github_api/utils/url'
1
+ # encoding: utf-8
2
+
3
+ require 'github_api/utils/url'
2
4
 
3
5
  module Github
4
6
  class PageIterator
data/lib/github_api/pull_requests.rb CHANGED
@@ -45,7 +45,7 @@ module Github
45
45
  #
46
46
  def list(user_name, repo_name, params={})
47
47
  _update_user_repo_params(user_name, repo_name)
48
- _validate_user_repo_params(user, repo) unless (user? && repo?)
48
+ assert_presence_of user, repo
49
49
 
50
50
  normalize! params
51
51
  filter! VALID_REQUEST_PARAM_NAMES, params
@@ -69,9 +69,7 @@ module Github
69
69
  #
70
70
  def get(user_name, repo_name, request_id, params={})
71
71
  _update_user_repo_params(user_name, repo_name)
72
- _validate_user_repo_params(user, repo) unless user? && repo?
73
- _validate_presence_of request_id
74
-
72
+ assert_presence_of user, repo, request_id
75
73
  normalize! params
76
74
  # _merge_mime_type(:pull_request, params)
77
75
 
@@ -110,7 +108,7 @@ module Github
110
108
  #
111
109
  def create(user_name, repo_name, params={})
112
110
  _update_user_repo_params(user_name, repo_name)
113
- _validate_user_repo_params(user, repo) unless user? && repo?
111
+ assert_presence_of user, repo
114
112
 
115
113
  normalize! params
116
114
  # _merge_mime_type(:pull_request, params)
@@ -135,8 +133,7 @@ module Github
135
133
  #
136
134
  def update(user_name, repo_name, request_id, params={})
137
135
  _update_user_repo_params(user_name, repo_name)
138
- _validate_user_repo_params(user, repo) unless user? && repo?
139
- _validate_presence_of request_id
136
+ assert_presence_of user, repo, request_id
140
137
 
141
138
  normalize! params
142
139
  filter! VALID_REQUEST_PARAM_NAMES, params
@@ -154,8 +151,7 @@ module Github
154
151
  #
155
152
  def commits(user_name, repo_name, request_id, params={})
156
153
  _update_user_repo_params(user_name, repo_name)
157
- _validate_user_repo_params(user, repo) unless user? && repo?
158
- _validate_presence_of request_id
154
+ assert_presence_of user, repo, request_id
159
155
 
160
156
  normalize! params
161
157
  # _merge_mime_type(:pull_request, params)
@@ -173,9 +169,7 @@ module Github
173
169
  #
174
170
  def files(user_name, repo_name, request_id, params={})
175
171
  _update_user_repo_params(user_name, repo_name)
176
- _validate_user_repo_params(user, repo) unless user? && repo?
177
- _validate_presence_of request_id
178
-
172
+ assert_presence_of user, repo, request_id
179
173
  normalize! params
180
174
  # _merge_mime_type(:pull_request, params)
181
175
 
@@ -192,8 +186,7 @@ module Github
192
186
  #
193
187
  def merged?(user_name, repo_name, request_id, params={})
194
188
  _update_user_repo_params(user_name, repo_name)
195
- _validate_user_repo_params(user, repo) unless user? && repo?
196
- _validate_presence_of request_id
189
+ assert_presence_of user, repo, request_id
197
190
 
198
191
  normalize! params
199
192
  # _merge_mime_type(:pull_request, params)
@@ -215,8 +208,7 @@ module Github
215
208
  #
216
209
  def merge(user_name, repo_name, request_id, params={})
217
210
  _update_user_repo_params(user_name, repo_name)
218
- _validate_user_repo_params(user, repo) unless user? && repo?
219
- _validate_presence_of request_id
211
+ assert_presence_of user, repo, request_id
220
212
 
221
213
  normalize! params
222
214
  # _merge_mime_type(:pull_request, params)