github_api 0.6.3 → 0.6.4

data/README.md

@@ -301,6 +301,24 @@ res.next_page
 res.last_page
 ```
 
+## Error Handling
+
+The generic error class `Github::Error::GithubError` will handle both the client(`Github::Error::ClientError`) and service(`Github::Error::ServiceError`) side errors. For instance in your code you can catch erros like
+
+```ruby
+begin
+  # Do something with github_api gem
+rescue Github::Error::GithubError => e
+  puts e.message
+
+  if e.is_a? Github::Error::ServiceError
+    # handle GitHub service errors such as 404
+  elsif e.is_a? Github::Error::ClientError
+    # handle client errors e.i. missing required parameter in request
+  end
+end
+```
+
 ## Response Message
 
 Each response comes packaged with methods allowing for inspection of HTTP start line and headers. For example to check for rate limits and status code issue

data/lib/github_api/api.rb

@@ -5,6 +5,7 @@ require 'github_api/connection'
 require 'github_api/validations'
 require 'github_api/request'
 require 'github_api/mime_type'
+require 'github_api/rate_limit'
 require 'github_api/core_ext/hash'
 require 'github_api/core_ext/array'
 require 'github_api/compatibility'
@@ -13,10 +14,12 @@ require 'github_api/api_factory'
 
 module Github
   class API
+    include Constants
     include Authorization
     include MimeType
     include Connection
     include Request
+    include RateLimit
 
     # TODO consider these optional in a stack
     include Validations
@@ -83,19 +86,17 @@ module Github
       end
     end
 
+    def update_settings(options={})
+      options.each do |key, val|
+        self.instance_variable_set(:"@#{key}", val)
+      end
+    end
+
     def _update_user_repo_params(user_name, repo_name=nil) # :nodoc:
       self.user = user_name || self.user
       self.repo = repo_name || self.repo
     end
 
-    def _merge_user_into_params!(params)  #  :nodoc:
-      params.merge!({ 'user' => self.user }) if user?
-    end
-
-    def _merge_user_repo_into_params!(params)   #  :nodoc:
-      { 'user' => self.user, 'repo' => self.repo }.merge!(params)
-    end
-
     # TODO: See whether still needed, consider adding to core_exts
     def _hash_traverse(hash, &block)
       hash.each do |key, val|

data/lib/github_api/authorization.rb

@@ -6,11 +6,13 @@ module Github
     attr_accessor :scopes
 
     # Setup OAuth2 instance
-    def client
+    def client(options={})
       @client ||= ::OAuth2::Client.new(client_id, client_secret,
-        :site          => 'https://github.com',
-        :authorize_url => 'login/oauth/authorize',
-        :token_url     => 'login/oauth/access_token'
+        {
+          :site          => options.fetch(:site) { Github.site },
+          :authorize_url => 'login/oauth/authorize',
+          :token_url     => 'login/oauth/access_token'
+        }
       )
     end
 

data/lib/github_api/configuration.rb

@@ -9,6 +9,7 @@ module Github
       :client_secret,
       :oauth_token,
       :endpoint,
+      :site,
       :mime_type,
       :user_agent,
       :connection_options,
@@ -40,9 +41,12 @@ module Github
     # By default, don't set a user basic authentication
     DEFAULT_BASIC_AUTH = nil
 
-    # The endpoint used to connect to GitHub if none is set
+    # The api endpoint used to connect to GitHub if none is set
     DEFAULT_ENDPOINT = 'https://api.github.com'.freeze
 
+    # The web endpoint used to connect to GitHub if none is set
+    DEFAULT_SITE = 'https://github.com'.freeze
+
     # The value sent in the http header for 'User-Agent' if none is set
     DEFAULT_USER_AGENT = "Github Ruby Gem #{Github::VERSION::STRING}".freeze
 
@@ -81,6 +85,7 @@ module Github
       self.client_secret      = DEFAULT_CLIENT_SECRET
       self.oauth_token        = DEFAULT_OAUTH_TOKEN
       self.endpoint           = DEFAULT_ENDPOINT
+      self.site               = DEFAULT_SITE
       self.user_agent         = DEFAULT_USER_AGENT
       self.connection_options = DEFAULT_CONNECTION_OPTIONS
       self.mime_type          = DEFAULT_MIME_TYPE

data/lib/github_api/connection.rb

@@ -26,9 +26,10 @@ module Github
     def default_options(options={})
       {
         :headers => {
-          ACCEPT           => "application/vnd.github.v3.raw+json," \
-                              "application/vnd.github.beta.raw+json;q=0.5," \
-                              "application/json;q=0.1",
+          ACCEPT           =>  "application/json" \
+                               "application/vnd.github+json;q=0.7" \
+                               "application/vnd.github.v3.raw+json;q=0.5" \
+                               "application/vnd.github.beta.raw+json;q=0.1",
           ACCEPT_CHARSET   => "utf-8",
           USER_AGENT       => user_agent,
           CONTENT_TYPE     => 'application/json'

data/lib/github_api/error.rb

@@ -5,31 +5,40 @@ module Github
     class GithubError < StandardError
       attr_reader :response_message, :response_headers
 
-      def initialize(message)
-        super message
-        @response_message = message
+      # Initialize a new Github error object.
+      #
+      def initialize(message=$!)
+        if message.respond_to?(:backtrace)
+          super(message.message)
+          @response_message = message
+        else
+          super(message.to_s)
+        end
       end
 
-#       def inspect
-#         %(#<#{self.class}>)
-#       end
-    end
+      def backtrace
+        @response_message ? @response_message.backtrace : super
+      end
+
+    end # GithubError
   end # Error
 end # Github
 
 %w[
   service_error
-  not_found
-  forbidden
   bad_request
   unauthorized
-  service_unavailable
-  internal_server_error
+  forbidden
+  not_found
+  not_acceptable
   unprocessable_entity
+  internal_server_error
+  service_unavailable
   client_error
   invalid_options
   required_params
   unknown_value
+  validations
 ].each do |error|
   require "github_api/error/#{error}"
 end

data/lib/github_api/error/bad_request.rb

@@ -4,8 +4,10 @@ module Github
   module Error
     # Raised when Github returns the HTTP status code 400
     class BadRequest < ServiceError
-      def initialize(env)
-        super(env)
+      http_status_code 400
+
+      def initialize(response)
+        super(response)
       end
     end
   end

data/lib/github_api/error/forbidden.rb

@@ -3,9 +3,11 @@
 module Github #:nodoc
   # Raised when Github returns the HTTP status code 403
   module Error
-    class Forbidden < GithubError
-      def initialize(env)
-        super(env)
+    class Forbidden < ServiceError
+      http_status_code 403
+
+      def initialize(response)
+        super(response)
       end
     end
   end # Error

data/lib/github_api/error/internal_server_error.rb

@@ -3,10 +3,13 @@
 module Github #:nodoc
   # Raised when Github returns the HTTP status code 500
   module Error
-    class InternalServerError < GithubError
-      def initialize(env)
-        super(env)
+    class InternalServerError < ServiceError
+      http_status_code 500
+
+      def initialize(response)
+        super(response)
       end
-    end
+
+    end # InternalServerError
   end # Error
 end # Github

data/lib/github_api/error/not_acceptable.rb

@@ -0,0 +1,15 @@
+# encoding: utf-8
+
+module Github #:nodoc
+  # Raised when GitHub returns the HTTP status code 406
+  module Error
+    class NotAcceptable < ServiceError
+      http_status_code 406
+
+      def initialize(response)
+        super(response)
+      end
+
+    end # NotAcceptable
+  end # Error
+end # Github

data/lib/github_api/error/not_found.rb

@@ -4,6 +4,8 @@ module Github #:nodoc
   # Raised when Github returns the HTTP status code 404
   module Error
     class NotFound < ServiceError
+      http_status_code 404
+
       def initialize(env)
         super(env)
       end

data/lib/github_api/error/service_error.rb

@@ -1,19 +1,56 @@
 # encoding: utf-8
+require 'multi_json'
 
-module Github #:nodoc
-  # Raised when Github returns any of the HTTP status codes
+module Github
+  # Raised when GitHub returns any of the HTTP status codes
   module Error
     class ServiceError < GithubError
-      attr_accessor :http_headers
+      attr_reader :http_headers
 
-      def initialize(env)
-        super(generate_message(env))
-        @http_headers = env[:response_headers]
+      def initialize(response)
+        @http_headers = response[:response_headers]
+        message = parse_response(response)
+        super(message)
       end
 
-      def generate_message(env)
-        "#{env[:method].to_s.upcase} #{env[:url].to_s}: #{env[:status]} #{env[:body]}"
+      def parse_response(response)
+        body = parse_body(response[:body])
+        "#{response[:method].to_s.upcase} #{response[:url].to_s}: #{response[:status]} #{body}"
       end
+
+      def decode_body(body)
+        if body.respond_to?(:to_str) && body.length >= 2
+           MultiJson.load(body, :symbolize_keys => true)
+        else
+          body
+        end
+      end
+
+      def parse_body(body)
+        body = decode_body(body)
+
+        return '' if body.nil? || body.empty?
+
+        if body[:error]
+          body[:error]
+        elsif body[:errors]
+          error = Array(body[:errors]).first
+          if error.kind_of?(Hash)
+            error[:message]
+          else
+            error
+          end
+        elsif body[:message]
+          body[:message]
+        else
+          ''
+        end
+      end
+
+      def self.http_status_code(code)
+        define_method(:http_status_code) { code }
+      end
+
     end
   end # Error
 end # Github

data/lib/github_api/error/service_unavailable.rb

@@ -1,12 +1,15 @@
 # encoding: utf-8
 
 module Github #:nodoc
-  # Raised when Github returns the HTTP status code 404
+  # Raised when Github returns the HTTP status code 503
   module Error
-    class ServiceUnavailable < GithubError
-      def initialize(env)
-        super(env)
+    class ServiceUnavailable < ServiceError
+      http_status_code 503
+
+      def initialize(response)
+        super(response)
       end
-    end
+
+    end # ServiceUnavailable
   end # Error
 end # Github

data/lib/github_api/error/unauthorized.rb

@@ -3,10 +3,13 @@
 module Github #:nodoc
   # Raised when Github returns the HTTP status code 401
   module Error
-    class Unauthorized < GithubError
-      def initialize(env)
-        super(env)
+    class Unauthorized < ServiceError
+      http_status_code 401
+
+      def initialize(response)
+        super(response)
       end
-    end
+
+    end # Unauthorized
   end # Error
 end # Github

data/lib/github_api/error/unprocessable_entity.rb

@@ -3,9 +3,11 @@
 module Github #:nodoc
   # Raised when Github returns the HTTP status code 422
   module Error
-    class UnprocessableEntity < GithubError
-      def initialize(env)
-        super(env)
+    class UnprocessableEntity < ServiceError
+      http_status_code 422
+
+      def initialize(response)
+        super(response)
       end
     end
   end # Error

data/lib/github_api/error/validations.rb

@@ -7,9 +7,9 @@ module Github #:nodoc
       def initialize(errors)
         super(
           generate_message(
-            :problem => '',
-            :summary => '',
-            :resolution => ''
+            :problem => "Attempted to send request with nil arguments for #{errors.keys.join(', ')}.",
+            :summary => 'Each request expects certain number of arguments.',
+            :resolution => 'Double check that the provided arguments are set to some value.'
           )
         )
       end

data/lib/github_api/rate_limit.rb

@@ -0,0 +1,13 @@
+module Github
+  module RateLimit
+
+    def ratelimit
+      get_request("/rate_limit").rate.limit
+    end
+
+    def ratelimit_remaining
+      get_request("/rate_limit").rate.remaining
+    end
+
+  end # RateLimit
+end # Github

data/lib/github_api/repos.rb

@@ -54,7 +54,7 @@ module Github
 
     # Access to Repos::Contents API
     def contents
-      @commits ||= ApiFactory.new 'Repos::Contents'
+      @contents ||= ApiFactory.new 'Repos::Contents'
     end
 
     # Access to Repos::Downloads API
@@ -277,7 +277,6 @@ module Github
     def list(*args)
       params = args.extract_options!
       normalize! params
-      _merge_user_into_params!(params) unless params.has_key?('user')
       filter! %w[ org user type ], params
 
       response = if (user_name = params.delete("user"))

data/lib/github_api/repos/watching.rb

@@ -35,7 +35,6 @@ module Github
     def watched(*args)
       params = args.extract_options!
       normalize! params
-      _merge_user_into_params!(params) unless params.has_key?('user')
 
       response = if (user_name = params.delete('user'))
         get_request("/users/#{user_name}/watched", params)

data/lib/github_api/response/raise_error.rb

@@ -16,6 +16,8 @@ module Github
         raise Github::Error::Forbidden.new(env)
       when 404
         raise Github::Error::NotFound.new(env)
+      when 406
+        raise Github::Error::NotAcceptable.new(env)
       when 422
         raise Github::Error::UnprocessableEntity.new(env)
       when 500

data/lib/github_api/validations/presence.rb

@@ -8,8 +8,13 @@ module Github
       # Ensures that esential arguments are present before request is made
       #
       def _validate_presence_of(*params)
-        params.each do |param|
-          raise ArgumentError, "parameter cannot be nil" if param.nil?
+        case params
+        when Hash
+          raise Github::Error::Validations.new(params)
+        when Array
+          params.each do |param|
+            raise ArgumentError, "parameter cannot be nil" if param.nil?
+          end
         end
       end
 

data/lib/github_api/version.rb

@@ -4,7 +4,7 @@ module Github
   module VERSION
     MAJOR = 0
     MINOR = 6
-    PATCH = 3
+    PATCH = 4
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.');

data/spec/github/error/service_error_spec.rb

@@ -0,0 +1,43 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Error::ServiceError do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+
+  def test_request(body='')
+    stub_get("/repos/#{user}/#{repo}/branches").
+      to_return(:body => body, :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+  end
+
+  it "handles empty message" do
+    test_request
+    expect {
+      Github.repos.branches user, repo
+    }.to raise_error(Github::Error::NotFound)
+  end
+
+  it "handles error message" do
+    test_request :error => 'not found'
+    expect {
+      Github.repos.branches user, repo
+    }.to raise_error(Github::Error::NotFound, /not found/)
+  end
+
+  it "handles nested errors" do
+    test_request :errors => { :message => 'key is already in use' }
+    expect {
+      Github.repos.branches user, repo
+    }.to raise_error(Github::Error::NotFound, /key is already in use/)
+  end
+
+  it 'decodes message' do
+    test_request MultiJson.dump(:errors => { :message => 'key is already in use' })
+    expect {
+      Github.repos.branches user, repo
+    }.to raise_error(Github::Error::NotFound, /key is already in use/)
+  end
+
+
+end # Github::Error::ServiceError

data/spec/github/error/validations_spec.rb

@@ -0,0 +1,21 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Error::Validations do
+  describe '#message' do
+    let(:error) { described_class.new(:username => nil) }
+
+    it 'contains the problem in the message' do
+      error.message.should include "Attempted to send request with nil arguments"
+    end
+
+    it 'contains the summary in the message' do
+      error.message.should include "Each request expects certain number of arguments."
+    end
+
+    it 'contains the resolution in the message' do
+      error.message.should include "Double check that the provided arguments are set to some value."
+    end
+  end
+end # Github::Error::Validations

data/spec/github/git_data/references_spec.rb

@@ -131,7 +131,7 @@ describe Github::GitData::References do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/git/refs/#{ref}").
-          to_return(:body => fixture('git_data/reference.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => '', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to retrive resource" do
@@ -196,8 +196,8 @@ describe Github::GitData::References do
     context "failed to create resource" do
       before do
         stub_post("/repos/#{user}/#{repo}/git/refs").with(inputs).
-          to_return(:body => fixture('git_data/reference.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
+          to_return(:body => '', :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should faile to retrieve resource" do
@@ -256,8 +256,8 @@ describe Github::GitData::References do
     context "failed to update resource" do
       before do
         stub_patch("/repos/#{user}/#{repo}/git/refs/#{ref}").with(inputs).
-          to_return(:body => fixture('git_data/reference.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
+          to_return(:body => '', :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should faile to retrieve resource" do

data/spec/github/orgs/members_spec.rb

@@ -51,7 +51,7 @@ describe Github::Orgs::Members do
     context "resource not found" do
       before do
         stub_get("/orgs/#{org}/members").
-          to_return(:body => fixture('orgs/members.json'), :status => 404,
+          to_return(:body => '', :status => 404,
             :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
@@ -136,7 +136,8 @@ describe Github::Orgs::Members do
     context "resource not found" do
       before do
         stub_get("/orgs/#{org}/public_members").
-          to_return(:body => fixture('orgs/members.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => '', :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should return 404 with a message 'Not Found'" do
@@ -197,7 +198,7 @@ describe Github::Orgs::Members do
     context "resource not found" do
       before do
         stub_put("/orgs/#{org}/public_members/#{member}").
-          to_return(:body => fixture('orgs/members.json'), :status => 404,
+          to_return(:body => '', :status => 404,
             :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
@@ -232,7 +233,7 @@ describe Github::Orgs::Members do
     context "resource not found" do
       before do
         stub_delete("/orgs/#{org}/public_members/#{member}").
-          to_return(:body => fixture('orgs/members.json'), :status => 404,
+          to_return(:body => '', :status => 404,
             :headers => {:content_type => "application/json; charset=utf-8"})
       end
 

data/spec/github/orgs/teams_spec.rb

@@ -52,7 +52,7 @@ describe Github::Orgs::Teams do
     context "resource not found" do
       before do
         stub_get("/orgs/#{org}/teams").
-          to_return(:body => fixture('orgs/teams.json'), :status => 404,
+          to_return(:body => '', :status => 404,
             :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
@@ -146,7 +146,7 @@ describe Github::Orgs::Teams do
     context "failed to create resource" do
       before do
         stub_post("/orgs/#{org}/teams").with(inputs).
-          to_return(:body => fixture('orgs/team.json'), :status => 404,
+          to_return(:body => '', :status => 404,
             :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
@@ -285,7 +285,8 @@ describe Github::Orgs::Teams do
     context "resource not found" do
       before do
         stub_get("/teams/#{team}/members").
-          to_return(:body => fixture('orgs/teams.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => '', :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should return 404 with a message 'Not Found'" do

data/spec/github/repos/keys_spec.rb

@@ -43,7 +43,7 @@ describe Github::Repos::Keys do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/keys").
-          to_return(:body => fixture("repos/keys.json"), :status => 404)
+          to_return(:body => '', :status => 404)
       end
 
       it "should fail to retrieve resource" do
@@ -85,7 +85,7 @@ describe Github::Repos::Keys do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/keys/#{key_id}").
-          to_return(:body => fixture("repos/keys.json"), :status => 404)
+          to_return(:body => '', :status => 404)
       end
 
       it "should fail to retrieve resource" do

data/spec/github/repos/watching_spec.rb

@@ -67,7 +67,7 @@ describe Github::Repos::Watching do
     context "if user unauthenticated" do
       it "should fail to get resource without username " do
         stub_get("/user/watched").
-          to_return(:body => fixture("repos/watched.json"), :status => 401, :headers => {})
+          to_return(:body => '', :status => 401, :headers => {})
         expect {
           github.repos.watching.watched
         }.to raise_error(Github::Error::Unauthorized)

data/spec/github/repos_spec.rb

@@ -67,7 +67,7 @@ describe Github::Repos do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/branches").
-          to_return(:body => fixture('repos/branches.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => '', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
 
       end
 
@@ -163,8 +163,8 @@ describe Github::Repos do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/contributors").
-          to_return(:body => fixture('repos/contributors.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
+          to_return(:body => '', :status => 404, 
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to get resource" do
@@ -525,7 +525,8 @@ describe Github::Repos do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/tags").
-          to_return(:body => fixture('repos/branches.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => '', :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to get resource" do
@@ -580,7 +581,8 @@ describe Github::Repos do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/teams").
-          to_return(:body => fixture('repos/teams.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => '', :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to get resource" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_api
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.6.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-17 00:00:00.000000000Z
+date: 2012-07-28 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &2153056440 !ruby/object:Gem::Requirement
+  requirement: &2153193940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 1.2.0
   type: :runtime
   prerelease: false
-  version_requirements: *2153056440
+  version_requirements: *2153193940
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &2153055720 !ruby/object:Gem::Requirement
+  requirement: &2153193440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *2153055720
+  version_requirements: *2153193440
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &2153055000 !ruby/object:Gem::Requirement
+  requirement: &2153192940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '1.3'
   type: :runtime
   prerelease: false
-  version_requirements: *2153055000
+  version_requirements: *2153192940
 - !ruby/object:Gem::Dependency
   name: oauth2
-  requirement: &2153054440 !ruby/object:Gem::Requirement
+  requirement: &2153192560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153054440
+  version_requirements: *2153192560
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2153053580 !ruby/object:Gem::Requirement
+  requirement: &2153192000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 1.5.2
   type: :runtime
   prerelease: false
-  version_requirements: *2153053580
+  version_requirements: *2153192000
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2153053000 !ruby/object:Gem::Requirement
+  requirement: &2153191480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153053000
+  version_requirements: *2153191480
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &2153052540 !ruby/object:Gem::Requirement
+  requirement: &2153190980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153052540
+  version_requirements: *2153190980
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2153052080 !ruby/object:Gem::Requirement
+  requirement: &2153190380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: 1.8.0
   type: :development
   prerelease: false
-  version_requirements: *2153052080
+  version_requirements: *2153190380
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2153051600 !ruby/object:Gem::Requirement
+  requirement: &2153189800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 2.2.0
   type: :development
   prerelease: false
-  version_requirements: *2153051600
+  version_requirements: *2153189800
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &2153051140 !ruby/object:Gem::Requirement
+  requirement: &2153189220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 0.6.1
   type: :development
   prerelease: false
-  version_requirements: *2153051140
+  version_requirements: *2153189220
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2153050760 !ruby/object:Gem::Requirement
+  requirement: &2153188820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -131,10 +131,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153050760
+  version_requirements: *2153188820
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2153050300 !ruby/object:Gem::Requirement
+  requirement: &2153188240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -142,10 +142,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153050300
+  version_requirements: *2153188240
 - !ruby/object:Gem::Dependency
   name: guard-cucumber
-  requirement: &2153049880 !ruby/object:Gem::Requirement
+  requirement: &2153187680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -153,10 +153,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153049880
+  version_requirements: *2153187680
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2153049460 !ruby/object:Gem::Requirement
+  requirement: &2153187220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -164,10 +164,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153049460
+  version_requirements: *2153187220
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2153049040 !ruby/object:Gem::Requirement
+  requirement: &2153186740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -175,7 +175,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153049040
+  version_requirements: *2153186740
 description: ! ' Ruby wrapper that supports all of the GitHub API v3 methods(nearly
   200). It''s build in a modular way, that is, you can either instantiate the whole
   api wrapper Github.new or use parts of it e.i. Github::Repos.new if working solely
@@ -301,6 +301,7 @@ files:
 - lib/github_api/error/forbidden.rb
 - lib/github_api/error/internal_server_error.rb
 - lib/github_api/error/invalid_options.rb
+- lib/github_api/error/not_acceptable.rb
 - lib/github_api/error/not_found.rb
 - lib/github_api/error/required_params.rb
 - lib/github_api/error/service_error.rb
@@ -338,7 +339,7 @@ files:
 - lib/github_api/params_hash.rb
 - lib/github_api/pull_requests/comments.rb
 - lib/github_api/pull_requests.rb
-- lib/github_api/ratelimit_status.rb
+- lib/github_api/rate_limit.rb
 - lib/github_api/repos/collaborators.rb
 - lib/github_api/repos/commits.rb
 - lib/github_api/repos/contents.rb
@@ -461,7 +462,9 @@ files:
 - spec/github/error/client_error_spec.rb
 - spec/github/error/invalid_options_spec.rb
 - spec/github/error/required_params_spec.rb
+- spec/github/error/service_error_spec.rb
 - spec/github/error/unknown_value_spec.rb
+- spec/github/error/validations_spec.rb
 - spec/github/events_spec.rb
 - spec/github/gists/comments_spec.rb
 - spec/github/gists_spec.rb
@@ -525,7 +528,7 @@ files:
 homepage: https://github.com/peter-murach/github
 licenses: []
 post_install_message: ! "\n--------------------------------------------------------------------------------\nThank
-  you for installing github_api-0.6.3.\n\n*NOTE*: Version 0.5.0 introduces breaking
+  you for installing github_api-0.6.4.\n\n*NOTE*: Version 0.5.0 introduces breaking
   changes to the way github api is queried.\nThe interface has been rewritten to be
   more consistent with REST verbs that\ninteract with GitHub hypermedia resources.
   Thus, to list resources 'list' or 'all'\nverbs are used, to retrieve individual

data/lib/github_api/ratelimit_status.rb

@@ -1,17 +0,0 @@
-module Github
-  class RatelimitStatus
-    include Github::Constants
-
-    attr_reader :ratelimit_limit, :ratelimit_remaining
-
-    def initialize(env)
-      @env = env
-      @ratelimit_limit     = env[:response_headers][RATELIMIT_LIMIT]
-      @ratelimit_remaining = env[:response_headers][RATELIMIT_REMAINING]
-    end
-
-    def ratelimit_reset_time
-      @ratelimit_reset_time ||= Time.parse(@env[:reponse_headers]['date'])
-    end
-  end
-end