github_api 0.4.5 → 0.4.6

data/spec/github/gists_spec.rb

@@ -378,6 +378,11 @@ describe Github::Gists, :type => :base do
       }.to raise_error(ArgumentError)
     end
 
+    it 'should perform request' do
+      github.gists.starred? gist_id
+      a_get("/gists/#{gist_id}/star").should have_been_made
+    end
+
     it 'should return true if gist is already starred' do
       github.gists.starred?(gist_id).should be_true
     end

data/spec/github/issues/comments_spec.rb

@@ -1,11 +1,12 @@
 require 'spec_helper'
 
 describe Github::Issues::Comments, :type => :base do
+  let!(:comment_id) { 1 }
+  let!(:issue_id) { 1 }
 
   it { described_class::VALID_ISSUE_COMMENT_PARAM_NAME.should_not be_nil }
 
   describe 'comments' do
-    let(:issue_id) { 1 }
 
     it { github.issues.should respond_to :comments }
     it { github.issues.should respond_to :issue_comments }
@@ -65,7 +66,6 @@ describe Github::Issues::Comments, :type => :base do
   end # comments
 
   describe "comment" do
-    let(:comment_id) { 1 }
 
     it { github.issues.should respond_to :comment }
     it { github.issues.should respond_to :issue_comment }
@@ -121,7 +121,7 @@ describe Github::Issues::Comments, :type => :base do
 
     context "resouce created" do
       before do
-        stub_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").with(inputs).
+        stub_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").with(:body => inputs).
           to_return(:body => fixture('issues/comment.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
       end
 

data/spec/github/issues/events_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 
 describe Github::Issues::Events, :type => :base do
+  let(:issue_id) { 1 }
 
   describe 'events' do
     it { github.issues.should respond_to :events }
@@ -9,8 +10,6 @@ describe Github::Issues::Events, :type => :base do
     it { github.issues.should respond_to :repo_events }
 
     context 'without issue_id' do
-      let(:issue_id) { nil }
-
       context "resource found" do
         before do
           stub_get("/repos/#{user}/#{repo}/issues/events").
@@ -23,29 +22,29 @@ describe Github::Issues::Events, :type => :base do
         end
 
         it "should get the resources" do
-          github.issues.events user, repo, issue_id
+          github.issues.events user, repo
           a_get("/repos/#{user}/#{repo}/issues/events").should have_been_made
         end
 
         it "should return array of resources" do
-          events = github.issues.events user, repo, issue_id
+          events = github.issues.events user, repo
           events.should be_an Array
           events.should have(1).items
         end
 
         it "should be a mash type" do
-          events = github.issues.events user, repo, issue_id
+          events = github.issues.events user, repo
           events.first.should be_a Hashie::Mash
         end
 
         it "should get issue information" do
-          events = github.issues.events user, repo, issue_id
+          events = github.issues.events user, repo
           events.first.actor.login.should == 'octocat'
         end
 
         it "should yield to a block" do
-          github.issues.should_receive(:events).with(user, repo, issue_id).and_yield('web')
-          github.issues.events(user, repo, issue_id) { |param| 'web' }.should == 'web'
+          github.issues.should_receive(:events).with(user, repo).and_yield('web')
+          github.issues.events(user, repo) { |param| 'web' }.should == 'web'
         end
       end
 
@@ -57,7 +56,7 @@ describe Github::Issues::Events, :type => :base do
 
         it "should return 404 with a message 'Not Found'" do
           expect {
-            github.issues.events user, repo, issue_id
+            github.issues.events user, repo
           }.to raise_error(Github::Error::NotFound)
         end
       end
@@ -65,8 +64,6 @@ describe Github::Issues::Events, :type => :base do
     end # without issue_id
 
     context 'with issue_id' do
-      let(:issue_id) { 123 }
-
       context "resource found" do
         before do
           stub_get("/repos/#{user}/#{repo}/issues/#{issue_id}/events").

data/spec/github/pull_requests_spec.rb

@@ -11,11 +11,11 @@ describe Github::PullRequests, :type => :base do
     end
 
     context 'resource found' do
-      let(:params) { { :state => 'closed', :unrelated => true } }
+      let(:inputs) { { 'state'=> 'closed', 'unrelated' => true } }
 
       before do
         stub_get("/repos/#{user}/#{repo}/pulls").
-          with(:query => params.except(:unrelated)).
+          with(:query => inputs.except('unrelated')).
           to_return(:body => fixture('pull_requests/pull_requests.json'),
             :status => 200,
             :headers => {:content_type => "application/json; charset=utf-8"})
@@ -26,23 +26,23 @@ describe Github::PullRequests, :type => :base do
       end
 
       it "should get the resources" do
-        github.pull_requests.pull_requests user, repo, params
-        a_get("/repos/#{user}/#{repo}/pulls").with(:query => params).should have_been_made
+        github.pull_requests.pull_requests user, repo, inputs
+        a_get("/repos/#{user}/#{repo}/pulls").with(:query => inputs).should have_been_made
       end
 
       it "should return array of resources" do
-        pull_requests = github.pull_requests.pull_requests user, repo, params
+        pull_requests = github.pull_requests.pull_requests user, repo, inputs
         pull_requests.should be_an Array
         pull_requests.should have(1).items
       end
 
       it "should be a mash type" do
-        pull_requests = github.pull_requests.pull_requests user, repo, params
+        pull_requests = github.pull_requests.pull_requests user, repo, inputs
         pull_requests.first.should be_a Hashie::Mash
       end
 
       it "should get pull request information" do
-        pull_requests = github.pull_requests.pull_requests user, repo, params
+        pull_requests = github.pull_requests.pull_requests user, repo, inputs
         pull_requests.first.title.should == 'new-feature'
       end
 

data/spec/github/result_spec.rb

@@ -4,7 +4,7 @@ describe Github::Result do
 
   let(:github) { Github.new }
   let(:user)   { 'wycats' }
-  let(:res)    { github.events.public :per_page => 20 }
+  let(:res)    { github.events.public({ 'per_page' => 20 }) }
   let(:pages)  { ['1', '5', '6'] }
   let(:link) {
     "<https://api.github.com/users/wycats/repos?page=6&per_page=20>; rel=\"last\", <https://api.github.com/users/wycats/repos?page=1&per_page=20>; rel=\"first\""

data/spec/github/users/followers_spec.rb

@@ -1,5 +1,242 @@
 require 'spec_helper'
 
 describe Github::Users::Followers, :type => :base do
-  pending
+
+  before do
+    reset_authentication_for github
+  end
+
+  after do
+    reset_authentication_for github
+  end
+
+  describe "#followers" do
+    context "resource found for a user" do
+      before do
+        stub_get("/users/#{user}/followers").
+          to_return(:body => fixture('users/followers.json'),
+            :status => 200,
+            :headers => {:content_type => "application/json; charset=utf-8"})
+      end
+
+      it "should get the resources" do
+        github.users.followers user
+        a_get("/users/#{user}/followers").should have_been_made
+      end
+
+      it "should return resource" do
+        followers = github.users.followers user
+        followers.should be_an Array
+        followers.should have(1).items
+      end
+
+      it "should be a mash type" do
+        followers = github.users.followers user
+        followers.first.should be_a Hashie::Mash
+      end
+
+      it "should get followers information" do
+        followers = github.users.followers user
+        followers.first.login.should == 'octocat'
+      end
+
+      it "should yield to a block" do
+        github.users.should_receive(:followers).with(user).and_yield('web')
+        github.users.followers(user) { |param| 'web' }
+      end
+    end
+
+    context "resource found for an authenticated user" do
+      before do
+        github.oauth_token = OAUTH_TOKEN
+        stub_get("/user/followers").
+          with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+          to_return(:body => fixture('users/followers.json'),
+            :status => 200,
+            :headers => {:content_type => "application/json; charset=utf-8"})
+      end
+
+      it "should get the resources" do
+        github.users.followers
+        a_get("/user/followers").
+          with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+          should have_been_made
+      end
+    end
+
+    context "resource not found for a user" do
+      before do
+        stub_get("/users/#{user}/followers").
+          to_return(:body => "", :status => [404, "Not Found"])
+      end
+
+      it "should return 404 with a message 'Not Found'" do
+        expect {
+          github.users.followers user
+        }.to raise_error(Github::Error::NotFound)
+      end
+    end
+  end # followers
+
+  describe "#following" do
+    context "resource found for a user" do
+      before do
+        stub_get("/users/#{user}/following").
+          to_return(:body => fixture('users/followers.json'),
+            :status => 200,
+            :headers => {:content_type => "application/json; charset=utf-8"})
+      end
+
+      it "should get the resources" do
+        github.users.following user
+        a_get("/users/#{user}/following").should have_been_made
+      end
+
+      it "should return resource" do
+        followings = github.users.following user
+        followings.should be_an Array
+        followings.should have(1).items
+      end
+
+      it "should be a mash type" do
+        followings = github.users.following user
+        followings.first.should be_a Hashie::Mash
+      end
+
+      it "should get following users information" do
+        followings = github.users.following user
+        followings.first.login.should == 'octocat'
+      end
+
+      it "should yield to a block" do
+        github.users.should_receive(:following).with(user).and_yield('web')
+        github.users.following(user) { |param| 'web' }
+      end
+    end
+
+    context "resource found for an authenticated user" do
+      before do
+        github.oauth_token = OAUTH_TOKEN
+        stub_get("/user/following").
+          with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+          to_return(:body => fixture('users/followers.json'),
+            :status => 200,
+            :headers => {:content_type => "application/json; charset=utf-8"})
+      end
+
+      it "should get the resources" do
+        github.users.following
+        a_get("/user/following").
+          with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+          should have_been_made
+      end
+    end
+
+    context "resource not found for a user" do
+      before do
+        stub_get("/users/#{user}/following").
+          to_return(:body => "", :status => [404, "Not Found"])
+      end
+
+      it "should return 404 with a message 'Not Found'" do
+        expect {
+          github.users.following user
+        }.to raise_error(Github::Error::NotFound)
+      end
+    end
+  end # following
+
+  context '#following?' do
+    before do
+      github.oauth_token = OAUTH_TOKEN
+      stub_get("/user/following/#{user}").
+        with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+        to_return(:body => '',
+              :status => 204,
+              :headers => {:content_type => "application/json; charset=utf-8"})
+    end
+
+    it 'should raise error if username not present' do
+      expect {
+        github.users.following? nil
+      }.to raise_error(ArgumentError)
+    end
+
+    it 'should perform request' do
+      github.users.following?(user)
+      a_get("/user/following/#{user}").
+        with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+        should have_been_made
+    end
+
+    it 'should return true if user is being followed' do
+      github.users.following?(user).should be_true
+    end
+
+    it 'should return false if user is not being followed' do
+      stub_get("/user/following/#{user}").
+        with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+        to_return(:body => '',
+              :status => 404,
+              :headers => {:content_type => "application/json; charset=utf-8"})
+      github.users.following?(user).should be_false
+    end
+  end # following?
+
+  context '#follow' do
+    before do
+      github.oauth_token = OAUTH_TOKEN
+      stub_put("/user/following/#{user}").
+        with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+        to_return(:body => '',
+              :status => 204,
+              :headers => {:content_type => "application/json; charset=utf-8"})
+    end
+
+    it "should raise error if gist id not present" do
+      expect {
+        github.users.follow nil
+      }.to raise_error(ArgumentError)
+    end
+
+    it 'successfully unfollows a user' do
+      github.users.follow(user)
+      a_put("/user/following/#{user}").
+        with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+        should have_been_made
+    end
+
+    it "should return 204 with a message 'Not Found'" do
+      github.users.follow(user).status.should be 204
+    end
+  end # follow
+
+  context '#unfollow' do
+    before do
+      github.oauth_token = OAUTH_TOKEN
+      stub_delete("/user/following/#{user}").
+        with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+        to_return(:body => '',
+              :status => 204,
+              :headers => {:content_type => "application/json; charset=utf-8"})
+    end
+
+    it "should raise error if gist id not present" do
+      expect {
+        github.users.unfollow nil
+      }.to raise_error(ArgumentError)
+    end
+
+    it 'successfully unfollows a user' do
+      github.users.unfollow(user)
+      a_delete("/user/following/#{user}").
+        with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+        should have_been_made
+    end
+
+    it "should return 204 with a message 'Not Found'" do
+      github.users.unfollow(user).status.should be 204
+    end
+  end # unfollow
+
 end # Github::Users::Followers

data/spec/github/users_spec.rb

@@ -14,7 +14,8 @@ describe Github::Users, :type => :base do
     context "resource found for a user" do
       before do
         stub_get("/users/#{user}").
-          to_return(:body => fixture('users/user.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('users/user.json'),
+            :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should get the resources" do
@@ -45,19 +46,16 @@ describe Github::Users, :type => :base do
 
     context "resource found for an authenticated user" do
       before do
-        reset_authentication_for github
         github.oauth_token = OAUTH_TOKEN
-        stub_get("/user?access_token=#{OAUTH_TOKEN}").
+        stub_get("/user").
+          with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
           to_return(:body => fixture('users/user.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
-      after do
-        reset_authentication_for github
-      end
-
       it "should get the resources" do
         github.users.get_user
-        a_get("/user?access_token=#{OAUTH_TOKEN}").should have_been_made
+        a_get("/user").with(:query => {:access_token => "#{OAUTH_TOKEN}"}).
+          should have_been_made
       end
     end
 
@@ -90,17 +88,12 @@ describe Github::Users, :type => :base do
 
     context "resouce updated" do
       before do
-        reset_authentication_for github
         github.oauth_token = OAUTH_TOKEN
         stub_patch("/user?access_token=#{OAUTH_TOKEN}").with(user_params).
           to_return(:body => fixture('users/user.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
 
       end
 
-      after do
-        reset_authentication_for github
-      end
-
       it "should create resource successfully" do
         github.users.update_user
         a_patch("/user?access_token=#{OAUTH_TOKEN}").with(user_params).should have_been_made
@@ -119,7 +112,6 @@ describe Github::Users, :type => :base do
 
     context "failed to update resource" do
       before do
-        reset_authentication_for github
         github.oauth_token = OAUTH_TOKEN
         stub_patch("/user?access_token=#{OAUTH_TOKEN}").with(user_params).
           to_return(:body => fixture('users/user.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})