github_api 0.4.4 → 0.4.5

data/lib/github_api/response/raise_error.rb

@@ -9,28 +9,23 @@ module Github
     def on_complete(env)
       case env[:status].to_i
       when 400
-        raise Github::BadRequest.new(response_message(env), env[:response_headers])
+        raise Github::Error::BadRequest.new(env)
       when 401
-        raise Github::Unauthorised.new(response_message(env), env[:response_headers])
+        raise Github::Error::Unauthorized.new(env)
       when 403
-        raise Github::Forbidden.new(response_message(env), env[:response_headers])
+        raise Github::Error::Forbidden.new(env)
       when 404
-        raise Github::ResourceNotFound.new(response_message(env), env[:response_headers])
-
+        raise Github::Error::NotFound.new(env)
       when 422
-        raise Github::UnprocessableEntity.new(response_message(env), env[:response_headers])
+        raise Github::Error::UnprocessableEntity.new(env)
       when 500
-        raise Github::InternalServerError.new(response_message(env), env[:response_headers])
+        raise Github::Error::InternalServerError.new(env)
       when 503
-        raise Github::ServiceUnavailable.new(response_message(env), env[:response_headers])
+        raise Github::Error::ServiceUnavailable.new(env)
       when 400...600
-        raise Github::Error.new(response_message(env), env[:response_headers])
+        raise Github::Error::ServiceError.new(env)
       end
     end
 
-    def response_message(env)
-      "#{env[:method].to_s.upcase} #{env[:url].to_s}: #{env[:status]}#{env[:body]}"
-    end
-
   end # Response::RaiseError
 end # Github

data/lib/github_api/users/followers.rb

@@ -65,7 +65,7 @@ module Github
         _normalize_params_keys(params)
         get("/user/following/#{user_name}", params)
         true
-      rescue Github::ResourceNotFound
+      rescue Github::Error::NotFound
         false
       end
 

data/lib/github_api/version.rb

@@ -4,7 +4,7 @@ module Github
   module VERSION
     MAJOR = 0
     MINOR = 4
-    PATCH = 4
+    PATCH = 5
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.');

data/spec/fixtures/pull_requests/comment.json

@@ -0,0 +1,17 @@
+{
+  "url": "https://api.github.com/repos/octocat/Hello-World/pulls/comments/1",
+  "id": 1,
+  "body": "Great stuff",
+  "path": "file1.txt",
+  "position": 4,
+  "commit_id": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+  "user": {
+    "login": "octocat",
+    "id": 1,
+    "avatar_url": "https://github.com/images/error/octocat_happy.gif",
+    "gravatar_id": "somehexcode",
+    "url": "https://api.github.com/users/octocat"
+  },
+  "created_at": "2011-04-14T16:00:49Z",
+  "updated_at": "2011-04-14T16:00:49Z"
+}

data/spec/fixtures/pull_requests/comments.json

@@ -0,0 +1,19 @@
+[
+  {
+    "url": "https://api.github.com/repos/octocat/Hello-World/pulls/comments/1",
+    "id": 1,
+    "body": "Great stuff",
+    "path": "file1.txt",
+    "position": 4,
+    "commit_id": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+    "user": {
+      "login": "octocat",
+      "id": 1,
+      "avatar_url": "https://github.com/images/error/octocat_happy.gif",
+      "gravatar_id": "somehexcode",
+      "url": "https://api.github.com/users/octocat"
+    },
+    "created_at": "2011-04-14T16:00:49Z",
+    "updated_at": "2011-04-14T16:00:49Z"
+  }
+]

data/spec/fixtures/pull_requests/commits.json

@@ -0,0 +1,27 @@
+[
+  {
+    "sha": "7638417db6d59f3c431d3e1f261cc637155684cd",
+    "url": "https://api.github.com/repos/octocat/Hello-World/git/commits/7638417db6d59f3c431d3e1f261cc637155684cd",
+    "author": {
+      "date": "2010-04-10T14:10:01-07:00",
+      "name": "Scott Chacon",
+      "email": "schacon@gmail.com"
+    },
+    "committer": {
+      "date": "2010-04-10T14:10:01-07:00",
+      "name": "Scott Chacon",
+      "email": "schacon@gmail.com"
+    },
+    "message": "added readme, because im a good github citizen\n",
+    "tree": {
+      "url": "https://api.github.com/repos/octocat/Hello-World/git/trees/691272480426f78a0138979dd3ce63b77f706feb",
+      "sha": "691272480426f78a0138979dd3ce63b77f706feb"
+    },
+    "parents": [
+      {
+        "url": "https://api.github.com/repos/octocat/Hello-World/git/commits/1acc419d4d6a9ce985db7be48c6349a0475975b5",
+        "sha": "1acc419d4d6a9ce985db7be48c6349a0475975b5"
+      }
+    ]
+  }
+]

data/spec/fixtures/pull_requests/files.json

@@ -0,0 +1,13 @@
+[
+  {
+    "sha": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+    "filename": "file1.txt",
+    "status": "added",
+    "additions": 103,
+    "deletions": 21,
+    "changes": 124,
+    "blob_url": "https://github.com/octocate/Hello-World/blob/6dcb09b5b57875f334f61aebed695e2e4193db5e/file1.txt",
+    "raw_url": "https://github.com/octocate/Hello-World/raw/6dcb09b5b57875f334f61aebed695e2e4193db5e/file1.txt",
+    "patch": "@@ -132,7 +132,7 @@ module Test @@ -1000,7 +1000,7 @@ module Test"
+  }
+]

data/spec/fixtures/pull_requests/merge_failure.json

@@ -0,0 +1,5 @@
+{
+  "sha": null,
+  "merged": false,
+  "message": "Failure reason"
+}

data/spec/fixtures/pull_requests/merge_success.json

@@ -0,0 +1,5 @@
+{
+  "sha": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+  "merged": true,
+  "message": "Pull Request successfully merged"
+}

data/spec/fixtures/pull_requests/pull_request.json

@@ -0,0 +1,123 @@
+{
+  "url": "https://api.github.com/octocat/Hello-World/pulls/1",
+  "html_url": "https://github.com/octocat/Hello-World/pulls/1",
+  "diff_url": "https://github.com/octocat/Hello-World/pulls/1.diff",
+  "patch_url": "https://github.com/octocat/Hello-World/pulls/1.patch",
+  "issue_url": "https://github.com/octocat/Hello-World/issue/1",
+  "number": 1,
+  "state": "open",
+  "title": "new-feature",
+  "body": "Please pull these awesome changes",
+  "created_at": "2011-01-26T19:01:12Z",
+  "updated_at": "2011-01-26T19:01:12Z",
+  "closed_at": "2011-01-26T19:01:12Z",
+  "merged_at": "2011-01-26T19:01:12Z",
+  "_links": {
+    "self": {
+      "href": "https://api.github.com/octocat/Hello-World/pulls/1"
+    },
+    "html": {
+      "href": "https://github.com/octocat/Hello-World/pull/1"
+    },
+    "comments": {
+      "href": "https://api.github.com/octocat/Hello-World/issues/1/comments"
+    },
+    "review_comments": {
+      "href": "https://api.github.com/octocat/Hello-World/pulls/1/comments"
+    }
+  },
+  "merged": false,
+  "mergeable": true,
+  "merged_by": {
+    "login": "octocat",
+    "id": 1,
+    "avatar_url": "https://github.com/images/error/octocat_happy.gif",
+    "gravatar_id": "somehexcode",
+    "url": "https://api.github.com/users/octocat"
+  },
+  "comments": 10,
+  "commits": 3,
+  "additions": 100,
+  "deletions": 3,
+  "changed_files": 5,
+  "head": {
+    "label": "new-topic",
+    "ref": "new-topic",
+    "sha": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+    "user": {
+      "login": "octocat",
+      "id": 1,
+      "avatar_url": "https://github.com/images/error/octocat_happy.gif",
+      "gravatar_id": "somehexcode",
+      "url": "https://api.github.com/users/octocat"
+    },
+    "repo": {
+      "url": "https://api.github.com/repos/octocat/Hello-World",
+      "html_url": "https://github.com/octocat/Hello-World",
+      "clone_url": "https://github.com/octocat/Hello-World.git",
+      "git_url": "git://github.com/octocat/Hello-World.git",
+      "ssh_url": "git@github.com:octocat/Hello-World.git",
+      "svn_url": "https://svn.github.com/octocat/Hello-World",
+      "owner": {
+        "login": "octocat",
+        "id": 1,
+        "avatar_url": "https://github.com/images/error/octocat_happy.gif",
+        "gravatar_id": "somehexcode",
+        "url": "https://api.github.com/users/octocat"
+      },
+      "name": "Hello-World",
+      "description": "This your first repo!",
+      "homepage": "https://github.com",
+      "language": null,
+      "private": false,
+      "fork": false,
+      "forks": 9,
+      "watchers": 80,
+      "size": 108,
+      "master_branch": "master",
+      "open_issues": 0,
+      "pushed_at": "2011-01-26T19:06:43Z",
+      "created_at": "2011-01-26T19:01:12Z"
+    }
+  },
+  "base": {
+    "label": "master",
+    "ref": "master",
+    "sha": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+    "user": {
+      "login": "octocat",
+      "id": 1,
+      "avatar_url": "https://github.com/images/error/octocat_happy.gif",
+      "gravatar_id": "somehexcode",
+      "url": "https://api.github.com/users/octocat"
+    },
+    "repo": {
+      "url": "https://api.github.com/repos/octocat/Hello-World",
+      "html_url": "https://github.com/octocat/Hello-World",
+      "clone_url": "https://github.com/octocat/Hello-World.git",
+      "git_url": "git://github.com/octocat/Hello-World.git",
+      "ssh_url": "git@github.com:octocat/Hello-World.git",
+      "svn_url": "https://svn.github.com/octocat/Hello-World",
+      "owner": {
+        "login": "octocat",
+        "id": 1,
+        "avatar_url": "https://github.com/images/error/octocat_happy.gif",
+        "gravatar_id": "somehexcode",
+        "url": "https://api.github.com/users/octocat"
+      },
+      "name": "Hello-World",
+      "description": "This your first repo!",
+      "homepage": "https://github.com",
+      "language": null,
+      "private": false,
+      "fork": false,
+      "forks": 9,
+      "watchers": 80,
+      "size": 108,
+      "master_branch": "master",
+      "open_issues": 0,
+      "pushed_at": "2011-01-26T19:06:43Z",
+      "created_at": "2011-01-26T19:01:12Z"
+    }
+  }
+}

data/spec/fixtures/pull_requests/pull_requests.json

@@ -0,0 +1,31 @@
+[
+  {
+    "url": "https://api.github.com/octocat/Hello-World/pulls/1",
+    "html_url": "https://github.com/octocat/Hello-World/pulls/1",
+    "diff_url": "https://github.com/octocat/Hello-World/pulls/1.diff",
+    "patch_url": "https://github.com/octocat/Hello-World/pulls/1.patch",
+    "issue_url": "https://github.com/octocat/Hello-World/issue/1",
+    "number": 1,
+    "state": "open",
+    "title": "new-feature",
+    "body": "Please pull these awesome changes",
+    "created_at": "2011-01-26T19:01:12Z",
+    "updated_at": "2011-01-26T19:01:12Z",
+    "closed_at": "2011-01-26T19:01:12Z",
+    "merged_at": "2011-01-26T19:01:12Z",
+    "_links": {
+      "self": {
+        "href": "https://api.github.com/octocat/Hello-World/pulls/1"
+      },
+      "html": {
+        "href": "https://github.com/octocat/Hello-World/pull/1"
+      },
+      "comments": {
+        "href": "https://api.github.com/octocat/Hello-World/issues/1/comments"
+      },
+      "review_comments": {
+        "href": "https://api.github.com/octocat/Hello-World/pulls/1/comments"
+      }
+    }
+  }
+]

data/spec/github/authorizations_spec.rb

@@ -60,7 +60,7 @@ describe Github::Authorizations do
       end
 
       it "should return 404 with a message 'Not Found'" do
-        expect { github.oauth.authorizations }.to raise_error(Github::ResourceNotFound)
+        expect { github.oauth.authorizations }.to raise_error(Github::Error::NotFound)
       end
     end
   end # authorizations
@@ -104,7 +104,7 @@ describe Github::Authorizations do
       it "should fail to retrive resource" do
         expect {
           github.oauth.authorization authorization_id
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # authorization
@@ -150,7 +150,7 @@ describe Github::Authorizations do
       it "should fail to retrieve resource" do
         expect {
           github.oauth.create_authorization inputs
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # create_authorization
@@ -197,7 +197,7 @@ describe Github::Authorizations do
       it "should fail to retrieve resource" do
         expect {
           github.oauth.update_authorization authorization_id, inputs
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # update_authorization
@@ -234,7 +234,7 @@ describe Github::Authorizations do
       it "should fail to retrieve resource" do
         expect {
           github.oauth.delete_authorization authorization_id
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # delete_authorization

data/spec/github/events_spec.rb

@@ -48,7 +48,7 @@ describe Github::Events do
       it "should return 404 with a message 'Not Found'" do
         expect {
           github.events.public
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # public_events
@@ -101,7 +101,7 @@ describe Github::Events do
       it "should return 404 with a message 'Not Found'" do
         expect {
           github.events.repository user, repo
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # repository
@@ -154,7 +154,7 @@ describe Github::Events do
       it "should return 404 with a message 'Not Found'" do
         expect {
           github.events.issue user, repo
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # repository
@@ -207,7 +207,7 @@ describe Github::Events do
       it "should return 404 with a message 'Not Found'" do
         expect {
           github.events.network user, repo
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # network
@@ -260,7 +260,7 @@ describe Github::Events do
       it "should return 404 with a message 'Not Found'" do
         expect {
           github.events.org org
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # org
@@ -345,7 +345,7 @@ describe Github::Events do
       it "should return 404 with a message 'Not Found'" do
         expect {
           github.events.received user
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # received
@@ -430,7 +430,7 @@ describe Github::Events do
       it "should return 404 with a message 'Not Found'" do
         expect {
           github.events.performed user
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # performed
@@ -483,7 +483,7 @@ describe Github::Events do
       it "should return 404 with a message 'Not Found'" do
         expect {
           github.events.user_org user, org
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # user_org

data/spec/github/gists/comments_spec.rb

@@ -59,7 +59,7 @@ describe Github::Gists::Comments, :type => :base do
       it "should return 404 with a message 'Not Found'" do
         expect {
           github.gists.comments gist_id
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # comments
@@ -110,7 +110,7 @@ describe Github::Gists::Comments, :type => :base do
       it "should fail to retrive resource" do
         expect {
           github.gists.comment comment_id
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # comment
@@ -162,7 +162,7 @@ describe Github::Gists::Comments, :type => :base do
       it "should faile to retrieve resource" do
         expect {
           github.gists.create_comment gist_id, inputs
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # create_comment
@@ -214,7 +214,7 @@ describe Github::Gists::Comments, :type => :base do
       it "should faile to retrieve resource" do
         expect {
           github.gists.edit_comment comment_id, inputs
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # edit_comment
@@ -249,7 +249,7 @@ describe Github::Gists::Comments, :type => :base do
       it "should faile to retrieve resource" do
         expect {
           github.gists.delete_comment comment_id
-        }.to raise_error(Github::ResourceNotFound)
+        }.to raise_error(Github::Error::NotFound)
       end
     end
   end # delete_comment