github_api 0.4.3 → 0.4.4

data/spec/github/repos/hooks_spec.rb

@@ -121,14 +121,22 @@ describe Github::Repos::Hooks, :type => :base do
     let(:inputs) {
       {
         :name => 'web',
-        :config => { :url => "http://something.com/webhook" },
-        :active => true
+        :config => {
+          :url => "http://something.com/webhook",
+          :address => "test@example.com",
+          :subdomain => "github",
+          :room => "Commits",
+          :token => "abc123"
+        },
+        :active => true,
+        :unrelated => true
       }
     }
 
     context "resouce created" do
       before do
-        stub_post("/repos/#{user}/#{repo}/hooks").with(inputs).
+        stub_post("/repos/#{user}/#{repo}/hooks").
+          with(:body => JSON.generate(inputs.except(:unrelated))).
           to_return(:body => fixture('repos/hook.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
@@ -179,14 +187,22 @@ describe Github::Repos::Hooks, :type => :base do
     let(:inputs) {
       {
         :name => 'web',
-        :config => { :url => "http://something.com/webhook" },
-        :active => true
+        :config => {
+          :url => "http://something.com/webhook",
+          :address => "test@example.com",
+          :subdomain => "github",
+          :room => "Commits",
+          :token => "abc123"
+        },
+        :active => true,
+        :unrelated => true
       }
     }
 
     context "resource edited successfully" do
       before do
-        stub_patch("/repos/#{user}/#{repo}/hooks/#{hook_id}").with(inputs).
+        stub_patch("/repos/#{user}/#{repo}/hooks/#{hook_id}").
+          with(:body => JSON.generate(inputs.except(:unrelated))).
           to_return(:body => fixture("repos/hook.json"), :status => 200, :headers => { :content_type => "application/json; charset=utf-8"})
       end
 

data/spec/github/result_spec.rb

@@ -22,6 +22,7 @@ describe Github::Result do
           'content-length' => '344',
           'etag' => "\"d9a88f20567726e29d35c6fae87cef2f\"",
           'server' => "nginx/1.0.4",
+          'Date' => "Sun, 05 Feb 2012 15:02:34 GMT",
           'Link' => link
         })
 
@@ -36,6 +37,7 @@ describe Github::Result do
           'X-RateLimit-Remaining' => '4999',
           'X-RateLimit-Limit' => '5000',
           'content-length' => '344',
+          'Date' => "Sun, 05 Feb 2012 15:02:34 GMT",
           'Link' => link
         })
     end
@@ -65,6 +67,10 @@ describe Github::Result do
     res.etag.should eql "\"d9a88f20567726e29d35c6fae87cef2f\""
   end
 
+  it 'should read response date' do
+    res.date.should eql "Sun, 05 Feb 2012 15:02:34 GMT"
+  end
+
   it 'should read response server' do
     res.server.should eql "nginx/1.0.4"
   end

data/spec/github/validation_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe Github::Validation, :type => :base do
+
+  context '#_validate_inputs' do
+    before do
+      @required = ['param_a', 'param_c']
+      @provided = { 'param_a' => true, 'param_c' => true }
+    end
+
+    it 'detect missing parameter' do
+      github._validate_inputs(@required, @provided.except('param_c')).should be_false
+    end
+
+    it 'asserts correct required parameters' do
+      github._validate_inputs(@required, @provided).should be_true
+    end
+  end
+
+  context '#_validate_presence_of' do
+    it 'throws error if passed param is nil' do
+      gist_id = nil
+      expect {
+        github._validate_presence_of gist_id
+      }.to raise_error(ArgumentError)
+    end
+  end
+
+  context '#_validate_params_values' do
+    let(:permitted) {
+      {
+        'param_a' => ['a', 'b'],
+        'param_b' => /^github$/
+      }
+    }
+
+    it 'fails to accept unkown value for a given parameter key' do
+      actual = { 'param_a' => 'x' }
+      expect {
+        github._validate_params_values(permitted, actual)
+      }.to raise_error(ArgumentError)
+    end
+
+    it 'accepts known value for a given parameter key' do
+      actual = { 'param_a' => 'a'}
+      github._validate_params_values(permitted, actual)
+    end
+
+    it 'fails to match regex value for a given parameter key' do
+      actual = { 'param_b' => 'xgithub' }
+      expect {
+        github._validate_params_values(permitted, actual)
+      }.to raise_error(ArgumentError)
+    end
+
+    it 'matches regex value for a given parameter key' do
+      actual = { 'param_b' => 'github'}
+      github._validate_params_values(permitted, actual)
+    end
+  end
+end # Github::Validation

metadata

@@ -2,7 +2,7 @@
 name: github_api
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors: 
 - Piotr Murach
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-04 00:00:00 +00:00
+date: 2012-02-09 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -179,6 +179,8 @@ files:
 - Rakefile
 - features/authentication.feature
 - features/cassettes/errors/repos/create.yml
+- features/cassettes/gists/comments/all.yml
+- features/cassettes/gists/comments/first.yml
 - features/cassettes/gists/gist/first.yml
 - features/cassettes/gists/gist.yml
 - features/cassettes/gists/gists/public_all.yml
@@ -199,6 +201,7 @@ files:
 - features/cassettes/repos/tags.yml
 - features/cassettes/repos/teams.yml
 - features/error_codes.feature
+- features/gists/comments.feature
 - features/gists.feature
 - features/github_api.feature
 - features/options.feature
@@ -212,6 +215,7 @@ files:
 - features/support/vcr.rb
 - lib/github_api/api/actions.rb
 - lib/github_api/api.rb
+- lib/github_api/api_factory.rb
 - lib/github_api/authorization.rb
 - lib/github_api/authorizations.rb
 - lib/github_api/cache_control.rb
@@ -225,6 +229,7 @@ files:
 - lib/github_api/deprecation.rb
 - lib/github_api/error.rb
 - lib/github_api/events.rb
+- lib/github_api/filter.rb
 - lib/github_api/gists/comments.rb
 - lib/github_api/gists.rb
 - lib/github_api/git_data/blobs.rb
@@ -248,6 +253,7 @@ files:
 - lib/github_api/paged_request.rb
 - lib/github_api/pull_requests/comments.rb
 - lib/github_api/pull_requests.rb
+- lib/github_api/ratelimit_status.rb
 - lib/github_api/repos/collaborators.rb
 - lib/github_api/repos/commits.rb
 - lib/github_api/repos/downloads.rb
@@ -272,12 +278,15 @@ files:
 - lib/github_api/users/keys.rb
 - lib/github_api/users.rb
 - lib/github_api/utils/url.rb
+- lib/github_api/validation.rb
 - lib/github_api/version.rb
 - lib/github_api.rb
 - spec/coverage_adapter.rb
 - spec/fixtures/auths/authorization.json
 - spec/fixtures/auths/authorizations.json
 - spec/fixtures/events/events.json
+- spec/fixtures/gists/comment.json
+- spec/fixtures/gists/comments.json
 - spec/fixtures/gists/gist.json
 - spec/fixtures/gists/gists.json
 - spec/fixtures/git_data/blob.json
@@ -328,6 +337,7 @@ files:
 - spec/fixtures/repos/watched.json
 - spec/fixtures/repos/watchers.json
 - spec/fixtures/users/user.json
+- spec/github/api_factory_spec.rb
 - spec/github/api_spec.rb
 - spec/github/authorization_spec.rb
 - spec/github/authorizations_spec.rb
@@ -335,6 +345,7 @@ files:
 - spec/github/core_ext/hash_spec.rb
 - spec/github/deprecation_spec.rb
 - spec/github/events_spec.rb
+- spec/github/filter_spec.rb
 - spec/github/gists/comments_spec.rb
 - spec/github/gists_spec.rb
 - spec/github/git_data/blobs_spec.rb
@@ -369,6 +380,7 @@ files:
 - spec/github/result_spec.rb
 - spec/github/users_spec.rb
 - spec/github/utils/url_spec.rb
+- spec/github/validation_spec.rb
 - spec/github_spec.rb
 - spec/README.rdoc
 - spec/spec_helper.rb