github_api 0.10.2 → 0.11.0

data/spec/github/pagination/iterator/number_spec.rb

@@ -13,8 +13,8 @@ describe Github::PageIterator, 'when number' do
   let(:last_link) { "https://api.github.com/users/wycats/repos?page=6&per_page=20" }
 
   let(:current_api) { Github::Repos.new }
-  let(:user)   { 'wycats' }
-  let(:response) { stub(:response).as_null_object }
+  let(:user)     { 'wycats' }
+  let(:response) { double(:response).as_null_object }
 
   subject(:instance) { described_class.new(links, current_api) }
 

data/spec/github/pagination/iterator/sha_spec.rb

@@ -15,8 +15,8 @@ describe Github::PageIterator, 'when sha' do
   let(:last_sha) { "d1e503c02fa770859895dd0d12aedefa28b95723"}
 
   let(:current_api) { Github::Repos.new }
-  let(:user)   { 'wycats' }
-  let(:response) { stub(:response).as_null_object }
+  let(:user)     { 'wycats' }
+  let(:response) { double(:response).as_null_object }
 
   subject(:instance) { described_class.new(links, current_api) }
 

data/spec/github/params_hash_spec.rb

@@ -47,6 +47,12 @@ describe Github::ParamsHash do
     it { expect(subject.data).to eql('foobar') }
   end
 
+  context 'extracts options headers' do
+    let(:hash) { {:content_type => 'application/octet-stream'} }
+
+    it { expect(subject.options[:headers]).to eql(hash) }
+  end
+
   context 'merges defaults' do
     let(:hash) { { :homepage => "https://tty.github.io" }}
     let(:defaults) {

data/spec/github/repos/assets/delete_spec.rb

@@ -0,0 +1,40 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Releases::Assets, '#delete' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:path) { "/repos/#{user}/#{repo}/releases/assets/#{id}" }
+  let(:id)   { 1 }
+
+  before {
+    stub_delete(path).to_return(body: body, status: status,
+      headers: {content_type: 'application/json; charset=utf-8'})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found successfully" do
+    let(:body)   { '' }
+    let(:status) { 204 }
+
+    it "should fail to delete without 'user/repo' parameters" do
+      expect { subject.delete }.to raise_error(ArgumentError)
+    end
+
+    it "should fail to delete resource without asset id" do
+      expect { subject.delete user, repo }.to raise_error(ArgumentError)
+    end
+
+    it "should delete the resource" do
+      subject.delete user, repo, id
+      a_delete(path).should have_been_made
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.delete user, repo, id }
+  end
+
+end # delete

data/spec/github/repos/assets/edit_spec.rb

@@ -0,0 +1,40 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Releases::Assets, '#edit' do
+  let(:owner)  { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:id)     { 1 }
+  let(:path)   { "/repos/#{owner}/#{repo}/releases/assets/#{id}" }
+  let(:inputs) { {'name' => 'readme', 'label' => 'New readme'} }
+
+  before {
+    stub_patch(path).with(inputs).to_return(body: body, status: status,
+      headers: {content_type: 'application/json; charset=utf-8'})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource edited successfully" do
+    let(:body)   { fixture("repos/asset.json") }
+    let(:status) { 200 }
+
+    it { expect {subject.edit owner, repo }.to raise_error(ArgumentError) }
+
+    it "should edit the resource" do
+      subject.edit owner, repo, id, inputs
+      expect(a_patch(path)).to have_been_made
+    end
+
+    it "should get the asset information back" do
+      asset = subject.edit owner, repo, id, inputs
+      expect(asset.id).to eq id
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.edit owner, repo, id, inputs }
+  end
+
+end # edit

data/spec/github/repos/assets/get_spec.rb

@@ -0,0 +1,45 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Releases::Assets, '#get' do
+  let(:owner) { 'peter-murach' }
+  let(:repo)  { 'github' }
+  let(:id)    { 1 }
+  let(:path)  { "/repos/#{owner}/#{repo}/releases/assets/#{id}" }
+
+  before {
+    stub_get(path).to_return(body: body, status: status,
+      headers: {content_type: 'application/json; charset=utf-8'})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body)   { fixture("repos/release.json") }
+    let(:status) { 200 }
+
+    it { should respond_to :find }
+
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
+    it "should fail to get resource without id" do
+      expect { subject.get owner, repo }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.get owner, repo, id
+      expect(a_get(path)).to have_been_made
+    end
+
+    it "should get key information" do
+      asset = subject.get owner, repo, id
+      expect(asset.id).to eq id
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get owner, repo, id }
+  end
+
+end # get

data/spec/github/repos/assets/list_spec.rb

@@ -0,0 +1,55 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Releases::Assets, '#list' do
+  let(:owner) { 'peter-murach' }
+  let(:repo)  { 'github' }
+  let(:id)    { 1 }
+  let(:path)  { "/repos/#{owner}/#{repo}/releases/#{id}/assets" }
+
+  before {
+    stub_get(path).to_return(body: body, status: status,
+      headers: {content_type: 'application/json; charset=utf-8'})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body)   { fixture("repos/assets.json") }
+    let(:status) { 200 }
+
+    it { should respond_to :all }
+
+    it { expect { subject.list }.to raise_error(ArgumentError) }
+
+    it "should fail to get resource without repository" do
+      expect { subject.list owner }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resources" do
+      subject.list owner, repo, id
+      expect(a_get(path)).to have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list owner, repo, id }
+    end
+
+    it "should get asset information" do
+      assets = subject.list owner, repo, id
+      expect(assets.first.name).to eq 'example.zip'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.list(owner, repo, id) { |obj| yielded << obj }
+      expect(yielded).to eq result
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list owner, repo, id }
+  end
+
+end # list

data/spec/github/repos/assets/upload_spec.rb

@@ -0,0 +1,44 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Releases::Assets, '#upload' do
+  let(:owner)    { 'peter-murach' }
+  let(:repo)     { 'github' }
+  let(:id)       { 1 }
+  let(:filepath) { 'batman.js' }
+  let(:file)     { double(:file, read: nil, close: nil) }
+  let(:endpoint) { 'https://uploads.github.com' }
+  let(:inputs)   { {name: 'batman.jpg', content_type: 'application/javascript'} }
+  let(:path)     { "/repos/#{owner}/#{repo}/releases/#{id}/assets" }
+
+  before {
+    Faraday::UploadIO.stub(:new).and_return(file)
+    stub_post(path, endpoint).with(query: {name:'batman.jpg'}).to_return(body: body, status: status,
+      headers: {content_type: 'application/json; charset=utf-8'})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource edited successfully" do
+    let(:body)   { fixture("repos/asset.json") }
+    let(:status) { 201 }
+
+    it { expect {subject.upload owner, repo }.to raise_error(ArgumentError) }
+
+    it "should upload the resource" do
+      subject.upload owner, repo, id, filepath, inputs
+      expect(a_post(path, endpoint).with(query: {name:'batman.jpg'})).to have_been_made
+    end
+
+    it "should get the asset information back" do
+      asset = subject.upload owner, repo, id, filepath, inputs
+      expect(asset.id).to eq id
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.upload owner, repo, id, filepath, inputs }
+  end
+
+end # upload

data/spec/github/repos/downloads/upload_spec.rb

@@ -9,10 +9,10 @@ describe Github::Repos::Downloads do
 
   after { reset_authentication_for(subject) }
 
-  let(:resource) { stub(:resource) }
+  let(:resource) { double(:resource) }
   let(:filename) { 'filename' }
-  let(:res)      { stub(:response, :body => 'success') }
-  let(:uploader) { stub(:uploader, :send => res) }
+  let(:res)      { double(:response, :body => 'success') }
+  let(:uploader) { double(:uploader, :send => res) }
 
   before { Github::S3Uploader.stub(:new) { uploader } }
 
@@ -23,8 +23,8 @@ describe Github::Repos::Downloads do
   end
 
   it "should upload resource successfully" do
-    res = stub(:response, :body => 'success')
-    uploader = stub(:uploader, :send => res)
+    res = double(:response, :body => 'success')
+    uploader = double(:uploader, :send => res)
     Github::S3Uploader.should_receive(:new).with(resource, filename) { uploader }
     subject.upload(resource, filename).should == 'success'
   end

data/spec/github/repos/releases/create_spec.rb

@@ -0,0 +1,44 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Releases, '#create' do
+  let(:owner)  { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:tag)    { 'v1.0.0' }
+  let(:path )  { "/repos/#{owner}/#{repo}/releases" }
+  let(:inputs) { {'name' => 'v1.0.0', 'body' => 'New release'} }
+
+  before {
+    stub_post(path).with(inputs).to_return(body: body, status: status,
+      headers: {content_type: 'application/json; charset=utf-8'})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context 'resource created' do
+    let(:body)   { fixture('repos/release.json') }
+    let(:status) { 201 }
+
+    it 'should fail to create resource without tag name' do
+      expect {
+        subject.create owner, repo
+      }.to raise_error(ArgumentError)
+    end
+
+    it "should create the resource" do
+      subject.create owner, repo, tag, inputs
+      expect(a_post(path).with(inputs)).to have_been_made
+    end
+
+    it "should get the key information back" do
+      release = subject.create owner, repo, tag, inputs
+      expect(release.tag_name).to eq tag
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.create owner, repo, tag, inputs }
+  end
+
+end # create

data/spec/github/repos/releases/delete_spec.rb

@@ -0,0 +1,40 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Releases, '#delete' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:id)   { 1 }
+  let(:path) { "/repos/#{user}/#{repo}/releases/#{id}" }
+
+  before {
+    stub_delete(path).to_return(body: body, status: status,
+      headers: {content_type: 'application/json; charset=utf-8'})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found successfully" do
+    let(:body)   { '' }
+    let(:status) { 204 }
+
+    it "should fail to delete without 'user/repo' parameters" do
+      expect { subject.delete }.to raise_error(ArgumentError)
+    end
+
+    it "should fail to delete resource without key id" do
+      expect { subject.delete user, repo }.to raise_error(ArgumentError)
+    end
+
+    it "should delete the resource" do
+      subject.delete user, repo, id
+      a_delete(path).should have_been_made
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.delete user, repo, id }
+  end
+
+end # delete

data/spec/github/repos/releases/edit_spec.rb

@@ -0,0 +1,40 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Releases, '#edit' do
+  let(:owner)  { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:id)     { 1 }
+  let(:path)   { "/repos/#{owner}/#{repo}/releases/#{id}" }
+  let(:inputs) { {'name' => 'v1.0.0', 'body' => 'New release'} }
+
+  before {
+    stub_patch(path).with(inputs).to_return(body: body, status: status,
+      headers: {content_type: 'application/json; charset=utf-8'})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource edited successfully" do
+    let(:body)   { fixture("repos/release.json") }
+    let(:status) { 200 }
+
+    it { expect {subject.edit owner, repo }.to raise_error(ArgumentError) }
+
+    it "should edit the resource" do
+      subject.edit owner, repo, id, inputs
+      expect(a_patch(path)).to have_been_made
+    end
+
+    it "should get the key information back" do
+      release = subject.edit owner, repo, id, inputs
+      expect(release.id).to eq id
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.edit owner, repo, id, inputs }
+  end
+
+end # edit

data/spec/github/repos/releases/get_spec.rb

@@ -0,0 +1,45 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Releases, '#get' do
+  let(:owner) { 'peter-murach' }
+  let(:repo)  { 'github' }
+  let(:id)    { 1 }
+  let(:path)  { "/repos/#{owner}/#{repo}/releases/#{id}" }
+
+  before {
+    stub_get(path).to_return(body: body, status: status,
+      headers: {content_type: 'application/json; charset=utf-8'})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body)   { fixture("repos/release.json") }
+    let(:status) { 200 }
+
+    it { should respond_to :find }
+
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
+    it "should fail to get resource without key" do
+      expect { subject.get owner, repo }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.get owner, repo, id
+      expect(a_get(path)).to have_been_made
+    end
+
+    it "should get key information" do
+      release = subject.get owner, repo, id
+      expect(release.id).to eq id
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get owner, repo, id }
+  end
+
+end # get