github-pages-health-check 1.8.1 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63d816be2a09fb2b98a8aa9de70ff9533f72e0711047ab63b730a02aa3b43f85
-  data.tar.gz: 21b4ecb9db896306e1d5b4940172b6249291af3864d2f3973ecb1393556ded4f
+  metadata.gz: 491f20abd7228f543a6f4682b74918a9f32265ca0f0f015d41ae40e5163462e6
+  data.tar.gz: 1dcb08e4d692030537e2d1334c09edbcac2e4179fb7ad05fe23cb412c6401270
 SHA512:
-  metadata.gz: 5fa9eb6db92604ca00ffd2e32a7cbc1c700edc1f43e2dea993a9ccd75f68376d539a9161142bb4ffb7725f7c121c346f0559e5dc65881267985b72e7d887464c
-  data.tar.gz: 37154b43277d90b689a84a5f4dd145ed04a03d54ad7761c149414e7d5ce17868bf76b1d6ff2f40fc6e16a97d373e1ebf6b0fd4db6dfc673c5da3451422ddad15
+  metadata.gz: 18bb1e7f1c7ece16a011ddd55c4f4238ab600be77013705857306cbbfd6d74e120b72f62ea853647c1b7d0a8affcc0dda222c7a22008645f4f66abe755c64634
+  data.tar.gz: b099817a6ebd5298f81a993f5c5c2b767bd291122f0262f81002bdb4a1fa315864f838698b9e192719f46fbbd4b7b0ceba59e92a3ad8fe10f94a3edf97aa5873

data/.rubocop.yml

@@ -128,16 +128,17 @@ Metrics/ClassLength:
     - lib/github-pages-health-check/domain.rb
 
 Metrics/CyclomaticComplexity:
-  Max: 8
+  Max: 9
   Exclude:
     - lib/github-pages-health-check/printer.rb
 
 Metrics/PerceivedComplexity:
-  Max: 8
+  Max: 9
   Exclude:
     - lib/github-pages-health-check/printer.rb
 
 Metrics/AbcSize:
+  Max: 17
   Exclude:
     - lib/github-pages-health-check/printer.rb
 

data/lib/github-pages-health-check/domain.rb

@@ -105,6 +105,7 @@ module GitHubPages
         return true if proxied?
         raise Errors::InvalidARecordError, :domain => self    if invalid_a_record?
         raise Errors::InvalidCNAMEError, :domain => self      if invalid_cname?
+        raise Errors::InvalidAAAARecordError, :domain => self if invalid_aaaa_record?
         raise Errors::NotServedByPagesError, :domain => self  unless served_by_pages?
         true
       end
@@ -114,6 +115,12 @@ module GitHubPages
         @deprecated_ip = (valid_domain? && a_record? && old_ip_address?)
       end
 
+      def invalid_aaaa_record?
+        return @invalid_aaaa_record if defined? @invalid_aaaa_record
+        @invalid_aaaa_record = (valid_domain? && should_be_a_record? &&
+                                aaaa_record_present?)
+      end
+
       def invalid_a_record?
         return @invalid_a_record if defined? @invalid_a_record
         @invalid_a_record = (valid_domain? && a_record? && !should_be_a_record?)
@@ -241,6 +248,7 @@ module GitHubPages
 
       REQUESTED_RECORD_TYPES = [
         Dnsruby::Types::A,
+        Dnsruby::Types::AAAA,
         Dnsruby::Types::CNAME,
         Dnsruby::Types::MX
       ].freeze
@@ -286,6 +294,11 @@ module GitHubPages
         dns.first.type == Dnsruby::Types::A
       end
 
+      def aaaa_record_present?
+        return unless dns?
+        dns.any? { |answer| answer.type == Dnsruby::Types::AAAA }
+      end
+
       # Is this domain's first response a CNAME record?
       def cname_record?
         return unless dns?

data/lib/github-pages-health-check/errors/invalid_aaaa_record_error.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module GitHubPages
+  module HealthCheck
+    module Errors
+      class InvalidAAAARecordError < GitHubPages::HealthCheck::Error
+        DOCUMENTATION_PATH = "/articles/setting-up-a-custom-domain-with-github-pages/".freeze
+
+        def message
+          <<-MSG
+             Your site's DNS settings are using a custom subdomain, #{domain.host},
+             that's set up with an AAAA record. GitHub Pages currently does not support
+             IPv6.
+           MSG
+        end
+      end
+    end
+  end
+end

data/lib/github-pages-health-check/resolver.rb

@@ -27,7 +27,6 @@ module GitHubPages
         @domain = domain
       end
 
-      # rubocop:disable Metrics/AbcSize
       def query(type)
         if PREFERS_AUTHORITATIVE_ANSWER.include?(type)
           answer = authoritative_resolver.query(domain, type).answer
@@ -38,7 +37,6 @@ module GitHubPages
       rescue Dnsruby::ResolvTimeout, Dnsruby::ResolvError
         self.class.default_resolver.query(domain, type).answer
       end
-      # rubocop:enable Metrics/AbcSize
 
       private
 

data/lib/github-pages-health-check/version.rb

@@ -2,6 +2,6 @@
 
 module GitHubPages
   module HealthCheck
-    VERSION = "1.8.1".freeze
+    VERSION = "1.9.0".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: github-pages-health-check
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: 1.9.0
 platform: ruby
 authors:
 - GitHub, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-07 00:00:00.000000000 Z
+date: 2018-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -192,6 +192,7 @@ files:
 - lib/github-pages-health-check/errors/build_error.rb
 - lib/github-pages-health-check/errors/deprecated_ip_error.rb
 - lib/github-pages-health-check/errors/invalid_a_record_error.rb
+- lib/github-pages-health-check/errors/invalid_aaaa_record_error.rb
 - lib/github-pages-health-check/errors/invalid_cname_error.rb
 - lib/github-pages-health-check/errors/invalid_dns_error.rb
 - lib/github-pages-health-check/errors/invalid_domain_error.rb