github-pages-health-check 1.18.2 → 1.18.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd7b9a6265476c7ffa7b965ed0c331df229ceef7446b119fa35188acc8c43155
-  data.tar.gz: fb46e328d327c0ca84f6d69e1a183ea1989b226596d9bef705b489536f37bc30
+  metadata.gz: be8f2f5afcacf1c6155e28bc3b0019f0096f2b2ff1bd6c5c86c8e3fc0336a86f
+  data.tar.gz: c68fa1d0c592ec2357331bb30f9ff7435348777d6872c0915ae1fea6dbb03e9d
 SHA512:
-  metadata.gz: 52ed7e445d7a983bc42076cc9c23eb51bc0b9966d9642638503d5b1d2f7e23e13881162f5138cdffbee2635acc63b76f5b7a47b2bf99a120fcee931f1cc36034
-  data.tar.gz: cfb67f8e4f0ed0c75e68c62d7bdd214842bb006dd824e9a09f331ccc9e7053e4e7f2cd16f443f61db6c5d3f262278a55168cf601e70c207feddc5c4bbee14c2c
+  metadata.gz: 77b2fcb2d737a1c28a8469333934335509664b169ab9a2483a5ab287ecd9ec43ef9ffc797d4cc2b2afd68929c7bc7a92ed897e8c3c832ad45b857c990c59359b
+  data.tar.gz: 1a6c44c4d002607840493af318bd7c8b3b6cf9fb5c34ea7e1ad67e9a2aff6b05900254eb6876bdff7aaf1c71527c7a86ff541a166e5112c323b7bf9d6b9b549f

data/.github/CODEOWNERS

@@ -0,0 +1,2 @@
+# Automatically add our team to each pull request in this repo
+* @github/pages-reviewers

data/.github/workflows/pages-gem.yml

@@ -0,0 +1,27 @@
+name: Publish Gem
+
+on:
+  release:
+    types: [released]
+
+permissions:
+  contents: read
+
+jobs:
+  release:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@52753b7da854d5c07df37391a986c76ab4615999 # v1.191.0
+        with:
+          ruby-version: '3.2'
+      - name: Build gem
+        run: |
+          gem build github-pages-health-check.gemspec
+      - name: Publish gem
+        env:
+          GEM_HOST_API_KEY: ${{ secrets.PAGES_GEM_PUBLISHING }}
+        run: |
+          gem push github-pages-health-check-*.gem

data/.github/workflows/push-cibuild.yml

@@ -1,5 +1,7 @@
 on: push
 name: "GitHub Pages Health Check Tests"
+permissions:
+  contents: read
 jobs:
   build:
     name: "GitHub Pages Health Check Tests"
@@ -8,8 +10,6 @@ jobs:
       fail-fast: false
       matrix:
         ruby:
-          - '2.6'
-          - '2.7'
           - '3.0'
           - '3.1'
           - '3.2'

data/.rubocop.yml

@@ -17,7 +17,7 @@
 #
 
 AllCops:
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 3.0
   Exclude:
     - 'bin/**/*'
     - 'script/**/*'

data/.ruby-version

@@ -1 +1 @@
-2.7.1
+3.2

data/Gemfile

@@ -8,6 +8,7 @@ group :development do
   gem "pry", "~> 0.10"
   gem "pry-byebug"
   gem "rspec", "~> 3.0"
+  gem "rspec-retry", "~> 0.6"
   gem "rubocop", "~> 0.52"
   gem "webmock", "~> 3.8"
 end

data/github-pages-health-check.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency("addressable", "~> 2.3")
   s.add_dependency("dnsruby", "~> 1.60")
-  s.add_dependency("octokit", ">= 4", "< 8")
-  s.add_dependency("public_suffix", ">= 3.0", "< 6.0")
+  s.add_dependency("octokit", ">= 4", "< 10")
+  s.add_dependency("public_suffix", ">= 3.0", "< 7.0")
   s.add_dependency("typhoeus", "~> 1.3")
 end

data/lib/github-pages-health-check/domain.rb

@@ -91,7 +91,7 @@ module GitHubPages
         host uri nameservers dns_resolves? proxied? cloudflare_ip?
         fastly_ip? old_ip_address? a_record? aaaa_record? a_record_present? aaaa_record_present?
         cname_record? mx_records_present? valid_domain? apex_domain?
-        should_be_a_record? cname_to_github_user_domain?
+        should_be_a_record? cname_to_github_user_domain? cname_to_domain_to_pages?
         cname_to_pages_dot_github_dot_com? cname_to_fastly?
         pointed_to_github_pages_ip? non_github_pages_ip_present? pages_domain?
         served_by_pages? valid? reason valid_domain? https?
@@ -243,6 +243,20 @@ module GitHubPages
         cname? && !cname_to_pages_dot_github_dot_com? && cname.pages_domain?
       end
 
+      # Check if the CNAME points to a Domain that points to pages
+      # e.g. CNAME -> Domain -> Pages
+      # rubocop:disable Metrics/AbcSize
+      def cname_to_domain_to_pages?
+        return false unless dns?
+
+        a_record_to_pages = dns.select { |d| d.type == Dnsruby::Types::A && d.name.to_s == host }.first
+
+        return false unless a_record_to_pages && cname? && !cname_to_pages_dot_github_dot_com? && @www_cname
+
+        CURRENT_IP_ADDRESSES.include?(a_record_to_pages.address.to_s.downcase)
+      end
+      # rubocop:enable Metrics/AbcSize
+
       # Is the given domain a CNAME to pages.github.(io|com)
       # instead of being CNAME'd to the user's subdomain?
       #
@@ -273,7 +287,7 @@ module GitHubPages
 
       # Is this domain owned by GitHub?
       def github_domain?
-        !!host.downcase.end_with?("github.com")
+        host.downcase.eql?("github.com") || host.downcase.end_with?(".github.com")
       end
 
       # Is the host our Fastly CNAME?
@@ -304,6 +318,7 @@ module GitHubPages
         return true if cloudflare_ip?
         return false if pointed_to_github_pages_ip?
         return false if cname_to_github_user_domain?
+        return false if cname_to_domain_to_pages?
         return false if cname_to_pages_dot_github_dot_com?
         return false if cname_to_fastly? || fastly_ip?
 
@@ -399,9 +414,16 @@ module GitHubPages
         cnames = dns.take_while { |answer| answer.type == Dnsruby::Types::CNAME }
         return if cnames.empty?
 
+        www_cname(cnames.last)
         @cname ||= Domain.new(cnames.last.cname.to_s)
       end
 
+      # Check if we have a 'www.' CNAME that matches the domain
+      def www_cname(cname)
+        @www_cname ||= cname.name.to_s.start_with?("www.") &&
+          cname.name.to_s.end_with?(cname.domainname.to_s)
+      end
+
       def mx_records_present?
         return unless dns?
 
@@ -454,8 +476,7 @@ module GitHubPages
         return false if host.include?("_")
 
         # Must be a CNAME or point to our IPs.
-        # Only check the one domain if a CNAME. Don't check the parent domain.
-        return true if cname_to_github_user_domain?
+        return true if cname_to_github_user_domain? || cname_to_domain_to_pages?
 
         # Check CAA records for the full domain and its parent domain.
         pointed_to_github_pages_ip? && caa.lets_encrypt_allowed?

data/lib/github-pages-health-check/version.rb

@@ -2,6 +2,6 @@
 
 module GitHubPages
   module HealthCheck
-    VERSION = "1.18.2"
+    VERSION = "1.18.5"
   end
 end

data/lib/github-pages-health-check.rb

@@ -66,6 +66,7 @@ module GitHubPages
 
       @typhoeus_options = {
         :followlocation => true,
+        :redir_protocols => %i[http https], # don't allow non-http protocols on redirections
         :timeout => TIMEOUT,
         :accept_encoding => "gzip",
         :method => :head,

data/script/cibuild-docker

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-: ${RUBY_VERSION:="2.7"}
+: ${RUBY_VERSION:="3.2"}
 docker build -t github-pages-health-check --build-arg RUBY_VERSION=$RUBY_VERSION .
 if [ -n "$DEBUG" ]; then
   # Run a shell.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: github-pages-health-check
 version: !ruby/object:Gem::Version
-  version: 1.18.2
+  version: 1.18.5
 platform: ruby
 authors:
 - GitHub, Inc.
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-19 00:00:00.000000000 Z
+date: 2024-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -47,7 +47,7 @@ dependencies:
         version: '4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8'
+        version: '10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -57,7 +57,7 @@ dependencies:
         version: '4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8'
+        version: '10'
 - !ruby/object:Gem::Dependency
   name: public_suffix
   requirement: !ruby/object:Gem::Requirement
@@ -67,7 +67,7 @@ dependencies:
         version: '3.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -77,7 +77,7 @@ dependencies:
         version: '3.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
@@ -99,7 +99,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".dockerignore"
+- ".github/CODEOWNERS"
 - ".github/dependabot.yml"
+- ".github/workflows/pages-gem.yml"
 - ".github/workflows/push-cibuild.yml"
 - ".gitignore"
 - ".rspec"
@@ -151,7 +153,7 @@ homepage: https://github.com/github/github-pages-health-check
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -166,8 +168,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
-signing_key:
+rubygems_version: 3.4.19
+signing_key: 
 specification_version: 4
 summary: Checks your GitHub Pages site for commons DNS configuration issues
 test_files: []