github-pages-health-check 1.12.0 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 679ba9ffc25dcc84048349056269a107b8b06238593b546e4bc896fa30521d1d
-  data.tar.gz: 4ecaddefc7f3d1451fa481faae3b088799077603dc8e3d8793400d7434002a72
+  metadata.gz: 1dc7e8e6ff875a82f7b7a63fb1c0f36887c4fb04a227216b6bd73219a1e5433e
+  data.tar.gz: 638976ceb500093ad1a9b1060eeced2206d7a7e368c0160efd6a63f9259de418
 SHA512:
-  metadata.gz: 89c5a7975632bee55c646c48093d56c319a5bf7ca9503adc2b05526691d053a5c8ac883b1608d83032193bd3da454091c4edc8f6f5401d528dfca8fc7c49b2b6
-  data.tar.gz: 0736ad8c4d6bb5ad484d90de791a66c806a79ac9cbeeda9c3923a7e3b7a417b144de200b7952dfe81eb0d609f2676a924cb94fb19edfebdc885e9d1f6745927d
+  metadata.gz: 72c2a0f8c3762c6fba32e9ff160dad0539bd039afd67c5d1de37f16f8ce03c54ad396b03a5af3a76b3436c0d7898c579ec767fc10cfebf8054d90bbd2afb070f
+  data.tar.gz: f18feaf2e003d54fd17d30d2585cd7840a2085e9174227bda7499aa5fdf3633d11b45a69b691836465e060570125703a8875a1eec4b2f73a181078ecb1f6ee4b

data/lib/github-pages-health-check/caa.rb

@@ -33,9 +33,8 @@ module GitHubPages
       end
 
       def records
-        unicode_host = Addressable::IDNA.to_unicode(host)
         @records ||= begin
-          get_caa_records(host) | get_caa_records(PublicSuffix.domain(unicode_host))
+          get_caa_records(host) | get_caa_records(host.split(".").drop(1).join("."))
         end
       end
 

data/lib/github-pages-health-check/domain.rb

@@ -63,28 +63,27 @@ module GitHubPages
         "43.249.72.133",
         "43.249.73.133",
         "43.249.74.133",
-        "43.249.75.133"
+        "43.249.75.133",
+
+        # 2018 Move to GitHub assigned IP space
+        "192.30.252.153",
+        "192.30.252.154"
       ].freeze
 
-      NEW_PRIMARY_IPS = %w(
+      CURRENT_IP_ADDRESSES = %w(
         185.199.108.153
         185.199.109.153
         185.199.110.153
         185.199.111.153
       ).freeze
 
-      CURRENT_IP_ADDRESSES = [
-        "192.30.252.153",
-        "192.30.252.154",
-        *NEW_PRIMARY_IPS
-      ].freeze
-
       HASH_METHODS = %i[
         host uri nameservers dns_resolves? proxied? cloudflare_ip?
         fastly_ip? old_ip_address? a_record? cname_record?
         mx_records_present? valid_domain? apex_domain? should_be_a_record?
         cname_to_github_user_domain? cname_to_pages_dot_github_dot_com?
-        cname_to_fastly? pointed_to_github_pages_ip? pages_domain?
+        cname_to_fastly? pointed_to_github_pages_ip?
+        non_github_pages_ip_present? pages_domain?
         served_by_pages? valid? reason valid_domain? https?
         enforces_https? https_error https_eligible? caa_error
       ].freeze
@@ -179,9 +178,14 @@ module GitHubPages
         a_record? && CURRENT_IP_ADDRESSES.include?(dns.first.address.to_s)
       end
 
-      # Is the domain's first response an A record to the new primary IPs?
-      def pointed_to_new_primary_ips?
-        a_record? && NEW_PRIMARY_IPS.include?(dns.first.address.to_s)
+      # Are any of the domain's A records pointing elsewhere?
+      def non_github_pages_ip_present?
+        return unless dns?
+        a_records = dns.select { |answer| answer.type == Dnsruby::Types::A }
+
+        a_records.any? { |answer| !github_pages_ip?(answer.address.to_s) }
+
+        false
       end
 
       # Is the domain's first response a CNAME to a pages domain?
@@ -363,8 +367,9 @@ module GitHubPages
 
       # Can an HTTPS certificate be issued for this domain?
       def https_eligible?
-        (cname_to_github_user_domain? || pointed_to_new_primary_ips?) &&
-          !aaaa_record_present? && caa.lets_encrypt_allowed?
+        (cname_to_github_user_domain? || pointed_to_github_pages_ip?) &&
+          !aaaa_record_present? && !non_github_pages_ip_present? &&
+          caa.lets_encrypt_allowed?
       end
 
       # Any errors querying CAA records
@@ -457,6 +462,10 @@ module GitHubPages
       def legacy_ip?(ip_addr)
         LEGACY_IP_ADDRESSES.include?(ip_addr)
       end
+
+      def github_pages_ip?(ip_addr)
+        CURRENT_IP_ADDRESSES.include?(ip_addr)
+      end
     end
   end
 end

data/lib/github-pages-health-check/version.rb

@@ -2,6 +2,6 @@
 
 module GitHubPages
   module HealthCheck
-    VERSION = "1.12.0".freeze
+    VERSION = "1.13.0".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: github-pages-health-check
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.13.0
 platform: ruby
 authors:
 - GitHub, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-20 00:00:00.000000000 Z
+date: 2018-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -234,7 +234,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Checks your GitHub Pages site for commons DNS configuration issues