github-ldap 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5094836df33821281e971a9d3f1028df7cba6d71
-  data.tar.gz: f681bea4b0ae307888cd037db8b232e4e08af462
+  metadata.gz: 28c2327d79def9d64d8f90b46e6a12b7055ed6ac
+  data.tar.gz: 3e1a9c422a6d1729c526d21657c51ee15b7662c3
 SHA512:
-  metadata.gz: a6464449256546e16d1962bba8b3c6599a5eb3e6f41d965225c540a98c2d1f19313e90da62c3ca84a09ae374fdde525d68089da73c251681b28053c09e23e9b6
-  data.tar.gz: 6830909544c79613b8ea4626032303b6ef8a3aa8d25ea95fe6347257bae7ca9c2e3ca881c6711a3cd27836d866ae8e3bdfe18d7035053b78f7628a2760ad776c
+  metadata.gz: b347d766538664ea6d4a5b93cc4f4ef7eea792f601ae03e4aa8a4f824e0e3d9aa7867257cad27e7daee6a686e1e144b23b5531cb6f38a4b1394f4d3688f8c981
+  data.tar.gz: 424fa3a3f07d1871c464d9aae38cd48dc2dec3b0a6200060923ee20d13ba59e70c815fca37047d18577d40a034b2a3d4c068b9b39d71d5d13ebb96849d156460

data/github-ldap.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "github-ldap"
-  spec.version       = "1.1.0"
+  spec.version       = "1.1.1"
   spec.authors       = ["David Calavera"]
   spec.email         = ["david.calavera@gmail.com"]
   spec.description   = %q{Ldap authentication for humans}

data/lib/github/ldap.rb

@@ -87,11 +87,15 @@ module GitHub
     # base_name: is the dn of the base root.
     #
     # Returns a new Group object.
+    # Returns nil if the dn is not in the server.
     def group(base_name)
+      entry = domain(base_name).bind
+      return unless entry
+
       if @virtual_attributes.enabled?
-        VirtualGroup.new(self, domain(base_name).bind)
+        VirtualGroup.new(self, entry)
       else
-        Group.new(self, domain(base_name).bind)
+        Group.new(self, entry)
       end
     end
 

data/test/group_test.rb

@@ -6,11 +6,12 @@ class GitHubLdapGroupTest < GitHub::Ldap::Test
   end
 
   def groups_domain
-    GitHub::Ldap.new(options).domain("ou=groups,dc=github,dc=com")
+    @ldap.domain("ou=groups,dc=github,dc=com")
   end
 
   def setup
-    @group = GitHub::Ldap.new(options).group("cn=enterprise,ou=groups,dc=github,dc=com")
+    @ldap  = GitHub::Ldap.new(options)
+    @group = @ldap.group("cn=enterprise,ou=groups,dc=github,dc=com")
   end
 
   def test_subgroups
@@ -30,6 +31,11 @@ class GitHubLdapGroupTest < GitHub::Ldap::Test
     groups = groups_domain.filter_groups('devs')
     assert_equal 1, groups.size
   end
+
+  def test_unknown_group
+    refute @ldap.group("cn=foobar,ou=groups,dc=github,dc=com"),
+      "Expected to not bind any group"
+  end
 end
 
 class GitHubLdapLoopedGroupTest < GitHub::Ldap::Test

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github-ldap
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - David Calavera