github-ldap 1.0.13 → 1.0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 663aa6744a1c2d0be074f1a483d7de549c6406ea
-  data.tar.gz: ec942332f6459f1c49565f9046c6bdd45636b724
+  metadata.gz: 07498d4477565ea224ca8af669cc442308276298
+  data.tar.gz: cf73c24745848b687a4efacf7d3eaa19a19418bb
 SHA512:
-  metadata.gz: 2323046a450b696e794b7eb3e6984d5c107e196ea4939a63ad9d1140a3733891cc1453611ed4bce323d9c470d0cfb86be59cb80cdd6be228bdbcf1e38a7d9f61
-  data.tar.gz: 20de0be293a681998e4fa66874d5258da002293c6e610a2b24aa6c2f3d1f45be3abc4dba7ef190e3413b8ded3c7e1457f7b9d3398a7cafa35270fb7d39f2064f
+  metadata.gz: 96c0ab7db485b52cd67bc1939eaa68fd85c7ae31515e0b06e2abc780980302ac501b1d070b9c05712e7debf804f2cd0618eb4eca1ff81dbddca3887e2f4f22e2
+  data.tar.gz: 9ba0caec46275cfd3cced39d07bac7f2ba398a88539f6756d83dea441de784d6d0a198f93a8bc51c9d17c7dc82bbb17fa17ddd588721820e5aa61c3414112f9f

data/.travis.yml

@@ -2,3 +2,6 @@ language: ruby
 rvm:
     - 1.9.3
     - 2.0.0
+    
+notifications:
+  email: false

data/github-ldap.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "github-ldap"
-  spec.version       = "1.0.13"
+  spec.version       = "1.0.15"
   spec.authors       = ["David Calavera"]
   spec.email         = ["david.calavera@gmail.com"]
   spec.description   = %q{Ldap authentication for humans}

data/lib/github/ldap/domain.rb

@@ -73,8 +73,9 @@ module GitHub
       # Returns the user if the login matches any `uid`.
       # Returns nil if there are no matches.
       def user?(login)
+        escaped_login = Net::LDAP::Filter.escape(login)
         rs = search(
-          filter: Net::LDAP::Filter.eq(@uid, login),
+          filter: Net::LDAP::Filter.eq(@uid, escaped_login),
           attributes: [],
           limit: 1)
         rs and rs.first
@@ -119,6 +120,16 @@ module GitHub
 
         @connection.search(options)
       end
+
+      # Provide a meaningful result after a protocol operation (for example,
+      # bind or search) has completed.
+      #
+      # Returns an OpenStruct containing an LDAP result code and a
+      # human-readable string.
+      # See http://tools.ietf.org/html/rfc4511#appendix-A
+      def get_operation_result
+        @connection.get_operation_result
+      end
     end
   end
 end

data/test/domain_test.rb

@@ -95,6 +95,10 @@ module GitHubLdapDomainTestCases
     assert_equal 'uid=calavera,dc=github,dc=com', @domain.user?('calavera').dn
   end
 
+  def test_user_wildcards_are_filtered
+    assert !@domain.user?('cal*'), 'Expected uid `cal*` to not complete'
+  end
+
   def test_user_does_not_exist
     assert !@domain.user?('foobar'), 'Expected uid `foobar` to not exist.'
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: github-ldap
 version: !ruby/object:Gem::Version
-  version: 1.0.13
+  version: 1.0.15
 platform: ruby
 authors:
 - David Calavera
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-13 00:00:00.000000000 Z
+date: 2013-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-ldap