github-ds 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 235c233b2750caaa258c1fc172f6b2b14d117d533f247fbce0cb34ca83779b96
-  data.tar.gz: 88caf6d96cce86f1ad841e22397e2f21ed63982a00fc3469009ed230126001a1
+  metadata.gz: 88208f2b8cc24184dce9a984af467c44d9560196e9832d637ee99aac34082da8
+  data.tar.gz: 70f8c5e30c4b237e33e0d96ff747c4719bcf300f5a67472fe7d347e6779ff0f7
 SHA512:
-  metadata.gz: 47af7f674f862f846be53c0546cbb76ec38f9d96c8043b0107a7406a5bbf8bdfa7773fcbdf0071165d18105327471f7b06ee41c7e46f3464ea1c621d0f9dac0e
-  data.tar.gz: 5a73591ab5bd465376ec8d2e849aaf1fd10f269121eb50bc1428f1f7c42c91d9a4305299f70b21df1aecb9757c16de516ceab7594ba8f290d5e37d491615986b
+  metadata.gz: 5afcb251c8dcbb250db23eb758f67a38baa8933fcf6325f2c9a419ae1dcee5455d7571a0eb0cfed0b401134225e482c74cab421b0bd116931996b5b954710c78
+  data.tar.gz: bda6aa58192ec5d29d3a909f1d14d939fcb4b069019c7d617ede8f3e580eceedaddb180cf2c266cf9e8d21e262d7752d3d04d20ecfe1e5491cf75f544a611395

data/.travis.yml

@@ -3,15 +3,12 @@ before_install:
   - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
   - gem install bundler -v '<2'
 rvm:
-  - 2.3
-  - 2.4
   - 2.5
+  - 2.6
+  - 2.7
 script: bundle exec rake
 env:
-  - RAILS_VERSION=6.0.0.rc1
+  - RAILS_VERSION=6.0.3.1
   - RAILS_VERSION=5.2.0
-  - RAILS_VERSION=5.1.5
-  - RAILS_VERSION=5.0.6
-  - RAILS_VERSION=4.2.10
 services:
   - mysql

data/Gemfile

@@ -1,12 +1,18 @@
 source "https://rubygems.org"
 gemspec
 
-DEFAULT_RAILS_VERSION = '5.0.2'
+DEFAULT_RAILS_VERSION = '6.0.3'
+ENV['RAILS_VERSION'] ||= DEFAULT_RAILS_VERSION
 
-if ENV['RAILS_VERSION'] = '4.2.10'
+if ENV['RAILS_VERSION'] == '4.2.10'
   gem 'mysql2', '~> 0.3.18'
 else
   gem "mysql2"
 end
-gem "rails", "~> #{ENV['RAILS_VERSION'] || DEFAULT_RAILS_VERSION}"
-gem "activerecord", "~> #{ENV['RAILS_VERSION'] || DEFAULT_RAILS_VERSION}"
+
+if ENV['RAILS_VERSION'] == 'master'
+  gem "activerecord", git: "https://github.com/rails/rails"
+else
+  gem "rails", "~> #{ENV['RAILS_VERSION'] || DEFAULT_RAILS_VERSION}"
+  gem "activerecord", "~> #{ENV['RAILS_VERSION'] || DEFAULT_RAILS_VERSION}"
+end

data/github-ds.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "activerecord", ">= 3.2"
 
   spec.add_development_dependency "bundler", ">= 1.14"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", "~> 12.0"
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "timecop", "~> 0.8.1"
   spec.add_development_dependency "activesupport"

data/lib/generators/github/ds/active_record_generator.rb

@@ -18,7 +18,7 @@ module Github
         end
 
         def self.migration_version
-          if Rails.version.start_with?('5')
+          if Rails::VERSION::MAJOR.to_i >= 5
             "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
           end
         end

data/lib/github/ds/version.rb

@@ -1,5 +1,5 @@
 module GitHub
   module DS
-    VERSION = "0.4.0"
+    VERSION = "0.5.0"
   end
 end

data/lib/github/sql.rb

@@ -43,7 +43,7 @@ module GitHub
     # GitHub::SQL#initialize or overriding connection then you'll need to use
     # the instance version.
     def self.transaction(options = {}, &block)
-      ActiveRecord::Base.connection.transaction(options, &block)
+      ActiveRecord::Base.connection.transaction(**options, &block)
     end
 
     # Public: Instantiate a literal SQL value.
@@ -213,7 +213,7 @@ module GitHub
       # Use select_all to retrieve hashes for each row instead of arrays of values.
       @models = connection.
         select_all(query, "#{klass.name} Load via #{self.class.name}").
-          collect! { |record| klass.send :instantiate, record }
+        map { |record| klass.send :instantiate, record }
 
       retrieve_found_row_count
       freeze
@@ -299,7 +299,7 @@ module GitHub
 
     # Public: Run inside a transaction for the connection.
     def transaction(options = {}, &block)
-      connection.transaction(options, &block)
+      connection.transaction(**options, &block)
     end
 
     # Internal: The object we use to execute SQL and retrieve results. Defaults

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: github-ds
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - GitHub Open Source
 - John Nunemaker
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2019-12-20 00:00:00.000000000 Z
+date: 2020-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -199,7 +199,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -214,8 +214,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: A collection of libraries for working with SQL on top of ActiveRecord's connection.
 test_files: []