github-ds 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e3dda4d4ed9f093a4e3d098f5701f804bde5fc55
-  data.tar.gz: ee1f88f94fcd6986913b9c4ee1dc85269b8bb108
+  metadata.gz: 71f03b79bb5da02405c55e147147550eede9a120
+  data.tar.gz: 69c8978ef97b5d7a45e005cbbdf371ce601c68bc
 SHA512:
-  metadata.gz: dcff9123a791a1ca4e81f2db9faef112331712070cf5920465c4bcd46c42eabc36b48626f80eeff886dd8791e98e0d6611be9b94b7f20ff179b17fe585ee2f9d
-  data.tar.gz: a30eed58460e4f4e9430f12fe41f6ab1537eb1f3b07a33d990606cb62b8e19dedd079ac210da68105ff8f30dec56b91e2f5ebd9213606882dcf6b32e31067014
+  metadata.gz: 4d7c7c75907e73190497e58bdda8a9729a334e7aa05f6482c57ea1f0a48ed0db9871728604f7160e23d02e0d641d581241113d3f0bb85b90959c877b2fa84b44
+  data.tar.gz: 600871b7b135f7d0544e74e05921e97b1e6c292046b14306bbbe68155c3c8df7bb3a42a2abe18769db41c011787c82dfd1cd3d3411b3fd10ab8b55f92b413971

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.2.2
+
+Additions
+
+* `GitHub::KV` accepts `SQL::Literal` as valid values https://github.com/github/github-ds/pull/21/commits/c11d4e3154dd3435d509a3356f46d0a2981d7234
+
+Fixes
+
+* Value length validation takes into account that strings can be made of multi-byte characters https://github.com/github/github-ds/pull/21/commits/5156f95ef04b1ecf2ce90929c5752b2e61d39566
+
 ## 0.2.1
 
 Additions

data/examples/example_setup.rb

@@ -34,7 +34,7 @@ rescue
     adapter: "mysql2",
     username: "root",
   })
-  ActiveRecord::Base.connection.execute("CREATE DATABASE `github_ds_test`")
+  ActiveRecord::Base.connection.execute("CREATE DATABASE IF NOT EXISTS `github_ds_test`")
   attempts += 1
   retry
 end

data/lib/github/ds/version.rb

@@ -1,5 +1,5 @@
 module GitHub
   module DS
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

data/lib/github/kv.rb

@@ -271,14 +271,18 @@ module GitHub
     end
 
   private
-    def validate_key(key)
-      raise TypeError, "key must be a String in #{self.class.name}, but was #{key.class}" unless key.is_a?(String)
+    def validate_key(key, error_message: nil)
+      unless key.is_a?(String)
+        raise TypeError, error_message || "key must be a String in #{self.class.name}, but was #{key.class}"
+      end
 
       validate_key_length(key)
     end
 
-    def validate_value(value)
-      raise TypeError, "value must be a String in #{self.class.name}, but was #{value.class}" unless value.is_a?(String)
+    def validate_value(value, error_message: nil)
+      unless value.is_a?(String) || value.is_a?(GitHub::SQL::Literal)
+        raise TypeError, error_message || "value must be a String in #{self.class.name} or SQL::Literal, but was #{value.class}"
+      end
 
       validate_value_length(value)
     end
@@ -299,20 +303,12 @@ module GitHub
 
     def validate_key_value_hash(kvs)
       unless kvs.is_a?(Hash)
-        raise TypeError, "kvs must be a {String => String} in #{self.class.name}, but was #{key.class}"
+        raise TypeError, "kvs must be a {String => String} in #{self.class.name}, but was #{kvs.class}"
       end
 
       kvs.each do |key, value|
-        unless key.is_a?(String)
-          raise TypeError, "kvs must be a {String => String} in #{self.class.name}, but also saw at least one key of type #{key.class}"
-        end
-
-        unless value.is_a?(String)
-          raise TypeError, "kvs must be a {String => String} in #{self.class.name}, but also saw at least one value of type #{value.class}"
-        end
-
-        validate_key_length(key)
-        validate_value_length(value)
+        validate_key(key, error_message: "kvs must be a {String => [String | SQL::Literal]} in #{self.class.name}, but also saw at least one key of type #{key.class}")
+        validate_value(value, error_message: "kvs must be a {String => [String | SQL::Literal]} in #{self.class.name}, but also saw at least one value of type #{value.class}")
       end
     end
 
@@ -323,7 +319,7 @@ module GitHub
     end
 
     def validate_value_length(value)
-      if value.length > MAX_VALUE_LENGTH
+      if value.bytesize > MAX_VALUE_LENGTH
         raise ValueLengthError, "value of length #{value.length} exceeds maximum value length of #{MAX_VALUE_LENGTH}"
       end
     end

data/lib/github/sql.rb

@@ -44,6 +44,10 @@ module GitHub
       def inspect
         "<#{self.class.name} #{value}>"
       end
+
+      def bytesize
+        value.bytesize
+      end
     end
 
     # Internal: a list of arrays of values for insertion into SQL.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github-ds
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-14 00:00:00.000000000 Z
+date: 2017-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord