git_statistics 0.3.0 → 0.4.0

data/spec/results_spec.rb

@@ -2,82 +2,111 @@ require File.dirname(__FILE__) + '/spec_helper'
 include GitStatistics
 
 describe Results do
-  email = false
-  merge = false
-  sort = "commits"
-
-  commits = Commits.new
-  commits.load(fixture("multiple_authors.json"))
-  commits.calculate_statistics(email, merge)
-
-  results = Results.new(commits)
+  let(:verbose) {false}
+  let(:limit) {100}
+  let(:fresh) {true}
+  let(:pretty) {false}
+  let(:collector) {Collector.new(verbose, limit, fresh, pretty)}
+
+  let(:commits) {collector.commits}
+
+  let(:fixture_file) {"multiple_authors.json"}
+  let(:save_file) {collector.commits_path + "0.json"}
+  let(:email) {false}
+  let(:merge) {false}
+  let(:sort) {:commits}
+  let(:top_n) {0}
+
+  let(:results) {
+    setup_commits(commits, fixture_file, save_file, pretty)
+    commits.calculate_statistics(email, merge)
+    commits.author_top_n_type(sort)
+    results = Results.new(commits)
+  }
+
+  let(:config) {
+    results.prepare_result_summary(sort, email, top_n)
+  }
 
   describe "#prepare_result_summary" do
-
     context "with email and sorting" do
-      config = results.prepare_result_summary(sort, email)
-      data = config[:data]
-
-      author_1 = "Kevin Jalbert"
-      author_2 = "John Smith"
-
-      it {data.has_key?(author_1).should be_true}
-      it {data.has_key?(author_2).should be_true}
-
-      it {data[author_1][:commits].should == 1}
-      it {data[author_1][:additions].should == 73}
-      it {data[author_1][:deletions].should == 0}
-      it {data[author_1][:create].should == 2}
-
-      it {data[author_1][:languages][:Ruby][:additions].should == 62}
-      it {data[author_1][:languages][:Ruby][:deletions].should == 0}
-      it {data[author_1][:languages][:Ruby][:create].should == 1}
-      it {data[author_1][:languages][:Markdown][:additions].should == 11}
-      it {data[author_1][:languages][:Markdown][:deletions].should == 0}
-      it {data[author_1][:languages][:Markdown][:create].should == 1}
-
-      it {data[author_2][:commits].should == 1}
-      it {data[author_2][:additions].should == 64}
-      it {data[author_2][:deletions].should == 16}
-
-      it {data[author_2][:languages][:Ruby][:additions].should == 64}
-      it {data[author_2][:languages][:Ruby][:deletions].should == 16}
+      context "on first author" do
+        let(:data) {config[:data]}
+        author = "Kevin Jalbert"
+        subject {data[author]}
+
+        it {data.has_key?(author).should be_true}
+
+        it {subject[:commits].should == 1}
+        it {subject[:additions].should == 73}
+        it {subject[:deletions].should == 0}
+        it {subject[:create].should == 2}
+
+        it {subject[:languages][:Ruby][:additions].should == 62}
+        it {subject[:languages][:Ruby][:deletions].should == 0}
+        it {subject[:languages][:Ruby][:create].should == 1}
+        it {subject[:languages][:Markdown][:additions].should == 11}
+        it {subject[:languages][:Markdown][:deletions].should == 0}
+        it {subject[:languages][:Markdown][:create].should == 1}
+      end
+
+      context "on second author" do
+        let(:data) {config[:data]}
+        author = "John Smith"
+        subject {data[author]}
+
+        it {data.has_key?(author).should be_true}
+        it {subject[:commits].should == 1}
+        it {subject[:additions].should == 64}
+        it {subject[:deletions].should == 16}
+
+        it {subject[:languages][:Ruby][:additions].should == 64}
+        it {subject[:languages][:Ruby][:deletions].should == 16}
+      end
 
       it {config[:sort].should == sort}
       it {config[:email].should == email}
-      it {config[:top_n].should == 0}
+      it {config[:top_n].should == top_n}
       it {config[:author_length].should == 17}
       it {config[:language_length].should == 8}
     end
 
     context "with negative top_n" do
-      config = results.prepare_result_summary(sort, email, -1)
-      data = config[:data]
-
-      author_1 = "Kevin Jalbert"
-      author_2 = "John Smith"
-
-      it {data.has_key?(author_1).should be_true}
-      it {data.has_key?(author_2).should be_true}
-
-      it {data[author_1][:commits].should == 1}
-      it {data[author_1][:additions].should == 73}
-      it {data[author_1][:deletions].should == 0}
-      it {data[author_1][:create].should == 2}
-
-      it {data[author_1][:languages][:Ruby][:additions].should == 62}
-      it {data[author_1][:languages][:Ruby][:deletions].should == 0}
-      it {data[author_1][:languages][:Ruby][:create].should == 1}
-      it {data[author_1][:languages][:Markdown][:additions].should == 11}
-      it {data[author_1][:languages][:Markdown][:deletions].should == 0}
-      it {data[author_1][:languages][:Markdown][:create].should == 1}
-
-      it {data[author_2][:commits].should == 1}
-      it {data[author_2][:additions].should == 64}
-      it {data[author_2][:deletions].should == 16}
-
-      it {data[author_2][:languages][:Ruby][:additions].should == 64}
-      it {data[author_2][:languages][:Ruby][:deletions].should == 16}
+      let(:top_n) {-1}
+
+      context "on first author" do
+        let(:data) {config[:data]}
+        author = "Kevin Jalbert"
+        subject {data[author]}
+
+        it {data.has_key?(author).should be_true}
+
+        it {subject[:commits].should == 1}
+        it {subject[:additions].should == 73}
+        it {subject[:deletions].should == 0}
+        it {subject[:create].should == 2}
+
+        it {subject[:languages][:Ruby][:additions].should == 62}
+        it {subject[:languages][:Ruby][:deletions].should == 0}
+        it {subject[:languages][:Ruby][:create].should == 1}
+        it {subject[:languages][:Markdown][:additions].should == 11}
+        it {subject[:languages][:Markdown][:deletions].should == 0}
+        it {subject[:languages][:Markdown][:create].should == 1}
+      end
+
+      context "on second author" do
+        let(:data) {config[:data]}
+        author = "John Smith"
+        subject {data[author]}
+
+        it {data.has_key?(author).should be_true}
+        it {subject[:commits].should == 1}
+        it {subject[:additions].should == 64}
+        it {subject[:deletions].should == 16}
+
+        it {subject[:languages][:Ruby][:additions].should == 64}
+        it {subject[:languages][:Ruby][:deletions].should == 16}
+      end
 
       it {config[:sort].should == sort}
       it {config[:email].should == email}
@@ -87,30 +116,28 @@ describe Results do
     end
 
     context "with top_n that filters to one author" do
-      config = results.prepare_result_summary(sort, email, 1)
-      data = config[:data]
-
-      author_1 = "Kevin Jalbert"
-      author_2 = "John Smith"
+      let(:top_n) {1}
+      let(:data) {config[:data]}
+      author = "Kevin Jalbert"
+      subject {data[author]}
 
-      it {data.has_key?(author_1).should be_true}
-      it {data.has_key?(author_2).should be_false}
+      it {data.has_key?(author).should be_true}
 
-      it {data[author_1][:commits].should == 1}
-      it {data[author_1][:additions].should == 73}
-      it {data[author_1][:deletions].should == 0}
-      it {data[author_1][:create].should == 2}
+      it {subject[:commits].should == 1}
+      it {subject[:additions].should == 73}
+      it {subject[:deletions].should == 0}
+      it {subject[:create].should == 2}
 
-      it {data[author_1][:languages][:Ruby][:additions].should == 62}
-      it {data[author_1][:languages][:Ruby][:deletions].should == 0}
-      it {data[author_1][:languages][:Ruby][:create].should == 1}
-      it {data[author_1][:languages][:Markdown][:additions].should == 11}
-      it {data[author_1][:languages][:Markdown][:deletions].should == 0}
-      it {data[author_1][:languages][:Markdown][:create].should == 1}
+      it {subject[:languages][:Ruby][:additions].should == 62}
+      it {subject[:languages][:Ruby][:deletions].should == 0}
+      it {subject[:languages][:Ruby][:create].should == 1}
+      it {subject[:languages][:Markdown][:additions].should == 11}
+      it {subject[:languages][:Markdown][:deletions].should == 0}
+      it {subject[:languages][:Markdown][:create].should == 1}
 
       it {config[:sort].should == sort}
       it {config[:email].should == email}
-      it {config[:top_n].should == 1}
+      it {config[:top_n].should == top_n}
       it {config[:author_length].should == 17}
       it {config[:language_length].should == 8}
     end
@@ -118,24 +145,21 @@ describe Results do
 
   describe "#print_summary" do
     context "with valid data" do
-      config = results.prepare_result_summary(sort, email)
-      language_data = results.print_summary(sort, email)
+      let(:language_data) {results.print_summary(sort, email)}
       it {language_data.should == fixture("summary_output.txt").read}
     end
   end
 
   describe "#print_language_data" do
     context "with valid data" do
-      config = results.prepare_result_summary(sort, email)
-      language_data = results.print_language_data(config[:pattern], config[:data]["Kevin Jalbert"])
+      let(:language_data) {results.print_language_data(config[:pattern], config[:data]["Kevin Jalbert"])}
       it {language_data.should == fixture("language_data_output.txt").read}
     end
   end
 
   describe "#print_header" do
     context "with valid data" do
-      config = results.prepare_result_summary(sort, email)
-      header = results.print_header(config)
+      let(:header) {results.print_header(config)}
       it {header.should == fixture("header_output.txt").read}
     end
   end

data/spec/spec_helper.rb

@@ -9,3 +9,9 @@ require File.dirname(__FILE__) + '/../lib/git_statistics/initialize.rb'
 def fixture(file)
   File.new(File.dirname(__FILE__) + '/fixtures/' + file, 'r')
 end
+
+def setup_commits(commits, file_load, file_save, pretty)
+  return if file_load == nil || file_save == nil
+  commits.load(fixture(file_load))
+  commits.save(file_save, pretty)
+end

data/spec/utilities_spec.rb

@@ -4,62 +4,67 @@ include GitStatistics
 describe Utilities do
 
   describe "#get_repository" do
+    let(:repo) {Utilities.get_repository(dir)}
+
     context "with root directory" do
-      repo = Utilities.get_repository(Dir.pwd) # git_statistics/
+      let(:dir) {Dir.pwd} # git_statistics/
       it {repo.instance_of?(Grit::Repo).should be_true}
     end
 
     context "with sub directory" do
-      repo = Utilities.get_repository(File.dirname(__FILE__))  # git_statistics/spec/
+      let(:dir) {File.dirname(__FILE__)} # git_statistics/spec/
       it {repo.instance_of?(Grit::Repo).should be_true}
     end
 
-    context "not in a repository directory" do
-      repo = Utilities.get_repository(Dir.pwd + "../")  # git_statistics/../
+    context "when not in a repository directory" do
+      let(:dir) {Dir.pwd + "../"} # git_statistics/../
       it {repo.should == nil}
     end
   end
 
   describe "#find_longest_length" do
+    let(:max) {nil}
+    let(:results) {Utilities.find_longest_length(list, max)}
+
     context "with empty list" do
-      results = Utilities.find_longest_length([])
+      let(:list) {[]}
       it {results.should == nil}
     end
 
     context "with nil list" do
-      results = Utilities.find_longest_length(nil)
+      let(:list) {nil}
       it {results.should == nil}
     end
 
     context "with preset minimum length" do
-      results = Utilities.find_longest_length([], 10)
+      let(:list) {[]}
+      let(:max) {10}
       it {results.should == 10}
     end
 
     context "with valid list" do
-      list = ["abc", "a", "ab"]
-      results = Utilities.find_longest_length(list)
+      let(:list) {["abc", "a", "ab"]}
       it {results.should == 3}
     end
 
     context "with valid hash" do
-      list = {"a" => "word_a", "ab" => "word_b", "abc" => "word_c"}
-      results = Utilities.find_longest_length(list)
+      let(:list) {{"a" => "word_a", "ab" => "word_b", "abc" => "word_c"}}
       it {results.should == 3}
     end
   end
 
   describe "#unique_data_in_hash" do
-    type = "word".to_sym
+    let(:type) {:word}
+    let(:list) {Utilities.unique_data_in_hash(data, type)}
 
     context "with valid type" do
-      data = {:entry_a => {type => "test"},
-              :entry_b => {type => "a"},
-              :entry_c => {type => "a"},
-              :entry_d => {type => "is"},
-              :entry_e => {type => "test"}}
-
-      list = Utilities.unique_data_in_hash(data, type)
+      let(:data) {
+        {:entry_a => {type => "test"},
+         :entry_b => {type => "a"},
+         :entry_c => {type => "a"},
+         :entry_d => {type => "is"},
+         :entry_e => {type => "test"}}
+      }
 
       it {list.size.should == 3}
       it {list.include?("is").should be_true}
@@ -68,102 +73,139 @@ describe Utilities do
     end
 
     context "with invalid type" do
-      data = {:entry_a => {:wrong => "test"},
-              :entry_e => {:wrong => "is"}}
-
-      list = Utilities.unique_data_in_hash(data, type)
+      let(:data) {
+        {:entry_a => {:wrong => "test"},
+         :entry_b => {:wrong => "is"}}
+      }
 
       it {list.should == [nil]}
     end
   end
 
   describe "#clean_string" do
+    let(:unclean) {"  master   "}
+    let(:clean) {Utilities.clean_string(unclean)}
+
     context "with trailling spaces" do
-      unclean = "  master   "
-      clean = Utilities.clean_string(unclean)
       it {clean.should == "master"}
     end
   end
 
   describe "#split_old_new_file" do
+    let(:files) {Utilities.split_old_new_file(old, new)}
     context "with a change in middle" do
-      old = "lib/{old_dir"
-      new = "new_dir}/file.rb"
-      files = Utilities.split_old_new_file(old, new)
-      it {files[:old_file].should == "lib/old_dir/file.rb"}
+      let(:old) {"lib/{old_dir"}
+      let(:new) {"new_dir}/file.rb"}
       it {files[:new_file].should == "lib/new_dir/file.rb"}
     end
 
     context "with a change at beginning" do
-      old = "{src/dir/lib"
-      new = "lib/dir}/file.rb"
-      files = Utilities.split_old_new_file(old, new)
+      let(:old) {"{src/dir/lib"}
+      let(:new) {"lib/dir}/file.rb"}
       it {files[:old_file].should == "src/dir/lib/file.rb"}
       it {files[:new_file].should == "lib/dir/file.rb"}
     end
 
     context "with a change at beginning, alternative" do
-      old = "src/{"
-      new = "dir}/file.rb"
-      files = Utilities.split_old_new_file(old, new)
+      let(:old) {"src/{"}
+      let(:new) {"dir}/file.rb"}
       it {files[:old_file].should == "src/file.rb"}
       it {files[:new_file].should == "src/dir/file.rb"}
     end
 
     context "with a change at ending" do
-      old = "lib/dir/{old_file.rb"
-      new = "new_file.rb}"
-      files = Utilities.split_old_new_file(old, new)
+      let(:old) {"lib/dir/{old_file.rb"}
+      let(:new) {"new_file.rb}"}
       it {files[:old_file].should == "lib/dir/old_file.rb"}
       it {files[:new_file].should == "lib/dir/new_file.rb"}
     end
 
     context "with a simple complete change" do
-      old = "file.rb"
-      new = "lib/dir/file.rb}"
-      files = Utilities.split_old_new_file(old, new)
+      let(:old) {"file.rb"}
+      let(:new) {"lib/dir/file.rb}"}
       it {files[:old_file].should == "file.rb"}
       it {files[:new_file].should == "lib/dir/file.rb"}
     end
   end
 
-  describe "find_blob_in_tree" do
-    repo = Utilities.get_repository(Dir.pwd)
-    sha = "7d6c29f0ad5860d3238debbaaf696e361bf8c541"  # Commit within repository
-    tree = repo.tree(sha)
+  describe "#find_blob_in_tree" do
+    let(:sha) {"7d6c29f0ad5860d3238debbaaf696e361bf8c541"}  # Commit within repository
+    let(:tree) {Utilities.get_repository(Dir.pwd).tree(sha)}
+    let(:file) {nil}
+    let(:blob) {Utilities.find_blob_in_tree(tree, file.split(File::Separator))}
 
     context "blob on root tree" do
-      file = "Gemfile"
-      blob = Utilities.find_blob_in_tree(tree, file.split(File::Separator))
+      let(:file) {"Gemfile"}
       it {blob.instance_of?(Grit::Blob).should be_true}
       it {blob.name.should == file}
     end
 
     context "blob down tree" do
-      file = "lib/git_statistics/collector.rb"
-      blob = Utilities.find_blob_in_tree(tree, file.split(File::Separator))
+      let(:file) {"lib/git_statistics/collector.rb"}
       it {blob.instance_of?(Grit::Blob).should be_true}
       it {blob.name.should == file.split(File::Separator).last}
     end
 
     context "file is nil" do
-      blob = Utilities.find_blob_in_tree(tree, nil)
+      let(:blob) {Utilities.find_blob_in_tree(tree, nil)}
       it {blob.should == nil}
     end
 
     context "file is empty" do
-      blob = Utilities.find_blob_in_tree(tree, [""])
+      let(:file) {""}
       it {blob.should == nil}
     end
 
     context "file is submodule" do
-      sha = "1940ef1c613a04f855d3867b874a4267d3e2c011"
-      tree = repo.tree(sha)
-      file = "Spoon-Knife"
-      blob = Utilities.find_blob_in_tree(tree, file.split(File::Separator))
+      let(:sha) {"1940ef1c613a04f855d3867b874a4267d3e2c011"}
+      let(:file) {"Spoon-Knife"}
       it {blob.instance_of?(Grit::Submodule).should be_true}
       it {blob.name.should == file}
     end
   end
 
+  describe "#get_number_of_files" do
+    let(:files) {Utilities.get_number_of_files(directory, pattern)}
+    let(:pattern) {/\d+\.json/}
+    let(:directory) {Dir.pwd + File::Separator + "tmp_dir_for_spec" + File::Separator}
+
+    before(:each) do
+      FileUtils.mkdir_p(directory)
+    end
+
+    after(:each) do
+      FileUtils.rmdir(directory)
+    end
+
+    context "with valid files" do
+      it do
+        FileUtils.touch(directory + "0.json")
+        FileUtils.touch(directory + "1.json")
+        FileUtils.touch(directory + "2.json")
+        files.should == 3
+        FileUtils.rm(directory + "0.json")
+        FileUtils.rm(directory + "1.json")
+        FileUtils.rm(directory + "2.json")
+      end
+    end
+
+    context "with invalid files" do
+      it do
+        FileUtils.touch(directory + "0.json")
+        FileUtils.touch(directory + "incorrect.json")
+        FileUtils.touch(directory + "1.json")
+        files.should == 2
+        FileUtils.rm(directory + "0.json")
+        FileUtils.rm(directory + "incorrect.json")
+        FileUtils.rm(directory + "1.json")
+      end
+    end
+
+    context "with no files" do
+      it do
+        files.should == 0
+      end
+    end
+  end
+
 end