git_reflow 0.7.4 → 0.7.5

data/spec/lib/git_server/git_hub/pull_request_spec.rb

@@ -42,6 +42,7 @@ describe GitReflow::GitServer::GitHub::PullRequest do
 
     github.class.stub(:remote_user).and_return(user)
     github.class.stub(:remote_repo_name).and_return(repo)
+    allow(GitReflow::GitServer::PullRequest).to receive(:approval_regex).and_return(/(?i-mx:lgtm|looks good to me|:\+1:|:thumbsup:|:shipit:)/)
   end
 
   describe '#initialize(options)' do
@@ -64,21 +65,43 @@ describe GitReflow::GitServer::GitHub::PullRequest do
   end
 
   describe '#comments' do
-    before do
-      FakeGitHub.new(
-        repo_owner: user,
-        repo_name: repo,
-        pull_request: {
-          number: existing_pull_request.number,
-          comments: [{author: comment_author}]
-        },
-        issue: {
-          number: existing_pull_request.number,
-          comments: [{author: comment_author}]
-        })
+    context "Testing Appending of Comments" do
+      before do
+        FakeGitHub.new(
+          repo_owner: user,
+          repo_name: repo,
+          pull_request: {
+            number: existing_pull_request.number,
+            comments: [{author: comment_author}]
+          },
+          issue: {
+            number: existing_pull_request.number,
+            comments: [{author: comment_author}]
+          })
+      end
+      specify { expect(subject.comments).to eql(existing_pull_comments.to_a + existing_issue_comments.to_a) }
     end
 
-    specify { expect(subject.comments).to eql(existing_pull_comments.to_a + existing_issue_comments.to_a) }
+    context "Testing Nil Comments" do
+      before do
+        stub_request(:get, "https://api.github.com/repos/reenhanced/repo/pulls/2/comments?access_token=a1b2c3d4e5f6g7h8i9j0").
+         with(:headers => {'Accept'=>'application/vnd.github.v3+json,application/vnd.github.beta+json;q=0.5,application/json;q=0.1', 'Accept-Charset'=>'utf-8', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Authorization'=>'token a1b2c3d4e5f6g7h8i9j0', 'User-Agent'=>'Github API Ruby Gem 0.12.4'}).
+         to_return(:status => 200, :body => "", :headers => {})
+
+        FakeGitHub.new(
+          repo_owner: user,
+          repo_name: repo,
+          pull_request: {
+            number: existing_pull_request.number,
+            comments: nil
+          },
+          issue: {
+            number: existing_pull_request.number,
+            comments: nil
+          })
+      end
+      specify { expect(subject.comments).to eql([]) }
+    end
   end
 
   describe '#reviewers' do
@@ -99,7 +122,131 @@ describe GitReflow::GitServer::GitHub::PullRequest do
         })
     end
 
-    specify { expect(subject.reviewers).to eql(['tito', 'bobby', 'randy']) }
+    specify { expect(subject.reviewers).to eq(['tito', 'bobby', 'randy']) }
+  end
+
+
+  describe "#approved?" do
+
+    context "no approvals and build success" do
+      before do
+        FakeGitHub.new(
+          repo_owner: user,
+          repo_name: repo,
+          pull_request: {
+            number: existing_pull_request.number,
+            owner: existing_pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("0")
+      end
+      specify { expect(subject.approved?).to be_truthy }
+    end
+
+    context "all commenters must approve and minimum_approvals is nil" do
+      before do
+        FakeGitHub.new(
+          repo_owner: user,
+          repo_name: repo,
+          pull_request: {
+            number: existing_pull_request.number,
+            owner: existing_pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return(nil)
+        allow(subject).to receive(:has_comments?).and_return(true)
+        allow(subject).to receive(:approvals).and_return(["Simon"])
+        allow(subject).to receive(:reviewers_pending_response).and_return([])
+      end
+      specify { expect(subject.approved?).to be_truthy }
+    end
+
+    context "all commenters must approve but we have no pending reviewers" do
+      before do
+        FakeGitHub.new(
+          repo_owner: user,
+          repo_name: repo,
+          pull_request: {
+            number: existing_pull_request.number,
+            owner: existing_pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("")
+        allow(subject).to receive(:has_comments?).and_return(true)
+        allow(subject).to receive(:approvals).and_return(["Simon"])
+        allow(subject).to receive(:reviewers_pending_response).and_return([])
+      end
+      specify { expect(subject.approved?).to be_truthy }
+    end
+
+    context "all commenters must approve but we have 1 pending reviewer" do
+      before do
+        FakeGitHub.new(
+          repo_owner: user,
+          repo_name: repo,
+          pull_request: {
+            number: existing_pull_request.number,
+            owner: existing_pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("")
+        allow(subject).to receive(:has_comments?).and_return(true)
+        allow(subject).to receive(:approvals).and_return(["Simon"])
+        allow(subject).to receive(:reviewers_pending_response).and_return(["Simon"])
+      end
+      specify { expect(subject.approved?).to be_falsy }
+    end
+
+    context "2 approvals required but we only have 1 approval" do
+      before do
+        FakeGitHub.new(
+          repo_owner: user,
+          repo_name: repo,
+          pull_request: {
+            number: existing_pull_request.number,
+            owner: existing_pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("2")
+        allow(subject).to receive(:approvals).and_return(["Simon"])
+        allow(subject).to receive(:last_comment).and_return("LGTM")
+      end
+      specify { expect(subject.approved?).to be_falsy }
+    end
+
+    context "2 approvals required and we have 2 approvals but last comment is not approval" do
+      before do
+        FakeGitHub.new(
+          repo_owner: user,
+          repo_name: repo,
+          pull_request: {
+            number: existing_pull_request.number,
+            owner: existing_pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("2")
+        allow(subject).to receive(:approvals).and_return(["Simon", "Peter"])
+        allow(subject).to receive(:last_comment).and_return("Boo")
+      end
+      specify { expect(subject.approved?).to be_falsy }
+    end
+
+    context "2 approvals required and we have 2 approvals and last comment is approval" do
+      before do
+        FakeGitHub.new(
+          repo_owner: user,
+          repo_name: repo,
+          pull_request: {
+            number: existing_pull_request.number,
+            owner: existing_pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("2")
+        allow(subject).to receive(:approvals).and_return(["Simon", "Peter"])
+        allow(subject).to receive(:last_comment).and_return("LGTM")
+      end
+      specify { expect(subject.approved?).to be_truthy }
+    end
   end
 
   describe '#approvals' do
@@ -195,9 +342,13 @@ describe GitReflow::GitServer::GitHub::PullRequest do
             owner:    existing_pull_request.head.user.login,
             comments: [{author: 'tito', body: 'lgtm'}, {author: 'ringo', body: ':+1:'}]
           })
+
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:approval_regex).and_return(/(?i-mx:lgtm|looks good to me|:\+1:|:thumbsup:|:shipit:)/)
       end
 
-      specify { expect(subject.approvals).to eq(['tito', 'ringo']) }
+      context "2 approvals" do
+        specify { expect(subject.approvals).to eq(['tito', 'ringo']) }
+      end
 
       context "but a new commit has been introduced" do
         before do

data/spec/lib/git_server/pull_request_spec.rb

@@ -4,6 +4,7 @@ describe GitReflow::GitServer::PullRequest do
   let(:pull_request) { Fixture.new('pull_requests/external_pull_request.json').to_json_hashie }
   let(:github)      { stub_github_with({ user: 'reenhanced', repo: 'repo', pull: pull_request }) }
   let!(:github_api) { github.connection }
+  let(:git_server)  { GitReflow::GitServer::GitHub.new {} }
 
   describe "#good_to_merge?(options)" do
     subject            { GitReflow::GitServer::GitHub::PullRequest.new(pull_request) }
@@ -20,9 +21,17 @@ describe GitReflow::GitServer::PullRequest do
       # setup initial valid state
       allow_any_instance_of(GitReflow::GitServer::GitHub::PullRequest).to receive(:build).and_return(Struct.new(:state, :description, :url).new)
       GitReflow.git_server.stub(:find_open_pull_request).with({from: 'new-feature', to: 'master'}).and_return(pull_request)
-    end
+      
+      # stubs approvals and last_comment conditions to default to true
+      pull_request.stub(:approvals).and_return(["Simon", "John"])
+      pull_request.stub_chain(:last_comment, :match).and_return(true)
+      allow(GitReflow::GitServer::PullRequest).to receive(:minimum_approvals).and_return("2")
+      allow(GitReflow::GitServer::PullRequest).to receive(:approval_regex).and_return(/(?i-mx:lgtm|looks good to me|:\+1:|:thumbsup:|:shipit:)/)
 
-    specify { expect(subject.good_to_merge?).to eq(true) }
+    end
+    context "with no status" do
+      specify { expect(subject.good_to_merge?).to eq(true) }
+    end
 
     context "with build status" do
       context "of 'success'" do
@@ -36,13 +45,45 @@ describe GitReflow::GitServer::PullRequest do
       end
     end
 
+    # Need at least 1 comment for you to merge
     context "with no comments" do
-      before { allow(subject).to receive(:has_comments?).and_return(false) }
+      before {
+        allow(subject).to receive(:has_comments?).and_return(false)
+        allow(subject).to receive(:build_status).and_return('success')
+        allow(subject).to receive(:approvals).and_return(["Simon", "John"])
+      }
       specify { expect(subject.good_to_merge?).to eq(true) }
       context "and no approvals" do
-        before { allow(subject).to receive(:approvals?).and_return([]) }
-        specify { expect(subject.good_to_merge?).to eq(true) }
+        before { allow(subject).to receive(:approvals).and_return([]) }
+        specify { expect(subject.good_to_merge?).to eq(false) }
+      end
+    end
+
+    context "with 1 approval" do
+      before do
+        allow(subject).to receive(:reviewers).and_return(['bob'])
+        allow(subject).to receive(:approvals).and_return(['joe'])
+      end
+      specify { expect(subject.good_to_merge?).to eq(false) }
+    end
+
+    context "with 2 approvals" do
+      before do
+        allow(subject).to receive(:reviewers).and_return(['bob'])
+        allow(subject).to receive(:approvals).and_return(['joe', 'bob'])
+        allow(subject).to receive(:last_comment).and_return('hi')
+        allow(subject).to receive(:build_status).and_return('success')
+      end
+      specify { expect(subject.good_to_merge?).to eq(false) }
+    end
+
+    context "with 2 approvals and last comment LGTM" do
+      before do
+        allow(subject).to receive(:reviewers).and_return(['bob'])
+        allow(subject).to receive(:approvals).and_return(['joe', 'bob'])
+        allow(subject).to receive(:last_comment).and_return('LGTM')
       end
+      specify { expect(subject.good_to_merge?).to eq(true) }
     end
 
     context "with comments" do
@@ -66,28 +107,286 @@ describe GitReflow::GitServer::PullRequest do
     end
   end
 
-  describe "#display_pull_request_summary" do
-    subject            { GitReflow::GitServer::GitHub::PullRequest.new(pull_request).display_pull_request_summary }
+  describe "#approved?" do
+    subject            { GitReflow::GitServer::GitHub::PullRequest.new(pull_request) }
 
-    before do
-      FakeGitHub.new(
+    context "no approvals and build success" do
+      before do
+        FakeGitHub.new(
         repo_owner:   'reenhanced',
         repo_name:    'repo',
-        pull_request: {
-          number:   pull_request.number,
-          owner:    pull_request.head.user.login,
-          comments: [{author: 'tito', body: 'lgtm'}, {author: 'ringo', body: ':+1:'}]
-        })
-      allow_any_instance_of(GitReflow::GitServer::GitHub::PullRequest).to receive(:build).and_return(Struct.new(:state, :description, :url).new)
-      GitReflow.git_server.stub(:find_open_pull_request).with({from: 'new-external-feature', to: 'master'}).and_return(pull_request)
+          pull_request: {
+            number: pull_request.number,
+            owner: pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow.git_server).to receive(:get_build_status).and_return(Struct.new(:state, :description, :target_url).new())
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("0")
+      end
+      specify { expect(subject.approved?).to be_truthy }
+    end
+
+    context "all commenters must approve and minimum_approvals is nil" do
+      before do
+        FakeGitHub.new(
+        repo_owner:   'reenhanced',
+        repo_name:    'repo',
+          pull_request: {
+            number: pull_request.number,
+            owner: pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow.git_server).to receive(:get_build_status).and_return(Struct.new(:state, :description, :target_url).new())
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return(nil)
+        allow(subject).to receive(:approvals).and_return(["Simon"])
+        allow(subject).to receive(:has_comments?).and_return(true)
+        allow(subject).to receive(:reviewers_pending_response).and_return([])
+      end
+      specify { expect(subject.approved?).to be_truthy }
+    end
+
+    context "all commenters must approve but we have no pending reviewers" do
+      before do
+        FakeGitHub.new(
+          repo_owner:   'reenhanced',
+          repo_name:    'repo',
+          pull_request: {
+            number: pull_request.number,
+            owner: pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow.git_server).to receive(:get_build_status).and_return(Struct.new(:state, :description, :target_url).new())
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("")
+        allow(subject).to receive(:has_comments?).and_return(true)
+        allow(subject).to receive(:approvals).and_return(["Simon"])
+        allow(subject).to receive(:reviewers_pending_response).and_return([])
+      end
+      specify { expect(subject.approved?).to be_truthy }
+    end
+
+    context "all commenters must approve but we have 1 pending reviewer" do
+      before do
+        FakeGitHub.new(
+          repo_owner:   'reenhanced',
+          repo_name:    'repo',
+          pull_request: {
+            number: pull_request.number,
+            owner: pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow.git_server).to receive(:get_build_status).and_return(Struct.new(:state, :description, :target_url).new())
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("")
+        allow(subject).to receive(:has_comments?).and_return(true)
+        allow(subject).to receive(:approvals).and_return(["Simon"])
+        allow(subject).to receive(:reviewers_pending_response).and_return(["Simon"])
+      end
+      specify { expect(subject.approved?).to be_falsy }
+    end
+
+    context "2 approvals required but we only have 1 approval" do
+      before do
+        FakeGitHub.new(
+          repo_owner:   'reenhanced',
+          repo_name:    'repo',
+          pull_request: {
+            number: pull_request.number,
+            owner: pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow.git_server).to receive(:get_build_status).and_return(Struct.new(:state, :description, :target_url).new())
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("2")
+        allow(subject).to receive(:approvals).and_return(["Simon"])
+        allow(subject).to receive(:last_comment).and_return("LGTM")
+      end
+      specify { expect(subject.approved?).to be_falsy }
+    end
+
+    context "2 approvals required and we have 2 approvals but last comment is not approval" do
+      before do
+        FakeGitHub.new(
+          repo_owner:   'reenhanced',
+          repo_name:    'repo',
+          pull_request: {
+            number: pull_request.number,
+            owner: pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow.git_server).to receive(:get_build_status).and_return(Struct.new(:state, :description, :target_url).new())
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("2")
+        allow(subject).to receive(:approvals).and_return(["Simon", "Peter"])
+        allow(subject).to receive(:last_comment).and_return("Boo")
+      end
+      specify { expect(subject.approved?).to be_falsy }
+    end
+
+    context "2 approvals required and we have 2 approvals and last comment is approval" do
+      before do
+        FakeGitHub.new(
+          repo_owner:   'reenhanced',
+          repo_name:    'repo',
+          pull_request: {
+            number: pull_request.number,
+            owner: pull_request.head.user.login,
+            comments: []
+          })
+        allow(GitReflow.git_server).to receive(:get_build_status).and_return(Struct.new(:state, :description, :target_url).new())
+        allow(GitReflow::GitServer::GitHub::PullRequest).to receive(:minimum_approvals).and_return("2")
+        allow(subject).to receive(:approvals).and_return(["Simon", "Peter"])
+        allow(subject).to receive(:last_comment).and_return("LGTM")
+      end
+      specify { expect(subject.approved?).to be_truthy }
     end
+  end
+
+  describe "#rejection_message" do
+    subject            { GitReflow::GitServer::GitHub::PullRequest.new(pull_request) }
+
+    before do
+      allow(GitReflow.git_server).to receive(:get_build_status).and_return(Struct.new(:state, :description, :target_url).new())
+    end
+
+    context "Testing a Failure Build Status" do
+      before do
+        allow(subject).to receive(:build_status).and_return('failure')
+      end
+
+      specify { subject.rejection_message.should eq(": ") }
+    end
+
+    context "Testing Minimum Approvals Failure" do
+      before do
+        allow(subject).to receive(:build_status).and_return('success')
+        allow(subject).to receive(:approval_minimums_reached?).and_return(false)
+        allow(GitReflow::GitServer::PullRequest).to receive(:minimum_approvals).and_return("2")
+      end
+      specify { subject.rejection_message.should eq("You need approval from at least 2 users!") }
+    end
+
+    context "Testing Minimum Approvals Reached" do
+      before do
+        allow(subject).to receive(:build_status).and_return(nil)
+        allow(subject).to receive(:all_comments_addressed?).and_return(false)
+        allow(subject).to receive(:last_comment).and_return("Hello")
+      end
+      specify { subject.rejection_message.should eq("The last comment is holding up approval:\nHello") }
+    end
+
+    context "Testing All Comments Addressed" do
+      before do
+        allow(subject).to receive(:build_status).and_return('success')
+        allow(subject).to receive(:all_comments_addressed?).and_return(false)
+        allow(subject).to receive(:last_comment).and_return("Hello")
+      end
+      specify { subject.rejection_message.should eq("The last comment is holding up approval:\nHello") }
+    end
+
+    context "Testing All Comments Addressed" do
+      before do
+        allow(subject).to receive(:reviewers_pending_response).and_return(['Simon'])
+        allow(subject).to receive(:build?).and_return('success')
+        allow(subject).to receive(:all_comments_addressed?).and_return(true)
+        allow(subject).to receive(:approval_minimums_reached?).and_return(true)
+      end
+      specify { subject.rejection_message.should eq( "You still need a LGTM from: Simon") }
+    end
+
+    context "Testing Last Case" do
+      before do
+        allow(subject).to receive(:reviewers_pending_response).and_return([])
+        allow(subject).to receive(:build?).and_return('success')
+        allow(subject).to receive(:all_comments_addressed?).and_return(true)
+        allow(subject).to receive(:approval_minimums_reached?).and_return(true)
+      end
+      specify { subject.rejection_message.should eq("Your code has not been reviewed yet.") }
+    end
+  end
 
-    it "displays relavent information about the pull request" do
-      expect{ subject }.to have_output("branches: new-external-feature -> reenhanced:master")
-      expect{ subject }.to have_output("number: #{pull_request.number}")
-      expect{ subject }.to have_output("url: #{pull_request.html_url}")
-      expect{ subject }.to have_output("reviewed by: #{"tito".colorize(:green)}, #{"ringo".colorize(:green)}")
-      expect{ subject }.to have_output("Last comment: \":+1:\"")
+  describe "#all_comments_addressed" do
+    subject            { GitReflow::GitServer::GitHub::PullRequest.new(pull_request) }
+
+    before do
+      allow(GitReflow.git_server).to receive(:get_build_status).and_return(Struct.new(:state, :description, :target_url).new())
+    end
+
+    context "Testing a Failure Case" do
+      before do
+        allow(subject).to receive(:minimum_approvals).and_return('2')
+        allow(subject).to receive(:approvals).and_return(['Simon'])
+      end
+      specify { subject.approval_minimums_reached?.should eq(true) }
+    end
+
+    context "Testing a Success Case" do
+      before do
+        allow(subject).to receive(:minimum_approvals).and_return('2')
+        allow(subject).to receive(:approvals).and_return(['Simon', 'John'])
+      end
+      specify { subject.approval_minimums_reached?.should eq(true) }
+    end
+
+    context "Testing Case with no minimum_approval" do
+      before do
+        allow(subject).to receive(:minimum_approvals).and_return('')
+        allow(subject).to receive(:approvals).and_return([])
+      end
+      specify { subject.approval_minimums_reached?.should eq(true) }
+    end
+  end
+
+  describe "#display_pull_request_summary" do
+    subject            { GitReflow::GitServer::GitHub::PullRequest.new(pull_request).display_pull_request_summary }
+
+    context "Testing Pull Request Properties" do
+      before do
+        FakeGitHub.new(
+          repo_owner:   'reenhanced',
+          repo_name:    'repo',
+          pull_request: {
+            number:   pull_request.number,
+            owner:    pull_request.head.user.login,
+            comments: [{author: 'tito', body: 'lgtm'}, {author: 'ringo', body: ':+1:'}]
+          })
+        allow_any_instance_of(GitReflow::GitServer::GitHub::PullRequest).to receive(:build).and_return(Struct.new(:state, :description, :url).new)
+        GitReflow.git_server.stub(:find_open_pull_request).with({from: 'new-external-feature', to: 'master'}).and_return(pull_request)
+      end
+
+      it "displays relavent information about the pull request" do
+        expect{ subject }.to have_output("branches: new-external-feature -> reenhanced:master")
+        expect{ subject }.to have_output("number: #{pull_request.number}")
+        expect{ subject }.to have_output("url: #{pull_request.html_url}")
+        expect{ subject }.to have_output("reviewed by: #{"tito".colorize(:green)}, #{"ringo".colorize(:green)}")
+        expect{ subject }.to have_output("Last comment: \":+1:\"")
+      end
+    end
+
+    context "Testing Different LGTM Regex Expressions " do
+      before do
+        FakeGitHub.new(
+          repo_owner:   'reenhanced',
+          repo_name:    'repo',
+          pull_request: {
+            number:   pull_request.number,
+            owner:    pull_request.head.user.login,
+            comments: [
+              {author: 'tito', body: 'lgtm'}, 
+              {author: 'ringo', body: ':+1:'}, 
+              {author: 'Simon', body: ':shipit:'}, 
+              {author: 'Peter', body: 'looks good to me'},
+              {author: 'Johnny', body: 'LgTm'},
+              {author: 'Jacob', body: 'LOOKS GOOD TO ME'}
+            ]
+          })
+        allow_any_instance_of(GitReflow::GitServer::GitHub::PullRequest).to receive(:build).and_return(Struct.new(:state, :description, :url).new)
+        GitReflow.git_server.stub(:find_open_pull_request).with({from: 'new-external-feature', to: 'master'}).and_return(pull_request)
+      end
+
+      it "displays relavent information about the pull request" do
+        expect{ subject }.to have_output("branches: new-external-feature -> reenhanced:master")
+        expect{ subject }.to have_output("number: #{pull_request.number}")
+        expect{ subject }.to have_output("url: #{pull_request.html_url}")
+        expect{ subject }.to have_output("reviewed by: #{"tito".colorize(:green)}, #{"ringo".colorize(:green)}, #{"Simon".colorize(:green)}, #{"Peter".colorize(:green)}, #{"Johnny".colorize(:green)}, #{"Jacob".colorize(:green)}")
+        expect{ subject }.to have_output("Last comment: \"LOOKS GOOD TO ME\"")
+      end
     end
   end
 end