git_reflow 0.6.7 → 0.7.0

data/spec/lib/git_server/git_hub_spec.rb

@@ -12,8 +12,8 @@ describe GitReflow::GitServer::GitHub do
   let(:enterprise_api)         { 'https://github.gittyup.com/api/v3' }
   let(:github)                 { stub_github_with(pull: existing_pull_request) }
   let!(:github_api)            { github.connection }
-  let(:existing_pull_request)  { Hashie::Mash.new JSON.parse(fixture('pull_requests/pull_request.json').read) }
-  let(:existing_pull_requests) { JSON.parse(fixture('pull_requests/pull_requests.json').read).collect {|pull| Hashie::Mash.new pull } }
+  let(:existing_pull_request)  { Fixture.new('pull_requests/pull_request.json').to_json_hashie }
+  let(:existing_pull_requests) { Fixture.new('pull_requests/pull_requests.json').to_json_hashie }
 
   before do
     HighLine.any_instance.stub(:ask) do |terminal, question|
@@ -38,7 +38,7 @@ describe GitReflow::GitServer::GitHub do
     it 'sets the reflow git server provider to GitHub in the git config' do
       GitReflow::Config.should_receive(:set).once.with('github.site', github_site, local: false)
       GitReflow::Config.should_receive(:set).once.with('github.endpoint', github_api_endpoint, local: false)
-      GitReflow::Config.should_receive(:set).once.with('reflow.git-server', 'GitHub')
+      GitReflow::Config.should_receive(:set).once.with('reflow.git-server', 'GitHub', local: false)
       subject
     end
 
@@ -48,7 +48,7 @@ describe GitReflow::GitServer::GitHub do
       it 'sets the enterprise site and api as the site and api endpoints for the GitHub provider in the git config' do
         GitReflow::Config.should_receive(:set).once.with('github.site', enterprise_site, local: false)
         GitReflow::Config.should_receive(:set).once.with('github.endpoint', enterprise_api, local: false)
-        GitReflow::Config.should_receive(:set).once.with('reflow.git-server', 'GitHub')
+        GitReflow::Config.should_receive(:set).once.with('reflow.git-server', 'GitHub', local: false)
         subject
       end
 
@@ -167,12 +167,21 @@ describe GitReflow::GitServer::GitHub do
     let(:body)           { 'Funky body' }
     let(:current_branch) { 'new-feature' }
 
-    before { github.class.stub(:current_branch).and_return(current_branch) }
+    subject { github.create_pull_request({ title: title, body: body, base: 'master' }) }
+
+    before do
+      github.class.stub(:current_branch).and_return(current_branch)
+      allow(GitReflow).to receive(:git_server).and_return(github)
+      stub_request(:post, %r{/repos/#{user}/#{repo}/pulls}).
+        to_return(body: Fixture.new('pull_requests/pull_request.json').to_s, status: 201, headers: {content_type: "application/json; charset=utf-8"})
+    end
+
+    specify { expect(subject.class.to_s).to eq('GitReflow::GitServer::GitHub::PullRequest') }
 
     it 'creates a pull request using the remote user and repo' do
       github_api.stub(:pull_requests)
-      github_api.pull_requests.should_receive(:create).with(user, repo, title: title, body: body, head: "#{user}:#{current_branch}", base: 'master')
-      github.create_pull_request({ title: title, body: body, base: 'master' })
+      expect(github_api.pull_requests).to receive(:create).with(user, repo, title: title, body: body, head: "#{user}:#{current_branch}", base: 'master').and_return(existing_pull_request)
+      subject
     end
   end
 
@@ -192,23 +201,6 @@ describe GitReflow::GitServer::GitHub do
     end
   end
 
-  describe '#pull_request_comments(pull_request)' do
-    let(:pull_request_comments) { JSON.parse(fixture('pull_requests/comments.json').read).collect {|c| Hashie::Mash.new(c) } }
-
-    subject { github.pull_request_comments(existing_pull_request) }
-
-    before do
-      github_api.stub_chain(:issues, :comments)
-      github_api.stub_chain(:pull_requests, :comments)
-    end
-
-    it 'includes both issue comments and pull request comments' do
-      github_api.issues.comments.should_receive(:all).with(user, repo, number: existing_pull_request.number).and_return([pull_request_comments.first])
-      github_api.pull_requests.comments.should_receive(:all).with(user, repo, number: existing_pull_request.number).and_return([pull_request_comments.first])
-      subject.count.should == 2
-    end
-  end
-
   describe '#get_build_status(sha)' do
     let(:sha) { '6dcb09b5b57875f334f61aebed695e2e4193db5e' }
     subject   { github.get_build_status(sha) }
@@ -223,7 +215,7 @@ describe GitReflow::GitServer::GitHub do
   describe '#comment_authors_for_pull_request(pull_request, options = {})' do
   end
 
-  describe '#get_commited_time(commit_sha)' do
+  describe '#get_committed_time(commit_sha)' do
   end
 
 end

data/spec/lib/git_server/pull_request_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+describe GitReflow::GitServer::PullRequest do
+  let(:pull_request) { Fixture.new('pull_requests/external_pull_request.json').to_json_hashie }
+  let(:github)      { stub_github_with({ user: 'reenhanced', repo: 'repo', pull: pull_request }) }
+  let!(:github_api) { github.connection }
+
+  describe "#good_to_merge?(options)" do
+    subject            { GitReflow::GitServer::GitHub::PullRequest.new(pull_request) }
+
+    before do
+      FakeGitHub.new(
+        repo_owner:   'reenhanced',
+        repo_name:    'repo',
+        pull_request: {
+          number:   pull_request.number,
+          owner:    pull_request.head.user.login,
+          comments: [{author: 'tito', body: 'lgtm'}, {author: 'ringo', body: ':+1:'}]
+        })
+      # setup initial valid state
+      allow_any_instance_of(GitReflow::GitServer::GitHub::PullRequest).to receive(:build).and_return(Struct.new(:state, :description, :url).new)
+      GitReflow.git_server.stub(:find_open_pull_request).with({from: 'new-feature', to: 'master'}).and_return(pull_request)
+    end
+
+    specify { expect(subject.good_to_merge?).to eq(true) }
+
+    context "with build status" do
+      context "of 'success'" do
+        before  { allow(subject).to receive(:build_status).and_return('success') }
+        specify { expect(subject.good_to_merge?).to eq(true) }
+      end
+
+      context "NOT of 'success'" do
+        before { allow(subject).to receive(:build_status).and_return('failure') }
+        specify { expect(subject.good_to_merge?).to eq(false) }
+      end
+    end
+
+    context "with no comments" do
+      before { allow(subject).to receive(:has_comments?).and_return(false) }
+      specify { expect(subject.good_to_merge?).to eq(true) }
+      context "and no approvals" do
+        before { allow(subject).to receive(:approvals?).and_return([]) }
+        specify { expect(subject.good_to_merge?).to eq(true) }
+      end
+    end
+
+    context "with comments" do
+      before do
+        allow(subject).to receive(:reviewers).and_return(['bob'])
+        allow(subject).to receive(:approvals).and_return([])
+      end
+      specify { expect(subject.good_to_merge?).to eq(false) }
+    end
+
+    context "force merge?" do
+      context "with pending comments" do
+        before { allow(subject).to receive(:approvals).and_return([]) }
+        specify { expect(subject.good_to_merge?(force: true)).to eq(true) }
+      end
+
+      context "with build failure" do
+        before { allow(subject).to receive(:build_status).and_return('failure') }
+        specify { expect(subject.good_to_merge?(force: true)).to eq(true) }
+      end
+    end
+  end
+
+  describe "#display_pull_request_summary" do
+    subject            { GitReflow::GitServer::GitHub::PullRequest.new(pull_request).display_pull_request_summary }
+
+    before do
+      FakeGitHub.new(
+        repo_owner:   'reenhanced',
+        repo_name:    'repo',
+        pull_request: {
+          number:   pull_request.number,
+          owner:    pull_request.head.user.login,
+          comments: [{author: 'tito', body: 'lgtm'}, {author: 'ringo', body: ':+1:'}]
+        })
+      allow_any_instance_of(GitReflow::GitServer::GitHub::PullRequest).to receive(:build).and_return(Struct.new(:state, :description, :url).new)
+      GitReflow.git_server.stub(:find_open_pull_request).with({from: 'new-external-feature', to: 'master'}).and_return(pull_request)
+    end
+
+    it "displays relavent information about the pull request" do
+      expect{ subject }.to have_output("branches: new-external-feature -> reenhanced:master")
+      expect{ subject }.to have_output("number: #{pull_request.number}")
+      expect{ subject }.to have_output("url: #{pull_request.html_url}")
+      expect{ subject }.to have_output("reviewed by: #{"tito".colorize(:green)}, #{"ringo".colorize(:green)}")
+      expect{ subject }.to have_output("Last comment: \":+1:\"")
+    end
+  end
+end

data/spec/support/command_line_helpers.rb

@@ -12,6 +12,11 @@ module CommandLineHelpers
       $output << output
       output = ''
     end
+
+    allow_any_instance_of(GitReflow::GitServer::PullRequest).to receive(:printf) do |format, *output|
+      $output << Array(output).join(" ")
+      output = ''
+    end.and_return("")
   end
 
   def stub_run_for(module_to_stub)
@@ -30,12 +35,22 @@ module CommandLineHelpers
   def reset_stubbed_command_line
     $commands_ran = []
     $stubbed_commands = {}
+    $output = []
+    $says = []
   end
 
   def stub_command(command, return_value)
     $stubbed_commands[command] = return_value
     GitReflow::Sandbox.stub(:run).with(command).and_return(return_value)
   end
+
+  def stub_command_line_inputs(inputs)
+    HighLine.any_instance.stub(:ask) do |terminal, question|
+     return_value = inputs[question]
+     question = ""
+     return_value
+    end
+  end
 end
 
 RSpec::Matchers.define :have_run_command do |command|
@@ -109,7 +124,7 @@ end
 RSpec::Matchers.define :have_output do |expected_output|
   match do |block|
     block.call
-    $output.include? expected_output
+    $output.join("\n").include? expected_output
   end
 
   supports_block_expectations

data/spec/support/fake_github.rb

@@ -0,0 +1,128 @@
+require 'rspec/mocks'
+require 'webmock'
+require 'chronic'
+
+class FakeGitHub
+  include WebMock::API
+
+  attr_accessor :repo_owner, :repo_name
+
+  DEFAULT_COMMIT_AUTHOR = "reenhanced".freeze
+  DEFAULT_COMMIT_TIME   = "1 minute ago".freeze
+
+  # EXAMPLE:
+  #
+  #   FakeGitHub.new(repo_owner: user, repo_name: repo,
+  #     pull_request: {
+  #       number: existing_pull_request.number,
+  #       comments: [{author: comment_author}]
+  #     },
+  #     issue: {
+  #       comments: [{author: comment_author}]
+  #     })
+  #
+  def initialize(repo_owner: nil, repo_name: nil, pull_request: {}, issue: {}, commits: [])
+    raise "FakeGitHub#new: repo_owner AND repo_name keywords are required" unless repo_owner and repo_name
+
+    self.repo_owner = repo_owner
+    self.repo_name  = repo_name
+
+    stub_github_request(:pull_request, pull_request) if pull_request
+    stub_github_request(:issue, issue) if issue
+    stub_github_request(:commits, commits) if commits.any?
+
+    if pull_request and (issue.none? or !issue[:comments])
+      stub_github_request(:issue, pull_request.merge({comments: []}))
+    end
+
+    if pull_request and commits.none?
+      stub_github_request(:commits, [{
+        author:              pull_request[:owner] || DEFAULT_COMMIT_AUTHOR,
+        created_at:          Chronic.parse(DEFAULT_COMMIT_TIME)
+      }])
+    end
+
+    self
+  end
+
+  def stub_github_request(object_to_stub, object_data)
+    case object_to_stub
+    when :commits
+      commits_response = Fixture.new('repositories/commits.json.erb',
+                            repo_owner:          repo_owner,
+                            repo_name:           repo_name,
+                            commits:             object_data)
+      commits_response.to_json_hashie.each_with_index do |commit, index|
+        stub_request(:get, %r{/repos/#{self.repo_owner}/(#{self.repo_name}/)?commits/#{commit.sha}\?}).
+          to_return(
+            body: commit.to_json.to_s,
+            status: 201,
+            headers: {content_type: "application/json; charset=utf-8"})
+      stub_request(:get, %r{/repos/#{self.repo_owner}/commits\Z}).
+        to_return(
+          body: commits_response.to_s,
+          status: 201,
+          headers: {content_type: "application/json; charset=utf-8"})
+      end
+    when :issue
+      # Stubbing issue comments
+      if object_data[:comments]
+        stub_request(:get, %r{/repos/#{self.repo_owner}/(#{self.repo_name}/)?issues/#{object_data[:number] || 1}/comments}).
+          with(query: {'access_token' => 'a1b2c3d4e5f6g7h8i9j0'}).
+          to_return(body: Fixture.new('issues/comments.json.erb',
+                                         repo_owner:          self.repo_owner,
+                                         repo_name:           self.repo_name,
+                                         comments:            object_data[:comments],
+                                         pull_request_number: object_data[:number] || 1,
+                                         body:                object_data[:body] || 'Hammer time',
+                                         created_at:          object_data[:created_at] || Chronic.parse("1.minute ago")).to_s,
+                    status: 201,
+                    headers: {content_type: "application/json; charset=utf-8"})
+      else
+        stub_request(:get, %r{/repos/#{self.repo_owner}/(#{self.repo_name}/)?issues/#{object_data[:number] || 1}/comments}).
+          with(query: {'access_token' => 'a1b2c3d4e5f6g7h8i9j0'}).
+          to_return(body: '[]', status: 201, headers: {content_type: "application/json; charset=utf-8"})
+      end
+    when :pull_request
+      # EXAMPLES
+      stubbed_pull_request_response = Fixture.new('pull_requests/pull_request.json.erb',
+                                                  number:             object_data[:number] || 1,
+                                                  title:              object_data[:title] || 'Please merge these changes',
+                                                  body:               object_data[:body] || 'Bone saw is ready.',
+                                                  state:              object_data[:state] || 'open',
+                                                  owner:              object_data[:owner] || 'octocat',
+                                                  feature_repo_owner: object_data[:feature_repo_owner] || self.repo_owner,
+                                                  feature_branch:     object_data[:feature_branch] || 'new-feature',
+                                                  base_branch:        object_data[:base_branch] || 'master',
+                                                  repo_owner:         self.repo_owner,
+                                                  repo_name:          self.repo_name)
+
+      stub_request(:get, "#{GitReflow::GitServer::GitHub.api_endpoint}/repos/#{self.repo_owner}/#{self.repo_name}/pulls/#{object_data[:number]}").
+        with(query: {'access_token' => 'a1b2c3d4e5f6g7h8i9j0'}).
+        to_return(body: stubbed_pull_request_response.to_s, status: 201, headers: {content_type: "application/json; charset=utf-8"})
+      stub_request(:get, "#{GitReflow::GitServer::GitHub.api_endpoint}/repos/#{self.repo_owner}/#{self.repo_name}/pulls")
+        .with(:query => {'access_token' => 'a1b2c3d4e5f6g7h8i9j0', 'base' => object_data[:base_branch] || 'master', 'head' => "#{object_data[:feature_repo_owner] || self.repo_owner}:#{object_data[:feature_branch] || "new-feature"}", 'state' => object_data[:state] || 'open'}).
+        to_return(:body => "[#{stubbed_pull_request_response.to_s}]", :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+
+      # Stubbing pull request comments
+      if object_data[:comments]
+        stub_request(:get, %r{/repos/#{self.repo_owner}/(#{self.repo_name}/)?pulls/#{object_data[:number] || 1}/comments}).
+          with(query: {'access_token' => 'a1b2c3d4e5f6g7h8i9j0'}).
+          to_return(body: Fixture.new('pull_requests/comments.json.erb',
+                                      repo_owner:          self.repo_owner,
+                                      repo_name:           self.repo_name,
+                                      comments:            object_data[:comments],
+                                      pull_request_number: object_data[:number] || 1,
+                                      created_at:          object_data[:created_at] || Time.now).to_s,
+                    status: 201,
+                    headers: {content_type: "application/json; charset=utf-8"})
+      end
+
+      # Stubbing pull request commits
+      #stub_get(%r{#{GitReflow::GitServer::GitHub.api_endpoint}/repos/#{user}/#{repo}/pulls/#{existing_pull_request.number}/commits}).
+      #  with(query: {"access_token" => "a1b2c3d4e5f6g7h8i9j0"}).
+      #  to_return(:body => Fixture.new("pull_requests/commits.json").to_s, status: 201, headers: {content_type: "application/json; charset=utf-8"})
+    end
+  end
+end
+

data/spec/support/fixtures.rb

@@ -1,8 +1,54 @@
-def fixture_path
-  File.expand_path("../../fixtures", __FILE__)
-end
+# ERB parsing credit:
+# http://stackoverflow.com/questions/8954706/render-an-erb-template-with-values-from-a-hash/9734736#9734736
 
-def fixture(file)
-  File.new(File.join(fixture_path, '/', file))
-end
+require 'erb'
+require 'ostruct'
+
+class Fixture
+  attr_accessor :file, :locals
+
+  def initialize(file, locals = {})
+    @file   = fixture(file)
+    @locals = locals
+  end
+
+  def fixture_path
+    File.expand_path("../../fixtures", __FILE__)
+  end
+
+  def fixture(file)
+    File.new(File.join(fixture_path, "/", file))
+  end
 
+  def to_s
+    if File.extname(file) == ".erb"
+      ERB.new(template_file_content).result(OpenStruct.new(locals).instance_eval { binding }).to_s
+    else
+      template_file_content.to_s
+    end
+  end
+
+  def to_json
+    if File.extname(file) == ".erb"
+      rendered_file = ERB.new(template_file_content).result(OpenStruct.new(locals).instance_eval { binding })
+      JSON.parse(rendered_file)
+    else
+      JSON.parse(template_file_content)
+    end
+  end
+
+  def to_json_hashie
+    json = self.to_json
+    if json.is_a? Array
+      json.map {|json_object| Hashie::Mash.new json_object }
+    else
+      Hashie::Mash.new json
+    end
+  end
+
+  private
+
+  def template_file_content
+    @file_content ||= file.read
+  end
+end

data/spec/support/github_helpers.rb

@@ -1,8 +1,7 @@
 $LOAD_PATH << 'lib'
 require 'git_reflow'
 require 'github_api'
-require File.expand_path('../web_mocks', __FILE__)
-require File.expand_path('../fixtures', __FILE__)
+require 'spec_helper'
 
 module GithubHelpers
   def stub_github_with(options = {})
@@ -56,15 +55,15 @@ module GithubHelpers
     github_server.class.stub(:remote_user).and_return(user)
     github_server.class.stub(:remote_repo).and_return(repo)
     github_server.class.stub(:oauth_token).and_return(oauth_token_hash.token)
-    github_server.class.stub(:get_commited_time).and_return(Time.now)
+    github_server.class.stub(:get_committed_time).and_return(Time.now)
 
     GitReflow.stub(:git_server).and_return(github_server)
 
     # Stubbing statuses for a given commit
-    stub_request(:get, %r{#{GitReflow.git_server.class.api_endpoint}/repos/#{user}/commits/\w+}).
-      to_return(:body => fixture('repositories/commit.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
-    stub_request(:get, %r{#{GitReflow.git_server.class.api_endpoint}/repos/#{user}/commits/\w+/statuses?}).
-      to_return(:body => fixture('pull_requests/pull_requests.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+    #stub_request(:get, %r{#{GitReflow.git_server.class.api_endpoint}/repos/#{user}/commits/\w+}).
+    #  to_return(:body => Fixture.new('repositories/commit.json.erb', repo_owner: user, repo_name: repo, author: user).to_json.to_s, :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+    stub_request(:get, %r{/repos/#{user}/(#{repo}/)?commits/\w+/statuses}).
+      to_return(:body => Fixture.new('repositories/statuses.json').to_s, :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
 
     if pull
       # Stubbing review
@@ -72,22 +71,33 @@ module GithubHelpers
         to_return(:body => pull.to_s, :status => 201, :headers => {:content_type => "application/json\; charset=utf-8"})
 
       # Stubbing pull request finder
+      stub_get("/repos/#{user}/#{repo}/pulls/#{pull.number}").with(:query => {'access_token' => 'a1b2c3d4e5f6g7h8i9j0'}).
+        to_return(:body => Fixture.new('pull_requests/pull_request.json').to_s, :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
       stub_get("/repos/#{user}/pulls").with(:query => {'access_token' => 'a1b2c3d4e5f6g7h8i9j0', 'base' => 'master', 'head' => "#{user}:#{branch}", 'state' => 'open'}).
-        to_return(:body => fixture('pull_requests/pull_requests.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+        to_return(:body => Fixture.new('pull_requests/pull_requests.json').to_s, :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
       stub_get("/repos/#{user}/#{repo}/pulls").with(:query => {'access_token' => 'a1b2c3d4e5f6g7h8i9j0', 'base' => 'master', 'head' => "#{user}:#{branch}", 'state' => 'open'}).
-        to_return(:body => fixture('pull_requests/pull_requests.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+        to_return(:body => Fixture.new('pull_requests/pull_requests.json').to_s, :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
       # Stubbing pull request comments
+      stub_get("/repos/#{user}/#{repo}/pulls/#{pull.number}/comments?").with(:query => {'access_token' => 'a1b2c3d4e5f6g7h8i9j0'}).
+        to_return(:body => Fixture.new('pull_requests/comments.json.erb', repo_owner: user, repo_name: repo, comments: [{author: user}], pull_request_number: pull.number).to_json.to_s, :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
       stub_get("/repos/#{user}/pulls/#{pull.number}/comments?").with(:query => {'access_token' => 'a1b2c3d4e5f6g7h8i9j0'}).
-        to_return(:body => fixture('pull_requests/comments.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+        to_return(:body => Fixture.new('pull_requests/comments.json.erb', repo_owner: user, repo_name: repo, comments: [{author: user}], pull_request_number: pull.number).to_s, :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
       # Stubbing issue comments
       stub_get("/repos/#{user}/issues/#{pull.number}/comments?").with(:query => {'access_token' => 'a1b2c3d4e5f6g7h8i9j0'}).
-        to_return(:body => fixture('issues/comments.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+        to_return(:body => Fixture.new('issues/comments.json.erb', repo_owner: user, repo_name: repo, comments: [{author: user}], pull_request_number: pull.number).to_s, :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+      stub_get("/repos/#{user}/#{repo}/issues/#{pull.number}/comments?").with(:query => {'access_token' => 'a1b2c3d4e5f6g7h8i9j0'}).
+        to_return(:body => Fixture.new('issues/comments.json.erb', repo_owner: user, repo_name: repo, comments: [{author: user}], pull_request_number: pull.number).to_json.to_s, :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+      # Stubbing pull request commits
+      stub_get("/repos/#{user}/#{repo}/pulls/#{pull.number}/commits").with(query: {"access_token" => "a1b2c3d4e5f6g7h8i9j0"}).
+        to_return(:body => Fixture.new("pull_requests/commits.json").to_s, status: 201, headers: {content_type: "application/json; charset=utf-8"})
+      stub_request(:get, %r{/repos/#{user}/commits/\w+}).with(query: {"access_token" => "a1b2c3d4e5f6g7h8i9j0"}).
+        to_return(:body => Fixture.new("repositories/commit.json").to_s, status: 201, headers: {content_type: "application/json; charset=utf-8"})
     end
 
     github_server
   end
 end
-
+#
 # the github_api gem does some overrides to Hash so we have to make sure
 # this still works here...
 class Hash