git_ownership_insights 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b993d413af1897253069cfd6ef12e1ba1b91228d7b72753d08e3a104e8df172b
-  data.tar.gz: b9ac3f82ee048d2501541672185f36333820c14cbd0da2ae6bd733509bb307d9
+  metadata.gz: eb151470ef24ed0e040026ced3fb187e7cc02012ba0564dd062be4611b8219a8
+  data.tar.gz: 64b844eebef335350f0fa9fa939c0d338910b5a711652a8c9ba926a7caec3456
 SHA512:
-  metadata.gz: 82bc549f312667ca1e3771e9b7fd0427d7ad7950b0981592ae5954bd8860717dff78540d82caee64a5c82b5460ce4b39f6627a89675bb729b95276c2e1625568
-  data.tar.gz: 5849484323479c350f1cead67c3ea38673ff51dc386b7e6e48f716ef401c64e66ae1e56fefe7223b59c23e59dc098369d1e725dcef45ae94b42dabd3f33e6082
+  metadata.gz: f3ab9fa17feabb5b7774f61911ae34dd36605b412a365d3192fb76ec8585569635aa74121b31fb5fbbe67c77fe1b8e77f3983724839a4ff4261b0212f79ccf4d
+  data.tar.gz: 4a176d6a400141e7fda5697d53f54ad4f7d599ab1ec85178798ad70c0188a7145aa49a688be37ad3d7c0e33c20a77ae478211dd6a08718625e87de6f4d33455d

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-01-30 15:39:52 UTC using RuboCop version 1.60.0.
+# on 2024-01-30 16:41:47 UTC using RuboCop version 1.60.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -13,36 +13,36 @@ Lint/ConstantDefinitionInBlock:
   Exclude:
     - 'spec/git_ownership_insights_spec.rb'
 
-# Offense count: 4
+# Offense count: 6
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 181
+  Max: 92
 
 # Offense count: 4
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 # AllowedMethods: refine
 Metrics/BlockLength:
-  Max: 76
+  Max: 75
 
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 200
+  Max: 207
 
-# Offense count: 1
+# Offense count: 2
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
-  Max: 28
+  Max: 12
 
-# Offense count: 4
+# Offense count: 6
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 109
+  Max: 49
 
 # Offense count: 1
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
-  Max: 29
+  Max: 12
 
 # Offense count: 1
 # Configuration parameters: AllowedConstants.
@@ -57,7 +57,7 @@ Style/MultilineBlockChain:
   Exclude:
     - 'lib/git_ownership_insights/git_ownership_insight.rb'
 
-# Offense count: 11
+# Offense count: 12
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    git_ownership_insights (2.0.3)
+    git_ownership_insights (2.0.4)
       date
       pry
 

data/lib/git_ownership_insights/git_ownership_insight.rb

@@ -53,6 +53,55 @@ class GitOwnershipInsights
     codeowners[best_match].split(' ')
   end
 
+  def handle_codeowners(file_team_map:)
+    puts "\n"
+    puts '*Code ownership data:*'
+    codeowners = read_codeowners_file
+
+    owners_data = Hash.new do |hash, key|
+      hash[key] = { directories: Hash.new do |h, k|
+        h[k] = { files: [] }
+      end, churn_count: 0 }
+    end
+
+    file_team_map.each do |file, count|
+      owners = find_owners(file, codeowners)
+      owners.each do |owner|
+        owners_data[owner][:churn_count] += count.last
+
+        dir_path = File.dirname(file)
+        owners_data[owner][:directories][dir_path][:files] << { name: File.basename(file), count: }
+      end
+    end
+
+    # Sort owners_data by total count in descending order
+    sorted_owners_data = owners_data.sort_by { |_, data| -data[:churn_count] }
+
+    # Take the last 5 elements
+    top_owners_data = sorted_owners_data.last(TOP_CONTRIBUTED_TEAMS.to_i)
+
+    converted_team_map = file_team_map.transform_keys { |key| File.basename(key) }
+
+    puts '   Codeownership data:'
+    top_owners_data.each do |owner, data|
+      puts "      #{owner.split('/').last}:\n         Total Count: #{data[:churn_count]}"
+      data[:directories].each do |dir, dir_data|
+        puts "            Directory: #{dir}\n               Top files:"
+        dir_data[:files].each do |file_data|
+          next if converted_team_map[File.basename(file_data[:name])].nil?
+
+          contributors = converted_team_map[file_data[:name]]&.first&.empty? ? ['Excluded contributor'] : converted_team_map[file_data[:name]].first
+          puts "                  #{File.basename(file_data[:name])} - #{file_data[:count].last} #{contributors}}"
+        end
+      end
+    end
+  end
+
+  def find_owner(file:)
+    codeowners = read_codeowners_file
+    find_owners(file, codeowners)
+  end
+
   def count_big_files(directory_path, size: BIG_FILE_SIZE)
     size = size.to_i
     # Get a list of all files in the specified directory
@@ -125,21 +174,12 @@ class GitOwnershipInsights
     `git log --pretty=format:"%s" --since="#{start_date}" --until="#{end_date}" --follow -- "#{file}"`
   end
 
-  def contribution_message
-    duration_in_days = @duration_in_days.to_i
+  def analyze_changed_files(uniq_code_files_with_changes:, start_date:, end_date:)
     all_teams = []
     cross_teams_count = 0
     single_ownership_teams_count = 0
     files_changed_by_many_teams = 0
     total_changes = 0
-    start_date = @begin_time.to_time.to_i - duration_in_days * 86_400 - 30 * 86_400
-    end_date = @begin_time.to_time.to_i - 30 * 86_400
-    git_ls = git_files(directory_path: @directory_path)
-    file_count = filter_existing_code_files(git_ls.split).count
-    all_files_with_changes = files_with_changes(directory_path: @directory_path, start_date:, end_date:).split.sort
-    code_files_with_changes = filter_existing_code_files(all_files_with_changes)
-    uniq_code_files_with_changes = code_files_with_changes.uniq
-
     file_team_map = {}
     uniq_code_files_with_changes.each do |file|
       filename = File.basename(file)
@@ -163,22 +203,35 @@ class GitOwnershipInsights
 
       puts "\n#{filename} [#{commit_count}]:#{teams}\n" if @debug
     end
+    [all_teams, cross_teams_count, single_ownership_teams_count, files_changed_by_many_teams, total_changes, file_team_map]
+  end
 
-    occurrences = all_teams.flatten.compact.tally
-    sorted_occurrences = occurrences.sort_by { |element, count| [-count, element] }
-    contributors = Hash[sorted_occurrences]
-
-    churn_count = file_team_map.values.map { |value| value[1] }.sum
-    hotspot_changes_percentage = (churn_count.to_f / total_changes) * 100
-
-    # Filter files based on extension and size
-    filtered_files = file_team_map.select do |file_path|
+  def filter_files(file_team_map:)
+    file_team_map.select do |file_path|
       next unless File.exist?(file_path)
 
       # Check if the file size is more than BIG_FILE_SIZE lines (excluding empty and commented lines)
       File.foreach(file_path).reject { |line| line.match(%r{^\s*(//|/\*.*\*/|\s*$)}) }.count > BIG_FILE_SIZE.to_i
     end
+  end
 
+  def contribution_message
+    duration_in_days = @duration_in_days.to_i
+    start_date = @begin_time.to_time.to_i - duration_in_days * 86_400 - 30 * 86_400
+    end_date = @begin_time.to_time.to_i - 30 * 86_400
+    git_ls = git_files(directory_path: @directory_path)
+    file_count = filter_existing_code_files(git_ls.split).count
+    all_files_with_changes = files_with_changes(directory_path: @directory_path, start_date:, end_date:).split.sort
+    code_files_with_changes = filter_existing_code_files(all_files_with_changes)
+    uniq_code_files_with_changes = code_files_with_changes.uniq
+    all_teams, cross_teams_count, single_ownership_teams_count, files_changed_by_many_teams, total_changes, file_team_map = analyze_changed_files(uniq_code_files_with_changes:, start_date:, end_date:)
+    occurrences = all_teams.flatten.compact.tally
+    sorted_occurrences = occurrences.sort_by { |element, count| [-count, element] }
+    contributors = Hash[sorted_occurrences]
+    churn_count = file_team_map.values.map { |value| value[1] }.sum
+    hotspot_changes_percentage = (churn_count.to_f / total_changes) * 100
+    # Filter files based on extension, existence and size
+    filtered_files = filter_files(file_team_map:)
     filtered_top_touched_files = filtered_files.sort_by { |element, count| [-count.last, element] }
 
     puts ''
@@ -205,53 +258,15 @@ class GitOwnershipInsights
       puts "\n"
       puts '   *Hotspot changes:*'
       filtered_top_touched_files.each do |line|
-        puts "     #{line.first.gsub(@directory_path, '')} Contributors: #{line.last.first} Commits: #{line.last.last}"
+        file = line.first
+        contributors = line.last.first
+        commits = line.last.last
+        puts "     #{file.gsub(@directory_path, '')} Contributors: #{contributors} Commits: #{commits} Owner: #{find_owner(file:)}"
       end
     end
 
-    if CODEOWNERS
-      puts "\n"
-      puts '*Code ownership data:*'
-      codeowners = read_codeowners_file
-
-      owners_data = Hash.new do |hash, key|
-        hash[key] = { directories: Hash.new do |h, k|
-          h[k] = { files: [] }
-        end, churn_count: 0 }
-      end
-
-      file_team_map.each do |file, count|
-        owners = find_owners(file, codeowners)
-        owners.each do |owner|
-          owners_data[owner][:churn_count] += count.last
-
-          dir_path = File.dirname(file)
-          owners_data[owner][:directories][dir_path][:files] << { name: File.basename(file), count: }
-        end
-      end
-
-      # Sort owners_data by total count in descending order
-      sorted_owners_data = owners_data.sort_by { |_, data| -data[:churn_count] }
-
-      # Take the last 5 elements
-      top_owners_data = sorted_owners_data.last(TOP_CONTRIBUTED_TEAMS.to_i)
-
-      converted_team_map = file_team_map.transform_keys { |key| File.basename(key) }
+    handle_codeowners(file_team_map:) if CODEOWNERS
 
-      puts '   Codeownership data:'
-      top_owners_data.each do |owner, data|
-        puts "      #{owner.split('/').last}:\n         Total Count: #{data[:churn_count]}"
-        data[:directories].each do |dir, dir_data|
-          puts "            Directory: #{dir}\n               Top files:"
-          dir_data[:files].each do |file_data|
-            next if converted_team_map[File.basename(file_data[:name])].nil?
-
-            contributors = converted_team_map[file_data[:name]]&.first&.empty? ? ['Excluded contributor'] : converted_team_map[file_data[:name]].first
-            puts "                  #{File.basename(file_data[:name])} - #{file_data[:count].last} #{contributors}}"
-          end
-        end
-      end
-    end
     @steps -= 1
 
     return unless @steps.positive?

data/lib/git_ownership_insights/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class GitOwnershipInsights
-  VERSION = '2.0.3'
+  VERSION = '2.0.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git_ownership_insights
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Serghei Moret