git_hub_bub 1.0.0 → 2.0.0

data/test/git_hub_bub/request_test.rb

@@ -1,100 +1,99 @@
-require 'test_helper'
+require "test_helper"
 
 class RequestTest < Test::Unit::TestCase
-
   def teardown
     GitHubBub::Request.clear_callbacks
   end
 
   def test_set_url
-    request = GitHubBub::Request.new('foo')
+    request = GitHubBub::Request.new("foo")
     assert_equal "https://api.github.com/foo", request.url
-    request = GitHubBub::Request.new('http://foo.com')
+    request = GitHubBub::Request.new("http://foo.com")
     assert_equal "http://foo.com", request.url
-    request = GitHubBub::Request.new('https://bar.com')
+    request = GitHubBub::Request.new("https://bar.com")
     assert_equal "https://bar.com", request.url
-    request = GitHubBub::Request.new('arthurnn/http')
+    request = GitHubBub::Request.new("arthurnn/http")
     assert_equal "https://api.github.com/arthurnn/http", request.url
-    request = GitHubBub::Request.new('arthurnn/https')
+    request = GitHubBub::Request.new("arthurnn/https")
     assert_equal "https://api.github.com/arthurnn/https", request.url
   end
 
   def test_set_callback
-    request = GitHubBub::Request.new('foo')
+    request = GitHubBub::Request.new("foo")
 
     GitHubBub::Request.set_before_callback do |request|
-      request.url = 'bar'
+      request.url = "bar"
     end
 
     request.before_callbacks!
 
-    assert_equal 'bar', request.url
+    assert_equal "bar", request.url
   end
 
   def test_token_parse
-    request = GitHubBub::Request.new('foo', token: "foo", what: "yeah")
+    request = GitHubBub::Request.new("foo", token: "foo", what: "yeah")
     request.set_auth_from_token!
-    assert_equal "token foo", request.options[:headers]['Authorization']
+    assert_equal "token foo", request.options[:headers]["Authorization"]
     assert_equal nil, request.options[:token]
   end
 
   def test_head_issues
-    VCR.use_cassette('HEAD rails/rails/issues') do
-      response = GitHubBub.head('/repos/rails/rails/issues')
-      assert_equal "GitHub.com", response.headers['Server']
+    VCR.use_cassette("HEAD rails/rails/issues") do
+      response = GitHubBub.head("/repos/rails/rails/issues")
+      assert_equal "GitHub.com", response.headers["Server"]
     end
   end
 
   def test_get_issues
-    VCR.use_cassette('GET rails/rails/issues') do
-      response = GitHubBub.get('/repos/rails/rails/issues')
-      assert_equal 'https://api.github.com/repos/rails/rails/issues/10715', response.json_body.first['url']
+    VCR.use_cassette("GET rails/rails/issues") do
+      response = GitHubBub.get("/repos/rails/rails/issues")
+      assert_equal "https://api.github.com/repos/rails/rails/issues/10715", response.json_body.first["url"]
     end
 
-    VCR.use_cassette('GET rails/rails/issues?page=2') do
-      response = GitHubBub.get('/repos/rails/rails/issues', page: 2)
-      assert_equal 'https://api.github.com/repos/rails/rails/issues/10664', response.json_body.first['url']
+    VCR.use_cassette("GET rails/rails/issues?page=2") do
+      response = GitHubBub.get("/repos/rails/rails/issues", page: 2)
+      assert_equal "https://api.github.com/repos/rails/rails/issues/10664", response.json_body.first["url"]
     end
   end
 
   def test_post_issues
-    VCR.use_cassette('POST /:owner/:repo/issues') do
-      params = { title: "Testing",
-                 body:  "a gem called git_hub_bub",
-                 token: ENV['GITHUB_API_KEY']}
-      response = GitHubBub.post("/repos/#{ENV['OWNER']}/#{ENV['REPO']}/issues", params)
-      assert_equal "https://api.github.com/repos/#{ENV['OWNER']}/#{ENV['REPO']}/issues/77", response.json_body['url']
-      assert_equal params[:title], response.json_body['title']
+    VCR.use_cassette("POST /:owner/:repo/issues") do
+      params = {title: "Testing",
+                body: "a gem called git_hub_bub",
+                token: ENV["GITHUB_API_KEY"]}
+      response = GitHubBub.post("/repos/#{ENV["OWNER"]}/#{ENV["REPO"]}/issues", params)
+      assert_equal "https://api.github.com/repos/#{ENV["OWNER"]}/#{ENV["REPO"]}/issues/77", response.json_body["url"]
+      assert_equal params[:title], response.json_body["title"]
     end
   end
 
   def test_patch
-    VCR.use_cassette('PATCH user') do
-      params = { name:  ENV['USER_NAME'],
-                 token: ENV['GITHUB_API_KEY']}
-      response = GitHubBub.post('user', params)
-      assert_equal params[:name], response.json_body['name']
-      assert_equal ENV['OWNER'], response.json_body['login']
+    VCR.use_cassette("PATCH user") do
+      params = {name: ENV["USER_NAME"],
+                token: ENV["GITHUB_API_KEY"]}
+      response = GitHubBub.post("user", params)
+      assert_equal params[:name], response.json_body["name"]
+      assert_equal ENV["OWNER"], response.json_body["login"]
     end
   end
 
   # http://developer.github.com/v3/activity/watching/
   def test_put
-    VCR.use_cassette('PUT /repos/:owner/:repo/subscription') do
+    VCR.use_cassette("PUT /repos/:owner/:repo/subscription") do
       subscribed = true
-      ignored    = false
-      response = GitHubBub.put("/repos/#{ENV['WATCH_OWNER']}/#{ENV['WATCH_REPO']}/subscription", subscribed: subscribed, ignored: ignored, token: ENV['GITHUB_API_KEY'])
+      ignored = false
+      response = GitHubBub.put("/repos/#{ENV["WATCH_OWNER"]}/#{ENV["WATCH_REPO"]}/subscription", subscribed: subscribed, ignored: ignored, token: ENV["GITHUB_API_KEY"])
       assert_equal 200, response.status
-      assert_equal ignored, response.json_body['ignored']
-      assert_equal subscribed, response.json_body['subscribed']
+      assert_equal ignored, response.json_body["ignored"]
+      assert_equal subscribed, response.json_body["subscribed"]
     end
   end
 
   def test_delete
-    VCR.use_cassette('DELETE milestone') do
-      name = 'test'
-      response = GitHubBub.post("repos/#{ENV['OWNER']}/#{ENV['REPO']}/labels", name: name, color: 'FFFFFF', token: ENV['GITHUB_API_KEY'])
-      response = GitHubBub.delete("repos/#{ENV['OWNER']}/#{ENV['REPO']}/labels/#{name}", token: ENV['GITHUB_API_KEY'])
+    VCR.use_cassette("DELETE milestone") do
+      name = "test"
+      GitHubBub.post("repos/#{ENV["OWNER"]}/#{ENV["REPO"]}/labels", name: name, color: "FFFFFF", token: ENV["GITHUB_API_KEY"])
+      response = GitHubBub.delete("repos/#{ENV["OWNER"]}/#{ENV["REPO"]}/labels/#{name}", token: ENV["GITHUB_API_KEY"])
       assert_equal 204, response.status
     end
   end

data/test/git_hub_bub/response_test.rb

@@ -1,13 +1,11 @@
-require 'test_helper'
+require "test_helper"
 
 class ResponseTest < Test::Unit::TestCase
-
   def test_pagination
     response = GitHubBub::Response.new(rails_issues_data(:first))
-    assert_equal({"next_url"=>"https://api.github.com/repositories/8514/issues?page=2",
-                  "last_url"=>"https://api.github.com/repositories/8514/issues?page=18"},
-                  response.pagination)
-
+    assert_equal({"next_url" => "https://api.github.com/repositories/8514/issues?page=2",
+                  "last_url" => "https://api.github.com/repositories/8514/issues?page=18"},
+      response.pagination)
 
     assert_equal "https://api.github.com/repositories/8514/issues?page=2", response.next_url
     assert_equal "https://api.github.com/repositories/8514/issues?page=18", response.last_url
@@ -18,26 +16,25 @@ class ResponseTest < Test::Unit::TestCase
     assert response.first_page?
 
     response = GitHubBub::Response.new(rails_issues_data(:second))
-    assert_equal({"next_url"=>"https://api.github.com/repositories/8514/issues?page=3",
-                  "last_url"=>"https://api.github.com/repositories/8514/issues?page=18",
-                  "first_url"=>"https://api.github.com/repositories/8514/issues?page=1",
-                  "prev_url"=>"https://api.github.com/repositories/8514/issues?page=1"},
-                  response.pagination)
+    assert_equal({"next_url" => "https://api.github.com/repositories/8514/issues?page=3",
+                  "last_url" => "https://api.github.com/repositories/8514/issues?page=18",
+                  "first_url" => "https://api.github.com/repositories/8514/issues?page=1",
+                  "prev_url" => "https://api.github.com/repositories/8514/issues?page=1"},
+      response.pagination)
 
     assert_equal "https://api.github.com/repositories/8514/issues?page=3", response.next_url
     assert_equal "https://api.github.com/repositories/8514/issues?page=18", response.last_url
     assert_equal "https://api.github.com/repositories/8514/issues?page=1", response.prev_url
     assert_equal "https://api.github.com/repositories/8514/issues?page=1", response.first_url
 
-
     refute response.last_page?
     refute response.first_page?
 
     response = GitHubBub::Response.new(rails_issues_data(:last))
-    assert_equal({"last_url"=>"https://api.github.com/repositories/8514/issues?page=1",
-                  "first_url"=>"https://api.github.com/repositories/8514/issues?page=1",
-                  "prev_url"=>"https://api.github.com/repositories/8514/issues?page=17"},
-                  response.pagination)
+    assert_equal({"last_url" => "https://api.github.com/repositories/8514/issues?page=1",
+                  "first_url" => "https://api.github.com/repositories/8514/issues?page=1",
+                  "prev_url" => "https://api.github.com/repositories/8514/issues?page=17"},
+      response.pagination)
 
     assert_equal nil, response.next_url
     assert_equal "https://api.github.com/repositories/8514/issues?page=1", response.last_url
@@ -60,12 +57,31 @@ class ResponseTest < Test::Unit::TestCase
       assert_equal 0, response.rate_limit_reset_time_left
     end
 
-    Timecop.freeze(Time.at(epoch_time - 2 ).to_datetime) do
+    Timecop.freeze(Time.at(epoch_time - 2).to_datetime) do
       response = GitHubBub::Response.new(rails_issues_data(:last))
       assert_equal 2, response.rate_limit_reset_time_left
     end
   end
 
+  def test_last_page_with_next_but_no_last_url
+    # This reproduces a real response from the GitHub API where the Link header
+    # only contains rel="next" but no rel="last"
+    data = {
+      body: "[{\"url\":\"https://api.github.com/repos/puma/puma/issues/3643\"}]",
+      headers: {
+        "Link" => "<https://api.github.com/repositories/2441517/issues?direction=desc&page=2&sort=comments&state=open&after=Y3Vyc29yOnYyOpIIzpU4Fek%3D&per_page=30>; rel=\"next\""
+      },
+      status: 200
+    }
+    response = GitHubBub::Response.new(data)
+
+    assert_equal "https://api.github.com/repositories/2441517/issues?direction=desc&page=2&sort=comments&state=open&after=Y3Vyc29yOnYyOpIIzpU4Fek%3D&per_page=30",
+      response.next_url
+    assert_nil response.last_url
+
+    refute response.last_page?
+  end
+
   def test_rate_limit_sleep
     epoch_time = 1504196685
 
@@ -99,7 +115,7 @@ class ResponseTest < Test::Unit::TestCase
     Timecop.freeze(Time.at(epoch_time - 1).to_datetime) do
       response = GitHubBub::Response.new(rails_issues_data(:last))
       response.headers["X-RateLimit-Limit"] = "10"
-      assert_equal 1.0/10, response.rate_limit_sleep!(bypass_sleep: true)
+      assert_equal 1.0 / 10, response.rate_limit_sleep!(bypass_sleep: true)
     end
   end
 end

data/test/git_hub_bub/valid_token_test.rb

@@ -1,4 +1,4 @@
-require 'test_helper'
+require "test_helper"
 
 class ValidTokenTest < Test::Unit::TestCase
   include WebMock::API
@@ -8,14 +8,23 @@ class ValidTokenTest < Test::Unit::TestCase
   end
 
   def test_does_not_add_token_to_header
-    token    = "foo"
-    url      = "https://#{ENV['GITHUB_APP_ID']}:#{ENV['GITHUB_APP_SECRET']}@api.github.com/applications/#{ENV['GITHUB_APP_ID']}/tokens/#{token}"
-    stub_get = stub_request(:get, url)
+    # Disable VCR so WebMock's stub_request can handle the request directly
+    VCR.turned_off do
+      token = "foo"
+      url = "https://api.github.com/applications/#{ENV["GITHUB_APP_ID"]}/tokens/#{token}"
+      # Add a basic auth header, will fail if `'Authorization'=>'token ...'` header is added by mistake
+      stub_get = stub_request(:get, url).with(basic_auth: [ENV["GITHUB_APP_ID"], ENV["GITHUB_APP_SECRET"]])
 
-    GitHubBub::Request.any_instance.expects(:token).never
+      GitHubBub::Request.set_before_callback do |request|
+        if request.token?
+          # Should be true for this call
+        else
+          raise "nope"
+        end
+      end
 
-    GitHubBub.valid_token?(token)
-    assert_requested stub_get
+      GitHubBub.valid_token?(token)
+      assert_requested stub_get
+    end
   end
-
 end