git_game_show 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 719118cfd107443e62e4c5e91fe2ee425bf58d30b9c681df744e9e8fbc25f81d
-  data.tar.gz: 80cb0a7b0f9653d33e0e58057eb9fc85df59757486e452c22de2ea3508a0bcb2
+  metadata.gz: 6dd69e30776e28d63d3fd20db47716c0e957dace72788a5e0479047fe8cbe708
+  data.tar.gz: cd8e8579ec722b25a67ffd1c8268f35a724dcf75cd863420ffebad9025f1ebf4
 SHA512:
-  metadata.gz: 6ba0dec0a4e51517994a4c574cb1d1c738780e2a812a4d516fb53f18d46d9c08661ec924a67dbb228d4efffe360e0f47bebe804464fe7b83e10ad053a859da96
-  data.tar.gz: acc62cb0dcaf6ae4d6249b8a1b4b5b6f03fc3d2d19016dc2f65a64991d31069b7b5b1786ff5c1566575c193473ba36d4ac3285385f46d74f81f30e6e21449a10
+  metadata.gz: 8874ab5bb9a8349e9b22926e8456fef2aa1ce4bcdaf1ca14b170d82d6e0491a68db6c576eda153b92fbca942efa1861dd44d139d1d57e709fe2853e5c2b36fe6
+  data.tar.gz: 37c9292edb46b4e3be1283efbd09b3762c504696a5d875a16c7d8a12fdbc68265319f40b4db992e0c4fd71d42bf420abcce75bd3e62402c741ba38e459c265a2

data/lib/git_game_show/cli.rb

@@ -510,6 +510,7 @@ module GitGameShow
 
     def display_ggs
       clear_screen
+      puts ""
       lines = [
         " ██████╗ ".colorize(:red) + "  ██████╗ ".colorize(:green) + "  █████╗".colorize(:blue),
         "██╔════╝ ".colorize(:red) + " ██╔════╝ ".colorize(:green) + " ██╔═══╝".colorize(:blue),

data/lib/git_game_show/player_client.rb

@@ -543,7 +543,7 @@ module GitGameShow
 
       # Display a fun "Game Starting" animation
       box_width = 40
-      puts "\n\n"
+      puts "\n"
       puts ("╭" + "─" * box_width + "╮").center(@game_width).colorize(:green)
       puts ("│" + "Game starting...".center(box_width) + "│").center(@game_width).colorize(:green)
       puts ("╰" + "─" * box_width + "╯").center(@game_width).colorize(:green)
@@ -600,8 +600,6 @@ module GitGameShow
       mini_game = data['mini_game']
       description = data['description']
 
-      puts "\n\n"
-
       # Box is drawn with exactly 45 "━" characters for the top and bottom borders
       # The top and bottom including borders are 48 characters wide
       box_width = 42
@@ -610,6 +608,7 @@ module GitGameShow
       box_middle = "│#{"Round #{round_num} of #{total_rounds}".center(box_width - 2)}│".center(@game_width)
 
       # Output the box
+      puts "\n"
       puts box_top.colorize(:green)
       puts box_middle.colorize(:green)
       puts box_bottom.colorize(:green)
@@ -643,9 +642,6 @@ module GitGameShow
 
       # No need to reserve space for timer - it will be at the bottom of the screen
 
-      # Display question header
-      puts "\n"
-
       # Draw a simple box for the question header
       box_width = 42
       box_top    = ("╭" + "─" * (box_width - 2) + "╮").center(@game_width)
@@ -653,6 +649,7 @@ module GitGameShow
       box_middle = "│#{"Question #{question_num} of #{total_questions}".center(box_width - 2)}│".center(@game_width)
 
       # Output the question box
+      puts "\n"
       puts box_top.colorize(:light_blue)
       puts box_middle.colorize(:light_blue)
       puts box_bottom.colorize(:light_blue)
@@ -867,8 +864,6 @@ module GitGameShow
       # Start with a clean screen
       clear_screen
 
-      puts "\n"
-
       # Box is drawn with exactly 45 "━" characters for the top and bottom borders
       # The top and bottom including borders are 48 characters wide
       box_width = 40
@@ -877,6 +872,7 @@ module GitGameShow
       box_middle = "│#{'Round Results'.center(box_width)}│".center(@game_width)
 
       # Output the box
+      puts "\n"
       puts box_top.colorize(:light_blue)
       puts box_middle.colorize(:light_blue)
       puts box_bottom.colorize(:light_blue)
@@ -988,7 +984,7 @@ module GitGameShow
       clear_screen
 
       box_width = 40
-      puts ""
+      puts "\n"
       puts ("╭" + "─" * box_width + "╮").center(@game_width).colorize(:yellow)
       puts "│#{'Scoreboard'.center(box_width)}┃".center(@game_width).colorize(:yellow)
       puts ("╰" + "─" * box_width + "╯").center(@game_width).colorize(:yellow)

data/lib/git_game_show/version.rb

@@ -1,4 +1,4 @@
 module GitGameShow
   # Current version of Git Game Show
-  VERSION = "0.1.8"
+  VERSION = "0.1.9"
 end

data/mini_games/file_quiz.rb

@@ -1,4 +1,7 @@
 module GitGameShow
+  # Disable debug mode for normal operation
+  $FILE_QUIZ_DEBUG = false
+
   class FileQuiz < MiniGame
     self.name = "File Quiz"
     self.description = "Match the commit message to the right changed file!"
@@ -15,39 +18,54 @@ module GitGameShow
 
     def generate_questions(repo)
       begin
-        # Get commits from the repo - based on similar approach as AuthorQuiz
-        # Start by getting a larger number of commits to ensure enough variety
-        commit_count = [self.class.questions_per_round * 10, 100].min
-        
-        # Get all commits
-        commits = repo.log(commit_count).to_a
-        
+        # Use the same approach as AuthorQuiz - get ALL commits using the helper method
+        commits = get_all_commits(repo)
+
+        # Check if we got any commits at all
+        if commits.nil? || commits.empty?
+          # Silently fall back to sample questions
+          return generate_sample_questions
+        end
+
         # Shuffle commits for better variety
         commits.shuffle!
-        
+
         # Process commits to find ones with good file changes
         valid_commits = []
-        
+
         commits.each do |commit|
           # Get changed files for this commit
           changed_files = []
-          
+
           begin
-            # Try to get the diff with previous commit
+            # Use standard Git methods instead of run_command (silently)
+
+            # Use git commands quietly without showing output
             if commit.parents.empty?
-              # First commit - get the files directly
-              diff_output = repo.lib.run_command('show', ['--name-only', '--pretty=format:', commit.sha])
-              changed_files = diff_output.split("\n").reject(&:empty?)
+              # For first commit, get files directly
+              cmd = "cd #{repo.dir.path} && git show --name-only --pretty=format: #{commit.sha} 2>/dev/null"
+              diff_output = `#{cmd}`
             else
-              # Regular commit with parent
-              diff_output = repo.lib.run_command('diff', ['--name-only', "#{commit.sha}^", commit.sha])
-              changed_files = diff_output.split("\n").reject(&:empty?)
+              # For normal commits with parents
+              cmd = "cd #{repo.dir.path} && git diff --name-only #{commit.sha}^ #{commit.sha} 2>/dev/null"
+              diff_output = `#{cmd}`
+
+              # If diff returns empty, try using show as fallback
+              if diff_output.strip.empty?
+                cmd = "cd #{repo.dir.path} && git show --name-only --pretty=format: #{commit.sha} 2>/dev/null"
+                diff_output = `#{cmd}`
+              end
             end
-            
-            # Skip if no files or too many files (probably a merge or refactoring)
+
+            # Parse the output to get changed files (quietly)
+            changed_files = diff_output.split("\n").reject(&:empty?)
+
+            # Skip if no files changed (can't create a question for this)
             next if changed_files.empty?
-            next if changed_files.size > 8 # Skip large commits that likely changed multiple unrelated files
-            
+
+            # Super relaxed - accept ANY commit with files that changed
+            # No more filtering by number of files
+
             # Create structure with relevant commit data
             valid_commits << {
               sha: commit.sha,
@@ -56,29 +74,31 @@ module GitGameShow
               date: commit.date,
               files: changed_files
             }
-            
+
             # Once we have enough commits, we can stop
-            break if valid_commits.size >= self.class.questions_per_round * 3
+            # Get more commits to have a better selection
+            break if valid_commits.size >= self.class.questions_per_round * 5
           rescue => e
-            # Skip problematic commits
+            # Silently skip problematic commits
             next
           end
         end
-        
-        # If we couldn't find enough good commits, fall back to samples
-        if valid_commits.size < self.class.questions_per_round
+
+        # Never fall back to samples as long as we have at least 1 valid commit
+        if valid_commits.empty?
+          # Silently fall back to sample questions if needed
           return generate_sample_questions
         end
-        
+
         # Prioritize commits that modified interesting files (not just .gitignore etc.)
         prioritized_commits = valid_commits.sort_by do |commit|
           # Higher score = more interesting commit
           score = 0
-          
+
           # Prioritize based on file types
           commit[:files].each do |file|
             ext = File.extname(file).downcase
-            
+
             case ext
             when '.rb', '.js', '.py', '.java', '.tsx', '.jsx'
               score += 3  # Source code is most interesting
@@ -90,30 +110,33 @@ module GitGameShow
               score -= 1  # Less interesting files
             end
           end
-          
+
           # Prioritize based on commit message length - longer messages are often more descriptive
           message_length = commit[:message].to_s.strip.length
           score += [message_length / 20, 5].min
-          
+
           # Return negative score so highest scores come first in sort
           -score
         end
-        
-        # Select top commits for questions
-        selected_commits = prioritized_commits.take(self.class.questions_per_round)
-        
+
+        # Take as many commits as we need for questions
+        needed_commits = [self.class.questions_per_round, prioritized_commits.size].min
+        selected_commits = prioritized_commits.take(needed_commits)
+
         # Create questions from selected commits
         questions = []
-        
+
         selected_commits.each do |commit|
           # Choose the most interesting file as the correct answer
-          # (Sort by extension priority, then by path length to favor shorter paths)
           files = commit[:files]
-          
+
+          # Skip if somehow we got a commit with no files
+          next if files.empty?
+
           # Score files by interestingness
           scored_files = files.map do |file|
             ext = File.extname(file).downcase
-            
+
             # Start with base score by extension
             score = case ext
             when '.rb', '.js', '.py', '.java', '.tsx', '.jsx'
@@ -129,32 +152,33 @@ module GitGameShow
             else
               5   # Other files are neutral
             end
-            
+
             # Shorter paths are usually more recognizable
             score -= [file.length / 10, 5].min
-            
+
             # Prefer files in main directories (src, lib, app) over deeply nested ones
             if file.start_with?('src/', 'lib/', 'app/')
               score += 3
             end
-            
+
             [file, score]
           end
-          
+
           # Sort by score (highest first) and select most interesting file
-          correct_file = scored_files.sort_by { |_, score| -score }.first[0]
-          
+          scored_files.sort_by! { |_, score| -score }
+          correct_file = scored_files.first[0]
+
           # Get incorrect options from other commits
           other_files = []
           other_commits = selected_commits - [commit]
-          
+
           # Collect files from other commits
           other_commits.each do |other_commit|
             other_commit[:files].each do |file|
               other_files << file unless files.include?(file)
             end
           end
-          
+
           # If we don't have enough other files, use some from sample data
           if other_files.size < 3
             sample_files = [
@@ -164,19 +188,19 @@ module GitGameShow
             ]
             other_files += sample_files.reject { |f| files.include?(f) }
           end
-          
+
           # Take up to 3 unique other files, prioritizing diverse ones
           other_files = other_files.uniq.sample(3)
-          
+
           # Create options array with the correct answer and incorrect ones
           all_options = ([correct_file] + other_files).shuffle
-          
+
           # Format the commit date nicely
           nice_date = commit[:date].strftime('%b %d, %Y') rescue "Unknown date"
-          
+
           # Clean up commit message - take first line if multiple lines
           message = commit[:message].to_s.split("\n").first.strip
-          
+
           # Format consistently with other mini-games
           questions << {
             question: "Which file was most likely changed in this commit?\n\n   \"#{message}\"",
@@ -185,62 +209,66 @@ module GitGameShow
             correct_answer: correct_file
           }
         end
-        
-        # Final safety check - if we couldn't create enough questions, use samples
+
+        # If we still couldn't create enough questions, use a mix of real and samples
         if questions.size < self.class.questions_per_round
-          return generate_sample_questions
+          # Add sample questions to fill the remaining slots (silently)
+          sample_questions = generate_sample_questions
+          remaining_slots = self.class.questions_per_round - questions.size
+          questions += sample_questions.take(remaining_slots)
         end
-        
+
         return questions
       rescue => e
-        # If anything fails, fall back to sample questions
+        # If anything fails, silently fall back to sample questions
         return generate_sample_questions
       end
     end
 
     def evaluate_answers(question, player_answers)
       results = {}
-      
+
       player_answers.each do |player_name, answer_data|
         answered = answer_data[:answered] || false
         player_answer = answer_data[:answer]
         correct = player_answer == question[:correct_answer]
-        
+
         points = correct ? 10 : 0
-        
+
         # Bonus points for fast answers (if correct)
         if correct
           time_taken = answer_data[:time_taken] || 15
-          
+
           if time_taken < 5
             points += 5
           elsif time_taken < 10
             points += 3
           end
         end
-        
+
         results[player_name] = {
           answer: player_answer,
           correct: correct,
           points: points
         }
       end
-      
+
       results
     end
 
     # Generate sample questions only used when no repository data is available
     def generate_sample_questions
+      # No debug message in production
       questions = []
 
       # Common file options
       common_files = [
         "src/main.js",
         "README.md",
-        "lib/utils.js", 
+        "lib/utils.js",
         "css/styles.css"
       ]
-      
+
       # Common sample commit messages
       sample_messages = [
         "Update documentation with new API endpoints",
@@ -254,14 +282,14 @@ module GitGameShow
       self.class.questions_per_round.times do |i|
         # Use modulo to cycle through sample messages
         message = sample_messages[i % sample_messages.size]
-        
+
         # Different correct answers for each question
         correct_file = common_files[i % common_files.size]
-        
+
         # Options are all files with the correct one included
         all_options = common_files.shuffle
-        
-        # Create the question
+
+        # Create the question - clearly label as sample data
         questions << {
           question: "Which file was most likely changed in this commit?\n\n   \"#{message} (SAMPLE)\"",
           commit_info: "sample#{i} (Demo Question)",
@@ -272,7 +300,5 @@ module GitGameShow
 
       questions
     end
-
-    # No private methods needed anymore
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git_game_show
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - Justin Paulson