git_evolution 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bf16cc71418f589e13752aa32e110fe41dda318a
-  data.tar.gz: f527d0c64625e859bbda0759eaec9453d4651809
+  metadata.gz: 9601a4a1eb15dc6bda2ed6c3229858602d933733
+  data.tar.gz: 98056387ada1c9303ce8f47603a82657df8b5df6
 SHA512:
-  metadata.gz: 75f452c8f3cd00f2e99ed0eb7afedb2391205e693a310ef4e4d6cd0cd7aa4d099c32ed4b414aef33271881dca134677a17616174170d8dd9832b4526af4c36c3
-  data.tar.gz: cdfdee0e7dc34c330da4b40f0ba190911dc87291d9186ed288e2660bf0acf15253db26033a45394a89768743de100f7b564e33be2c7f186d46c03e8d59b0a0a9
+  metadata.gz: a8ae0797250443a52f297cf840d002fea1ab97598586a43f8cbc25892ab5d8160775806a3535c8aa364e0b90a87aa076331591e96c5773c7fff4c3c9803eb768
+  data.tar.gz: e2ba200cfb1bfe7d0aa87963be0c3e58667f38460b6bd09707a0064529a3f29cc5deada0a36971d45170e64973618a39ca61b25160fe40c0f3087ef908241148

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    git_evolution (0.1.2)
+    git_evolution (0.1.3)
       bundler (~> 1.0)
       chronic (~> 0.10.0)
       rake (~> 10.0)

data/lib/git_evolution/errors.rb

@@ -0,0 +1,9 @@
+module GitEvolution
+  class Exception < StandardError; end
+
+  class FileMissingError < GitEvolution::Exception; end
+  class InvalidRangeFormatError < GitEvolution::Exception; end
+  class FileDoesNotExistError < GitEvolution::Exception; end
+  class RangeOutOfBoundsError < GitEvolution::Exception; end
+  class TimeParseError < GitEvolution::Exception; end
+end

data/lib/git_evolution/option_handler.rb

@@ -5,7 +5,7 @@ module GitEvolution
         range: nil,
         since: nil,
         start_line: nil,
-        end_line: nil,
+        end_line: nil
       )
 
       OptionParser.new do |opts|
@@ -19,6 +19,8 @@ module GitEvolution
         end
       end.parse!
 
+      raise(FileMissingError, 'Missing required file argument') if args.empty?
+
       options[:file] = File.expand_path(args[0])
       options[:start_line], options[:end_line] = parse_range(options[:range])
 
@@ -31,7 +33,7 @@ module GitEvolution
       return if range.nil?
 
       regex_matches = range.match(/^(\d+):(\d+)/)
-      raise 'The --range option was not in the valid format (N:N)' if regex_matches.nil?
+      raise(InvalidRangeFormatError, 'The --range option was not in the valid format (N:N)') if regex_matches.nil?
 
       start_line = regex_matches[1].to_i
       end_line = regex_matches[2].to_i
@@ -41,21 +43,21 @@ module GitEvolution
 
     def self.validate_options!(options)
       if options.file.nil?
-        raise 'Missing required file argument'
+        raise(FileMissingError, 'Missing required file argument')
       elsif !File.exist?(options.file)
-        raise "File #{options.file} does not exist"
+        raise(FileDoesNotExistError, "File #{options.file} does not exist")
       end
 
       if !options.range.nil?
-        raise 'Start line cannot be greater than the end line' if options.start_line > options.end_line
+        raise(RangeOutOfBoundsError, 'Start line cannot be greater than the end line') if options.start_line > options.end_line
 
         file_length = File.new(options.file).readlines.size
-        raise "End line cannot be larger than the length of the file (#{file_length})" if options.end_line > file_length
+        raise(RangeOutOfBoundsError, "End line cannot be larger than the length of the file (#{file_length})") if options.end_line > file_length
       end
 
       if !options.since.nil?
         options.since = Chronic.parse(options.since)
-        raise 'The since time could not be properly parsed' if options.since.nil?
+        raise(TimeParseError, 'The since time could not be properly parsed') if options.since.nil?
       end
     end
   end

data/lib/git_evolution/version.rb

@@ -1,3 +1,3 @@
 module GitEvolution
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/spec/git_evolution/option_handler_spec.rb

@@ -2,8 +2,9 @@ require 'spec_helper'
 
 RSpec.describe GitEvolution::OptionHandler do
   describe '.parse_options' do
-    subject { described_class.parse_options([file]) }
+    subject { described_class.parse_options(args) }
 
+    let(:args) { [file] }
     let!(:tmp_dir) { Dir.mktmpdir }
     let(:file) { tmp_dir + '/file.txt' }
     let(:start_line) { 1 }
@@ -21,6 +22,14 @@ RSpec.describe GitEvolution::OptionHandler do
       expect(subject.end_line).to eq(end_line)
       expect(subject.file).to eq(file)
     end
+
+    context 'no arguments passed' do
+      let(:args) { [] }
+
+      it 'raises a FileMissingException' do
+        expect { subject }.to raise_error(GitEvolution::FileMissingError)
+      end
+    end
   end
 
   describe '.parse_range' do
@@ -84,7 +93,7 @@ RSpec.describe GitEvolution::OptionHandler do
       let(:end_line) { 1 }
 
       it 'invalid options' do
-        expect { described_class.validate_options!(options) }.to raise_error
+        expect { described_class.validate_options!(options) }.to raise_error(GitEvolution::RangeOutOfBoundsError)
       end
     end
 
@@ -94,13 +103,13 @@ RSpec.describe GitEvolution::OptionHandler do
       before { FileUtils.rm(file) }
 
       it 'invalid options' do
-        expect { described_class.validate_options!(options) }.to raise_error
+        expect { described_class.validate_options!(options) }.to raise_error(GitEvolution::FileDoesNotExistError)
       end
 
       context 'missing file argument' do
         it 'invalid options' do
           options.file = nil
-          expect { described_class.validate_options!(options) }.to raise_error
+          expect { described_class.validate_options!(options) }.to raise_error(GitEvolution::FileMissingError)
         end
       end
     end
@@ -110,7 +119,7 @@ RSpec.describe GitEvolution::OptionHandler do
       let(:end_line) { 40 }
 
       it 'invalid options' do
-        expect { described_class.validate_options!(options) }.to raise_error
+        expect { described_class.validate_options!(options) }.to raise_error(GitEvolution::RangeOutOfBoundsError)
       end
     end
 
@@ -119,7 +128,7 @@ RSpec.describe GitEvolution::OptionHandler do
         let(:since) { 'csdcsdc' }
 
         it 'invalid options' do
-          expect { described_class.validate_options!(options) }.to raise_error
+          expect { described_class.validate_options!(options) }.to raise_error(GitEvolution::TimeParseError)
         end
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: git_evolution
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Kevin Jalbert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-30 00:00:00.000000000 Z
+date: 2015-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,6 +86,7 @@ files:
 - git_evolution.gemspec
 - lib/git_evolution.rb
 - lib/git_evolution/commit.rb
+- lib/git_evolution/errors.rb
 - lib/git_evolution/initialize.rb
 - lib/git_evolution/option_handler.rb
 - lib/git_evolution/report_presenter.rb