git 5.0.1 → 5.0.3

data/README.md

@@ -6,14 +6,19 @@
 # The Git Gem
 
 [![Gem Version](https://badge.fury.io/rb/git.svg)](https://badge.fury.io/rb/git)
+[![Build Status](https://github.com/ruby-git/ruby-git/actions/workflows/continuous_integration.yml/badge.svg)](https://github.com/ruby-git/ruby-git/actions/workflows/continuous_integration.yml)
 [![Documentation](https://img.shields.io/badge/Documentation-Latest-green)](https://rubydoc.info/gems/git/)
 [![Change
 Log](https://img.shields.io/badge/CHANGELOG-Latest-green)](https://rubydoc.info/gems/git/file/CHANGELOG.md)
-[![Build
-Status](https://github.com/ruby-git/ruby-git/workflows/CI/badge.svg?branch=main)](https://github.com/ruby-git/ruby-git/actions?query=workflow%3ACI)
 [![Conventional
 Commits](https://img.shields.io/badge/Conventional%20Commits-1.0.0-%23FE5196?logo=conventionalcommits&logoColor=white)](https://conventionalcommits.org)
-[![AI Policy](https://img.shields.io/badge/AI%20Policy-Required-blue)](AI_POLICY.md)
+[![AI Policy](https://img.shields.io/badge/AI%20Policy-Doc-blue)](AI_POLICY.md)
+[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](LICENSE)
+
+> **v5.0.0 is here.** This is a major release with a redesigned internal
+> architecture, but most v4.x code runs unchanged thanks to compatibility
+> shims. See [UPGRADING.md](UPGRADING.md) for the migration guide and
+> [CHANGELOG.md](CHANGELOG.md) for full release notes.
 
 - [Summary](#summary)
 - [Install](#install)

data/Rakefile

@@ -9,19 +9,8 @@ default_tasks = %i[spec:unit spec:integration rubocop]
 default_tasks << :yard if Rake::Task.task_defined?(:yard)
 default_tasks << :build
 
-default_tasks_parallel = %w[spec:unit:parallel spec:integration:parallel rubocop]
-default_tasks_parallel << :yard if Rake::Task.task_defined?(:yard)
-default_tasks_parallel << :build
-
-# Use parallel test execution for MRI where it cuts build times by 30-48%.
-# JRuby and TruffleRuby are slower with parallel_tests because each worker
-# process pays JVM/Truffle startup and warm-up overhead independently,
-# resulting in 18-28% slower builds vs. serial execution.
-parallel_supported = RUBY_ENGINE == 'ruby'
-task default: parallel_supported ? default_tasks_parallel : default_tasks
-
-desc 'Same as default but runs tests in parallel'
-task 'default:parallel': default_tasks_parallel
+desc 'Run all CI tasks (tests, linters, yard, and build)'
+task default: default_tasks
 
 module Rake
   # Overload Rake::Task to add logging

data/git.gemspec

@@ -1,7 +1,19 @@
 # frozen_string_literal: true
 
-$LOAD_PATH.unshift File.expand_path('lib', __dir__)
-require 'git/version'
+# Read the version out of lib/git/version.rb rather than requiring it.
+#
+# The Gemfile uses `gemspec`, so Bundler evaluates this file on every `bundle exec`.
+# `require`ing lib/git/version.rb here would therefore load it before SimpleCov
+# starts in spec_helper, leaving it invisible to the coverage report -- an
+# unmeasured hole in the 100% coverage gate. See the "Test coverage policy" section
+# of CONTRIBUTING.md.
+#
+# release-please rewrites the `VERSION = '...'` assignment in place (see
+# `version-file` in .release-please-config.json), so matching on it stays correct
+# across releases. If the match ever fails, the raise below stops the build
+# immediately rather than letting a nil version reach the specification.
+version = File.read(File.expand_path('lib/git/version.rb', __dir__))[/^\s*VERSION\s*=\s*['"]([^'"]+)['"]/, 1]
+raise 'Could not determine Git::VERSION from lib/git/version.rb' if version.nil?
 
 Gem::Specification.new do |spec|
   spec.author = 'Scott Chacon and others'
@@ -17,7 +29,7 @@ Gem::Specification.new do |spec|
     including branching and merging, object inspection and manipulation, history, patch
     generation and more.
   DESCRIPTION
-  spec.version = Git::VERSION
+  spec.version = version
 
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = spec.homepage
@@ -41,9 +53,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 13.3'
   spec.add_development_dependency 'rspec', '~> 3.13'
   spec.add_development_dependency 'rubocop', '~> 1.82'
-  spec.add_development_dependency 'simplecov', '~> 0.22'
+  spec.add_development_dependency 'simplecov', '~> 1.0'
   spec.add_development_dependency 'simplecov-lcov', '~> 0.9'
-  spec.add_development_dependency 'simplecov-rspec', '~> 0.4'
+  spec.add_development_dependency 'simplecov-rspec', '~> 1.1'
 
   if RUBY_ENGINE == 'truffleruby' && Gem::Version.new(RUBY_ENGINE_VERSION) < Gem::Version.new('34.0.0')
     # i18n 1.15+ uses Fiber.[] (Ruby 3.2 Fiber storage) which TruffleRuby < 34.0.0 does not implement

data/lib/git/commands/arguments.rb

@@ -2399,11 +2399,11 @@ module Git
           build_option(args, entry[:name], @option_definitions[entry[:name]], normalized_opts[entry[:name]])
         when :operand
           build_single_positional(args, entry[:name], allocated_positionals)
-        # :nocov: this case should be unreachable
+        # simplecov:disable this case should be unreachable
         else
           raise ArgumentError, "unknown entry kind: #{entry[:kind].inspect}"
         end
-        # :nocov:
+        # simplecov:enable
       end
 
       # Replace the END_OF_OPTIONS_MARKER with the stored `as:` value if any element

data/lib/git/commands/remote/remove.rb

@@ -13,9 +13,9 @@ module Git
       #   remove = Git::Commands::Remote::Remove.new(execution_context)
       #   remove.call('origin')
       #
-      # @example Remove a remote with a name that looks like a flag
-      #   remove = Git::Commands::Remote::Remove.new(execution_context)
-      #   remove.call('-weirdremote')
+      # @note No `end_of_options` boundary: `git remote remove` did not accept a `--`
+      #   separator until git 2.38.0, so a name that looks like a flag (e.g. `-weird`)
+      #   raises `ArgumentError` instead of being sent to git.
       #
       # @note `arguments` block audited against https://git-scm.com/docs/git-remote/2.53.0
       #
@@ -30,8 +30,6 @@ module Git
           literal 'remote'
           literal 'remove'
 
-          end_of_options
-
           operand :name, required: true
         end
 

data/lib/git/commands/remote/rename.rb

@@ -22,6 +22,13 @@ module Git
       #   rename = Git::Commands::Remote::Rename.new(execution_context)
       #   rename.call('origin', 'upstream', no_progress: true)
       #
+      # @note No `end_of_options` boundary despite `:progress` preceding the operands:
+      #   `git remote rename` did not accept a `--` separator until git 2.36.0. Since
+      #   the `old`/`new` operands are still validated (an operand is rejected as
+      #   option-like whenever no `--` boundary exists anywhere in the definition),
+      #   a name that looks like a flag (e.g. `-weird`) raises `ArgumentError` instead
+      #   of ever reaching git, so omitting the boundary introduces no ambiguity.
+      #
       # @note `arguments` block audited against https://git-scm.com/docs/git-remote/2.53.0
       #
       # @see Git::Commands::Remote
@@ -36,8 +43,6 @@ module Git
           literal 'rename'
           flag_option :progress, negatable: true
 
-          end_of_options
-
           operand :old, required: true
           operand :new, required: true
         end