git 4.4.0 → 4.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98b554ddb65a29cb16fc266ea5466c2919c312f5021729ec3719ded044a53a91
-  data.tar.gz: c98533fda6126f92b5deba44d7ed38878e537fcbd02508702c5f8d1d99d26355
+  metadata.gz: 7a068310fe357011fc394084d24264d30f7130dfea211dfc6a2ba5aff40d4c93
+  data.tar.gz: 7bd159311bc13ff18518828bbd9ea43da0435d3d1e13fc0762da69540f163c6a
 SHA512:
-  metadata.gz: 529bc860265d31541e62381dd7e551405e74cf494da695e740578d0e9c5409ea9151f823a44ad6d089f74d533787fd02f1ed9ca6030656a82ffb72a1936fbef0
-  data.tar.gz: 3131c1f4ae9e9fb177d6120a6f460e40ed7e592045718e733f861f4289dc4e6668e04eb8f8ab2c2b8fc73c299327817a89ae66f28369382c7856c2ec3d1853d1
+  metadata.gz: c2b616a55aac28d2c32097a2cdd14ee8f435ddba1c611393e053841f60deb3af30fd941673af433966378325a91feb280226bf511e67836b95895dfff2505dd9
+  data.tar.gz: 6a3c14186bc35d50905892ac333c0c3a7431199c670eaaa1101b56c60344a3fb01ff3f7ca2b7e35f14a7d4e1bb2701bd55c8a0050c58ebbcb5eafd82c3d0495b

data/.github/workflows/continuous_integration.yml

@@ -53,3 +53,68 @@ jobs:
 
       - name: Test Gem
         run: bundle exec rake test:gem
+
+  # The branch ruleset cannot require the matrix job above directly. A required status
+  # check is matched by name, and `build`'s name is a template -- GitHub only expands it
+  # into "Ruby 3.2 on ubuntu-latest" and friends when it evaluates the matrix. The
+  # job-level `if:` short-circuits before that happens, so a release PR reports one check
+  # named literally "Ruby ${{ matrix.ruby }} on ${{ matrix.operating-system }}" and the
+  # six expanded names never report at all. Required checks that never report block a PR
+  # indefinitely rather than passing, which is what stranded the v5.0.5 release PR on
+  # main and the v4.4.1 release PR here.
+  #
+  # So the ruleset requires this job instead: one stable name, no matrix, no template to
+  # expand. It also decouples the required-check list from the matrix, so adding or
+  # dropping a Ruby version no longer needs a matching ruleset edit.
+  #
+  # Unlike main, this branch has no separate lint job: `rake default` runs RuboCop and
+  # YARD inside every matrix leg, so this one check covers everything CI does here.
+  #
+  # This job carries the same release-PR guard as the matrix above, so that a release PR
+  # reports it as skipped rather than as a success for specs that never ran. Skipping is
+  # safe here and was not safe for `build`: this job's name is a literal string, so the
+  # check run exists and reports a skipped conclusion whether or not the job runs, and
+  # rulesets treat skipped as passing. A matrix job's name does not exist at all until the
+  # matrix is evaluated, which is the whole reason this job exists.
+  #
+  # `always()` is load-bearing and must stay. Without a status check function a job-level
+  # `if:` implies `success()`, so a failing matrix would skip this job -- and a skipped
+  # required check counts as passing, meaning a red build would merge. `always()` forces a
+  # real verdict on every run that is not a release PR. `!cancelled()` is not a substitute:
+  # a cancelled run would then skip the gate, and a skipped conclusion is one rulesets treat
+  # as passing -- so a build that never finished would stop blocking the merge.
+  #
+  # The case below accepts `success` only. `build` and this job now carry the same release-PR
+  # guard, so this job runs exactly when `build` ran; a `skipped` result would mean the two
+  # guards have drifted apart, and failing closed on it turns that into a loud failure rather
+  # than a silent pass.
+  #
+  # Note that a matrix leg marked `experimental: Yes` carries continue-on-error, and a
+  # continue-on-error failure does not fail the job as a whole -- so it does not fail this
+  # gate either. That is what `experimental` is for; no leg currently sets it.
+  build-complete:
+    name: All Specs Passed
+
+    needs: [build]
+
+    # Report a verdict on every non-release PR regardless of the matrix result, and skip
+    # on release PRs, where the matrix was never meant to run.
+    if: >-
+      always() &&
+      (github.event_name == 'workflow_dispatch' ||
+      (github.event_name == 'pull_request' && !startsWith(github.event.pull_request.head.ref, 'release-please--')))
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check the result of the build job
+        run: |
+          case "${{ needs.build.result }}" in
+            success)
+              echo "build: ${{ needs.build.result }}"
+              ;;
+            *)
+              echo "::error::build: ${{ needs.build.result }}"
+              exit 1
+              ;;
+          esac

data/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "4.4.0"
+  ".": "4.4.2"
 }

data/CHANGELOG.md

@@ -5,6 +5,26 @@
 
 # Change Log
 
+## [4.4.2](https://github.com/ruby-git/ruby-git/compare/v4.4.1...v4.4.2) (2026-08-19)
+
+
+### Bug Fixes
+
+* Run the Git.open bootstrap commands without redirecting stdin ([65de0fe](https://github.com/ruby-git/ruby-git/commit/65de0fe88bca34ad3de366ee9a212653de37fc6d)), closes [#840](https://github.com/ruby-git/ruby-git/issues/840)
+
+## [4.4.1](https://github.com/ruby-git/ruby-git/compare/v4.4.0...v4.4.1) (2026-08-09)
+
+
+### Bug Fixes
+
+* Pin LC_ALL to a locale that exists on the host platform ([690360e](https://github.com/ruby-git/ruby-git/commit/690360e386bac1dafb7b5bd0adbf10072e834f69)), closes [#1669](https://github.com/ruby-git/ruby-git/issues/1669)
+
+
+### Other Changes
+
+* Add a matrix-free All Specs Passed gate to 4.x ([5352d6d](https://github.com/ruby-git/ruby-git/commit/5352d6d4edfcb52c544139e265fb3636bc1937b7)), closes [#1675](https://github.com/ruby-git/ruby-git/issues/1675)
+* Skip the All Specs Passed gate on release PRs ([52473b2](https://github.com/ruby-git/ruby-git/commit/52473b21a733499eb274a7b03d53f1a0efbf5c86)), closes [#1675](https://github.com/ruby-git/ruby-git/issues/1675)
+
 ## [4.4.0](https://github.com/ruby-git/ruby-git/compare/v4.3.2...v4.4.0) (2026-07-11)
 
 

data/lib/git/base.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'logger'
-require 'open3'
 
 module Git
   # The main public interface for interacting with Git commands
@@ -41,21 +40,14 @@ module Git
     end
 
     def self.binary_version(binary_path)
-      result, status = execute_git_version(binary_path)
-
-      raise "Failed to get git version: #{status}\n#{result}" unless status.success?
-
-      parse_version_string(result)
+      parse_version_string(execute_git_version(binary_path))
     end
 
     private_class_method def self.execute_git_version(binary_path)
-      Open3.capture2e(
-        binary_path,
-        '-c', 'core.quotePath=true',
-        '-c', 'color.ui=false',
-        'version'
-      )
-    rescue Errno::ENOENT
+      bootstrap_command_line(binary_path).run('version', merge: true).stdout
+    rescue Git::CommandLineError => e
+      raise "Failed to get git version: #{e.result.status}\n#{e.result.stdout}"
+    rescue Errno::ENOENT, ProcessExecuter::SpawnError
       raise "Failed to get git version: #{binary_path} not found"
     end
 
@@ -98,26 +90,45 @@ module Git
     def self.root_of_worktree(working_dir)
       raise ArgumentError, "'#{working_dir}' does not exist" unless Dir.exist?(working_dir)
 
-      result, status = execute_rev_parse_toplevel(working_dir)
-      process_rev_parse_result(result, status, working_dir)
+      execute_rev_parse_toplevel(working_dir)
     end
 
     private_class_method def self.execute_rev_parse_toplevel(working_dir)
-      Open3.capture2e(
-        Git::Base.config.binary_path,
-        '-c', 'core.quotePath=true',
-        '-c', 'color.ui=false',
-        'rev-parse', '--show-toplevel',
-        chdir: File.expand_path(working_dir)
-      )
-    rescue Errno::ENOENT
+      bootstrap_command_line(Git::Base.config.binary_path).run(
+        'rev-parse', '--show-toplevel', chdir: File.expand_path(working_dir), merge: true, chomp: true
+      ).stdout
+    rescue Git::CommandLineError
+      raise ArgumentError, "'#{working_dir}' is not in a git working tree"
+    rescue Errno::ENOENT, ProcessExecuter::SpawnError
       raise ArgumentError, 'Failed to find the root of the worktree: git binary not found'
     end
 
-    private_class_method def self.process_rev_parse_result(result, status, working_dir)
-      raise ArgumentError, "'#{working_dir}' is not in a git working tree" unless status.success?
-
-      result.chomp
+    # A command line for the git commands that run before a repository is known
+    #
+    # `Open3` is deliberately not used here. Windows has no fork, so
+    # `Process.spawn` implements a redirect of the child's stdin by redirecting
+    # the *parent's* stdin and restoring it afterward, which replaces the
+    # process's stdin handle. That leaves a console REPL such as irb or pry
+    # unable to read input for the rest of the session. `Git::CommandLine`
+    # redirects only stdout and stderr, so stdin is never disturbed.
+    #
+    # @see https://github.com/ruby-git/ruby-git/issues/840 issue 840
+    #
+    # @param binary_path [String] the path to the git binary to run
+    #
+    # @return [Git::CommandLine] a command line that runs `binary_path` with
+    #   `-c core.quotePath=true -c color.ui=false`
+    #
+    #   Those are the options the `Open3` calls this replaced passed, kept as they were
+    #   so these two commands behave exactly as before. Neither `git version` nor
+    #   `git rev-parse --show-toplevel` emits colored output, so the remaining `color.*`
+    #   settings in {Git::Lib}'s `STATIC_GLOBAL_OPTS` are not needed here.
+    #
+    # @api private
+    #
+    private_class_method def self.bootstrap_command_line(binary_path)
+      Git::CommandLine.new({}, binary_path, ['-c', 'core.quotePath=true', '-c', 'color.ui=false'],
+                           Logger.new(nil))
     end
 
     # (see Git.open)

data/lib/git/lib.rb

@@ -11,7 +11,6 @@ require 'process_executer'
 require 'stringio'
 require 'tempfile'
 require 'zlib'
-require 'open3'
 
 module Git
   # Internal git operations
@@ -2075,7 +2074,7 @@ module Git
     # @example Unsetting an environment variable (used by worktree_command_line)
     #   env_overrides('GIT_INDEX_FILE' => nil)
     #   # => { 'GIT_DIR' => '/path/to/.git', 'GIT_WORK_TREE' => '/path/to/worktree',
-    #   #      'GIT_INDEX_FILE' => nil, 'GIT_SSH' => <git_ssh_value>, 'LC_ALL' => 'en_US.UTF-8' }
+    #   #      'GIT_INDEX_FILE' => nil, 'GIT_SSH' => <git_ssh_value>, 'LC_ALL' => <pinned_locale> }
     #   # When passed to Process.spawn, GIT_INDEX_FILE will be unset in the environment
     #
     # @see https://ruby-doc.org/core/Process.html#method-c-spawn Process.spawn
@@ -2088,10 +2087,67 @@ module Git
         'GIT_WORK_TREE' => @git_work_dir,
         'GIT_INDEX_FILE' => @git_index_file,
         'GIT_SSH' => resolved_git_ssh,
-        'LC_ALL' => 'en_US.UTF-8'
+        # Pin the locale so git's behavior does not depend on the user's environment.
+        # Added for issue #753, where a German user's `git branch` output
+        # ("* (HEAD losgelöst bei origin/25.1)") broke branch parsing.
+        #
+        # The pin has two halves, and both are load-bearing here:
+        #
+        # - Messages: keeps git's human-readable text in English. `BRANCH_LINE_REGEXP`
+        #   matches the literal English strings "(HEAD detached at ...)" and
+        #   "(not a branch)" in `git branch -a` output, which is the exact issue #753
+        #   failure mode.
+        # - Ctype: makes git's regex engine match *characters* rather than *bytes*.
+        #   Under a C ctype, `grep` and `log --grep` silently return wrong answers —
+        #   with exit status zero — for any pattern whose metacharacters span
+        #   non-ASCII text.
+        #
+        # So do not "simplify" this to `C`: that yields English messages and a broken
+        # ctype, which is the worst of both. A pinned locale the host does not have
+        # degrades to that same C ctype, which is why each branch below has to name a
+        # locale that actually exists on the platform it applies to:
+        #
+        # - Non-Darwin: `C.UTF-8`. Stock Debian, Ubuntu, and RHEL images generate no
+        #   `en_US.UTF-8`, so pinning it there produced exactly the silent breakage
+        #   above. (musl ignores the locale name for ctype, so Alpine is UTF-8 either
+        #   way.)
+        # - Darwin: `en_US.UTF-8`, which every macOS release ships. `C.UTF-8` did not
+        #   arrive until macOS 15, so macOS 11–14 — including Intel Macs that are
+        #   hardware-capped below 15 — would break under it. Delete this branch once
+        #   macOS 14 and earlier are out of support.
+        #
+        # Windows takes the non-Darwin branch, where the value makes no difference:
+        # Git for Windows folds case and runs PCRE in UTF mode under every value, and
+        # matches bytes for `.` and POSIX classes under every value — measured on git
+        # 2.55.0 against `en_US.UTF-8`, `C.UTF-8`, `C`, and no pin at all.
+        #
+        # RHEL 7 (glibc 2.17) has neither locale and gets a C ctype whatever is pinned.
+        # It is EOL, and there is deliberately no public override for this value.
+        'LC_ALL' => darwin_platform? ? 'en_US.UTF-8' : 'C.UTF-8'
       }.merge(additional_overrides)
     end
 
+    # Whether this process is running on macOS
+    #
+    # Checks `RUBY_DESCRIPTION` as well as `RUBY_PLATFORM` because JRuby reports
+    # `RUBY_PLATFORM` as `"java"` on every host and records the real platform only in
+    # `RUBY_DESCRIPTION` (as, for example, `"... [arm64-darwin]"`). Testing
+    # `RUBY_PLATFORM` alone would put JRuby on macOS onto the non-Darwin branch, which is
+    # the one platform pairing that branch must not be given. This is the same detection
+    # the test suite uses for Windows, and for the same reason.
+    #
+    # Test the platform plainly rather than sniffing the Darwin version: `RUBY_PLATFORM`
+    # records the version Ruby was *built* against, so a Ruby built on macOS 14 still
+    # reports `darwin23` when run on macOS 15.
+    #
+    # @return [Boolean] true if this process is running on macOS
+    #
+    # @api private
+    #
+    def darwin_platform?
+      RUBY_PLATFORM.include?('darwin') || RUBY_DESCRIPTION.include?('darwin')
+    end
+
     # Resolve the git_ssh value to use for this instance
     #
     # @return [String, nil] the resolved git_ssh value

data/lib/git/version.rb

@@ -3,5 +3,5 @@
 module Git
   # The current gem version
   # @return [String] the current gem version.
-  VERSION = '4.4.0'
+  VERSION = '4.4.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.4.2
 platform: ruby
 authors:
 - Scott Chacon and others
@@ -310,8 +310,8 @@ licenses:
 metadata:
   homepage_uri: http://github.com/ruby-git/ruby-git
   source_code_uri: http://github.com/ruby-git/ruby-git
-  changelog_uri: https://rubydoc.info/gems/git/4.4.0/file/CHANGELOG.md
-  documentation_uri: https://rubydoc.info/gems/git/4.4.0
+  changelog_uri: https://rubydoc.info/gems/git/4.4.2/file/CHANGELOG.md
+  documentation_uri: https://rubydoc.info/gems/git/4.4.2
   rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
@@ -328,7 +328,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - git 2.28.0 or greater
-rubygems_version: 4.0.10
+rubygems_version: 4.0.16
 specification_version: 4
 summary: An API to create, read, and manipulate Git repositories
 test_files: []