git 4.0.1 → 4.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 800cd24ccf9ac35997240caf75df510839ecc7fb6a7e810b518d8a68a19a9251
-  data.tar.gz: 50ac76f678bf832e9eea55c027d9ad6f98514880c7673b58a5602c85c34a080e
+  metadata.gz: 53b8b74b8c2b17a44030a715fa6d562e989189b2c2b1b6a3195d349ed4cab439
+  data.tar.gz: 504029d354e4def312a520cc93ed0ac5857d02093405f776897d50c7f979ffb7
 SHA512:
-  metadata.gz: 5e37d72ec1ebeea3d7eb784f6779e98288be086ac86941db67c0357b8902719218302449b69a5718d68da805f3bd8b19ddf21040766528724bc416e012bcc55b
-  data.tar.gz: 6402c06932c7d51f1a5ba6022464589be335c22539de31e5570e4ba22d54b76a2b7055edbe5d518c0377763837495f2005e83c91bbac360d752d724238a0d9c2
+  metadata.gz: 29db48811be6a98b1096bfab4f5347aac762fcc03b9e232246cfb17e574f32a8d5c9d8444e32c242c1b7a30a777cd89b1498d58a7a7fde0c313bfd045f6a8b72
+  data.tar.gz: a9d24b3d5aca3a7f63856ce74808d562626992c7c023f51bb01f6167cc1b9ed425ba57ad0aecce0d3c4f77fec5138efbe5a502d512dfcc26bccf6e6004969137

data/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "4.0.1"
+  ".": "4.0.4"
 }

data/CHANGELOG.md

@@ -5,6 +5,52 @@
 
 # Change Log
 
+## [4.0.4](https://github.com/ruby-git/ruby-git/compare/v4.0.3...v4.0.4) (2025-07-09)
+
+
+### Bug Fixes
+
+* Remove deprecation from Git::Path ([ab1e207](https://github.com/ruby-git/ruby-git/commit/ab1e20773c6a300b546841f79adf8dd6e707250e))
+* Remove deprecation from Git::Stash ([9da1e91](https://github.com/ruby-git/ruby-git/commit/9da1e9112e38c0e964dd2bc638bda7aebe45ba91))
+
+
+### Other Changes
+
+* Add tests for Git::Base#set_index including deprecation ([e6ccb11](https://github.com/ruby-git/ruby-git/commit/e6ccb11830a794f12235e47032235c3284c84cf6))
+* Add tests for Git::Base#set_working including deprecation ([ee11137](https://github.com/ruby-git/ruby-git/commit/ee1113706a8e34e9631f0e2d89bd602bca87f05f))
+* Add tests to verify Git::Object.new creates the right type of object ([ab17621](https://github.com/ruby-git/ruby-git/commit/ab17621d65a02b70844fde3127c9cbb219add7f5))
+* Verify deprecated Git::Log methods emit a deprecation warning ([abb0efb](https://github.com/ruby-git/ruby-git/commit/abb0efbdb3b6bb49352d097b1fece708477d4362))
+
+## [4.0.3](https://github.com/ruby-git/ruby-git/compare/v4.0.2...v4.0.3) (2025-07-08)
+
+
+### Bug Fixes
+
+* Correct the deprecation horizon for Git deprecations ([b7b7f38](https://github.com/ruby-git/ruby-git/commit/b7b7f38ccb88ba719e8ea7cb3fea14474b19a00c))
+* Fix Rubocop Layout/EmptyLinesAroundClassBody offense ([1de27da](https://github.com/ruby-git/ruby-git/commit/1de27daabed18b47a42539fe69b735d8ee90cbbb))
+* Internally create a Stash with non-deprecated initializer args ([8b9b9e2](https://github.com/ruby-git/ruby-git/commit/8b9b9e2f3b3fa525973785f642331317ade35936))
+* Report correct line number in deprecation warnings ([cca0deb](https://github.com/ruby-git/ruby-git/commit/cca0debb4166c809af76f9dc586e4fd06e142d44))
+* Un-deprecate Git::Diff methods ([761b6ff](https://github.com/ruby-git/ruby-git/commit/761b6ffcd363f4329a9cbafbf1379513a19ff174))
+
+
+### Other Changes
+
+* Make tests that emit a deprecation warning fail ([7e211d7](https://github.com/ruby-git/ruby-git/commit/7e211d7b2b7cc8d9da4a860361bef52280a5e73b))
+* Update all tests to not use deprecated features ([33ab0e2](https://github.com/ruby-git/ruby-git/commit/33ab0e255e229e22d84b14a4d4f5fb829c1fe37c))
+
+## [4.0.2](https://github.com/ruby-git/ruby-git/compare/v4.0.1...v4.0.2) (2025-07-08)
+
+
+### Bug Fixes
+
+* Call Git::Index#new correctly from initialize_components ([07dfab5](https://github.com/ruby-git/ruby-git/commit/07dfab5804874cbc52469bd40203b6d0b08be7a1))
+
+
+### Other Changes
+
+* Announce that the project has adopted RuboCop ([3d6cac9](https://github.com/ruby-git/ruby-git/commit/3d6cac94b47b3c1b1915f5c37f9e811041210ddc))
+* Update comment to be accurate ([3a87722](https://github.com/ruby-git/ruby-git/commit/3a87722760176db54dfef9631de6191b183ab223))
+
 ## [4.0.1](https://github.com/ruby-git/ruby-git/compare/v4.0.0...v4.0.1) (2025-07-06)
 
 

data/README.md

@@ -11,6 +11,7 @@
 [![Build Status](https://github.com/ruby-git/ruby-git/workflows/CI/badge.svg?branch=main)](https://github.com/ruby-git/ruby-git/actions?query=workflow%3ACI)
 [![Conventional Commits](https://img.shields.io/badge/Conventional%20Commits-1.0.0-%23FE5196?logo=conventionalcommits&logoColor=white)](https://conventionalcommits.org)
 
+- [📢 We Now Use RuboCop 📢](#-we-now-use-rubocop-)
 - [📢 Default Branch Rename 📢](#-default-branch-rename-)
 - [📢 We've Switched to Conventional Commits 📢](#-weve-switched-to-conventional-commits-)
 - [Summary](#summary)
@@ -23,6 +24,30 @@
 - [Ruby version support policy](#ruby-version-support-policy)
 - [License](#license)
 
+## 📢 We Now Use RuboCop 📢
+
+To improve code consistency and maintainability, the `ruby-git` project has now
+adopted [RuboCop](https://rubocop.org/) as our static code analyzer and formatter.
+
+This integration is a key part of our ongoing commitment to making `ruby-git` a
+high-quality, stable, and easy-to-contribute-to project. All new contributions will
+be expected to adhere to the style guidelines enforced by our RuboCop configuration.
+
+ RuboCop can be run from the project's Rakefile:
+
+```shell
+rake rubocop
+```
+
+RuboCop is also run  as part of the default rake task (by running `rake`) that is run
+in our Continuous Integration workflow.
+
+Going forward, any PRs that have any Robocop offenses will not be merged. In
+certain rare cases, it might be acceptable to disable a  RuboCop check for the most
+limited scope possible.
+
+If you have a problem fixing a  RuboCop offense, don't be afraid to ask a contributor.
+
 ## 📢 Default Branch Rename 📢
 
 On June 6th, 2025, the default branch was renamed from 'master' to 'main'.

data/Rakefile

@@ -14,9 +14,9 @@ task :test do
   # You can run individual test files (or multiple files) from the command
   # line with:
   #
-  # $ bin/test tests/units/test_archive.rb
+  # $ bin/test test_archive.rb
   #
-  # $ bin/test tests/units/test_archive.rb tests/units/test_object.rb
+  # $ bin/test test_archive.rb test_object.rb
 end
 default_tasks << :test
 

data/lib/git/base.rb

@@ -851,7 +851,7 @@ module Git
     def initialize_components(options)
       @working_directory = Git::WorkingDirectory.new(options[:working_directory]) if options[:working_directory]
       @repository = Git::Repository.new(options[:repository]) if options[:repository]
-      @index = Git::Index.new(options[:index], false) if options[:index]
+      @index = Git::Index.new(options[:index], must_exist: false) if options[:index]
     end
 
     # Normalize options before they are sent to Git::Base.new

data/lib/git/diff.rb

@@ -38,38 +38,31 @@ module Git
       @full_diff_files.map { |file| file[1] }.each(&)
     end
 
+    def size
+      stats_provider.total[:files]
+    end
+
     #
     # DEPRECATED METHODS
     #
 
     def name_status
-      Git::Deprecation.warn('Git::Diff#name_status is deprecated. Use Git::Base#diff_path_status instead.')
       path_status_provider.to_h
     end
 
-    def size
-      Git::Deprecation.warn('Git::Diff#size is deprecated. Use Git::Base#diff_stats(...).total[:files] instead.')
-      stats_provider.total[:files]
-    end
-
     def lines
-      Git::Deprecation.warn('Git::Diff#lines is deprecated. Use Git::Base#diff_stats(...).lines instead.')
       stats_provider.lines
     end
 
     def deletions
-      Git::Deprecation.warn('Git::Diff#deletions is deprecated. Use Git::Base#diff_stats(...).deletions instead.')
       stats_provider.deletions
     end
 
     def insertions
-      Git::Deprecation.warn('Git::Diff#insertions is deprecated. Use Git::Base#diff_stats(...).insertions instead.')
       stats_provider.insertions
     end
 
     def stats
-      Git::Deprecation.warn('Git::Diff#stats is deprecated. Use Git::Base#diff_stats instead.')
-      # CORRECTED: Re-create the original hash structure for backward compatibility
       {
         files: stats_provider.files,
         total: stats_provider.total

data/lib/git/log.rb

@@ -90,28 +90,56 @@ module Git
 
     # @deprecated Use {#execute} and call `each` on the result.
     def each(&)
-      deprecate_and_run
+      Git::Deprecation.warn(
+        'Calling Git::Log#each is deprecated. Call #execute and then #each on the result object.'
+      )
+      run_log_if_dirty
       @commits.each(&)
     end
 
     # @deprecated Use {#execute} and call `size` on the result.
     def size
-      deprecate_and_run
+      Git::Deprecation.warn(
+        'Calling Git::Log#size is deprecated. Call #execute and then #size on the result object.'
+      )
+      run_log_if_dirty
       @commits&.size
     end
 
     # @deprecated Use {#execute} and call `to_s` on the result.
     def to_s
-      deprecate_and_run
+      Git::Deprecation.warn(
+        'Calling Git::Log#to_s is deprecated. Call #execute and then #to_s on the result object.'
+      )
+      run_log_if_dirty
       @commits&.map(&:to_s)&.join("\n")
     end
 
     # @deprecated Use {#execute} and call the method on the result.
-    %i[first last []].each do |method_name|
-      define_method(method_name) do |*args|
-        deprecate_and_run
-        @commits&.public_send(method_name, *args)
-      end
+    def first
+      Git::Deprecation.warn(
+        'Calling Git::Log#first is deprecated. Call #execute and then #first on the result object.'
+      )
+      run_log_if_dirty
+      @commits&.first
+    end
+
+    # @deprecated Use {#execute} and call the method on the result.
+    def last
+      Git::Deprecation.warn(
+        'Calling Git::Log#last is deprecated. Call #execute and then #last on the result object.'
+      )
+      run_log_if_dirty
+      @commits&.last
+    end
+
+    # @deprecated Use {#execute} and call the method on the result.
+    def [](index)
+      Git::Deprecation.warn(
+        'Calling Git::Log#[] is deprecated. Call #execute and then #[] on the result object.'
+      )
+      run_log_if_dirty
+      @commits&.[](index)
     end
 
     # @!endgroup
@@ -131,13 +159,5 @@ module Git
       @commits = log_data.map { |c| Git::Object::Commit.new(@base, c['sha'], c) }
       @dirty = false
     end
-
-    def deprecate_and_run(method = caller_locations(1, 1)[0].label)
-      Git::Deprecation.warn(
-        "Calling Git::Log##{method} is deprecated. " \
-        "Call #execute and then ##{method} on the result object."
-      )
-      run_log_if_dirty
-    end
   end
 end

data/lib/git/path.rb

@@ -9,17 +9,7 @@ module Git
   class Path
     attr_accessor :path
 
-    def initialize(path, check_path = nil, must_exist: nil)
-      unless check_path.nil?
-        Git::Deprecation.warn(
-          'The "check_path" argument is deprecated and ' \
-          'will be removed in a future version. Use "must_exist:" instead.'
-        )
-      end
-
-      # default is true
-      must_exist = must_exist.nil? && check_path.nil? ? true : must_exist || check_path
-
+    def initialize(path, must_exist: true)
       path = File.expand_path(path)
 
       raise ArgumentError, 'path does not exist', [path] if must_exist && !File.exist?(path)

data/lib/git/stash.rb

@@ -3,16 +3,7 @@
 module Git
   # A stash in a Git repository
   class Stash
-    def initialize(base, message, existing = nil, save: nil)
-      unless existing.nil?
-        Git::Deprecation.warn(
-          'The "existing" argument is deprecated and will be removed in a future version. Use "save:" instead.'
-        )
-      end
-
-      # default is false
-      save = existing.nil? && save.nil? ? false : save | existing
-
+    def initialize(base, message, save: false)
       @base = base
       @message = message
       self.save unless save

data/lib/git/stashes.rb

@@ -12,7 +12,7 @@ module Git
 
       @base.lib.stashes_all.each do |indexed_message|
         _index, message = indexed_message
-        @stashes.unshift(Git::Stash.new(@base, message, true))
+        @stashes.unshift(Git::Stash.new(@base, message, save: true))
       end
     end
 

data/lib/git/version.rb

@@ -3,5 +3,5 @@
 module Git
   # The current gem version
   # @return [String] the current gem version.
-  VERSION = '4.0.1'
+  VERSION = '4.0.4'
 end

data/lib/git.rb

@@ -4,7 +4,7 @@ require 'active_support'
 require 'active_support/deprecation'
 
 module Git
-  Deprecation = ActiveSupport::Deprecation.new('3.0', 'Git')
+  Deprecation = ActiveSupport::Deprecation.new('5.0.0', 'Git')
 end
 
 require 'git/author'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.0.4
 platform: ruby
 authors:
 - Scott Chacon and others
@@ -281,8 +281,8 @@ licenses:
 metadata:
   homepage_uri: http://github.com/ruby-git/ruby-git
   source_code_uri: http://github.com/ruby-git/ruby-git
-  changelog_uri: https://rubydoc.info/gems/git/4.0.1/file/CHANGELOG.md
-  documentation_uri: https://rubydoc.info/gems/git/4.0.1
+  changelog_uri: https://rubydoc.info/gems/git/4.0.4/file/CHANGELOG.md
+  documentation_uri: https://rubydoc.info/gems/git/4.0.4
   rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths: