git 2.3.2 → 2.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4c3080ee5b1fd4b591abe1e3e94917ea4307c97a3cf75f93cbc910e5320142b
-  data.tar.gz: 1b5a4682825b282577918929d21967846191fdcf16a8dc3c72de71820fee74f9
+  metadata.gz: 5bc80ed5447f019e983721b8d5b9658be3acda92512312f81d9cad47d7b751e1
+  data.tar.gz: 3cfb80132b7dc28a0e10f7513e688bf8b43bc0786460cdfc93d00ce547533e83
 SHA512:
-  metadata.gz: 57434c5742779e9769f3a6ce85a5b25c5f3c4e5974427965bca0df4922a266ffb3225839ccf2964f2391d5b8c7eda68de4aa1d46bbbd264b6d5c53a2c7852f77
-  data.tar.gz: 6c1a1bc6010f883eb8b0d4ccd677a5f46c98db9f3f9e582b8c06f6b4294903c1949fe288fe2ae2c17c41ae9e5319fdc9fc64870e5f3f1219b03351a22f475d4c
+  metadata.gz: 86e89789bc17358bf813f46896bb509491b8db027104d440c0a3e8f7bb7716da0c76d6a264a589e188a1e7d5331c833d5b161536a6bd6dccf44ef3df64b6c780
+  data.tar.gz: 8e54f34cb83b0d3027870b1eea35eb23896cd572fc23c167655fb308e15e19ac3a24f7c7c5173fdb734aacfe410516d2bf2793baf4660b443a049a3259176cf0

data/CHANGELOG.md

@@ -5,6 +5,16 @@
 
 # Change Log
 
+## v2.3.3 (2024-12-04)
+
+[Full Changelog](https://github.com/ruby-git/ruby-git/compare/v2.3.2..v2.3.3)
+
+Changes since v2.3.2:
+
+* c25e5e0 test: add tests for spaces in the git binary path or the working dir
+* 5f43a1a fix: open3 errors on binary paths with spaces
+* 60b58ba test: add #run_command for tests to use instead of backticks
+
 ## v2.3.2 (2024-11-19)
 
 [Full Changelog](https://github.com/ruby-git/ruby-git/compare/v2.3.1..v2.3.2)

data/lib/git/base.rb

@@ -37,9 +37,15 @@ module Git
     end
 
     def self.binary_version(binary_path)
-      git_cmd = "#{binary_path} -c core.quotePath=true -c color.ui=false version 2>&1"
-      result, status = Open3.capture2(git_cmd)
-      result = result.chomp
+      result = nil
+      status = nil
+
+      begin
+        result, status = Open3.capture2e(binary_path, "-c", "core.quotePath=true", "-c", "color.ui=false", "version")
+        result = result.chomp
+      rescue Errno::ENOENT
+        raise RuntimeError, "Failed to get git version: #{binary_path} not found"
+      end
 
       if status.success?
         version = result[/\d+(\.\d+)+/]
@@ -81,9 +87,14 @@ module Git
       result = working_dir
       status = nil
 
-      git_cmd = "#{Git::Base.config.binary_path} -c core.quotePath=true -c color.ui=false rev-parse --show-toplevel 2>&1"
-      result, status = Open3.capture2(git_cmd, chdir: File.expand_path(working_dir))
-      result = result.chomp
+      raise ArgumentError, "'#{working_dir}' does not exist" unless Dir.exist?(working_dir)
+
+      begin
+        result, status = Open3.capture2e(Git::Base.config.binary_path, "-c", "core.quotePath=true", "-c", "color.ui=false", "rev-parse", "--show-toplevel", chdir: File.expand_path(working_dir))
+        result = result.chomp
+      rescue Errno::ENOENT
+        raise ArgumentError, "Failed to find the root of the worktree: git binary not found"
+      end
 
       raise ArgumentError, "'#{working_dir}' is not in a git working tree" unless status.success?
       result

data/lib/git/version.rb

@@ -1,5 +1,5 @@
 module Git
   # The current gem version
   # @return [String] the current gem version.
-  VERSION='2.3.2'
+  VERSION='2.3.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: git
 version: !ruby/object:Gem::Version
-  version: 2.3.2
+  version: 2.3.3
 platform: ruby
 authors:
 - Scott Chacon and others
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-19 00:00:00.000000000 Z
+date: 2024-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -243,8 +243,8 @@ licenses:
 metadata:
   homepage_uri: http://github.com/ruby-git/ruby-git
   source_code_uri: http://github.com/ruby-git/ruby-git
-  changelog_uri: https://rubydoc.info/gems/git/2.3.2/file/CHANGELOG.md
-  documentation_uri: https://rubydoc.info/gems/git/2.3.2
+  changelog_uri: https://rubydoc.info/gems/git/2.3.3/file/CHANGELOG.md
+  documentation_uri: https://rubydoc.info/gems/git/2.3.3
 post_install_message:
 rdoc_options: []
 require_paths: