git-trend 1.3.0 → 1.4.1

data/spec/git_trend/cli_spec.rb

@@ -1,5 +1,5 @@
-# rubocop:disable Style/TrailingWhitespace
-include GitTrend
+require "git_trend/scraper"
+
 RSpec.describe GitTrend::CLI do
   shared_examples "since daily ranking" do |since|
     it "display daily ranking" do
@@ -20,28 +20,32 @@ RSpec.describe GitTrend::CLI do
   end
 
   describe "#list" do
-    let(:cli) { CLI.new }
+    let(:cli) { described_class.new }
 
     describe "with -n option" do
       context "with 3" do
         before { stub_request_get("trending") }
+
         let(:number) { 3 }
+
         it "display top 3 daily ranking" do
-          res = <<-'EOS'.unindent
+          res = <<-OUTPUT.unindent
             |No. Name                                     Lang               Star
             |--- ---------------------------------------- ---------------- ------
             |  1 linexjlin/GPTs                                               445
             |  2 ml-explore/mlx-examples                  Python              161
             |  3 PRIS-CV/DemoFusion                       Jupyter Notebook    169
 
-          EOS
+          OUTPUT
           expect { cli.invoke(:list, [], number: number, description: false) }.to output(res).to_stdout
         end
       end
 
       context "with over 25" do
         before { stub_request_get("trending") }
+
         let(:number) { 26 }
+
         it "display daily ranking" do
           expect { cli.invoke(:list, [], number: number, description: false) }.to output(dummy_result_without_description).to_stdout
         end
@@ -51,10 +55,11 @@ RSpec.describe GitTrend::CLI do
     describe "with -l option" do
       context "with ruby" do
         before { stub_request_get("trending/#{language}") }
+
         let(:language) { "ruby" }
 
         it "display daily ranking by language" do
-          res = <<-'EOS'.unindent
+          res = <<-OUTPUT.unindent
             |No. Name                                     Lang         Star
             |--- ---------------------------------------- ---------- ------
             |  1 greatghoul/remote-working                Ruby           34
@@ -83,20 +88,21 @@ RSpec.describe GitTrend::CLI do
             | 24 chef/chef                                Ruby            0
             | 25 instructure/canvas-lms                   Ruby            0
 
-          EOS
+          OUTPUT
           expect { cli.invoke(:list, [], language: language, description: false) }.to output(res).to_stdout
         end
       end
 
       context "with alloy : when trending is nothing" do
         before { stub_request_get("trending/#{language}") }
+
         let(:language) { "alloy" }
 
         it "display the 0cases message" do
-          res = <<-'EOS'.unindent
+          res = <<-OUTPUT.unindent
             |It looks like we don’t have any trending repositories.
 
-          EOS
+          OUTPUT
           expect { cli.invoke(:list, [], language: language, description: false) }.to output(res).to_stdout
         end
       end
@@ -105,51 +111,55 @@ RSpec.describe GitTrend::CLI do
     describe "with -s option" do
       context "with no option" do
         before { stub_request_get("trending?since=") }
-        include_examples "since daily ranking", ""
+
+        it_behaves_like "since daily ranking", ""
       end
 
       describe "since daily" do
         before { stub_request_get("trending?since=daily") }
+
         context "with d" do
-          include_examples "since daily ranking", "d"
+          it_behaves_like "since daily ranking", "d"
         end
 
         context "with day" do
-          include_examples "since daily ranking", "day"
+          it_behaves_like "since daily ranking", "day"
         end
 
         context "with daily" do
-          include_examples "since daily ranking", "daily"
+          it_behaves_like "since daily ranking", "daily"
         end
       end
 
       describe "since weekly" do
         before { stub_request_get("trending?since=weekly") }
+
         context "with w" do
-          include_examples "since weekly ranking", "w"
+          it_behaves_like "since weekly ranking", "w"
         end
 
         context "with week" do
-          include_examples "since weekly ranking", "week"
+          it_behaves_like "since weekly ranking", "week"
         end
 
         context "with weekly" do
-          include_examples "since weekly ranking", "weekly"
+          it_behaves_like "since weekly ranking", "weekly"
         end
       end
 
       describe "since monthly" do
         before { stub_request_get("trending?since=monthly") }
+
         context "with m" do
-          include_examples "since monthly ranking", "m"
+          it_behaves_like "since monthly ranking", "m"
         end
 
         context "with month" do
-          include_examples "since monthly ranking", "month"
+          it_behaves_like "since monthly ranking", "month"
         end
 
         context "with monthly" do
-          include_examples "since monthly ranking", "monthly"
+          it_behaves_like "since monthly ranking", "monthly"
         end
       end
     end
@@ -193,11 +203,12 @@ RSpec.describe GitTrend::CLI do
     describe "with -l and -s option" do
       context "with ruby and weekly" do
         before { stub_request_get("trending/#{language}?since=#{since}") }
+
         let(:language) { "ruby" }
         let(:since) { "weekly" }
 
         it "display weekly ranking by language" do
-          res = <<-'EOS'.unindent
+          res = <<-OUTPUT.unindent
             |No. Name                                     Lang         Star
             |--- ---------------------------------------- ---------- ------
             |  1 mastodon/mastodon                        Ruby          115
@@ -226,7 +237,7 @@ RSpec.describe GitTrend::CLI do
             | 24 rubocop/rubocop                          Ruby           10
             | 25 paper-trail-gem/paper_trail              Ruby            3
 
-          EOS
+          OUTPUT
           expect { cli.invoke(:list, [], language: language, since: since, description: false) }.to output(res).to_stdout
         end
       end
@@ -235,18 +246,20 @@ RSpec.describe GitTrend::CLI do
 
   describe "#languages" do
     before { stub_request_get("trending") }
-    let(:cli) { CLI.new }
+
+    let(:cli) { described_class.new }
 
     context "with no option" do
       it "display languages" do
-        expect { cli.languages }.to output(match("C++").and match("HTML").and match("Ruby")).to_stdout
+        expect { cli.languages }.to output(include("C++", "HTML", "Ruby")).to_stdout
       end
     end
   end
 
   private
+
     def stub_request_get(stub_url_path, stub_file_name = nil)
-      url = Scraper::BASE_HOST.dup
+      url = GitTrend::Scraper::BASE_HOST.dup
       url << "/#{stub_url_path}" if stub_url_path
       uri = URI.parse(url)
       stub_file = stub_file_name || stub_url_path
@@ -254,11 +267,12 @@ RSpec.describe GitTrend::CLI do
         .to_return(
           status: 200,
           headers: { content_type: "text/html" },
-          body: load_http_stub(stub_file))
+          body: load_http_stub(stub_file)
+        )
     end
 
     def dummy_result_without_description
-      <<-'EOS'.unindent
+      <<-OUTPUT.unindent
         |No. Name                                       Lang               Star
         |--- ------------------------------------------ ---------------- ------
         |  1 linexjlin/GPTs                                                 445
@@ -287,11 +301,11 @@ RSpec.describe GitTrend::CLI do
         | 24 ytdl-org/youtube-dl                        Python               24
         | 25 dunglas/frankenphp                         Go                   53
 
-      EOS
+      OUTPUT
     end
 
     def dummy_result_no_options
-      <<-'EOS'.unindent
+      <<-OUTPUT.unindent
         |No. Name                                       Lang               Star Description
         |--- ------------------------------------------ ---------------- ------ ---------------------------------------------------------------------
         |  1 linexjlin/GPTs                                                 445 leaked prompts of GPTs
@@ -320,11 +334,11 @@ RSpec.describe GitTrend::CLI do
         | 24 ytdl-org/youtube-dl                        Python               24 Command-line program to download videos from YouTube.com and other...
         | 25 dunglas/frankenphp                         Go                   53 The modern PHP app server
 
-      EOS
+      OUTPUT
     end
 
     def dummy_weekly_result
-      <<-'EOS'.unindent
+      <<-OUTPUT.unindent
         |No. Name                                       Lang               Star
         |--- ------------------------------------------ ---------------- ------
         |  1 LC044/WeChatMsg                            Python            10719
@@ -353,11 +367,11 @@ RSpec.describe GitTrend::CLI do
         | 24 coolsnowwolf/lede                          C                   132
         | 25 QwenLM/Qwen                                Python              377
 
-      EOS
+      OUTPUT
     end
 
     def dummy_monthly_result
-      <<-'EOS'.unindent
+      <<-OUTPUT.unindent
         |No. Name                                     Lang               Star
         |--- ---------------------------------------- ---------------- ------
         |  1 SawyerHood/draw-a-ui                     TypeScript        11761
@@ -386,6 +400,6 @@ RSpec.describe GitTrend::CLI do
         | 24 SillyTavern/SillyTavern                  JavaScript         1566
         | 25 1Panel-dev/1Panel                        Go                 1950
 
-      EOS
+      OUTPUT
     end
 end

data/spec/git_trend/core_ext/string_spec.rb

@@ -0,0 +1,36 @@
+require "spec_helper"
+
+RSpec.shared_examples_for "without_options" do |examples|
+  examples.each do |example|
+    input = example[:inputs]
+    it "#{example[:object].inspect}.mb_truncate(#{input}) should return #{example[:expected].inspect}" do
+      expect(example[:object].send(:mb_truncate, input)).to eq example[:expected]
+    end
+  end
+end
+
+RSpec.describe String do
+  describe "#mb_truncate" do
+    context "ascii strings" do
+      examples = [
+        { object: "abc",   inputs: 2, expected: "..." },
+        { object: "abc",   inputs: 3, expected: "abc" },
+        { object: "abcde", inputs: 3, expected: "..." },
+        { object: "abcde", inputs: 4, expected: "a..." },
+        { object: "abcde", inputs: 5, expected: "abcde" },
+      ]
+      it_behaves_like "without_options", examples
+    end
+
+    context "multi-bytes strings" do
+      examples = [
+        { object: "あいう", inputs: 2, expected: "..." },
+        { object: "あいう", inputs: 3, expected: "..." },
+        { object: "あいう", inputs: 4, expected: "..." },
+        { object: "あいう", inputs: 5, expected: "あ..." },
+        { object: "あいう", inputs: 6, expected: "あいう" },
+      ]
+      it_behaves_like "without_options", examples
+    end
+  end
+end

data/spec/git_trend/scraper_spec.rb

@@ -1,17 +1,21 @@
-include GitTrend
+include GitTrend # rubocop:disable Style/MixinUsage
+
 RSpec.describe GitTrend::Scraper do
   let(:scraper) { Scraper.new }
 
   describe "settings" do
+    subject { scraper.instance_variable_get(:@agent) }
+
     before do
       allow(ENV).to receive(:[]).with("http_proxy").and_return("http://#{proxy_user}:#{proxy_pass}@#{proxy_addr}:#{proxy_port}")
     end
+
     let(:proxy_addr) { "192.168.1.99" }
     let(:proxy_port) { 9999 }
     let(:proxy_user) { "proxy_user" }
     let(:proxy_pass) { "proxy_pass" }
-    subject { scraper.instance_variable_get(:@agent) }
-    it "should use proxy settings of ENV" do
+
+    it "uses proxy settings of ENV" do
       aggregate_failures do
         expect(subject.proxy_addr).to eq proxy_addr
         expect(subject.proxy_user).to eq proxy_user
@@ -28,6 +32,7 @@ RSpec.describe GitTrend::Scraper do
         stub_request(:get, Scraper::BASE_URL)
           .to_return(status: 500, body: "[]")
       end
+
       it { expect { scraper.get }.to raise_error(Exception) }
     end
   end

data/spec/git_trend_spec.rb

@@ -1,81 +1,98 @@
 RSpec.describe GitTrend do
+  include described_class
+
+  let(:scraper_mock) { instance_double(Scraper) }
+
   before do
+    allow(Scraper).to receive(:new).and_return(scraper_mock)
     stub_request(:get, /.*/)
       .to_return(status: 200, headers: { content_type: "text/html" }, body: load_http_stub("trending"))
   end
 
   describe "#get" do
-    context "without options" do
-      it "Scraper#get call without options" do
-        expect_any_instance_of(Scraper).to receive(:get).with(no_args)
-        GitTrend.get
+    context "normal" do
+      before do
+        allow(scraper_mock).to receive(:get)
       end
-    end
 
-    context "parameter is 'ruby'" do
-      it "Scraper#get call with 'ruby'" do
-        expect_any_instance_of(Scraper).to receive(:get).with("ruby")
-        GitTrend.get("ruby")
+      context "without options" do
+        it "Scraper#get call without options" do
+          described_class.get
+          expect(scraper_mock).to have_received(:get).with(no_args)
+        end
       end
-    end
 
-    context "parameter is :ruby" do
-      it "Scraper#get call with :ruby" do
-        expect_any_instance_of(Scraper).to receive(:get).with(:ruby)
-        GitTrend.get(:ruby)
+      context "parameter is 'ruby'" do
+        it "Scraper#get call with 'ruby'" do
+          described_class.get("ruby")
+          expect(scraper_mock).to have_received(:get).with("ruby")
+        end
       end
-    end
 
-    context "parameter is since: :weekly" do
-      it "Scraper#get call with [nil, :weekly]" do
-        expect_any_instance_of(Scraper).to receive(:get).with(nil, :weekly)
-        GitTrend.get(since: :weekly)
+      context "parameter is :ruby" do
+        it "Scraper#get call with :ruby" do
+          described_class.get(:ruby)
+          expect(scraper_mock).to have_received(:get).with(:ruby)
+        end
       end
-    end
 
-    context "parameter is since: :week" do
-      it "Scraper#get call with [nil, :week]" do
-        expect_any_instance_of(Scraper).to receive(:get).with(nil, :week)
-        GitTrend.get(since: :week)
+      context "parameter is since: :weekly" do
+        it "Scraper#get call with [nil, :weekly]" do
+          described_class.get(since: :weekly)
+          expect(scraper_mock).to have_received(:get).with(nil, :weekly)
+        end
       end
-    end
 
-    context "parameter is since: :w" do
-      it "Scraper#get call with [nil, :w]" do
-        expect_any_instance_of(Scraper).to receive(:get).with(nil, :w)
-        GitTrend.get(since: :w)
+      context "parameter is since: :week" do
+        it "Scraper#get call with [nil, :week]" do
+          described_class.get(since: :week)
+          expect(scraper_mock).to have_received(:get).with(nil, :week)
+        end
       end
-    end
 
-    context "parameters are 'ruby', 'weekly'" do
-      it "Scraper#get call with ['ruby', 'weekly']" do
-        expect_any_instance_of(Scraper).to receive(:get).with("ruby", "weekly")
-        GitTrend.get("ruby", "weekly")
+      context "parameter is since: :w" do
+        it "Scraper#get call with [nil, :w]" do
+          described_class.get(since: :w)
+          expect(scraper_mock).to have_received(:get).with(nil, :w)
+        end
       end
-    end
 
-    context "parameters are :ruby, :weekly" do
-      it "Scraper#get call with [:ruby, :weekly]" do
-        expect_any_instance_of(Scraper).to receive(:get).with(:ruby, :weekly)
-        GitTrend.get(:ruby, :weekly)
+      context "parameters are 'ruby', 'weekly'" do
+        it "Scraper#get call with ['ruby', 'weekly']" do
+          described_class.get("ruby", "weekly")
+          expect(scraper_mock).to have_received(:get).with("ruby", "weekly")
+        end
+      end
+
+      context "parameters are :ruby, :weekly" do
+        it "Scraper#get call with [:ruby, :weekly]" do
+          described_class.get(:ruby, :weekly)
+          expect(scraper_mock).to have_received(:get).with(:ruby, :weekly)
+        end
       end
-    end
 
-    context "parameters are language: :ruby, since: :weekly" do
-      it "Scraper#get call with [:ruby, :weekly]" do
-        expect_any_instance_of(Scraper).to receive(:get).with(:ruby, :weekly)
-        GitTrend.get(language: :ruby, since: :weekly)
+      context "parameters are language: :ruby, since: :weekly" do
+        it "Scraper#get call with [:ruby, :weekly]" do
+          described_class.get(language: :ruby, since: :weekly)
+          expect(scraper_mock).to have_received(:get).with(:ruby, :weekly)
+        end
       end
     end
 
-    context "when too many parameters" do
-      it { expect { GitTrend.get("ruby", "weekly", "many_params") }.to raise_error(Exception) }
+    context "abnormal" do
+      context "when too many parameters" do
+        it { expect { described_class.get("ruby", "weekly", "many_params") }.to raise_error(Exception) }
+      end
     end
 
     describe "#languages" do
+      before do
+        allow(scraper_mock).to receive(:languages)
+      end
+
       it "Scraper#languages call" do
-        expect_any_instance_of(Scraper).to receive(:languages).with(no_args)
-        GitTrend.languages
+        described_class.languages
+        expect(scraper_mock).to have_received(:languages).with(no_args)
       end
     end
   end

data/spec/spec_helper.rb

@@ -14,25 +14,14 @@
 # users commonly want.
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
-# require "coveralls"
-# Coveralls.wear!
-
 require "simplecov"
-require "webmock/rspec"
-require "git_trend"
-
-# require "codeclimate-test-reporter"
-dir = File.join(ENV["CIRCLE_ARTIFACTS"] || "coverage")
-SimpleCov.coverage_dir(dir)
 SimpleCov.start do
   add_filter "/spec/"
-
-  formatter SimpleCov::Formatter::MultiFormatter.new([
-    SimpleCov::Formatter::HTMLFormatter,
-    # Coveralls::SimpleCov::Formatter
-  ])
 end
 
+require "webmock/rspec"
+require "git_trend"
+
 RSpec.configure do |config|
   config.expect_with :rspec do |expectations|
     expectations.syntax = :expect