git-multirepo 1.0.0.beta34 → 1.0.0.beta37

data/Rakefile

@@ -1,2 +1,2 @@
-require "bundler/gem_tasks"
-
+require "bundler/gem_tasks"
+

data/bin/multi

@@ -1,11 +1,11 @@
-#!/usr/bin/env ruby
-
-require "claide"
-require "commands"
-
-trap("INT") do
-  puts "\rAbort, abort!!" # \r hides the interrupt control characters
-  exit
-end
-
+#!/usr/bin/env ruby
+
+require "claide"
+require "commands"
+
+trap("INT") do
+  puts "\rAbort, abort!!" # \r hides the interrupt control characters
+  exit
+end
+
 MultiRepo::Command.run(ARGV)

data/docs/bug-repros/91565510-repro.sh

@@ -1,21 +1,21 @@
-echo "----> Setup a new test repo"
-dir_name="PreCommitHookAddTest"
-rm -rf $dir_name; mkdir $dir_name; cd $dir_name
-git init; git commit --allow-empty -m "Initial commit"
-
-echo "----> Add a pre-commit hook that stages a file that doesn't currently exist in the repo"
-echo "touch auto-added; git add auto-added" > .git/hooks/pre-commit
-chmod +x .git/hooks/pre-commit
-
-echo "----> Try committing a new file using the '-o' flag"
-touch manually-added; git add manually-added
-git commit -o -m "Commit that ran the pre-commit hook and should contain file 'auto-added'" -- manually-added
-
-echo "----> Results (expected: working copy clean; actual: auto-added is reported as both DELETED and UNTRACKED. HEAD and working copy are the same, staging area contains ‘incorrect' state)"
-git status
-
-echo "----> Stage the file after the fact"
-git add auto-added
-
-echo "----> Notice that the working copy is now clean"
+echo "----> Setup a new test repo"
+dir_name="PreCommitHookAddTest"
+rm -rf $dir_name; mkdir $dir_name; cd $dir_name
+git init; git commit --allow-empty -m "Initial commit"
+
+echo "----> Add a pre-commit hook that stages a file that doesn't currently exist in the repo"
+echo "touch auto-added; git add auto-added" > .git/hooks/pre-commit
+chmod +x .git/hooks/pre-commit
+
+echo "----> Try committing a new file using the '-o' flag"
+touch manually-added; git add manually-added
+git commit -o -m "Commit that ran the pre-commit hook and should contain file 'auto-added'" -- manually-added
+
+echo "----> Results (expected: working copy clean; actual: auto-added is reported as both DELETED and UNTRACKED. HEAD and working copy are the same, staging area contains ‘incorrect' state)"
+git status
+
+echo "----> Stage the file after the fact"
+git add auto-added
+
+echo "----> Notice that the working copy is now clean"
 git status

data/git-multirepo.gemspec

@@ -1,29 +1,29 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'info'
-
-Gem::Specification.new do |spec|
-  spec.name          = MultiRepo::NAME
-  spec.version       = MultiRepo::VERSION
-  spec.authors       = ["Michaël Fortin"]
-  spec.email         = ["fortinmike@irradiated.net"]
-  spec.summary       = %q{Track multiple Git repositories side-by-side}
-  spec.description   = MultiRepo::DESCRIPTION
-  spec.homepage      = "https://github.com/fortinmike/git-multirepo"
-  spec.license       = "MIT"
-  
-  spec.required_ruby_version = '~> 2.0'
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.1.0"
-
-  spec.add_runtime_dependency "claide", "~> 0.8", ">= 0.8.0"
-  spec.add_runtime_dependency "colored", "~> 1.2"
-  spec.add_runtime_dependency "os", "~> 0.9.6"
-end
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'info'
+
+Gem::Specification.new do |spec|
+  spec.name          = MultiRepo::NAME
+  spec.version       = MultiRepo::VERSION
+  spec.authors       = ["Michaël Fortin"]
+  spec.email         = ["fortinmike@irradiated.net"]
+  spec.summary       = %q{Track multiple Git repositories side-by-side}
+  spec.description   = MultiRepo::DESCRIPTION
+  spec.homepage      = "https://github.com/fortinmike/git-multirepo"
+  spec.license       = "MIT"
+  
+  spec.required_ruby_version = '~> 2.0'
+  spec.files         = `git ls-files -z`.split("\x0")
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ["lib"]
+
+  spec.add_development_dependency "bundler", "~> 1.7"
+  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rspec", "~> 3.1.0"
+
+  spec.add_runtime_dependency "claide", "~> 0.8", ">= 0.8.0"
+  spec.add_runtime_dependency "colored", "~> 1.2"
+  spec.add_runtime_dependency "os", "~> 0.9.6"
+end

data/lib/commands.rb

@@ -1,13 +1,14 @@
-require_relative "multirepo/commands/command"
-require_relative "multirepo/commands/add-command"
-require_relative "multirepo/commands/branch-command"
-require_relative "multirepo/commands/checkout-command"
-require_relative "multirepo/commands/clean-command"
-require_relative "multirepo/commands/clone-command"
-require_relative "multirepo/commands/fetch-command"
-require_relative "multirepo/commands/init-command"
-require_relative "multirepo/commands/install-command"
-require_relative "multirepo/commands/open-command"
-require_relative "multirepo/commands/remove-command"
-require_relative "multirepo/commands/uninit-command"
+require_relative "multirepo/commands/command"
+require_relative "multirepo/commands/add-command"
+require_relative "multirepo/commands/branch-command"
+require_relative "multirepo/commands/checkout-command"
+require_relative "multirepo/commands/clean-command"
+require_relative "multirepo/commands/clone-command"
+require_relative "multirepo/commands/fetch-command"
+require_relative "multirepo/commands/init-command"
+require_relative "multirepo/commands/install-command"
+require_relative "multirepo/commands/merge-command"
+require_relative "multirepo/commands/open-command"
+require_relative "multirepo/commands/remove-command"
+require_relative "multirepo/commands/uninit-command"
 require_relative "multirepo/commands/update-command"

data/lib/git-multirepo.rb

@@ -1,2 +1,2 @@
-require "multirepo/hooks/pre-commit-hook.rb"
+require "multirepo/hooks/pre-commit-hook.rb"
 require "multirepo/hooks/post-commit-hook.rb"

data/lib/info.rb

@@ -1,5 +1,5 @@
-module MultiRepo
-  NAME = "git-multirepo"
-  VERSION = "1.0.0.beta34"
-  DESCRIPTION = "Track multiple Git repositories side-by-side."
+module MultiRepo
+  NAME = "git-multirepo"
+  VERSION = "1.0.0.beta37"
+  DESCRIPTION = "Track multiple Git repositories side-by-side."
 end

data/lib/multirepo/commands/add-command.rb

@@ -1,52 +1,54 @@
-require "multirepo/utility/console"
-require "multirepo/files/config-file"
-
-module MultiRepo
-  class AddCommand < Command
-    self.command = "add"
-    self.summary = "Track an additional dependency with multirepo."
-    
-    def self.options
-      [['<path>', 'The relative path to the new dependency (e.g. ../MyNewDependency)']].concat(super)
-    end
-    
-    def initialize(argv)
-      @path = argv.shift_argument
-      super
-    end
-    
-    def validate!
-      super
-      help! "You must specify a repository to add as a dependency" unless @path
-    end
-    
-    def run
-      super
-      ensure_in_work_tree
-      ensure_multirepo_enabled
-      ensure_repo_valid
-      
-      entry = ConfigEntry.new(Repo.new(@path))
-      if ConfigFile.entry_exists?(entry)
-        Console.log_info("There is already an entry for '#{@path}' in the .multirepo file")
-      else
-        ConfigFile.add_entry(entry)
-        Console.log_step("Added '#{@path}' to the .multirepo file")
-      end
-    rescue MultiRepoException => e
-      Console.log_error(e.message)
-    end
-    
-    def ensure_repo_valid
-      raise MultiRepoException, "The provided path is not a direct sibling of the main repository" unless validate_is_sibling_repo(@path)
-      raise MultiRepoException, "There is no folder at path '#{@path}'" unless Dir.exists?(@path)
-      raise MultiRepoException, "'#{@path}' is not a repository" unless Repo.new(@path).exists?
-    end
-    
-    def validate_is_sibling_repo(path)
-      parent_dir = File.expand_path("..")
-      path = File.expand_path("..", path)
-      return parent_dir == path
-    end
-  end
+require "multirepo/utility/console"
+require "multirepo/files/config-file"
+
+module MultiRepo
+  class AddCommand < Command
+    self.command = "add"
+    self.summary = "Track an additional dependency with multirepo."
+    
+    def self.options
+      [['<path>', 'The relative path to the new dependency (e.g. ../MyNewDependency)']].concat(super)
+    end
+    
+    def initialize(argv)
+      @path = argv.shift_argument
+      super
+    end
+    
+    def validate!
+      super
+      help! "You must specify a repository to add as a dependency" unless @path
+    end
+    
+    def run
+      super
+      ensure_in_work_tree
+      ensure_multirepo_enabled
+      ensure_repo_valid
+      
+      config_file = ConfigFile.new(".")
+      entry = ConfigEntry.new(Repo.new(@path))
+      
+      if config_file.entry_exists?(entry)
+        Console.log_info("There is already an entry for '#{@path}' in the .multirepo file")
+      else
+        config_file.add_entry(entry)
+        Console.log_step("Added '#{@path}' to the .multirepo file")
+      end
+    rescue MultiRepoException => e
+      Console.log_error(e.message)
+    end
+    
+    def ensure_repo_valid
+      raise MultiRepoException, "The provided path is not a direct sibling of the main repository" unless validate_is_sibling_repo(@path)
+      raise MultiRepoException, "There is no folder at path '#{@path}'" unless Dir.exists?(@path)
+      raise MultiRepoException, "'#{@path}' is not a repository" unless Repo.new(@path).exists?
+    end
+    
+    def validate_is_sibling_repo(path)
+      parent_dir = File.expand_path("..")
+      path = File.expand_path("..", path)
+      return parent_dir == path
+    end
+  end
 end

data/lib/multirepo/commands/branch-command.rb

@@ -1,61 +1,66 @@
-require "multirepo/utility/console"
-require "multirepo/files/config-file"
-require "multirepo/files/tracking-files"
-
-module MultiRepo
-  class BranchCommand < Command
-    self.command = "branch"
-    self.summary = "Create and/or checkout a new branch for all repos."
-    
-    def self.options
-      [
-        ['<branch name>', 'The name of the branch to create and checkout.'],
-        ['[--force]', 'Force creating the branch even if the repos contain uncommmitted changes.'],
-        ['[--no-track]', 'Do not configure as a remote-tracking branch on creation.']
-      ].concat(super)
-    end
-    
-    def initialize(argv)
-      @branch_name = argv.shift_argument
-      @force = argv.flag?("force")
-      @remote_tracking = argv.flag?("track", true)
-      super
-    end
-    
-    def validate!
-      super
-      help! "You must specify a branch name" unless @branch_name
-    end
-    
-    def run
-      super
-      ensure_in_work_tree
-      ensure_multirepo_enabled
-      
-      Console.log_step("Branching...")
-
-      main_repo = Repo.new(".")
-      repos = ConfigFile.load_entries.map{ |entry| entry.repo }.push(main_repo)
-      
-      if !Utils.ensure_working_copies_clean(repos) && !@force
-        raise MultiRepoException, "Can't branch because not all repos are clean"
-      end
-
-      repos.each do |repo|
-        Console.log_substep("Branching and checking out #{repo.path} #{@branch_name} ...")
-
-        branch = repo.branch(@branch_name)
-        branch.create(@remote_tracking) unless branch.exists?
-        branch.checkout
-      end
-
-      Console.log_substep("Updating and committing tracking files")
-      TrackingFiles.update
-      TrackingFiles.commit("[multirepo] Post-branch tracking files update")
-
-      Console.log_step("Done!")
-    rescue MultiRepoException => e
-      Console.log_error(e.message)
-    end
-  end
+require "multirepo/utility/console"
+require "multirepo/files/config-file"
+require "multirepo/files/tracking-files"
+
+module MultiRepo
+  class BranchCommand < Command
+    self.command = "branch"
+    self.summary = "Create and/or checkout a new branch for all repos."
+    
+    def self.options
+      [
+        ['<branch name>', 'The name of the branch to create and checkout.'],
+        ['[--force]', 'Force creating the branch even if the repos contain uncommmitted changes.'],
+        ['[--no-track]', 'Do not configure as a remote-tracking branch on creation.']
+      ].concat(super)
+    end
+    
+    def initialize(argv)
+      @branch_name = argv.shift_argument
+      @force = argv.flag?("force")
+      @remote_tracking = argv.flag?("track", true)
+      super
+    end
+    
+    def validate!
+      super
+      help! "You must specify a branch name" unless @branch_name
+    end
+    
+    def run
+      super
+      ensure_in_work_tree
+      ensure_multirepo_enabled
+      
+      Console.log_step("Branching...")
+      
+      main_repo = Repo.new(".")
+      config_file = ConfigFile.new(".")
+      repos = config_file.load_entries.map{ |entry| entry.repo }.push(main_repo)
+      
+      if !Utils.ensure_working_copies_clean(repos) && !@force
+        raise MultiRepoException, "Can't branch because not all repos are clean"
+      end
+      
+      repos.each do |repo|
+        if @remote_tracking
+          Console.log_substep("Branching, checking out and pushing '#{repo.path}' #{@branch_name} ...")
+        else
+          Console.log_substep("Branching and checking out '#{repo.path}' #{@branch_name} (not pushed) ...")
+        end
+
+        branch = repo.branch(@branch_name)
+        branch.create(@remote_tracking) unless branch.exists?
+        branch.checkout
+      end
+
+      Console.log_substep("Updating and committing tracking files")
+      TrackingFiles.update
+      TrackingFiles.commit("[multirepo] Post-branch tracking files update")
+
+      Console.log_step("Done!")
+    rescue MultiRepoException => e
+      Console.log_error(e.message)
+    end
+  end
 end

data/lib/multirepo/commands/checkout-command.rb

@@ -1,141 +1,120 @@
-require "multirepo/utility/console"
-
-module MultiRepo
-  class CheckoutCommand < Command
-    self.command = "checkout"
-    self.summary = "Checks out the specified commit or branch of the main repo and checks out matching versions of all dependencies."
-    
-    class CheckoutMode
-      AS_LOCK = 0
-      LATEST = 1
-      EXACT = 2
-    end
-    
-    def self.options
-      [
-        ['<ref>', 'The main repo tag, branch or commit id to checkout.'],
-        ['[--latest]', 'Checkout the HEAD of each dependency branch (as recorded in the lock file) instead of the exact required commits.'],
-        ['[--exact]', 'Checkout the exact specified ref for each repo, regardless of what\'s stored in the lock file.']
-      ].concat(super)
-    end
-    
-    def initialize(argv)
-      @ref = argv.shift_argument
-      @checkout_latest = argv.flag?("latest")
-      @checkout_exact = argv.flag?("exact")
-      super
-    end
-    
-    def validate!
-      super
-      help! "You must specify a branch or commit id to checkout" unless @ref
-      help! "You can't provide more than one operation modifier (--latest, --exact, etc.)" if @checkout_latest && @checkout_exact
-    end
-    
-    def run
-      super
-      ensure_in_work_tree
-      ensure_multirepo_enabled
-      
-      Console.log_step("Checking out #{@ref} and its dependencies...")
-      
-      # Find out the checkout mode based on command-line options
-      mode = if @checkout_latest then
-        CheckoutMode::LATEST
-      elsif @checkout_exact then
-        CheckoutMode::EXACT
-      else
-        CheckoutMode::AS_LOCK
-      end
-      
-      main_repo = Repo.new(".")
-      initial_revision = main_repo.current_branch || main_repo.head_hash
-      
-      unless proceed_if_merge_commit?(main_repo, @ref, mode)
-        raise MultiRepoException, "Aborting checkout"
-      end
-      
-      main_repo_checkout_step(main_repo, initial_revision, @ref)
-      ensure_dependencies_clean_step(main_repo, initial_revision)
-      dependencies_checkout_step(mode, @ref)
-            
-      Console.log_step("Done!")
-    rescue MultiRepoException => e
-      Console.log_error(e.message)
-    end
-            
-    def main_repo_checkout_step(main_repo, initial_revision, ref)
-      # Make sure the main repo is clean before attempting a checkout
-      unless main_repo.is_clean?
-        raise MultiRepoException, "Can't checkout #{ref} because the main repo contains uncommitted changes"
-      end
-      
-      # Checkout the specified ref
-      unless main_repo.checkout(ref)
-        raise MultiRepoException, "Couldn't perform checkout of main repo #{ref}!"
-      end
-      
-      Console.log_substep("Checked out main repo #{ref}")
-      
-      # After checkout, make sure we're working with a multirepo-enabled ref
-      unless Utils.is_multirepo_tracked(".")
-        main_repo.checkout(initial_revision)
-        raise MultiRepoException, "This revision is not tracked by multirepo. Checkout reverted."
-      end
-    end
-    
-    def ensure_dependencies_clean_step(main_repo, initial_revision)
-      unless Utils.ensure_dependencies_clean(ConfigFile.load_entries)
-        main_repo.checkout(initial_revision)
-        raise MultiRepoException, "Checkout reverted."
-      end
-    end
-    
-    def dependencies_checkout_step(mode, ref = nil)
-      config_entries = ConfigFile.load_entries # Post-main-repo checkout config entries might be different than pre-checkout
-      LockFile.load_entries.each { |lock_entry| perform_dependency_checkout(config_entries, lock_entry, ref, mode) }
-    end
-    
-    def proceed_if_merge_commit?(main_repo, ref, mode)
-      return true unless main_repo.commit(ref).is_merge?
-      
-      case mode
-      when CheckoutMode::AS_LOCK
-        Console.log_error("The specified ref is a merge commit and an \"as-lock\" checkout was requested.")
-        Console.log_error("The resulting checkout would most probably not result in a valid project state.")
-        return false
-      when CheckoutMode::LATEST
-        Console.log_warning("The specified ref is a merge commit and a \"latest\" checkout was requested.")
-        Console.log_warning("The work branches recorded in the branch from which the merge was performed will be checked out.")
-      end
-      
-      return true
-    end
-    
-    def perform_dependency_checkout(config_entries, lock_entry, ref, mode)
-      # Find the config entry that matches the given lock entry
-      config_entry = config_entries.select{ |config_entry| config_entry.id == lock_entry.id }.first
-      
-      # Make sure the repo exists on disk, and clone it if it doesn't
-      # (in case the checked-out revision had an additional dependency)
-      unless config_entry.repo.exists?
-        Console.log_substep("Cloning missing dependency '#{config_entry.path}' from #{config_entry.url}")
-        config_entry.repo.clone(config_entry.url)
-      end
-      
-      # Find out the proper revision to checkout based on the checkout mode
-      revision = case mode
-      when CheckoutMode::AS_LOCK; lock_entry.head
-      when CheckoutMode::LATEST; lock_entry.branch
-      when CheckoutMode::EXACT; ref
-      end
-      
-      # Checkout!
-      if config_entry.repo.checkout(revision)
-        Console.log_substep("Checked out #{lock_entry.name} #{revision}")
-      else
-        raise MultiRepoException, "Couldn't check out the appropriate version of dependency #{lock_entry.name}"
-      end
-    end
-  end
+require "multirepo/utility/console"
+require "multirepo/logic/revision-selector"
+require "multirepo/logic/performer"
+
+module MultiRepo
+  class CheckoutCommand < Command
+    self.command = "checkout"
+    self.summary = "Checks out the specified commit or branch of the main repo and checks out matching versions of all dependencies."
+    
+    def self.options
+      [
+        ['<ref>', 'The main repo tag, branch or commit id to checkout.'],
+        ['[--latest]', 'Checkout the HEAD of each dependency branch (as recorded in the lock file) instead of the exact required commits.'],
+        ['[--exact]', 'Checkout the exact specified ref for each repo, regardless of what\'s stored in the lock file.']
+      ].concat(super)
+    end
+    
+    def initialize(argv)
+      @ref = argv.shift_argument
+      @checkout_latest = argv.flag?("latest")
+      @checkout_exact = argv.flag?("exact")
+      super
+    end
+    
+    def validate!
+      super
+      help! "You must specify a branch or commit id to checkout" unless @ref
+      help! "You can't provide more than one operation modifier (--latest, --exact, etc.)" if @checkout_latest && @checkout_exact
+    end
+    
+    def run
+      super
+      ensure_in_work_tree
+      
+      Console.log_step("Checking out #{@ref} and its dependencies...")
+      
+      # Find out the checkout mode based on command-line options
+      mode = RevisionSelector.mode_for_args(@checkout_latest, @checkout_exact)
+      
+      main_repo = Repo.new(".")
+      
+      unless proceed_if_merge_commit?(main_repo, @ref, mode)
+        raise MultiRepoException, "Aborting checkout"
+      end
+      
+      checkout_core(main_repo, mode)
+            
+      Console.log_step("Done!")
+    rescue MultiRepoException => e
+      Console.log_error(e.message)
+    end
+    
+    def checkout_core(main_repo, mode)
+      initial_revision = main_repo.current_branch || main_repo.head_hash
+      begin
+        # Checkout first because the current ref might not be multirepo-enabled
+        checkout_main_repo_step(main_repo)
+        # Only then can we check for dependencies and make sure they are clean
+        ensure_dependencies_clean_step(main_repo)
+      rescue MultiRepoException => e
+        Console.log_error("Reverting main repo checkout")
+        main_repo.checkout(initial_revision)
+        raise e
+      end
+      dependencies_checkout_step(mode, @ref)
+    end
+    
+    def checkout_main_repo_step(main_repo)
+      Performer.perform_main_repo_checkout(main_repo, @ref)
+    end
+    
+    def ensure_dependencies_clean_step(main_repo)
+      unless Utils.ensure_dependencies_clean(ConfigFile.new(".").load_entries)
+        raise MultiRepoException, "Dependencies are not clean!"
+      end
+    end
+    
+    def dependencies_checkout_step(mode, ref = nil)
+      Performer.perform_on_dependencies do |config_entry, lock_entry|
+        # Find out the required dependency revision based on the checkout mode
+        revision = RevisionSelector.revision_for_mode(mode, ref, lock_entry)
+        perform_dependency_checkout(config_entry, revision)
+      end
+    end
+    
+    def proceed_if_merge_commit?(main_repo, ref, mode)
+      return true unless main_repo.commit(ref).is_merge?
+      
+      case mode
+      when RevisionSelectionMode::AS_LOCK
+        Console.log_error("The specified ref is a merge commit and an \"as-lock\" checkout was requested.")
+        Console.log_error("The resulting checkout would most probably not result in a valid project state.")
+        return false
+      when RevisionSelectionMode::LATEST
+        Console.log_warning("The specified ref is a merge commit and a \"latest\" checkout was requested.")
+        Console.log_warning("The work branches recorded in the branch from which the merge was performed will be checked out.")
+      end
+      
+      return true
+    end
+    
+    def perform_dependency_checkout(config_entry, revision)
+      dependency_name = config_entry.repo.basename
+      
+      # Make sure the repo exists on disk, and clone it if it doesn't
+      # (in case the checked-out revision had an additional dependency)
+      unless config_entry.repo.exists?
+        Console.log_substep("Cloning missing dependency '#{config_entry.path}' from #{config_entry.url}")
+        config_entry.repo.clone(config_entry.url)
+      end
+      
+      # Checkout!
+      if config_entry.repo.checkout(revision)
+        Console.log_substep("Checked out #{dependency_name} #{revision}")
+      else
+        raise MultiRepoException, "Couldn't check out the appropriate version of dependency #{dependency_name}"
+      end
+    end
+  end
 end