git-lint 6.2.0 → 7.0.0

data/lib/git/lint/container.rb

@@ -15,11 +15,33 @@ module Git
       extend Dry::Container::Mixin
 
       namespace :trailers do
-        register(:collaborator, memoize: true) { /\ACo.*Authored.*By.*\Z/i }
-        register(:format, memoize: true) { /\AFormat.*\Z/i }
-        register(:issue, memoize: true) { /\AIssue.*\Z/i }
-        register(:signer, memoize: true) { /\ASigned.*By.*\Z/i }
-        register(:tracker, memoize: true) { /\ATracker.*\Z/i }
+        register :collaborator, memoize: true do
+          Configuration::Trailer[name: "Co-authored-by", pattern: /\ACo.*authored.*by.*\Z/i]
+        end
+
+        register :format, memoize: true do
+          Configuration::Trailer[name: "Format", pattern: /\AFormat.*\Z/i]
+        end
+
+        register :issue, memoize: true do
+          Configuration::Trailer[name: "Issue", pattern: /\AIssue.*\Z/i]
+        end
+
+        register :milestone, memoize: true do
+          Configuration::Trailer[name: "Milestone", pattern: /\AMilestone.*\Z/i]
+        end
+
+        register :reviewer, memoize: true do
+          Configuration::Trailer[name: "Reviewer", pattern: /\AReviewer.*\Z/i]
+        end
+
+        register :signer, memoize: true do
+          Configuration::Trailer[name: "Signed-off-by", pattern: /\ASigned.*off.*by.*\Z/i]
+        end
+
+        register :tracker, memoize: true do
+          Configuration::Trailer[name: "Tracker", pattern: /\ATracker.*\Z/i]
+        end
       end
 
       namespace :parsers do
@@ -27,7 +49,6 @@ module Git
       end
 
       namespace :sanitizers do
-        register(:email) { Gitt::Sanitizers::Email }
         register(:signature) { Gitt::Sanitizers::Signature }
       end
 
@@ -35,6 +56,7 @@ module Git
         register(:capitalization, memoize: true) { Validators::Capitalization.new }
         register(:email, memoize: true) { Validators::Email.new }
         register(:name, memoize: true) { Validators::Name.new }
+        register(:repeated_word, memoize: true) { Validators::RepeatedWord.new }
       end
 
       register :configuration, memoize: true do

data/lib/git/lint/errors/severity.rb

@@ -1,12 +1,17 @@
 # frozen_string_literal: true
 
+require "refinements/array"
+
 module Git
   module Lint
     module Errors
       # Categorizes severity errors.
       class Severity < Base
+        using Refinements::Array
+
         def initialize level
-          super %(Invalid severity level: #{level}. Use: #{Analyzers::Abstract::LEVELS.join ", "}.)
+          usage = Analyzers::Abstract::LEVELS.to_usage "or"
+          super %(Invalid severity level: #{level}. Use: #{usage}.)
         end
       end
     end

data/lib/git/lint/kit/filter_list.rb

@@ -1,21 +1,26 @@
 # frozen_string_literal: true
 
 require "core"
+require "refinements/array"
 
 module Git
   module Lint
     module Kit
       # Represents an regular expression list which may be used as an analyzer setting.
       class FilterList
+        using Refinements::Array
+
         def initialize list = Core::EMPTY_ARRAY
-          @list = Array list
+          @list = Array(list).map { |item| Regexp.new item }
         end
 
-        def to_hint = to_regexp.map(&:inspect).join(", ")
+        def empty? = list.empty?
+
+        def to_a = list
 
-        def to_regexp = list.map { |item| Regexp.new item }
+        alias to_ary to_a
 
-        def empty? = list.empty?
+        def to_usage(...) = list.to_usage(...)
 
         private
 

data/lib/git/lint/reporters/branch.rb

@@ -6,7 +6,7 @@ module Git
       # Reports issues related to a single branch.
       class Branch
         include Import[:color]
-        using ::Refinements::Strings
+        using Refinements::String
 
         def initialize(collector: Collector.new, **)
           super(**)
@@ -38,7 +38,7 @@ module Git
 
         def commit_total
           total = collector.total_commits
-          %(#{total} #{"commit".pluralize "s", count: total} inspected)
+          %(#{total} #{"commit".pluralize "s", total} inspected)
         end
 
         def issue_totals
@@ -52,19 +52,19 @@ module Git
         def issue_total
           style = collector.errors? ? :red : :yellow
           total = collector.total_issues
-          color["#{total} issue".pluralize("s", count: total), style]
+          color["#{total} issue".pluralize("s", total), style]
         end
 
         def warning_total
           style = collector.warnings? ? :yellow : :green
           total = collector.total_warnings
-          color["#{total} warning".pluralize("s", count: total), style]
+          color["#{total} warning".pluralize("s", total), style]
         end
 
         def error_total
           style = collector.errors? ? :red : :green
           total = collector.total_errors
-          color["#{total} error".pluralize("s", count: total), style]
+          color["#{total} error".pluralize("s", total), style]
         end
       end
     end

data/lib/git/lint/validators/name.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
-require "refinements/strings"
+require "refinements/string"
 
 module Git
   module Lint
     module Validators
       # Validates the format of names.
       class Name
-        using Refinements::Strings
+        using Refinements::String
 
         DELIMITER = /\s{1}/
         MINIMUM = 2

data/lib/git/lint/validators/repeated_word.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require "core"
+
+module Git
+  module Lint
+    module Validators
+      # Validates content has no repeated words.
+      class RepeatedWord
+        PATTERN = /
+          \w+(?=\s)         # Match word with trailing space.
+          |                 # Or.
+          (?<=\s)\w+(?=\s)  # Match word between two spaces.
+          |                 # Or.
+          (?<=\s)\w+        # Match word with leading space.
+        /x
+
+        def initialize pattern: PATTERN
+          @pattern = pattern
+        end
+
+        def call(content) = content ? scan(content) : Core::EMPTY_ARRAY
+
+        private
+
+        attr_reader :pattern
+
+        def scan content
+          content.scan(pattern).each_cons(2).with_object [] do |(current, future), repeats|
+            repeats.append future if current.casecmp(future).zero?
+          end
+        end
+      end
+    end
+  end
+end

data/lib/git/lint.rb

@@ -17,6 +17,8 @@ end
 module Git
   # Main namespace.
   module Lint
-    def self.loader(registry = Zeitwerk::Registry) = registry.loader_for __FILE__
+    def self.loader registry = Zeitwerk::Registry
+      @loader ||= registry.loaders.find { |loader| loader.tag == "git-lint" }
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git-lint
 version: !ruby/object:Gem::Version
-  version: 6.2.0
+  version: 7.0.0
 platform: ruby
 authors:
 - Brooke Kuhlmann
@@ -35,7 +35,7 @@ cert_chain:
   3n5C8/6Zh9DYTkpcwPSuIfAga6wf4nXc9m6JAw8AuMLaiWN/r/2s4zJsUHYERJEu
   gZGm4JqtuSg8pYjPeIJxS960owq+SfuC+jxqmRA54BisFCv/0VOJi7tiJVY=
   -----END CERTIFICATE-----
-date: 2023-10-15 00:00:00.000000000 Z
+date: 2024-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cogger
@@ -43,28 +43,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.15'
 - !ruby/object:Gem::Dependency
   name: core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: dry-container
   requirement: !ruby/object:Gem::Requirement
@@ -113,112 +113,112 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: gitt
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: infusible
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: refinements
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '12.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: runcom
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '11.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '11.0'
 - !ruby/object:Gem::Dependency
   name: sod
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.0'
+        version: '0.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.0'
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: spek
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: tone
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: zeitwerk
   requirement: !ruby/object:Gem::Requirement
@@ -253,20 +253,21 @@ files:
 - lib/git/lint/analyzers/commit_author_capitalization.rb
 - lib/git/lint/analyzers/commit_author_email.rb
 - lib/git/lint/analyzers/commit_author_name.rb
-- lib/git/lint/analyzers/commit_body_bullet.rb
 - lib/git/lint/analyzers/commit_body_bullet_capitalization.rb
 - lib/git/lint/analyzers/commit_body_bullet_delimiter.rb
+- lib/git/lint/analyzers/commit_body_bullet_only.rb
 - lib/git/lint/analyzers/commit_body_leading_line.rb
 - lib/git/lint/analyzers/commit_body_line_length.rb
 - lib/git/lint/analyzers/commit_body_paragraph_capitalization.rb
 - lib/git/lint/analyzers/commit_body_phrase.rb
 - lib/git/lint/analyzers/commit_body_presence.rb
-- lib/git/lint/analyzers/commit_body_single_bullet.rb
 - lib/git/lint/analyzers/commit_body_tracker_shorthand.rb
+- lib/git/lint/analyzers/commit_body_word_repeat.rb
 - lib/git/lint/analyzers/commit_signature.rb
 - lib/git/lint/analyzers/commit_subject_length.rb
 - lib/git/lint/analyzers/commit_subject_prefix.rb
 - lib/git/lint/analyzers/commit_subject_suffix.rb
+- lib/git/lint/analyzers/commit_subject_word_repeat.rb
 - lib/git/lint/analyzers/commit_trailer_collaborator_capitalization.rb
 - lib/git/lint/analyzers/commit_trailer_collaborator_email.rb
 - lib/git/lint/analyzers/commit_trailer_collaborator_key.rb
@@ -276,6 +277,11 @@ files:
 - lib/git/lint/analyzers/commit_trailer_format_value.rb
 - lib/git/lint/analyzers/commit_trailer_issue_key.rb
 - lib/git/lint/analyzers/commit_trailer_issue_value.rb
+- lib/git/lint/analyzers/commit_trailer_milestone_key.rb
+- lib/git/lint/analyzers/commit_trailer_milestone_value.rb
+- lib/git/lint/analyzers/commit_trailer_order.rb
+- lib/git/lint/analyzers/commit_trailer_reviewer_key.rb
+- lib/git/lint/analyzers/commit_trailer_reviewer_value.rb
 - lib/git/lint/analyzers/commit_trailer_signer_capitalization.rb
 - lib/git/lint/analyzers/commit_trailer_signer_email.rb
 - lib/git/lint/analyzers/commit_trailer_signer_key.rb
@@ -287,16 +293,17 @@ files:
 - lib/git/lint/cli/actions/hook.rb
 - lib/git/lint/cli/shell.rb
 - lib/git/lint/collector.rb
+- lib/git/lint/commits/hosts/circle_ci.rb
+- lib/git/lint/commits/hosts/container.rb
+- lib/git/lint/commits/hosts/git_hub_action.rb
+- lib/git/lint/commits/hosts/import.rb
+- lib/git/lint/commits/hosts/local.rb
+- lib/git/lint/commits/hosts/netlify_ci.rb
 - lib/git/lint/commits/loader.rb
-- lib/git/lint/commits/systems/circle_ci.rb
-- lib/git/lint/commits/systems/container.rb
-- lib/git/lint/commits/systems/git_hub_action.rb
-- lib/git/lint/commits/systems/import.rb
-- lib/git/lint/commits/systems/local.rb
-- lib/git/lint/commits/systems/netlify_ci.rb
 - lib/git/lint/configuration/contract.rb
 - lib/git/lint/configuration/defaults.yml
 - lib/git/lint/configuration/model.rb
+- lib/git/lint/configuration/trailer.rb
 - lib/git/lint/container.rb
 - lib/git/lint/errors/base.rb
 - lib/git/lint/errors/severity.rb
@@ -313,6 +320,7 @@ files:
 - lib/git/lint/validators/capitalization.rb
 - lib/git/lint/validators/email.rb
 - lib/git/lint/validators/name.rb
+- lib/git/lint/validators/repeated_word.rb
 homepage: https://alchemists.io/projects/git-lint
 licenses:
 - Hippocratic-2.1
@@ -332,14 +340,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '3.2'
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.20
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: A command line interface for linting Git commits.

data/lib/git/lint/analyzers/commit_body_bullet.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-module Git
-  module Lint
-    module Analyzers
-      # Analyzes commit body for correct bullet point syntax.
-      class CommitBodyBullet < Abstract
-        def valid? = commit.body_lines.all? { |line| !invalid_line? line }
-
-        def issue
-          return {} if valid?
-
-          {
-            hint: %(Avoid: #{filter_list.to_hint}.),
-            lines: affected_commit_body_lines
-          }
-        end
-
-        protected
-
-        def load_filter_list
-          Kit::FilterList.new configuration.commits_body_bullet_excludes
-        end
-
-        # :reek:FeatureEnvy
-        def invalid_line? line
-          return false if line.strip.empty?
-
-          !line.match?(/\A(?!\s*#{Regexp.union filter_list.to_regexp}\s+).+\Z/)
-        end
-      end
-    end
-  end
-end