git-lint 2.2.0 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a0ccd4d14bc5a75b14ae5a825f5eec453a560bc3e6df2bc959bbcb90f626794
-  data.tar.gz: 5f64925793493c9cde59a4828666137ba6a5203f664d5b97ce994552b38fcb42
+  metadata.gz: 2738d9812647c24090cf0465db57379709af0fd64c9c8aa474f7d68c2f7896f5
+  data.tar.gz: f258c1a530ce3faf4f115feb2a108d021f09959eda092be58d92b75b8b5862d6
 SHA512:
-  metadata.gz: b295196574a134f2ae5a3989c71d7023998eaf96476055a8c511a3f5d684fbaf1d9456fe887389042d4f8a88fb0d7bce0ea8e1a5663c490c1cf7756b9d6384c8
-  data.tar.gz: 542818d4e2dced990b4231b53160e6c59272c1db908e309a10566210be26eeddb6213ec1f6581c75b078f6d8581e0b4f85827efe03d0f93ce9a216a8133c94a8
+  metadata.gz: 44551a125b11785cdadbb3d65e63c049e2a513704ebef7f21419c95b21c396ac8f2193bd7f2bf35d4f30469789236b793a3cd1f2a3554efc715b0ebcaa4621e4
+  data.tar.gz: d6f8299c1c864fe7cfde0a692119b3bab8f1450ce89df534b76ac3c84d31cb54576cc2a45f300fdb8afd3cdfbd539f029aab88967e0bc7184ec9a4a0c8a01396

data/README.adoc

@@ -731,12 +731,12 @@ Automatically ignores _fixup!_ or _squash!_ commit prefixes when calculating sub
 | true    | error    | includes: (see below)
 |===
 
-Ensures the commit subject uses consistent prefixes that explain _what_ is being committed. The
+Ensures each commit subject uses consistent prefixes that explain _what_ is being committed. The
 `includes` are _case sensitive_ and default to the following prefixes:
 
 * *Fixed* - Identifies what was fixed. The commit should be as small as possible and consist of
-  changes to implementation and spec only. In some cases this might be a single line or file change.
-  The important point is the change is applied to existing code which corrects behavior that wasn't
+  changes to implementation and spec only. In some cases this might be a single line change. The
+  important point is the change is applied to existing code which corrects behavior that wasn't
   properly implemented earlier.
 * *Removed* - Identifies what was removed. The commit should be as small as possible and consist
   only of removed lines/files from the existing implementation. This might also mean breaking
@@ -747,18 +747,24 @@ Ensures the commit subject uses consistent prefixes that explain _what_ is being
 * *Updated* - Identifies what was updated. The commit should be as small as possible and _not add
   or fix_ existing behavior. This can sometimes be a grey area but is typically reserved for updates
   to documentation, code comments, dependencies, etc.
-* *Refactored* - Identifies what was refactored. The commit should be as small as possible and only
-  improve existing functionality while avoiding changes in behavior (especially to public API
-  that might effect downstream dependencies). Refactored code should never break existing specs.
-
-In practice, using a prefix other than what has been detailed above to explain _what_ is being
-committed is never needed. These prefixes are not only short and easy to remember but also have the
+* *Refactored* - Identifies what was refactored.
+  link:https://thoughtbot.com/blog/lets-not-misuse-refactoring[_Refactoring is for changing code
+  structure without changing observable behavior_]. The commit should be as small as possible and
+  not mix multiple kinds of changes at once. Refactored code should never break existing
+  implementation behavior or corresponding specs because, if that happens, then one of the other
+  four prefixes is what you want to use instead.
+
+In practice, it is quite rare to need a prefix other than what has been detailed above to explain
+_what_ is being committed. These prefixes are not only short and easy to remember but also have the
 added benefit of categorizing the commits for building release notes, change logs, etc. This becomes
-handy when coupled with another tool, link:https://www.alchemists.io/projects/milestoner[Milestoner],
-for producing consistent project milestones and Git tag histories.
+handy when coupled with another tool,
+link:https://www.alchemists.io/projects/milestoner[Milestoner], for producing consistent project
+milestones and Git tag histories. For a deeper dive on subject prefixes and good commit messages in
+general, please read about link:https://www.alchemists.io/articles/git_commit_anatomy[commit anatomy
+] to learn more. 🎉
 
-Automatically ignores _fixup!_ or _squash!_ commit prefixes when used as a Git Hook in order to not
-disturb interactive rebase workflows.
+💡 This analyzer automatically ignores _amend!_, _fixup!_, or _squash!_ commit prefixes when used as
+a Git Hook in order to not disturb interactive rebase workflows.
 
 === Commit Subject Suffix
 
@@ -947,7 +953,7 @@ configuration disabled.
 
 === Tags
 
-* Use tags to denote milestones/releases:
+* Use tags to denote link:https://www.alchemists.io/projects/milestoner[milestones]/releases:
 ** Makes it easier to record milestones and capture associated release notes.
 ** Makes it easier to compare differences between versions.
 ** Provides a starting point for debugging production issues (if any).
@@ -972,124 +978,8 @@ configuration disabled.
 
 === Code Reviews
 
-There are three main objectives each code review should achieve:
-
-. *Joy* - The experience of working with you, receiving feedback, giving feedback, and demonstrating
-   a level of care influences others and encourages a collaborative environment that is fun to work
-   in. Use this time to build and reinforce trust amongst your fellow colleagues.
-. *Quality*: Ensures changes are of highest quality that adhere to team standards while enhancing
-   the customer experience and not disrupting their workflow.
-. *Education*: Provides a chance for everyone on the team to learn more about the architecture,
-   product/service, and how each member of the team implements a solution. This is your chance to
-   ask questions and learn how to be a better engineer so take advantage of it.
-
-In addition to the objectives above, the following guidelines are worth following:
-
-* Keep code reviews short and easy to review:
-** Review your own code first before submitting to others. By ensuring your are confident in the
-   overall implementation and the commits in terms of commit messages and implementation details,
-   you'll encourage higher quality feedback and show appreciation for the reviewer's time.
-** Provide a high level overview that answers _why_ the code review is necessary.
-** Provide a link to the issue that prompted the code review (if any) and any additional details
-   worth highlighting to guide the reviewer through the process.
-** Provide screenshots/screencasts if possible.
-** Provide any ancillary notes or points of interest worth highlighting for the reviewer.
-** Ensure commits within the code review are related to the purpose of the code review and avoid
-   mixing in changes that are ancillary to the primary objective of the code view. If you do have
-   changes outside of the scope of the current code review, open those changes up as a separate code
-   review instead.
-** Prefer code reviews at about 300 lines in order to keep the quality of the code review and defect
-   detection high. This also shows you value the reviewers time and attention away from their own
-   work.
-** Avoid working on a large issues without first getting feedback in order to not overwhelm/surprise
-   the maintainers. More discussion up front will help ensure your work has a faster chance of
-   acceptance.
-* Review and rebase code reviews quickly:
-** Maintain a consistent but reasonable pace -- Review morning, noon, and night.
-** Avoid letting code reviews linger more than a day. Otherwise, you risk hampering moral and
-   diminishing the productivity of the team.
-* Use emojis, with a format of `<emoji> <feedback>`, to identify the kinds of feedback used during
-  the review process:
-** 🍵 (`:tea:`) - Signifies you are starting the code review. This is _non-blocking_ and
-    informational. Useful when reading over a code review with a large number of commits, complex
-    code, requires additional testing by the reviewer, etc.
-** ⭐️ (`:star:`) - Signifies code that is liked, favorited, remarkable, etc. This feedback is
-    _non-blocking_ and is always meant to be positive/uplifting.
-** ℹ️ (`:information_source:`) - Signifies informational feedback that is
-    _non-blocking_. Can also be used to let one know you are done reviewing but haven't approved yet
-    (due to feedback that needs addressing), rebasing a code review and then merging, waiting for a
-    blocking code review to be resolved, status updates to the code review, etc.
-** 💭 (`:thought_balloon:`) - Signifies inquisitive intent that is _non-blocking_.
-    Useful when asking questions and/or probing deeper into implementation details to learn more.
-** 🔤 (`:abc:`) - Signifies detection of a misspelling with suggested correction. This is
-    _blocking_ feedback that is easy to correct.
-** 🎨 (`:art:`) - Signifies an issue with code style and/or code quality. This can be _blocking_
-    or _non-blocking_ feedback. It is up to the discretion of the author on how to address the
-    feedback but encouraged that the feedback is incorporated or at least discussed. Generally,
-    these situations are automatically detected via code linters but there are occasions where
-    there is ambiguity in which linters can't catch.
-** 🏛 (`:classical_building:`) - Signifies an issue with the architecture of the
-    implementation. This is _blocking_ and requires immediate correction. The reviewer should
-    provide a suggested solution and/or links to patterns, articles, etc. that might help the author
-    fix the implementation. Pairing is encouraged if feedback is vast and/or complex.
-** 🔓 (`:unlock:`) - Signifies a security violation that would damage us and/or our customers. This
-   is _blocking_ feedback and must be addressed immediately.
-** 💡 (`:bulb:`) - Indicates a helpful tip or trick for improving the code. This can be
-    _blocking_ or _non-blocking_ feedback and is left up to the author to decide. Generally, it is a
-    good idea to address and resolve the feedback.
-** 🙇 (`:bow:`) - Indicates thankfulness of the feedback received. This is _non-blocking_ and
-    always meant as a response to helpful feedback.
-** ✅ (`:white_check_mark:`) - Signifies code review approval. The author can
-    rebase onto `main` and delete the feature branch at this point.
-* Use all feedback as a chance to learn, teach, strenghen the bond of trust between you and your
-  fellow colleagues, and avoid being cut by
-  link:https://fs.blog/2017/04/mental-model-hanlons-razor[Hanlon's Razor].
-* Use automation to ensure code reviews are consistent, of high quality, and swift to resolve. Each
-  code review can be an opportunity to identify and automate the process further.
-* Use face-to-face communication if a code review's written discussion gets lengthy/noisy.
-* Create follow-up actions if additional features are discovered during a code review to avoid
-  delaying code review acceptance. Return to the code review once the new actions have been logged.
-* The author, not the reviewer, should rebase the feature branch onto `main` upon approval.
-* Avoid reviewing your own code review before rebasing onto `main`. Have another pair of eyes
-  review your code first.
-* Ensure the following criteria is met before rebasing your feature branch to `main`:
-** Ensure all `fixup!` and `squash!` commits are interactively rebased. _Avoid rebasing these onto
-   the `main` branch!_
-** Ensure your feature branch is rebased upon `main`.
-** Ensure all tests and code quality checks are passing.
-** Ensure the feature branch is deleted after being successfully rebased.
-
-=== GitHub
-
-When using GitHub, enforce a rebase workflow for all of your GitHub projects (_highly recommended_).
-You can do this via your project options (i.e. `https://github.com/<username/<project>/settings`)
-and editing your merge options for code reviews as follows:
-
-image::https://www.alchemists.io/images/projects/git-lint/screenshots/github-settings-options.png[GitHub Merge Options]
-
-In addition to the above, you'll want to add _branch_ protection rules for your `main` branch. To
-do this, follow these steps:
-
-. Visit your branch settings (i.e. `https://github.com/<username>/<project>/settings/branches`).
-. Click the _Add rule_ button.
-. For _branch name pattern_, enter: `main`.
-. Check _Require pull request reviews before merging_.
-. Set _Required approving reviews_ to `2` as a minimum.
-. Check _Dismiss stale pull request approvals when new commits are pushed_.
-. Check _Require review from Code Owners_.
-. Check _Require status checks to pass before merging_.
-. Check _Require branches to be up to date before merging_.
-. Check _Require signed commits_.
-. Check _Require linear history_ (pairs well with the merge options mentioned above).
-. Check _Include administrators_.
-. Uncheck _Allow force pushes_.
-. Uncheck _Allow deletions_.
-
-With the above applied, you should have the following result:
-
-image::https://www.alchemists.io/images/projects/git-lint/screenshots/github-settings-branch_protections.png[GitHub Branch Protections]
-
-Applying the above changes will help maintain a clean Git history.
+For an in depth look at how to conduct code reviews, please read my
+link:https://www.alchemists.io/articles/code_reviews[article] on this subject to learn more.
 
 == Development
 

data/lib/git/lint/analyzers/abstract.rb

@@ -18,25 +18,17 @@ module Git
           @descendants << klass unless klass.to_s.start_with? "#<Class" # Ignore anonymous classes.
         end
 
-        def self.id
-          to_s.delete_prefix("Git::Lint::Analyzers").snakecase.to_sym
-        end
+        def self.id = to_s.delete_prefix("Git::Lint::Analyzers").snakecase.to_sym
 
-        def self.label
-          to_s.delete_prefix("Git::Lint::Analyzers").titleize
-        end
+        def self.label = to_s.delete_prefix("Git::Lint::Analyzers").titleize
 
         def self.defaults
           fail NotImplementedError, "The `.#{__method__}` method must be implemented."
         end
 
-        def self.descendants
-          @descendants || []
-        end
+        def self.descendants = @descendants || []
 
-        def self.build_issue_line index, line
-          {number: index + ISSUE_LINE_OFFSET, content: line}
-        end
+        def self.build_issue_line(index, line) = {number: index + ISSUE_LINE_OFFSET, content: line}
 
         attr_reader :commit
 
@@ -46,9 +38,7 @@ module Git
           @filter_list = load_filter_list
         end
 
-        def enabled?
-          settings.fetch :enabled
-        end
+        def enabled? = settings.fetch(:enabled)
 
         def severity
           settings.fetch(:severity).tap do |level|
@@ -60,17 +50,11 @@ module Git
           fail NotImplementedError, "The `##{__method__}` method must be implemented."
         end
 
-        def invalid?
-          !valid?
-        end
+        def invalid? = !valid?
 
-        def warning?
-          invalid? && severity == :warn
-        end
+        def warning? = invalid? && severity == :warn
 
-        def error?
-          invalid? && severity == :error
-        end
+        def error? = invalid? && severity == :error
 
         def issue
           fail NotImplementedError, "The `##{__method__}` method must be implemented."
@@ -80,9 +64,7 @@ module Git
 
         attr_reader :settings, :filter_list
 
-        def load_filter_list
-          Kit::FilterList.new settings[:list]
-        end
+        def load_filter_list = Kit::FilterList.new(settings[:list])
 
         def affected_commit_body_lines
           commit.body_lines.each.with_object([]).with_index do |(line, lines), index|

data/lib/git/lint/analyzers/commit_author_capitalization.rb

@@ -16,9 +16,7 @@ module Git
           @validator = validator
         end
 
-        def valid?
-          validator.new(commit.author_name).valid?
-        end
+        def valid? = validator.new(commit.author_name).valid?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_author_email.rb

@@ -16,9 +16,7 @@ module Git
           @validator = validator
         end
 
-        def valid?
-          validator.new(commit.author_email).valid?
-        end
+        def valid? = validator.new(commit.author_email).valid?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_author_name.rb

@@ -17,9 +17,7 @@ module Git
           @validator = validator
         end
 
-        def valid?
-          validator.new(commit.author_name, minimum: minimum).valid?
-        end
+        def valid? = validator.new(commit.author_name, minimum: minimum).valid?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_body_bullet.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.all? { |line| !invalid_line? line }
-        end
+        def valid? = commit.body_lines.all? { |line| !invalid_line? line }
 
         def issue
           return {} if valid?
@@ -27,9 +25,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :excludes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
 
         # :reek:FeatureEnvy
         def invalid_line? line

data/lib/git/lint/analyzers/commit_body_bullet_capitalization.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          lowercased_bullets.size.zero?
-        end
+        def valid? = lowercased_bullets.size.zero?
 
         def issue
           return {} if valid?
@@ -27,9 +25,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
         def invalid_line? line
           line.match?(/\A\s*#{Regexp.union filter_list.to_regexp}\s[[:lower:]]+/)
@@ -37,9 +33,7 @@ module Git
 
         private
 
-        def lowercased_bullets
-          commit.body_lines.select { |line| invalid_line? line }
-        end
+        def lowercased_bullets = commit.body_lines.select { |line| invalid_line? line }
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_bullet_delimiter.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.none? { |line| invalid_line? line }
-        end
+        def valid? = commit.body_lines.none? { |line| invalid_line? line }
 
         def issue
           return {} if valid?
@@ -27,17 +25,11 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
-        def invalid_line? line
-          line.match?(/\A\s*#{pattern}(?!(#{pattern}|\s)).+\Z/)
-        end
+        def invalid_line?(line) = line.match?(/\A\s*#{pattern}(?!(#{pattern}|\s)).+\Z/)
 
-        def pattern
-          Regexp.union filter_list.to_regexp
-        end
+        def pattern = Regexp.union(filter_list.to_regexp)
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_issue_tracker_link.rb

@@ -17,9 +17,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.none? { |line| invalid_line? line }
-        end
+        def valid? = commit.body_lines.none? { |line| invalid_line? line }
 
         def issue
           return {} if valid?
@@ -32,13 +30,9 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :excludes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
 
-        def invalid_line? line
-          line.match?(/.*#{Regexp.union filter_list.to_regexp}.*/)
-        end
+        def invalid_line?(line) = line.match?(/.*#{Regexp.union filter_list.to_regexp}.*/)
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_line_length.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.all? { |line| !invalid_line? line }
-        end
+        def valid? = commit.body_lines.all? { |line| !invalid_line? line }
 
         def issue
           return {} if valid?
@@ -27,15 +25,11 @@ module Git
 
         protected
 
-        def invalid_line? line
-          line.length > length
-        end
+        def invalid_line?(line) = line.length > length
 
         private
 
-        def length
-          settings.fetch :length
-        end
+        def length = settings.fetch(:length)
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_paragraph_capitalization.rb

@@ -11,13 +11,9 @@ module Git
           }
         end
 
-        def self.invalid? line
-          line.match?(/\A[[:lower:]].+\Z/m)
-        end
+        def self.invalid?(line) = line.match?(/\A[[:lower:]].+\Z/m)
 
-        def valid?
-          lowercased_lines.empty?
-        end
+        def valid? = lowercased_lines.empty?
 
         def issue
           return {} if valid?
@@ -30,9 +26,7 @@ module Git
 
         private
 
-        def lowercased_lines
-          commit.body_paragraphs.select { |line| self.class.invalid? line }
-        end
+        def lowercased_lines = commit.body_paragraphs.select { |line| self.class.invalid? line }
 
         def affected_lines
           klass = self.class

data/lib/git/lint/analyzers/commit_body_phrase.rb

@@ -41,9 +41,7 @@ module Git
         end
         # rubocop:enable Metrics/MethodLength
 
-        def valid?
-          commit.body_lines.all? { |line| !invalid_line? line }
-        end
+        def valid? = commit.body_lines.all? { |line| !invalid_line? line }
 
         def issue
           return {} if valid?
@@ -56,9 +54,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch(:excludes)
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
 
         def invalid_line? line
           line.downcase.match? Regexp.new(

data/lib/git/lint/analyzers/commit_body_presence.rb

@@ -4,7 +4,7 @@ module Git
   module Lint
     module Analyzers
       class CommitBodyPresence < Abstract
-        using Refinements::Strings
+        using GitPlus::Refinements::Strings
 
         def self.defaults
           {
@@ -21,9 +21,7 @@ module Git
           valid_lines.size >= minimum
         end
 
-        def minimum
-          settings.fetch :minimum
-        end
+        def minimum = settings.fetch(:minimum)
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_body_single_bullet.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          affected_commit_body_lines.size != 1
-        end
+        def valid? = affected_commit_body_lines.size != 1
 
         def issue
           return {} if valid?
@@ -27,13 +25,9 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
-        def invalid_line? line
-          line.match?(/\A#{Regexp.union filter_list.to_regexp}\s+/)
-        end
+        def invalid_line?(line) = line.match?(/\A#{Regexp.union filter_list.to_regexp}\s+/)
       end
     end
   end

data/lib/git/lint/analyzers/commit_subject_length.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.subject.sub(/(fixup!|squash!)\s{1}/, "").size <= length
-        end
+        def valid? = commit.subject.sub(/(fixup!|squash!)\s{1}/, "").size <= length
 
         def issue
           return {} if valid?
@@ -24,9 +22,7 @@ module Git
 
         private
 
-        def length
-          settings.fetch :length
-        end
+        def length = settings.fetch(:length)
       end
     end
   end

data/lib/git/lint/analyzers/commit_subject_prefix.rb

@@ -13,7 +13,7 @@ module Git
         end
 
         def valid?
-          return true if fixup_or_squash?
+          return true if commit.prefix?
           return true if filter_list.empty?
 
           commit.subject.match?(/\A#{Regexp.union filter_list.to_regexp}/)
@@ -27,15 +27,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch(:includes)
-        end
-
-        private
-
-        def fixup_or_squash?
-          commit.fixup? || commit.squash?
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
       end
     end
   end

data/lib/git/lint/analyzers/commit_subject_suffix.rb

@@ -30,9 +30,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch(:excludes)
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
       end
     end
   end

data/lib/git/lint/analyzers/commit_trailer_collaborator_capitalization.rb

@@ -22,9 +22,7 @@ module Git
         end
         # rubocop:enable Metrics/ParameterLists
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_trailer_collaborator_duplication.rb

@@ -19,9 +19,7 @@ module Git
           @tally = build_tally
         end
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_trailer_collaborator_email.rb

@@ -23,9 +23,7 @@ module Git
         end
         # rubocop:enable Metrics/ParameterLists
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_trailer_collaborator_key.rb

@@ -19,9 +19,7 @@ module Git
           @parser = parser
         end
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
@@ -34,9 +32,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
         def invalid_line? line
           collaborator = parser.new line

data/lib/git/lint/analyzers/commit_trailer_collaborator_name.rb

@@ -24,9 +24,7 @@ module Git
         end
         # rubocop:enable Metrics/ParameterLists
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
@@ -48,9 +46,7 @@ module Git
 
         attr_reader :parser, :validator
 
-        def minimum
-          settings.fetch :minimum
-        end
+        def minimum = settings.fetch(:minimum)
       end
     end
   end

data/lib/git/lint/branches/environments/circle_ci.rb

@@ -10,13 +10,9 @@ module Git
             @repository = repository
           end
 
-          def name
-            "origin/#{repository.branch_name}"
-          end
+          def name = "origin/#{repository.branch_name}"
 
-          def commits
-            repository.commits "origin/#{repository.branch_default}..#{name}"
-          end
+          def commits = repository.commits("origin/#{repository.branch_default}..#{name}")
 
           private
 

data/lib/git/lint/branches/environments/git_hub_action.rb

@@ -10,13 +10,9 @@ module Git
             @repository = repository
           end
 
-          def name
-            "origin/#{repository.branch_name}"
-          end
+          def name = "origin/#{repository.branch_name}"
 
-          def commits
-            repository.commits "origin/#{repository.branch_default}..#{name}"
-          end
+          def commits = repository.commits("origin/#{repository.branch_default}..#{name}")
 
           private
 

data/lib/git/lint/branches/environments/local.rb

@@ -10,13 +10,9 @@ module Git
             @repository = repository
           end
 
-          def name
-            repository.branch_name
-          end
+          def name = repository.branch_name
 
-          def commits
-            repository.commits "#{repository.branch_default}..#{name}"
-          end
+          def commits = repository.commits("#{repository.branch_default}..#{name}")
 
           private
 

data/lib/git/lint/branches/environments/netlify_ci.rb

@@ -14,9 +14,7 @@ module Git
             @environment = environment
           end
 
-          def name
-            environment["HEAD"]
-          end
+          def name = environment["HEAD"]
 
           def commits
             shell.capture3 "git remote add -f origin #{environment["REPOSITORY_URL"]}"

data/lib/git/lint/branches/environments/travis_ci.rb

@@ -14,9 +14,7 @@ module Git
             @environment = environment
           end
 
-          def name
-            pull_request_branch.empty? ? ci_branch : pull_request_branch
-          end
+          def name = pull_request_branch.empty? ? ci_branch : pull_request_branch
 
           def commits
             prepare_project
@@ -39,17 +37,11 @@ module Git
             shell.capture3 "git fetch"
           end
 
-          def ci_branch
-            environment["TRAVIS_BRANCH"]
-          end
+          def ci_branch = environment["TRAVIS_BRANCH"]
 
-          def pull_request_branch
-            environment["TRAVIS_PULL_REQUEST_BRANCH"]
-          end
+          def pull_request_branch = environment["TRAVIS_PULL_REQUEST_BRANCH"]
 
-          def pull_request_slug
-            environment["TRAVIS_PULL_REQUEST_SLUG"]
-          end
+          def pull_request_slug = environment["TRAVIS_PULL_REQUEST_SLUG"]
         end
       end
     end

data/lib/git/lint/branches/feature.rb

@@ -35,9 +35,7 @@ module Git
           end
         end
 
-        def key? key
-          current_environment.fetch(key, "false").to_bool
-        end
+        def key?(key) = current_environment.fetch(key, "false").to_bool
       end
     end
   end

data/lib/git/lint/cli.rb

@@ -71,17 +71,14 @@ module Git
 
       desc "--hook", "Add Git Hook support."
       map "--hook" => :hook
-      method_option :commit_message,
-                    desc: "Analyze commit message.",
-                    banner: "PATH",
-                    type: :string
+      method_option :commit_message, desc: "Analyze commit message.", banner: "PATH", type: :string
       def hook
         if options.commit_message?
           check_commit_message options.commit_message
         else
           help "--hook"
         end
-      rescue Errors::Base, GitPlus::Errors::Base => error
+      rescue Errors::Base, GitPlus::Error => error
         abort colorizer.red("#{Identity::LABEL}: #{error.message}")
       end
 

data/lib/git/lint/collector.rb

@@ -16,45 +16,25 @@ module Git
         analyzer
       end
 
-      def retrieve id
-        collection[id]
-      end
+      def retrieve(id) = collection[id]
 
-      def empty?
-        collection.empty?
-      end
+      def empty? = collection.empty?
 
-      def warnings?
-        collection.values.flatten.any?(&:warning?)
-      end
+      def warnings? = collection.values.flatten.any?(&:warning?)
 
-      def errors?
-        collection.values.flatten.any?(&:error?)
-      end
+      def errors? = collection.values.flatten.any?(&:error?)
 
-      def issues?
-        collection.values.flatten.any?(&:invalid?)
-      end
+      def issues? = collection.values.flatten.any?(&:invalid?)
 
-      def total_warnings
-        collection.values.flatten.count(&:warning?)
-      end
+      def total_warnings = collection.values.flatten.count(&:warning?)
 
-      def total_errors
-        collection.values.flatten.count(&:error?)
-      end
+      def total_errors = collection.values.flatten.count(&:error?)
 
-      def total_issues
-        collection.values.flatten.count(&:invalid?)
-      end
+      def total_issues = collection.values.flatten.count(&:invalid?)
 
-      def total_commits
-        collection.keys.size
-      end
+      def total_commits = collection.keys.size
 
-      def to_h
-        collection
-      end
+      def to_h = collection
 
       private
 

data/lib/git/lint/identity.rb

@@ -6,7 +6,7 @@ module Git
     module Identity
       NAME = "git-lint"
       LABEL = "Git Lint"
-      VERSION = "2.2.0"
+      VERSION = "2.3.2"
       VERSION_LABEL = "#{LABEL} #{VERSION}"
     end
   end

data/lib/git/lint/kit/filter_list.rb

@@ -9,17 +9,11 @@ module Git
           @list = Array list
         end
 
-        def to_hint
-          to_regexp.map(&:inspect).join ", "
-        end
+        def to_hint = to_regexp.map(&:inspect).join(", ")
 
-        def to_regexp
-          list.map { |item| Regexp.new item }
-        end
+        def to_regexp = list.map { |item| Regexp.new item }
 
-        def empty?
-          list.empty?
-        end
+        def empty? = list.empty?
 
         private
 

data/lib/git/lint/parsers/trailers/collaborator.rb

@@ -27,21 +27,13 @@ module Git
             @matches = build_matches
           end
 
-          def key
-            String matches["key"]
-          end
+          def key = String(matches["key"])
 
-          def name
-            String matches["name"]
-          end
+          def name = String(matches["name"])
 
-          def email
-            String(matches["email"]).delete_prefix("<").delete_suffix(">")
-          end
+          def email = String(matches["email"]).delete_prefix("<").delete_suffix(">")
 
-          def match?
-            text.match? key_pattern
-          end
+          def match? = text.match?(key_pattern)
 
           private
 

data/lib/git/lint/rake/tasks.rb

@@ -9,9 +9,7 @@ module Git
       class Tasks
         include ::Rake::DSL
 
-        def self.setup
-          new.install
-        end
+        def self.setup = new.install
 
         def initialize cli: CLI
           @cli = cli

data/lib/git/lint/refinements/strings.rb

@@ -11,13 +11,9 @@ module Git
             "#{count} #{self}#{suffix}"
           end
 
-          def fixup?
-            match?(/\Afixup!\s/)
-          end
+          def fixup? = match?(/\Afixup!\s/)
 
-          def squash?
-            match?(/\Asquash!\s/)
-          end
+          def squash? = match?(/\Asquash!\s/)
         end
       end
     end

data/lib/git/lint/reporters/branch.rb

@@ -7,7 +7,7 @@ module Git
     module Reporters
       # Reports issues related to a single branch.
       class Branch
-        using Refinements::Strings
+        using GitPlus::Refinements::Strings
 
         def initialize collector: Collector.new, colorizer: Pastel.new
           @collector = collector

data/lib/git/lint/reporters/commit.rb

@@ -21,9 +21,7 @@ module Git
 
         attr_reader :commit, :analyzers
 
-        def report
-          analyzers.reduce("") { |report, analyzer| report + Style.new(analyzer).to_s }
-        end
+        def report = analyzers.reduce("") { |report, analyzer| report + Style.new(analyzer).to_s }
       end
     end
   end

data/lib/git/lint/reporters/line.rb

@@ -23,9 +23,7 @@ module Git
 
         attr_reader :data
 
-        def content
-          data.fetch :content
-        end
+        def content = data.fetch(__method__)
       end
     end
   end

data/lib/git/lint/reporters/lines/paragraph.rb

@@ -17,13 +17,9 @@ module Git
 
           attr_reader :data
 
-          def label
-            "#{Line::DEFAULT_INDENT}Line #{number}: "
-          end
+          def label = "#{Line::DEFAULT_INDENT}Line #{number}: "
 
-          def paragraph
-            formatted_lines.join "\n"
-          end
+          def paragraph = formatted_lines.join("\n")
 
           def formatted_lines
             content.split("\n").map.with_index do |line, index|
@@ -31,17 +27,11 @@ module Git
             end
           end
 
-          def indent
-            " " * (label.length + 1)
-          end
+          def indent = " " * (label.length + 1)
 
-          def number
-            data.fetch :number
-          end
+          def number = data.fetch(:number)
 
-          def content
-            data.fetch :content
-          end
+          def content = data.fetch(:content)
         end
       end
     end

data/lib/git/lint/reporters/lines/sentence.rb

@@ -9,21 +9,15 @@ module Git
             @data = data
           end
 
-          def to_s
-            %(#{Line::DEFAULT_INDENT}Line #{number}: "#{content}"\n)
-          end
+          def to_s = %(#{Line::DEFAULT_INDENT}Line #{number}: "#{content}"\n)
 
           private
 
           attr_reader :data
 
-          def number
-            data.fetch :number
-          end
+          def number = data.fetch(:number)
 
-          def content
-            data.fetch :content
-          end
+          def content = data.fetch(:content)
         end
       end
     end

data/lib/git/lint/reporters/style.rb

@@ -13,9 +13,7 @@ module Git
           @colorizer = colorizer
         end
 
-        def to_s
-          colorizer.public_send color, message
-        end
+        def to_s = colorizer.public_send(color, message)
 
         private
 

data/lib/git/lint/validators/capitalization.rb

@@ -12,17 +12,13 @@ module Git
           @pattern = pattern
         end
 
-        def valid?
-          parts.all? { |name| String(name).match? pattern }
-        end
+        def valid? = parts.all? { |name| String(name).match? pattern }
 
         private
 
         attr_reader :text, :delimiter, :pattern
 
-        def parts
-          text.split delimiter
-        end
+        def parts = text.split(delimiter)
       end
     end
   end

data/lib/git/lint/validators/email.rb

@@ -11,9 +11,7 @@ module Git
           @pattern = pattern
         end
 
-        def valid?
-          String(text).match? pattern
-        end
+        def valid? = String(text).match?(pattern)
 
         private
 

data/lib/git/lint/validators/name.rb

@@ -13,17 +13,13 @@ module Git
           @minimum = minimum
         end
 
-        def valid?
-          parts.size >= minimum && parts.all? { |name| !String(name).empty? }
-        end
+        def valid? = parts.size >= minimum && parts.all? { |name| !String(name).empty? }
 
         private
 
         attr_reader :text, :delimiter, :minimum
 
-        def parts
-          String(text).split delimiter
-        end
+        def parts = String(text).split(delimiter)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git-lint
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.2
 platform: ruby
 authors:
 - Brooke Kuhlmann
@@ -28,7 +28,7 @@ cert_chain:
   lkHilIrX69jq8wMPpBhlaw2mRmeSL50Wv5u6xVBvOHhXFSP1crXM95vfLhLyRYod
   W2A=
   -----END CERTIFICATE-----
-date: 2021-04-04 00:00:00.000000000 Z
+date: 2021-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git_plus
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: pastel
   requirement: !ruby/object:Gem::Requirement
@@ -186,7 +186,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.2.25
 signing_key:
 specification_version: 4
 summary: A command line interface for linting Git commits.