git-lint 2.0.0 → 2.3.1

data/lib/git/lint/analyzers/commit_body_bullet_delimiter.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.none? { |line| invalid_line? line }
-        end
+        def valid? = commit.body_lines.none? { |line| invalid_line? line }
 
         def issue
           return {} if valid?
@@ -27,17 +25,11 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
-        def invalid_line? line
-          line.match?(/\A\s*#{pattern}(?!(#{pattern}|\s)).+\Z/)
-        end
+        def invalid_line?(line) = line.match?(/\A\s*#{pattern}(?!(#{pattern}|\s)).+\Z/)
 
-        def pattern
-          Regexp.union filter_list.to_regexp
-        end
+        def pattern = Regexp.union(filter_list.to_regexp)
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_issue_tracker_link.rb

@@ -17,9 +17,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.none? { |line| invalid_line? line }
-        end
+        def valid? = commit.body_lines.none? { |line| invalid_line? line }
 
         def issue
           return {} if valid?
@@ -32,13 +30,9 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :excludes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
 
-        def invalid_line? line
-          line.match?(/.*#{Regexp.union filter_list.to_regexp}.*/)
-        end
+        def invalid_line?(line) = line.match?(/.*#{Regexp.union filter_list.to_regexp}.*/)
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_line_length.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.all? { |line| !invalid_line? line }
-        end
+        def valid? = commit.body_lines.all? { |line| !invalid_line? line }
 
         def issue
           return {} if valid?
@@ -27,15 +25,11 @@ module Git
 
         protected
 
-        def invalid_line? line
-          line.length > length
-        end
+        def invalid_line?(line) = line.length > length
 
         private
 
-        def length
-          settings.fetch :length
-        end
+        def length = settings.fetch(:length)
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_paragraph_capitalization.rb

@@ -11,13 +11,9 @@ module Git
           }
         end
 
-        def self.invalid? line
-          line.match?(/\A[[:lower:]].+\Z/m)
-        end
+        def self.invalid?(line) = line.match?(/\A[[:lower:]].+\Z/m)
 
-        def valid?
-          lowercased_lines.empty?
-        end
+        def valid? = lowercased_lines.empty?
 
         def issue
           return {} if valid?
@@ -30,9 +26,7 @@ module Git
 
         private
 
-        def lowercased_lines
-          commit.body_paragraphs.select { |line| self.class.invalid? line }
-        end
+        def lowercased_lines = commit.body_paragraphs.select { |line| self.class.invalid? line }
 
         def affected_lines
           klass = self.class

data/lib/git/lint/analyzers/commit_body_phrase.rb

@@ -41,9 +41,7 @@ module Git
         end
         # rubocop:enable Metrics/MethodLength
 
-        def valid?
-          commit.body_lines.all? { |line| !invalid_line? line }
-        end
+        def valid? = commit.body_lines.all? { |line| !invalid_line? line }
 
         def issue
           return {} if valid?
@@ -56,9 +54,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch(:excludes)
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
 
         def invalid_line? line
           line.downcase.match? Regexp.new(

data/lib/git/lint/analyzers/commit_body_presence.rb

@@ -4,7 +4,7 @@ module Git
   module Lint
     module Analyzers
       class CommitBodyPresence < Abstract
-        using Refinements::Strings
+        using GitPlus::Refinements::Strings
 
         def self.defaults
           {
@@ -21,9 +21,7 @@ module Git
           valid_lines.size >= minimum
         end
 
-        def minimum
-          settings.fetch :minimum
-        end
+        def minimum = settings.fetch(:minimum)
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_body_single_bullet.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          affected_commit_body_lines.size != 1
-        end
+        def valid? = affected_commit_body_lines.size != 1
 
         def issue
           return {} if valid?
@@ -27,13 +25,9 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
-        def invalid_line? line
-          line.match?(/\A#{Regexp.union filter_list.to_regexp}\s+/)
-        end
+        def invalid_line?(line) = line.match?(/\A#{Regexp.union filter_list.to_regexp}\s+/)
       end
     end
   end

data/lib/git/lint/analyzers/commit_subject_length.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.subject.sub(/(fixup!|squash!)\s{1}/, "").size <= length
-        end
+        def valid? = commit.subject.sub(/(fixup!|squash!)\s{1}/, "").size <= length
 
         def issue
           return {} if valid?
@@ -24,9 +22,7 @@ module Git
 
         private
 
-        def length
-          settings.fetch :length
-        end
+        def length = settings.fetch(:length)
       end
     end
   end

data/lib/git/lint/analyzers/commit_subject_prefix.rb

@@ -13,7 +13,7 @@ module Git
         end
 
         def valid?
-          return true if fixup_or_squash?
+          return true if commit.prefix?
           return true if filter_list.empty?
 
           commit.subject.match?(/\A#{Regexp.union filter_list.to_regexp}/)
@@ -27,15 +27,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch(:includes)
-        end
-
-        private
-
-        def fixup_or_squash?
-          commit.fixup? || commit.squash?
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
       end
     end
   end

data/lib/git/lint/analyzers/commit_subject_suffix.rb

@@ -30,9 +30,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch(:excludes)
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
       end
     end
   end

data/lib/git/lint/analyzers/commit_trailer_collaborator_capitalization.rb

@@ -22,9 +22,7 @@ module Git
         end
         # rubocop:enable Metrics/ParameterLists
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_trailer_collaborator_duplication.rb

@@ -19,9 +19,7 @@ module Git
           @tally = build_tally
         end
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_trailer_collaborator_email.rb

@@ -23,9 +23,7 @@ module Git
         end
         # rubocop:enable Metrics/ParameterLists
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_trailer_collaborator_key.rb

@@ -19,9 +19,7 @@ module Git
           @parser = parser
         end
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
@@ -34,9 +32,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
         def invalid_line? line
           collaborator = parser.new line

data/lib/git/lint/analyzers/commit_trailer_collaborator_name.rb

@@ -24,9 +24,7 @@ module Git
         end
         # rubocop:enable Metrics/ParameterLists
 
-        def valid?
-          affected_commit_trailers.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
@@ -48,9 +46,7 @@ module Git
 
         attr_reader :parser, :validator
 
-        def minimum
-          settings.fetch :minimum
-        end
+        def minimum = settings.fetch(:minimum)
       end
     end
   end

data/lib/git/lint/branches/environments/circle_ci.rb

@@ -10,13 +10,9 @@ module Git
             @repository = repository
           end
 
-          def name
-            "origin/#{repository.branch_name}"
-          end
+          def name = "origin/#{repository.branch_name}"
 
-          def commits
-            repository.commits "origin/master..#{name}"
-          end
+          def commits = repository.commits("origin/#{repository.branch_default}..#{name}")
 
           private
 

data/lib/git/lint/branches/environments/git_hub_action.rb

@@ -10,13 +10,9 @@ module Git
             @repository = repository
           end
 
-          def name
-            "origin/#{repository.branch_name}"
-          end
+          def name = "origin/#{repository.branch_name}"
 
-          def commits
-            repository.commits "origin/master..#{name}"
-          end
+          def commits = repository.commits("origin/#{repository.branch_default}..#{name}")
 
           private
 

data/lib/git/lint/branches/environments/local.rb

@@ -10,13 +10,9 @@ module Git
             @repository = repository
           end
 
-          def name
-            repository.branch_name
-          end
+          def name = repository.branch_name
 
-          def commits
-            repository.commits "master..#{name}"
-          end
+          def commits = repository.commits("#{repository.branch_default}..#{name}")
 
           private
 

data/lib/git/lint/branches/environments/netlify_ci.rb

@@ -14,14 +14,12 @@ module Git
             @environment = environment
           end
 
-          def name
-            environment["HEAD"]
-          end
+          def name = environment["HEAD"]
 
           def commits
             shell.capture3 "git remote add -f origin #{environment["REPOSITORY_URL"]}"
             shell.capture3 "git fetch origin #{name}:#{name}"
-            repository.commits "origin/master..origin/#{name}"
+            repository.commits "origin/#{repository.branch_default}..origin/#{name}"
           end
 
           private

data/lib/git/lint/branches/environments/travis_ci.rb

@@ -14,13 +14,11 @@ module Git
             @environment = environment
           end
 
-          def name
-            pull_request_branch.empty? ? ci_branch : pull_request_branch
-          end
+          def name = pull_request_branch.empty? ? ci_branch : pull_request_branch
 
           def commits
             prepare_project
-            repository.commits "origin/master..#{name}"
+            repository.commits "origin/#{repository.branch_default}..#{name}"
           end
 
           private
@@ -35,21 +33,15 @@ module Git
               shell.capture3 "git fetch original_branch #{name}:#{name}"
             end
 
-            shell.capture3 "git remote set-branches --add origin master"
+            shell.capture3 "git remote set-branches --add origin #{repository.branch_default}"
             shell.capture3 "git fetch"
           end
 
-          def ci_branch
-            environment["TRAVIS_BRANCH"]
-          end
+          def ci_branch = environment["TRAVIS_BRANCH"]
 
-          def pull_request_branch
-            environment["TRAVIS_PULL_REQUEST_BRANCH"]
-          end
+          def pull_request_branch = environment["TRAVIS_PULL_REQUEST_BRANCH"]
 
-          def pull_request_slug
-            environment["TRAVIS_PULL_REQUEST_SLUG"]
-          end
+          def pull_request_slug = environment["TRAVIS_PULL_REQUEST_SLUG"]
         end
       end
     end

data/lib/git/lint/branches/feature.rb

@@ -35,9 +35,7 @@ module Git
           end
         end
 
-        def key? key
-          current_environment.fetch(key, "false").to_bool
-        end
+        def key?(key) = current_environment.fetch(key, "false").to_bool
       end
     end
   end