git-lint 11.0.0 → 11.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '09bc2331e668a1ed5e6851a60926668d1d392f4addd54a49ffed7fba63d78fcd'
-  data.tar.gz: b5937a91c8e8e100e054ef5209f5eb594c8facbca2fbd974acf637f3a147527d
+  metadata.gz: 62cc9f5a643edae10bb1f56299e1eb5ddf387077c5dee1a9fd86da6c752911af
+  data.tar.gz: abaef08bf9d812e901a7292b750d0434444b707415653b5e1e01ed9ae08e10b1
 SHA512:
-  metadata.gz: 6219f9cd5dad3b933a99ce75873c2f9bc8142f5cbf03c6886d2351b29fb1575396b2f4ddc0aff045b0cad546fe14419bd34d90dc1b6262a978d9991523e42a2c
-  data.tar.gz: a98ad6176494113b9eec2cde32f24412f6e4c361e240afed7260c90cc8e50f384f3d3a23a85f49e430566392d26e619d25fc066b5420f893257bd1642d88f009
+  metadata.gz: 67f273ead789248321314633d57dd7c90d84060c7534123ab31fdb87defa325dbeea5f34e22b15abd3a72e1156e46ddd5845afdac0822ca6cb2e68aee8d161df
+  data.tar.gz: 9583db5623950eda4dfa83037114be68737fc4f47817c98354c724efad478995b6ad21f38a72253c39003c1cfeeb7a071b82e89096dad818c29acb410ce16370

data/README.adoc

@@ -590,7 +590,7 @@ and provides the missing spec to ensure this doesn't happen again.
 Ensures a minimum number of lines are present within the commit body. Lines with empty characters
 (i.e. whitespace, carriage returns, etc.) are considered to be empty.
 
-Automatically ignores _fixup!_ commits as they are not meant to have bodies.
+Automatically ignores _fixup!_ directives because they are not meant to have bodies.
 
 ==== Commit Body Tracker Shorthand
 
@@ -675,7 +675,7 @@ Added documentation
 Added documentation
 ....
 
-Automatically ignores _amend!_, _fixup!_, or _squash!_ commit prefixes.
+Automatically ignores _amend!_, _fixup!_, and _squash!_ directives.
 
 ==== Commit Subject Length
 
@@ -690,7 +690,7 @@ lenient than the link:http://tbaggery.com/2008/04/19/a-note-about-git-commit-mes
 rule] as it gives one the ability to formulate a more descriptive subject line without being too
 wordy or suffer being word wrapped.
 
-Automatically ignores _fixup!_ or _squash!_ commit prefixes when calculating subject length.
+Automatically ignores _amend!_, _fixup!_, and _squash!_ directives.
 
 ==== Commit Subject Prefix
 
@@ -737,8 +737,7 @@ Each prefix is delimited by a space which is the default setting but can be cust
 Whatever you choose for a delimiter will not affect Git's special bang prefixes as described in the
 tip below.
 
-💡 This analyzer automatically ignores _amend!_, _fixup!_, or _squash!_ commit prefixes when used as
-a Git Hook in order to not disturb interactive rebase workflows.
+Automatically ignores _amend!_, _fixup!_, and _squash!_ directives.
 
 ==== Commit Subject Suffix
 
@@ -960,6 +959,8 @@ Milestone: patch
 
 This key is mandatory by default which means the key must always be present unless the repository is unpublished (i.e. has no origin). When the repository is unpublished, this gives you the freedom to release your initial version (i.e. 0.0.0) without this trailer. Once published, you'll need the trailer. To make the key optional, set mandatory to `false`.
 
+Automatically ignores _amend!_, _fixup!_, and _squash!_ directives.
+
 ==== Commit Trailer Milestone Value
 
 [options="header"]

data/git-lint.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name = "git-lint"
-  spec.version = "11.0.0"
+  spec.version = "11.1.0"
   spec.authors = ["Brooke Kuhlmann"]
   spec.email = ["brooke@alchemists.io"]
   spec.homepage = "https://alchemists.io/projects/git-lint"
@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "dry-monads", "~> 1.9"
   spec.add_dependency "dry-schema", "~> 1.15"
   spec.add_dependency "etcher", "~> 4.3"
-  spec.add_dependency "gitt", "~> 5.3"
+  spec.add_dependency "gitt", "~> 5.4"
   spec.add_dependency "infusible", "~> 5.0"
   spec.add_dependency "refinements", "~> 14.0"
   spec.add_dependency "runcom", "~> 13.0"

data/lib/git/lint/analyzers/commit_body_paragraph_new_line.rb

@@ -5,19 +5,40 @@ module Git
     module Analyzers
       # Analyzes proper capitalization of commit body paragraphs.
       class CommitBodyParagraphNewLine < Abstract
-        PATTERN = /
-          \n      # New line.
-          (?!     # Negative lookahead start.
-          \s{1,}  # Indentation.
-          |       # Or.
-          \s*     # Optional whitespace.
-          \#      # Comment character.
-          )       # Negative lookahead end.
-        /mx
-
-        def initialize(commit, pattern: PATTERN, **)
+        PATTERNS = {
+          general: /
+            \n      # New line.
+            (?!     # Negative lookahead start.
+            \s{1,}  # Indentation.
+            )       # Negative lookahead end.
+          /mx,
+          markup: /
+            \A       # Start of line.
+            (        # Start of conditional.
+            \s*\#    # Optional whitepace with comment.
+            |        # Or.
+            `        # Backtick.
+            |        # Or.
+            -        # Dash.
+            |        # Or.
+            _        # Underscore.
+            |        # Or.
+            \+       # Plus.
+            |        # Or.
+            \d+\.    # Ordered list item.
+            |        # Or.
+            \.       # Unordered list itme.
+            |        # Or.
+            \*       # Unordered list itme.
+            |        # Or.
+            \[.*?\]  # ASCII Doc code block.
+            )        # End of conditional.
+          /x
+        }.freeze
+
+        def initialize(commit, patterns: PATTERNS, **)
           super(commit, **)
-          @pattern = pattern
+          @patterns = patterns
         end
 
         def valid? = invalids.empty?
@@ -33,7 +54,7 @@ module Git
 
         private
 
-        attr_reader :pattern
+        attr_reader :patterns
 
         def affected_lines
           invalids.each.with_object [] do |line, lines|
@@ -42,7 +63,10 @@ module Git
         end
 
         def invalids
-          @invalids ||= commit.body_paragraphs.grep pattern
+          markup = patterns.fetch :markup
+          general = patterns.fetch :general
+
+          @invalids ||= commit.body_paragraphs.grep_v(markup).grep general
         end
       end
     end

data/lib/git/lint/analyzers/commit_trailer_milestone_key.rb

@@ -7,9 +7,7 @@ module Git
       class CommitTrailerMilestoneKey < Abstract
         include Dependencies[:git, setting: "trailers.milestone"]
 
-        def valid?
-          optional? && affected_commit_trailers.empty?
-        end
+        def valid? = !mandatory? && affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
@@ -32,13 +30,13 @@ module Git
 
         private
 
-        def optional?
-          return true unless mandatory?
+        def mandatory?
+          return false if commit.directive?
 
-          commit.trailers.any? { it.key == setting.name }
-        end
+          missing = commit.trailers.none? { it.key == setting.name }
 
-        def mandatory? = settings.commits_trailer_milestone_key_mandatory && git.origin?
+          settings.commits_trailer_milestone_key_mandatory && git.origin? && missing
+        end
 
         def hint_prefix
           settings.commits_trailer_milestone_key_mandatory ? "Use (manditory)" : "Use"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git-lint
 version: !ruby/object:Gem::Version
-  version: 11.0.0
+  version: 11.1.0
 platform: ruby
 authors:
 - Brooke Kuhlmann
@@ -125,14 +125,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.4'
 - !ruby/object:Gem::Dependency
   name: infusible
   requirement: !ruby/object:Gem::Requirement
@@ -347,7 +347,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.13
+rubygems_version: 4.0.14
 specification_version: 4
 summary: A command line interface for linting Git commits.
 test_files: []