git-lint 1.4.0 → 2.3.0

data/lib/git/lint/analyzers/commit_author_email.rb

@@ -16,9 +16,7 @@ module Git
           @validator = validator
         end
 
-        def valid?
-          validator.new(commit.author_email).valid?
-        end
+        def valid? = validator.new(commit.author_email).valid?
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_author_name.rb

@@ -17,9 +17,7 @@ module Git
           @validator = validator
         end
 
-        def valid?
-          validator.new(commit.author_name, minimum: minimum).valid?
-        end
+        def valid? = validator.new(commit.author_name, minimum: minimum).valid?
 
         def issue
           return {} if valid?
@@ -32,7 +30,7 @@ module Git
         attr_reader :validator
 
         def minimum
-          settings.fetch :minimum
+          settings.fetch __method__
         end
       end
     end

data/lib/git/lint/analyzers/commit_body_bullet.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.all? { |line| !invalid_line? line }
-        end
+        def valid? = commit.body_lines.all? { |line| !invalid_line? line }
 
         def issue
           return {} if valid?
@@ -27,9 +25,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :excludes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
 
         # :reek:FeatureEnvy
         def invalid_line? line

data/lib/git/lint/analyzers/commit_body_bullet_capitalization.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          lowercased_bullets.size.zero?
-        end
+        def valid? = lowercased_bullets.size.zero?
 
         def issue
           return {} if valid?
@@ -27,9 +25,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
         def invalid_line? line
           line.match?(/\A\s*#{Regexp.union filter_list.to_regexp}\s[[:lower:]]+/)
@@ -37,9 +33,7 @@ module Git
 
         private
 
-        def lowercased_bullets
-          commit.body_lines.select { |line| invalid_line? line }
-        end
+        def lowercased_bullets = commit.body_lines.select { |line| invalid_line? line }
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_bullet_delimiter.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.none? { |line| invalid_line? line }
-        end
+        def valid? = commit.body_lines.none? { |line| invalid_line? line }
 
         def issue
           return {} if valid?
@@ -27,17 +25,11 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
-        def invalid_line? line
-          line.match?(/\A\s*#{pattern}(?!(#{pattern}|\s)).+\Z/)
-        end
+        def invalid_line?(line) = line.match?(/\A\s*#{pattern}(?!(#{pattern}|\s)).+\Z/)
 
-        def pattern
-          Regexp.union filter_list.to_regexp
-        end
+        def pattern = Regexp.union(filter_list.to_regexp)
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_issue_tracker_link.rb

@@ -17,9 +17,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.none? { |line| invalid_line? line }
-        end
+        def valid? = commit.body_lines.none? { |line| invalid_line? line }
 
         def issue
           return {} if valid?
@@ -32,13 +30,9 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :excludes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
 
-        def invalid_line? line
-          line.match?(/.*#{Regexp.union filter_list.to_regexp}.*/)
-        end
+        def invalid_line?(line) = line.match?(/.*#{Regexp.union filter_list.to_regexp}.*/)
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_leading_line.rb

@@ -12,12 +12,12 @@ module Git
         end
 
         def valid?
-          raw_body = commit.raw_body
-          subject, body = raw_body.split "\n", 2
+          message = commit.message
+          subject, body = message.split "\n", 2
 
           return true if !String(subject).empty? && String(body).strip.empty?
 
-          raw_body.match?(/\A.+(\n\n|\#).+/m)
+          message.match?(/\A.+(\n\n|\#).+/m)
         end
 
         def issue

data/lib/git/lint/analyzers/commit_body_line_length.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.body_lines.all? { |line| !invalid_line? line }
-        end
+        def valid? = commit.body_lines.all? { |line| !invalid_line? line }
 
         def issue
           return {} if valid?
@@ -27,15 +25,11 @@ module Git
 
         protected
 
-        def invalid_line? line
-          line.length > length
-        end
+        def invalid_line?(line) = line.length > length
 
         private
 
-        def length
-          settings.fetch :length
-        end
+        def length = settings.fetch(:length)
       end
     end
   end

data/lib/git/lint/analyzers/commit_body_paragraph_capitalization.rb

@@ -11,13 +11,9 @@ module Git
           }
         end
 
-        def self.invalid? line
-          line.match?(/\A[[:lower:]].+\Z/m)
-        end
+        def self.invalid?(line) = line.match?(/\A[[:lower:]].+\Z/m)
 
-        def valid?
-          lowercased_lines.empty?
-        end
+        def valid? = lowercased_lines.empty?
 
         def issue
           return {} if valid?
@@ -30,9 +26,7 @@ module Git
 
         private
 
-        def lowercased_lines
-          commit.body_paragraphs.select { |line| self.class.invalid? line }
-        end
+        def lowercased_lines = commit.body_paragraphs.select { |line| self.class.invalid? line }
 
         def affected_lines
           klass = self.class

data/lib/git/lint/analyzers/commit_body_phrase.rb

@@ -41,9 +41,7 @@ module Git
         end
         # rubocop:enable Metrics/MethodLength
 
-        def valid?
-          commit.body_lines.all? { |line| !invalid_line? line }
-        end
+        def valid? = commit.body_lines.all? { |line| !invalid_line? line }
 
         def issue
           return {} if valid?
@@ -56,9 +54,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch(:excludes)
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
 
         def invalid_line? line
           line.downcase.match? Regexp.new(

data/lib/git/lint/analyzers/commit_body_presence.rb

@@ -4,7 +4,7 @@ module Git
   module Lint
     module Analyzers
       class CommitBodyPresence < Abstract
-        using Refinements::Strings
+        using GitPlus::Refinements::Strings
 
         def self.defaults
           {
@@ -21,9 +21,7 @@ module Git
           valid_lines.size >= minimum
         end
 
-        def minimum
-          settings.fetch :minimum
-        end
+        def minimum = settings.fetch(:minimum)
 
         def issue
           return {} if valid?

data/lib/git/lint/analyzers/commit_body_single_bullet.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          affected_commit_body_lines.size != 1
-        end
+        def valid? = affected_commit_body_lines.size != 1
 
         def issue
           return {} if valid?
@@ -27,13 +25,9 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
-        def invalid_line? line
-          line.match?(/\A#{Regexp.union filter_list.to_regexp}\s+/)
-        end
+        def invalid_line?(line) = line.match?(/\A#{Regexp.union filter_list.to_regexp}\s+/)
       end
     end
   end

data/lib/git/lint/analyzers/commit_subject_length.rb

@@ -12,9 +12,7 @@ module Git
           }
         end
 
-        def valid?
-          commit.subject.sub(/(fixup!|squash!)\s{1}/, "").size <= length
-        end
+        def valid? = commit.subject.sub(/(fixup!|squash!)\s{1}/, "").size <= length
 
         def issue
           return {} if valid?
@@ -24,9 +22,7 @@ module Git
 
         private
 
-        def length
-          settings.fetch :length
-        end
+        def length = settings.fetch(:length)
       end
     end
   end

data/lib/git/lint/analyzers/commit_subject_prefix.rb

@@ -13,7 +13,7 @@ module Git
         end
 
         def valid?
-          return true if fixup_or_squash?
+          return true if commit.prefix?
           return true if filter_list.empty?
 
           commit.subject.match?(/\A#{Regexp.union filter_list.to_regexp}/)
@@ -27,15 +27,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch(:includes)
-        end
-
-        private
-
-        def fixup_or_squash?
-          commit.is_a?(Git::Lint::Commits::Unsaved) && (commit.fixup? || commit.squash?)
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
       end
     end
   end

data/lib/git/lint/analyzers/commit_subject_suffix.rb

@@ -30,9 +30,7 @@ module Git
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch(:excludes)
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:excludes))
       end
     end
   end

data/lib/git/lint/analyzers/commit_trailer_collaborator_capitalization.rb

@@ -22,16 +22,14 @@ module Git
         end
         # rubocop:enable Metrics/ParameterLists
 
-        def valid?
-          affected_commit_trailer_lines.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
 
           {
             hint: "Name must be capitalized.",
-            lines: affected_commit_trailer_lines
+            lines: affected_commit_trailers
           }
         end
 

data/lib/git/lint/analyzers/commit_trailer_collaborator_duplication.rb

@@ -19,16 +19,14 @@ module Git
           @tally = build_tally
         end
 
-        def valid?
-          affected_commit_trailer_lines.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
 
           {
             hint: "Avoid duplication.",
-            lines: affected_commit_trailer_lines
+            lines: affected_commit_trailers
           }
         end
 
@@ -47,7 +45,7 @@ module Git
           zeros = Hash.new { |new_hash, missing_key| new_hash[missing_key] = 0 }
 
           zeros.tap do |collection|
-            commit.trailer_lines.each { |line| collection[line] += 1 if parser.new(line).match? }
+            commit.trailers.each { |line| collection[line] += 1 if parser.new(line).match? }
           end
         end
       end

data/lib/git/lint/analyzers/commit_trailer_collaborator_email.rb

@@ -23,16 +23,14 @@ module Git
         end
         # rubocop:enable Metrics/ParameterLists
 
-        def valid?
-          affected_commit_trailer_lines.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
 
           {
             hint: %(Email must follow name and use format: "<name@server.domain>".),
-            lines: affected_commit_trailer_lines
+            lines: affected_commit_trailers
           }
         end
 

data/lib/git/lint/analyzers/commit_trailer_collaborator_key.rb

@@ -19,24 +19,20 @@ module Git
           @parser = parser
         end
 
-        def valid?
-          affected_commit_trailer_lines.empty?
-        end
+        def valid? = affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
 
           {
             hint: "Use format: #{filter_list.to_hint}.",
-            lines: affected_commit_trailer_lines
+            lines: affected_commit_trailers
           }
         end
 
         protected
 
-        def load_filter_list
-          Kit::FilterList.new settings.fetch :includes
-        end
+        def load_filter_list = Kit::FilterList.new(settings.fetch(:includes))
 
         def invalid_line? line
           collaborator = parser.new line