git-lint 1.1.1 → 2.1.0

data/lib/git/lint/branches/feature.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "forwardable"
+require "refinements/strings"
 
 module Git
   module Lint
@@ -9,9 +10,11 @@ module Git
       class Feature
         extend Forwardable
 
-        def_delegators :selected_environment, :name, :shas
+        using ::Refinements::Strings
 
-        def initialize environment: ENV, git_repo: Git::Kit::Repo.new
+        def_delegators :selected_environment, :name, :commits
+
+        def initialize environment: ENV, git_repo: GitPlus::Repository.new
           message = "Invalid repository. Are you within a Git-enabled project?"
           fail Errors::Base, message unless git_repo.exist?
 
@@ -19,16 +22,13 @@ module Git
           @selected_environment = load_environment
         end
 
-        def commits
-          shas.map { |sha| Commits::Saved.new sha: sha }
-        end
-
         private
 
         attr_reader :current_environment, :selected_environment
 
         def load_environment
           if key? "CIRCLECI" then Environments::CircleCI.new
+          elsif key? "GITHUB_ACTIONS" then Environments::GitHubAction.new
           elsif key? "NETLIFY" then Environments::NetlifyCI.new environment: current_environment
           elsif key? "TRAVIS" then Environments::TravisCI.new environment: current_environment
           else Environments::Local.new
@@ -36,7 +36,7 @@ module Git
         end
 
         def key? key
-          current_environment[key] == "true"
+          current_environment.fetch(key, "false").to_bool
         end
       end
     end

data/lib/git/lint/cli.rb

@@ -3,6 +3,7 @@
 require "thor"
 require "thor/actions"
 require "runcom"
+require "pathname"
 require "pastel"
 
 module Git
@@ -60,7 +61,9 @@ module Git
                     type: :array,
                     default: []
       def analyze
-        collector = analyze_commits options.commits
+        # FIX: Need to accept SHAs.
+        # collector = analyze_commits options.commits
+        collector = analyze_commits
         abort if collector.errors?
       rescue Errors::Base => error
         abort colorizer.red("#{Identity::LABEL}: #{error.message}")
@@ -78,7 +81,7 @@ module Git
         else
           help "--hook"
         end
-      rescue Errors::Base => error
+      rescue Errors::Base, GitPlus::Errors::Base => error
         abort colorizer.red("#{Identity::LABEL}: #{error.message}")
       end
 
@@ -98,21 +101,16 @@ module Git
 
       attr_reader :configuration, :runner, :colorizer
 
-      def load_collector shas
-        commits = shas.map { |sha| Commits::Saved.new sha: sha }
-        commits.empty? ? runner.call : runner.call(commits: commits)
-      end
-
-      def analyze_commits shas
-        load_collector(shas).tap do |collector|
+      def analyze_commits
+        runner.call.tap do |collector|
           reporter = Reporters::Branch.new collector: collector
           say reporter.to_s
         end
       end
 
       def check_commit_message path
-        commit = Commits::Unsaved.new path: path
-        collector = runner.call commits: commit
+        commit = GitPlus::Repository.new.unsaved Pathname(path)
+        collector = runner.call commits: [commit]
         reporter = Reporters::Branch.new collector: collector
         say reporter.to_s
         abort if collector.errors?

data/lib/git/lint/collector.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require "refinements/strings"
+require "refinements/hashes"
 
 module Git
   module Lint
     class Collector
-      using Refinements::Strings
+      using ::Refinements::Hashes
 
       def initialize
         @collection = Hash.new { |default, missing_id| default[missing_id] = [] }

data/lib/git/lint/identity.rb

@@ -6,7 +6,7 @@ module Git
     module Identity
       NAME = "git-lint"
       LABEL = "Git Lint"
-      VERSION = "1.1.1"
+      VERSION = "2.1.0"
       VERSION_LABEL = "#{LABEL} #{VERSION}"
     end
   end

data/lib/git/lint/parsers/trailers/collaborator.rb

@@ -5,7 +5,7 @@ module Git
     module Parsers
       module Trailers
         class Collaborator
-          DEFAULT_KEY_PATTERN = /\ACo.*Authored.*By.*\Z/i.freeze
+          DEFAULT_KEY_PATTERN = /\ACo.*Authored.*By.*\Z/i
 
           DEFAULT_MATCH_PATTERN = /
             (?<key>\A.+)         # Key (anchored to start of line).
@@ -15,7 +15,7 @@ module Git
             (?<name_space>\s?)   # Space delimiter (optional).
             (?<email><.+>)?      # Collaborator email (optional).
             \Z                   # End of line.
-          /x.freeze
+          /x
 
           def initialize text,
                          key_pattern: DEFAULT_KEY_PATTERN,

data/lib/git/lint/reporters/branch.rb

@@ -23,22 +23,30 @@ module Git
 
         attr_reader :collector, :colorizer
 
+        def branch_report
+          return "" unless collector.issues?
+
+          "\n\n#{commit_report}".chomp
+        end
+
         def commit_report
           collector.to_h.reduce "" do |details, (commit, analyzers)|
             details + Commit.new(commit: commit, analyzers: analyzers).to_s
           end
         end
 
-        def branch_report
-          return "" unless collector.issues?
-
-          "\n\n#{commit_report}".chomp "\n"
-        end
-
         def commit_total
           %(#{"commit".pluralize count: collector.total_commits} inspected)
         end
 
+        def issue_totals
+          if collector.issues?
+            "#{issue_total} detected (#{warning_total}, #{error_total})"
+          else
+            colorizer.green("0 issues") + " detected"
+          end
+        end
+
         def issue_total
           color = collector.errors? ? :red : :yellow
           colorizer.public_send color, "issue".pluralize(count: collector.total_issues)
@@ -53,14 +61,6 @@ module Git
           color = collector.errors? ? :red : :green
           colorizer.public_send color, "error".pluralize(count: collector.total_errors)
         end
-
-        def issue_totals
-          if collector.issues?
-            "#{issue_total} detected (#{warning_total}, #{error_total})"
-          else
-            colorizer.green("0 issues") + " detected"
-          end
-        end
       end
     end
   end

data/lib/git/lint/runner.rb

@@ -3,19 +3,20 @@
 module Git
   module Lint
     class Runner
-      def initialize configuration:, collector: Collector.new
+      def initialize configuration:, branch: Branches::Feature.new, collector: Collector.new
         @configuration = configuration
+        @branch = branch
         @collector = collector
       end
 
-      def call commits: Branches::Feature.new.commits
-        Array(commits).map { |commit| check commit }
+      def call commits: branch.commits
+        commits.map { |commit| check commit }
         collector
       end
 
       private
 
-      attr_reader :configuration, :collector
+      attr_reader :configuration, :branch, :collector
 
       def check commit
         configuration.map { |id, settings| load_analyzer id, commit, settings }

data/lib/git/lint/validators/capitalization.rb

@@ -4,7 +4,7 @@ module Git
   module Lint
     module Validators
       class Capitalization
-        DEFAULT_PATTERN = /\A[[:upper:]].*\Z/.freeze
+        DEFAULT_PATTERN = /\A[[:upper:]].*\Z/
 
         def initialize text, delimiter: Name::DEFAULT_DELIMITER, pattern: DEFAULT_PATTERN
           @text = String text

data/lib/git/lint/validators/name.rb

@@ -4,7 +4,7 @@ module Git
   module Lint
     module Validators
       class Name
-        DEFAULT_DELIMITER = /\s{1}/.freeze
+        DEFAULT_DELIMITER = /\s{1}/
         DEFAULT_MINIMUM = 2
 
         def initialize text, delimiter: DEFAULT_DELIMITER, minimum: DEFAULT_MINIMUM

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git-lint
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 2.1.0
 platform: ruby
 authors:
 - Brooke Kuhlmann
@@ -28,246 +28,78 @@ cert_chain:
   2XV8FRa7/JimI07sPLC13eLY3xd/aYTi85Z782KIA4j0G8XEEWAX0ouBhlXPocZv
   QWc=
   -----END CERTIFICATE-----
-date: 2020-10-18 00:00:00.000000000 Z
+date: 2021-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: pastel
+  name: git_plus
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0.2'
 - !ruby/object:Gem::Dependency
-  name: refinements
+  name: pastel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7.11'
+        version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7.11'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
-  name: runcom
+  name: refinements
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
-  name: thor
+  name: runcom
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.20'
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.20'
+        version: '7.0'
 - !ruby/object:Gem::Dependency
-  name: bundler-audit
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.6'
-- !ruby/object:Gem::Dependency
-  name: gemsmith
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '14.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '14.2'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.7'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.13'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.13'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: reek
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.89'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.89'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.5'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.5'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.39'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.39'
-- !ruby/object:Gem::Dependency
-  name: simplecov
+  name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.19'
-  type: :development
+        version: '0.20'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: '0.20'
 description:
 email:
 - brooke@alchemists.io
@@ -281,7 +113,6 @@ files:
 - LICENSE.adoc
 - README.adoc
 - bin/git-lint
-- lib/git/kit/repo.rb
 - lib/git/lint.rb
 - lib/git/lint/analyzers/abstract.rb
 - lib/git/lint/analyzers/commit_author_capitalization.rb
@@ -306,14 +137,13 @@ files:
 - lib/git/lint/analyzers/commit_trailer_collaborator_key.rb
 - lib/git/lint/analyzers/commit_trailer_collaborator_name.rb
 - lib/git/lint/branches/environments/circle_ci.rb
+- lib/git/lint/branches/environments/git_hub_action.rb
 - lib/git/lint/branches/environments/local.rb
 - lib/git/lint/branches/environments/netlify_ci.rb
 - lib/git/lint/branches/environments/travis_ci.rb
 - lib/git/lint/branches/feature.rb
 - lib/git/lint/cli.rb
 - lib/git/lint/collector.rb
-- lib/git/lint/commits/saved.rb
-- lib/git/lint/commits/unsaved.rb
 - lib/git/lint/errors/base.rb
 - lib/git/lint/errors/severity.rb
 - lib/git/lint/errors/sha.rb
@@ -349,14 +179,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.5
 signing_key:
 specification_version: 4
 summary: A command line interface for linting Git commits.