git-hub 1.0.1 → 1.0.2

data/HISTORY.md

@@ -1,3 +1,8 @@
+## 1.0.2 (2010-03-07)
+
+* Bugfix: `hub remote -f name` (for real this time)
+* Bugfix: zsh quoting [thommay]
+
 ## 1.0.1 (2010-03-05)
 
 * Bugfix: `hub remote -f name`

data/lib/hub/commands.rb

@@ -119,7 +119,9 @@ module Hub
 
         if args.words[-2] == args.words[1]
           # rtomayko/tilt => rtomayko
-          args[-1] = user
+          # Make sure you dance around flags.
+          idx = args.index( args.words[-1] )
+          args[idx] = user
         else
           # They're specifying the remote name manually (e.g.
           # git remote add blah rtomayko/tilt), so just drop the last
@@ -129,7 +131,7 @@ module Hub
 
         args << url % [ user, repo ]
       elsif args.last !~ /:|\//
-        if args[2] == 'origin' && args[3].nil?
+        if args.words[2] == 'origin' && args.words[3].nil?
           # Origin special case.
           user = github_user
         else
@@ -137,7 +139,7 @@ module Hub
           user = args.last
         end
 
-        if args[-2] != args[1]
+        if args.words[-2] != args.words[1]
           # They're specifying the remote name manually (e.g.
           # git remote add blah rtomayko), so just drop the last
           # argument.
@@ -238,7 +240,7 @@ module Hub
       shells = {
         'sh'   => 'alias git=hub',
         'bash' => 'alias git=hub',
-        'zsh'  => 'function git(){hub $@}',
+        'zsh'  => 'function git(){hub "$@"}',
         'csh'  => 'alias git hub',
         'fish' => 'alias git hub'
       }

data/lib/hub/version.rb

@@ -1,3 +1,3 @@
 module Hub
-  Version = '1.0.1'
+  Version = '1.0.2'
 end

data/test/alias_test.rb

@@ -24,7 +24,7 @@ class AliasTest < Test::Unit::TestCase
   end
 
   def test_alias_zsh
-    assert_alias_command "zsh", "function git(){hub $@}"
+    assert_alias_command "zsh", 'function git(){hub "$@"}'
   end
 
   def test_alias_csh

data/test/helper.rb

@@ -3,6 +3,9 @@ $LOAD_PATH.unshift File.dirname(__FILE__) + '/../lib'
 require 'hub'
 require 'hub/standalone'
 
+# We're looking for `open` in the tests.
+ENV['BROWSER'] = 'open'
+
 class Test::Unit::TestCase
   # Shortcut for creating a `Hub` instance. Pass it what you would
   # normally pass `hub` on the command line, e.g.

data/test/hub_test.rb

@@ -117,6 +117,12 @@ class HubTest < Test::Unit::TestCase
     assert_command input, command
   end
 
+  def test_public_remote_f
+    input   = "remote add -f rtomayko"
+    command = "git remote add -f rtomayko git://github.com/rtomayko/hub.git"
+    assert_command input, command
+  end
+
   def test_named_public_remote
     input   = "remote add origin rtomayko"
     command = "git remote add origin git://github.com/rtomayko/hub.git"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: git-hub
 version: !ruby/object:Gem::Version 
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors: 
 - Chris Wanstrath
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-05 00:00:00 -08:00
+date: 2010-03-07 00:00:00 -08:00
 default_executable: hub
 dependencies: []