git-fit 0.15.2 → 0.15.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9309a27e967e49673133559b061b89a64d77d3e4575125490f1b9f86b3e79d43
-  data.tar.gz: a299431199f67d3e7ff3279857c0a19f97255970915c234dc29e329e23156f0d
+  metadata.gz: 1f6886c3420b0d964a5b827baa6614d50ff6365bddb2e79ab6ab3e2a914c1566
+  data.tar.gz: 6ef5678bf64437ab38e9c59a7e5d0967813640f81ad353235ddc787191c3c9c3
 SHA512:
-  metadata.gz: feba2797f9c5d8a096f65c51a479ac1bc03a05c5face9f066970a20b4cafa8f2acea522c7d7b89c63a261ba4472a885fe455d5156c5f87afca558b3665b34979
-  data.tar.gz: 9dc3878ca195c32eb45da3710b3c7649a275e1c12e4883fa548483a7fc10b28497195c8b603e02133fa6b562043b4ba2f8f002712c084d75526a51c04e1ef424
+  metadata.gz: 22cec3f9b63ad0fc26baed7d6992653631b0af58a0cf6e155f9623f7150dc2ee1ee5991ed1668e553399a686be57d3fdb487236623092257e1621346e10b610e
+  data.tar.gz: 75e18561d4d2fea9398fe74ed4389e791e8252a48c58eb5db1146779a33d867645179e716a2a265c62a403d385ea13e9db737780b87c8c500789f9c186826929

data/lib/git_fit/sync/garmin_base.rb

@@ -489,19 +489,19 @@ module GitFit
         moving_time = summary['movingDuration']&.to_i || summary['duration']&.to_i
         elapsed_time = summary['elapsedDuration']&.to_i || summary['duration']&.to_i
 
-        average_power = summary['avgPower']&.to_f
+        sensors = summary_sensor_values(summary, type)
+
+        average_power = positive_sensor_value(sensors[:average_power])
         average_power ||= fallback_avg_power(activity_id, l2_data)
 
-        max_power = summary['maxPower']&.to_f
+        max_power = positive_sensor_value(sensors[:max_power])
 
-        average_cadence = summary['avgCadence']&.to_f
-        average_cadence ||= sport_cadence(summary, type)&.to_f
+        average_cadence = positive_sensor_value(sensors[:average_cadence])
         average_cadence ||= fallback_avg_cadence(activity_id, l2_data)
 
-        max_cadence = summary['maxCadence']&.to_f
-        max_cadence ||= sport_max_cadence(summary, type)&.to_f
+        max_cadence = positive_sensor_value(sensors[:max_cadence])
 
-        average_temperature = summary['averageTemperature']&.to_f
+        average_temperature = sensors[:average_temperature]
         average_temperature ||= fallback_avg_temperature(activity_id, l2_data)
 
         {
@@ -558,12 +558,26 @@ module GitFit
         (power_values.sum.to_f / power_values.size).round(1)
       end
 
+      def summary_sensor_values(summary, type)
+        {
+          average_power: summary['averagePower']&.to_f,
+          max_power: summary['maxPower']&.to_f,
+          average_cadence: sport_cadence(summary, type)&.to_f,
+          max_cadence: sport_max_cadence(summary, type)&.to_f,
+          average_temperature: summary['averageTemperature']&.to_f,
+        }
+      end
+
+      def positive_sensor_value(value)
+        value&.positive? ? value : nil
+      end
+
       def sport_cadence(summary, type)
-        type == 'ride' ? summary['avgBikingCadence'] : summary['avgRunningCadence']
+        type == 'ride' ? summary['averageBikeCadence'] : summary['averageRunCadence']
       end
 
       def sport_max_cadence(summary, type)
-        type == 'ride' ? summary['maxBikingCadence'] : summary['maxRunningCadence']
+        type == 'ride' ? summary['maxBikeCadence'] : summary['maxRunCadence']
       end
 
       def fallback_avg_cadence(activity_id, l2_data)

data/lib/git_fit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GitFit
-  VERSION = '0.15.2'
+  VERSION = '0.15.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git-fit
 version: !ruby/object:Gem::Version
-  version: 0.15.2
+  version: 0.15.4
 platform: ruby
 authors:
 - Lax