giphy 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d3c7554e8f3aa5b3d2b541f954b2907a94cbe9ad
-  data.tar.gz: afd130adf6262c5a74e7313bd8da190a5db606cf
+  metadata.gz: 400b63fbcdafa08cc768ee85c1b2525b31d33a50
+  data.tar.gz: 181686b337c64a151569de7deb0338f3c627db91
 SHA512:
-  metadata.gz: b31939e10d260c2132a180060b376a04488dabd63b3259acae67e24b57caad625f1698b2e6507a16be032655b614fae30dce3d077f73e03e5397beb3e9ffbfe8
-  data.tar.gz: 4f166904151417744cccfcb519868b9e43fe278689e99ff6ff8011010bf531db1f190a057fb26fed690bad57ec72021e9c01a3c9813319bc8a89516f491bda02
+  metadata.gz: 992b85ca64125dda70ffebf884eba03bfc8627321f0faa273f816a4d5321a69b6eae0b7b1d514a8ce0c1c4c48c0b5cd15a93988e534c4e088eafef898947f2ca
+  data.tar.gz: 4d9e6af5673327a297eef1ef1268f3849b6f8f67384f3e651298317025f41b936cbb72d5bd4bb59339d3ca8cc2e4ce749e56377a929bdf2c147ba4e6f7eb391a

data/giphy.gemspec

@@ -19,10 +19,11 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake", "~> 10.1" 
+  spec.add_development_dependency "rake", "~> 10.1"
   spec.add_development_dependency "rspec", "~> 2.14"
   spec.add_development_dependency "rspec-its", "~> 1.0"
   spec.add_dependency "faraday", "~> 0.9"
+  spec.add_dependency "faraday_middleware"
   spec.add_dependency "faraday_middleware-parse_oj", "~> 0.3"
   spec.add_dependency "launchy", "~> 2.4"
 end

data/lib/giphy/errors/unexpected.rb

@@ -0,0 +1,5 @@
+module Giphy
+  module Errors
+    class Unexpected < StandardError ; end
+  end
+end

data/lib/giphy/request.rb

@@ -1,4 +1,5 @@
 require 'faraday'
+require 'faraday_middleware'
 require 'faraday_middleware/parse_oj'
 
 module Giphy
@@ -27,9 +28,11 @@ module Giphy
 
     def connection
       Faraday.new(url: URL) do |connection|
-        connection.request  :url_encoded
+        connection.use FaradayMiddleware::FollowRedirects
+        connection.use Faraday::Response::RaiseError
+        connection.request :url_encoded
         connection.response :oj
-        connection.adapter  Faraday.default_adapter
+        connection.adapter Faraday.default_adapter
       end
     end
 

data/lib/giphy/response.rb

@@ -9,6 +9,7 @@ module Giphy
     end
 
     def data
+      raise Giphy::Errors::Unexpected unless response.body
       response.body['data'] || raise(Giphy::Errors::API.new(error))
     end
 

data/lib/giphy/version.rb

@@ -1,3 +1,3 @@
 module Giphy
-  VERSION = "2.0.0"
+  VERSION = "2.0.1"
 end

data/spec/giphy/response_spec.rb

@@ -36,5 +36,14 @@ describe Giphy::Response do
         expect{ subject.data }.to raise_error Giphy::Errors::API
       end
     end
+
+    context "when response is empty" do
+      let(:hash) { nil }
+
+      it "raises an error and sets its message" do
+        expect{ subject.data }.to raise_error Giphy::Errors::Unexpected
+      end
+    end
+
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: giphy
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Sebastian Sogamoso
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-06 00:00:00.000000000 Z
+date: 2015-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: faraday_middleware
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday_middleware-parse_oj
   requirement: !ruby/object:Gem::Requirement
@@ -132,6 +146,7 @@ files:
 - lib/giphy/configuration.rb
 - lib/giphy/errors/api.rb
 - lib/giphy/errors/argument_error.rb
+- lib/giphy/errors/unexpected.rb
 - lib/giphy/favorite_gif.rb
 - lib/giphy/flagged_gif.rb
 - lib/giphy/gif.rb