gillbus 0.17.5 → 0.17.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea2abaaf26962b06ad6784e3a5bf6b8c35938583
-  data.tar.gz: 7b44f08e0fdca2b1dc01d937748ebcd92744398d
+  metadata.gz: 39981156aa20418b3109add8e3d94c63077bd44c
+  data.tar.gz: 50e5710aa809acc6203119011b706034fbdd100f
 SHA512:
-  metadata.gz: 2156ffdda7698d7240cca625014316740592fb13cd616752f2e9df6007a2e10a8b766261e23cfe9aebebeeee3acb1da0f3b6cb9697139509dbe71f087899f5b0
-  data.tar.gz: 206dd6ed1d24f615ec08859b004e2ae5dbb11a186ef9f518a43dbeda6e78d12fe62518726e86d5e998354e99a693671bcd47c6b9728fbf1f073f55612ae45f72
+  metadata.gz: 512923d49ef42592d7f3d1d2fbd4a6e97b888d15980cd1b1ebeee82ded1908cda2fa820e07d8a2769ebf797f2557e7d8beb1395e34dee02f54298705d2c2f4ab
+  data.tar.gz: 15d286724cead0805000c7d4d29c9abea2f7b59ca11561bc8cc6515a2e037cf616df9cbfa6284d9f90c418723de581c00ef6b3ad7d95add3171a6cb0a11c261d

data/lib/gillbus/base_response.rb

@@ -34,11 +34,11 @@ class Gillbus
     def self.parse_string(xml_string, **options)
       xml = MultiXml.parse(xml_string)
       # <DATA/> is a valid response
-      return ParseError.new(xml_string) unless xml.key?('DATA')
+      return ParseError.new(xml_string, 'DATA attribute missing') unless xml.key?('DATA')
       data = xml['DATA'] || {}
       parse(data, instance: new, options: options)
-    rescue MultiXml::ParseError, ArgumentError
-      ParseError.new(xml_string)
+    rescue MultiXml::ParseError, ArgumentError => e
+      ParseError.new(xml_string, e.message)
     end
   end
 end

data/lib/gillbus/parse_error.rb

@@ -1,8 +1,10 @@
 # I want it not to be an exception, for now
 class Gillbus::ParseError
-  def initialize(response_string)
+  def initialize(response_string, error_message)
     @response = response_string
+    @error_message = error_message
   end
+
   attr_reader :response
   attr_accessor :session_id
   attr_accessor :request_time
@@ -10,5 +12,7 @@ class Gillbus::ParseError
 
   def error_code; 0; end
 
-  def error_message; 'Malformed response'; end
+  def error_message
+    "Malformed response: #{@error_message}"
+  end
 end

data/lib/gillbus/version.rb

@@ -1,3 +1,3 @@
 class Gillbus
-  VERSION = '0.17.5'.freeze
+  VERSION = '0.17.6'.freeze
 end

data/test/error_test.rb

@@ -22,6 +22,7 @@ class ErrorTest < Minitest::Test
 
   def test_malformed_errorness
     assert malformed_response.error?
+    assert_equal "Malformed response: Not Terminated: text not terminated at 0:10", malformed_response.error_message
   end
 
   def test_malformed_2_errorness

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gillbus
 version: !ruby/object:Gem::Version
-  version: 0.17.5
+  version: 0.17.6
 platform: ruby
 authors:
 - Alexey "codesnik" Trofimenko
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-25 00:00:00.000000000 Z
+date: 2018-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport