gibbon 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cadad0262542fdc59cf9296a13273855c6060de0
-  data.tar.gz: 58cd1444c3e4cf456fa06386adbc3a4135ce9b46
+  metadata.gz: 6ee0feabc44b4f9a9f8ba62fbb303baf69412ce0
+  data.tar.gz: 94ccc2373e6991acba4a32418bbe2a63ae852763
 SHA512:
-  metadata.gz: f147ecf3ab960b613cd4f8623cc1ae06d40d1835f7d72af08bf6624dc1417a178671d69010eb3c5ed9fb8697e3d6b0426ba531ae31cdf4a812d527909cbb3678
-  data.tar.gz: 057fae67da3e668dcee8f38d3b2a2aa099523458dab1a04725e57a730674633603a596857776026201c929ba956f55939bef40b61f7ad4597c87e5aba24e255c
+  metadata.gz: 59cbe8d55f63cfd982cf1c5f59d770946177c2b567f123ce32f3527f88d05c4c0d1c1b55167f0cb48ebc9510293b0a4fa2a9100a62cdac26e00d61a66469d4b6
+  data.tar.gz: 64c09481ecde6b9fc53bc91f666f681af60d316591dee398f8c60785d4f117bbf8edd210231cfc1f662f02377af83ee879883bbdf50ec7a28cf31e0ad11e4c82

data/.travis.yml

@@ -1,6 +1,8 @@
 language: ruby
 sudo: false
 cache: bundler
+before_install:
+  - gem install bundler # -v 1.7.14 if a specific version is needed
 rvm:
   - 2.0.0
   - 2.1.5

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 ## [Unreleased][unreleased]
 
+## [3.1.1] - 2017-09-25
+- Fix MailChimpError initialization
+
 ## [3.1.0] - 2017-07-27
 - Add back support for Export API until MailChimp stops supporting it
 - Implement `responds_to_missing`

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2010-2015 Amro Mousa
+Copyright (c) 2010-2017 Amro Mousa
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/lib/gibbon/api_request.rb

@@ -102,7 +102,7 @@ module Gibbon
     def symbolize_keys
       @request_builder.symbolize_keys
     end
-    
+
     # Helpers
 
     def handle_error(error)
@@ -157,7 +157,7 @@ module Gibbon
       client
     end
 
-    def parse_response(response)      
+    def parse_response(response)
       parsed_response = nil
 
       if response.body && !response.body.empty?
@@ -166,9 +166,8 @@ module Gibbon
           body = MultiJson.load(response.body, symbolize_keys: symbolize_keys)
           parsed_response = Response.new(headers: headers, body: body)
         rescue MultiJson::ParseError
-          error = MailChimpError.new("Unparseable response: #{response.body}")
-          error.title = "UNPARSEABLE_RESPONSE"
-          error.status_code = 500
+          error_params = { title: "UNPARSEABLE_RESPONSE", status_code: 500 }
+          error = MailChimpError.new("Unparseable response: #{response.body}", error_params)
           raise error
         end
       end

data/lib/gibbon/version.rb

@@ -1,3 +1,3 @@
 module Gibbon
-  VERSION = "3.1.0"
+  VERSION = "3.1.1"
 end

data/spec/gibbon/mailchimp_error_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe Gibbon::MailChimpError do
+  let(:message) { 'Foo' }
+  let(:params) do
+    {
+      title: 'error_title',
+      detail: 'error_detail',
+      body: 'error_body',
+      raw_body: 'error_raw_body',
+      status_code: 'error_status_code'
+    }
+  end
+
+  before do
+    @gibbon = Gibbon::MailChimpError.new(message, params)
+  end
+
+  it "adds the error params to the error message" do
+    expected_message = "Foo "                               \
+                       "@title=\"error_title\", "           \
+                       "@detail=\"error_detail\", "         \
+                       "@body=\"error_body\", "             \
+                       "@raw_body=\"error_raw_body\", "     \
+                       "@status_code=\"error_status_code\""
+
+    expect(@gibbon.message).to eq(expected_message)
+  end
+
+  it 'sets the title attribute' do
+    expect(@gibbon.title).to eq(params[:title])
+  end
+
+  it 'sets the detail attribute' do
+    expect(@gibbon.detail).to eq(params[:detail])
+  end
+
+  it 'sets the body attribute' do
+    expect(@gibbon.body).to eq(params[:body])
+  end
+
+  it 'sets the raw_body attribute' do
+    expect(@gibbon.raw_body).to eq(params[:raw_body])
+  end
+
+  it 'sets the status_code attribute' do
+    expect(@gibbon.status_code).to eq(params[:status_code])
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gibbon
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Amro Mousa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-27 00:00:00.000000000 Z
+date: 2017-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -108,6 +108,7 @@ files:
 - spec/gibbon/api_request_spec.rb
 - spec/gibbon/export_spec.rb
 - spec/gibbon/gibbon_spec.rb
+- spec/gibbon/mailchimp_error_spec.rb
 - spec/gibbon/upsert_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/amro/gibbon
@@ -138,5 +139,6 @@ test_files:
 - spec/gibbon/api_request_spec.rb
 - spec/gibbon/export_spec.rb
 - spec/gibbon/gibbon_spec.rb
+- spec/gibbon/mailchimp_error_spec.rb
 - spec/gibbon/upsert_spec.rb
 - spec/spec_helper.rb