gibbon 3.0.1 → 3.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3cadf43e229868a253bae8af2b7e609db5ffd11b
-  data.tar.gz: 95049f9c9ce5f1d3b9cde18f4650d5be52b13947
+  metadata.gz: c1f19b602cdd22a49058f62d097abe6121d04ada
+  data.tar.gz: 01e37c1aa62e820a9b1cba9c476bdfba7640c001
 SHA512:
-  metadata.gz: 58ab02cdd0ebd1cff4c0211b3a6674484db6a50b52aa34dc7efc746e1c75792dca7a4dedd58e8efc7e38fef73fc285f4859c809bba1f1b5cf1d674bc89cca436
-  data.tar.gz: 15459d6835355d637505ffc34c3aecbac0a6232a271d1481952c60028f30bd7264c35bd5e922d12ec12717b36a83df59046c808f43b02c19dda60d9f60f2f33f
+  metadata.gz: cc64c4a643ceacc05f06e3a621616eb25a57072a0486bd134cd233f650966db1d5ed7f7c7154887fd96344844325bdadfe0a9f188c2c4c29add288fe638fc339
+  data.tar.gz: c046252678c798d2b1f10c87f34b6a507fb4d4d7e919e2528343fbfa19803387c44c7fa52b62a7111439fdc453ff7ce9719664d871614076b0d69d86f116c080

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 ## [Unreleased][unreleased]
 
+## [3.0.2] - 2017-05-08
+- Fix subtle bug in `symbolize_keys` when parsing error
+
 ## [3.0.1] - 2017-01-13
 - Gibbon::Request (API 3.0) now returns a `Gibbon::Response` object that exposes `headers` and the parsed response `body`
 - Remove Export API support (this is deprected after all)

data/README.markdown

@@ -4,21 +4,22 @@ Gibbon is an API wrapper for MailChimp's [API](http://kb.mailchimp.com/api/).
 
 [![Build Status](https://secure.travis-ci.org/amro/gibbon.svg)](http://travis-ci.org/amro/gibbon)
 [![Dependency Status](https://gemnasium.com/amro/gibbon.svg)](https://gemnasium.com/amro/gibbon)
-##Important Notes
+
+## Important Notes
 
 Please read MailChimp's [Getting Started Guide](http://kb.mailchimp.com/api/article/api-3-overview).
 
 Gibbon 3.0.0+ returns a `Gibbon::Response` instead of the response body directly. `Gibbon::Response` exposes the parsed response `body` and `headers`.
 
-##Installation
+## Installation
 
     $ gem install gibbon
 
-##Requirements
+## Requirements
 
 A MailChimp account and API key. You can see your API keys [here](http://admin.mailchimp.com/account/api).
 
-##Usage
+## Usage
 
 First, create a *one-time use instance* of `Gibbon::Request`:
 
@@ -84,7 +85,7 @@ gibbon = Gibbon::Request.new(api_key: "your_api_key", symbolize_keys: true)
 
 MailChimp's [resource documentation](http://kb.mailchimp.com/api/resources) is a list of available resources.
 
-##Debug Logging
+## Debug Logging
 
 Pass `debug: true` to enable debug logging to STDOUT.
 

data/lib/gibbon/api_request.rb

@@ -117,8 +117,12 @@ module Gibbon
 
           if parsed_response
             error_params[:body] = parsed_response
-            error_params[:title] = parsed_response["title"] if parsed_response["title"]
-            error_params[:detail] = parsed_response["detail"] if parsed_response["detail"]
+
+            title_key = symbolize_keys ? :title : "title"
+            detail_key = symbolize_keys ? :detail : "detail"
+
+            error_params[:title] = parsed_response[title_key] if parsed_response[title_key]
+            error_params[:detail] = parsed_response[detail_key] if parsed_response[detail_key]
           end
 
         end

data/lib/gibbon/version.rb

@@ -1,3 +1,3 @@
 module Gibbon
-  VERSION = "3.0.1"
+  VERSION = "3.0.2"
 end

data/spec/gibbon/api_request_spec.rb

@@ -42,5 +42,19 @@ describe Gibbon::APIRequest do
         expect(boom.raw_body).to eq "A non JSON response"
       end
     end
+
+    context "when symbolize_keys is true" do
+      it "sets title and detail on the error params" do
+        response_values = {:status => 422, :headers => {}, :body => '{"title": "foo", "detail": "bar"}'}
+        exception = Faraday::Error::ClientError.new("the server responded with status 422", response_values)
+        api_request = Gibbon::APIRequest.new(builder: Gibbon::Request.new(symbolize_keys: true))
+        begin
+          api_request.send :handle_error, exception
+        rescue => boom
+          expect(boom.title).to eq "foo"
+          expect(boom.detail).to eq "bar"
+        end
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gibbon
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.0.2
 platform: ruby
 authors:
 - Amro Mousa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-14 00:00:00.000000000 Z
+date: 2017-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday