gibbon 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9bbaffb886d48a6638dad933173180c5fa05a83
-  data.tar.gz: 3738e10aac82b774d4e835ef4d920195c08f0989
+  metadata.gz: a4ade9615ee9a69d1ce2d1d560ce14ec92430dd2
+  data.tar.gz: a82c3dea034eead23703265b805607a0c311e14f
 SHA512:
-  metadata.gz: 24b23d7562c0ec6a3b0afc359c2d22e7030438030bddbbec84cc008740e438736fb95f98d419377e91e915073a296a3b82c9f488d7792856deb7dc4530952fe6
-  data.tar.gz: 03b4df6bcafa1af1a13694e7dc2a71149a4eb64bb3f43653f006dcb97e7bb0bb346933a2b9e864cc82ac35dcd12b5efa01daea136b2ac632566e04a0cf2c1de7
+  metadata.gz: 6dd1f3f444a7e6e0852f70705676cff464e67c3455a3be06c16bbd6597e7c33678e392c47184821b8c97c77c3b4bbe834620dbf2430c56da3e7176d2e0fa7d25
+  data.tar.gz: 99e997b80b822cfa08d93fa4004ccd2395aa0a699ba9e37bfb0360b891194e5e861b6f32dfe1e0f5ebcb5e42f0a8d96eab0ee76a9ff1bcbbfd47670f4affe431

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 ## [Unreleased][unreleased]
 
+## [2.2.1] - 2016-01-01
+- Improve MailChimpError logging
+
 ## [2.2.0] - 2015-12-01
 - Adds support for proxies
 - Adds support for faraday_adapters

data/README.markdown

@@ -253,7 +253,7 @@ You can set an optional proxy url like this (or with an environment variable MAI
 gibbon.proxy = 'http://your_proxy.com:80'
 ```
 
-You can set a different Faraday adapter during initialization:
+You can set a different [Faraday adapter](https://github.com/lostisland/faraday) during initialization:
 
 ```ruby
 gibbon = Gibbon::Request.new(api_key: "your_api_key", faraday_adapter: :net_http)

data/lib/gibbon/api_request.rb

@@ -84,7 +84,7 @@ module Gibbon
     def timeout
       @request_builder.timeout
     end
-    
+
     def proxy
       @request_builder.proxy
     end
@@ -96,28 +96,27 @@ module Gibbon
     # Helpers
 
     def handle_error(error)
-      error_to_raise = nil
+      error_params = {}
 
       begin
-        error_to_raise = MailChimpError.new(error.message)
-
         if error.is_a?(Faraday::Error::ClientError) && error.response
           parsed_response = MultiJson.load(error.response[:body])
 
           if parsed_response
-            error_to_raise.body = parsed_response
-            error_to_raise.title = parsed_response["title"] if parsed_response["title"]
-            error_to_raise.detail = parsed_response["detail"] if parsed_response["detail"]
+            error_params[:body] = parsed_response
+            error_params[:title] = parsed_response["title"] if parsed_response["title"]
+            error_params[:detail] = parsed_response["detail"] if parsed_response["detail"]
           end
 
-          error_to_raise.status_code = error.response[:status]
-          error_to_raise.raw_body = error.response[:body]
+          error_params[:status_code] = error.response[:status]
+          error_params[:raw_body] = error.response[:body]
         end
       rescue MultiJson::ParseError
-        error_to_raise.message = error.message
-        error_to_raise.status_code = error.response[:status]
+        error_params[:status_code] = error.response[:status]
       end
 
+      error_to_raise = MailChimpError.new(error.message, error_params)
+
       raise error_to_raise
     end
 

data/lib/gibbon/mailchimp_error.rb

@@ -1,5 +1,29 @@
 module Gibbon
   class MailChimpError < StandardError
-    attr_accessor :title, :detail, :body, :raw_body, :status_code, :message
+    attr_reader :title, :detail, :body, :raw_body, :status_code
+
+    def initialize(message = "", params = {})
+      @title       = params[:title]
+      @detail      = params[:detail]
+      @body        = params[:body]
+      @raw_body    = params[:raw_body]
+      @status_code = params[:status_code]
+
+      super(message)
+    end
+
+    def to_s
+      super + " " + instance_variables_to_s
+    end
+
+    private
+
+    def instance_variables_to_s
+      [:title, :detail, :body, :raw_body, :status_code].map do |attr|
+        attr_value = send(attr)
+
+        "@#{attr}=#{attr_value.inspect}"
+      end.join(", ")
+    end
   end
 end

data/lib/gibbon/version.rb

@@ -1,3 +1,3 @@
 module Gibbon
-  VERSION = "2.2.0"
+  VERSION = "2.2.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gibbon
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Amro Mousa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-01 00:00:00.000000000 Z
+date: 2016-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday