ghrt 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a0eee993becd1ce252e5129d983e091caf811d9dd06fda2c94eee2a8ae38aec
-  data.tar.gz: 160203cc4e6479d42a074c85b7a484bb06704821f21417bc6fa07c4c220f7368
+  metadata.gz: 6558be581003cb72c9e3210a5aec53a1684d72e3e2a2b33782c85666ee23e088
+  data.tar.gz: 716457659603c23fcfcad5ad534f1ef81cca79fa086dff79005e17c8b09f8a3a
 SHA512:
-  metadata.gz: c81bb347d68ee8fd4e34e115e8d69e2147aaf10a36c7f39a5a5469c1f9b7bf08b4fb1519f798f25f1cb1c9eb559df744de940da9d3ccb0fad6fa1bba6ebbbf21
-  data.tar.gz: 6cfb68f2de25d3d8328af94b438b34947d9b31e24139df67b34be2a2bbc70d6ed621f5f76390e7d1a61ce7d9cf5ed61ec5e5073400e0aa99ab8e5a2dcc570cfe
+  metadata.gz: 22997d7f8ce3e15f8775bc963e263c99b63cbe64dbf5f49cef97971afc83e40ee11325a81dd4cfcf5c51945d524faa63fddd3f6bfda53d1ddf43a28217ce5c43
+  data.tar.gz: 76003d00b83d201d1e98b100b086d05ce446fc4b9d52bb98aa00fb1a765da6e8e672ecdf17b99344c1e2fbaac7bc9bd16a9ef9b7173d03a77bdd36fcf1c9eb8f

data/.gitignore

@@ -10,3 +10,4 @@
 # rspec failure tracking
 .rspec_status
 Gemfile.lock
+/ghrt-*.gem

data/exe/ghrt

@@ -30,6 +30,9 @@ OptionParser.new do |opts|
   opts.on('-s', '--since <yyyy-mm-dd>', 'Only return comments since ISO date') do |date|
     options[:since] = date
   end
+
+  opts.separator ''
+  opts.separator "Version #{Ghrt::VERSION}"
 end.parse!
 
 raise '--repo and --pull-request parameters must be provided' unless options[:repo] && options[:pr]

data/lib/ghrt/github.rb

@@ -11,11 +11,23 @@ module Ghrt
       @repo = repo
       @username = ENV['GITHUB_USERNAME']
       @token = ENV['GITHUB_TOKEN']
+      raise 'GITHUB_USERNAME and GITHUB_TOKEN environment variables must be set' unless @username && @token
+
       @verbose = verbose
     end
 
     def review_comments(pull_request, since)
-      response = query_github("/pulls/#{pull_request}/comments?since=#{since}")
+      response = []
+      page = 1
+
+      loop do
+        paged_response = query_github("/pulls/#{pull_request}/comments?since=#{since}&per_page=100&page=#{page}")
+        break if paged_response.empty?
+
+        response.concat(paged_response)
+        page += 1
+      end
+
       response.select { |comment| comment['user']['login'] == @username }
     end
 
@@ -35,7 +47,7 @@ module Ghrt
     end
 
     def parse_response(response)
-      puts response if @verbose
+      puts response.code if @verbose
       raise "Unexpected API response status #{response.code}" unless response.code == '200'
 
       JSON.parse(response.read_body)

data/lib/ghrt/reviewer_comments.rb

@@ -27,7 +27,7 @@ module Ghrt
             <div class="col-xl-12 mb-2">
               <a target="_blank" href='#{comment['html_url']}'><h3>##{index + 1} - #{comment['path']}:#{comment['original_position']}</h3></a>
               <div class="pl-3">
-                <pre class="prettyprint"><code>&#{comment['diff_hunk']}</code></pre>
+                <pre class="prettyprint"><code>#{normalise_diff_hunk(comment['diff_hunk'])}</code></pre>
                 <div class="text-muted" style="font-size: 1.1em">#{Kramdown::Document.new(comment['body']).to_html}</div>
               </div>
             </div>
@@ -42,5 +42,12 @@ module Ghrt
       HTML
     end
     # rubocop:enable Metrics/MethodLength
+
+    # Make hunks 6 lines long and remove headers
+    def self.normalise_diff_hunk(hunk)
+      return hunk.lines.to_a[1..-1].join if hunk.lines.count <= 6
+
+      hunk.lines.to_a[(hunk.lines.count - 6)..-1].join
+    end
   end
 end

data/lib/ghrt/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ghrt
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ghrt
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Alex Leaver
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-25 00:00:00.000000000 Z
+date: 2019-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kramdown