ghrh 0.0.2 → 0.0.3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ghrh (0.0.1)
+    ghrh (0.0.3)
       clamp (~> 0.6.1)
       highline (~> 1.6.19)
       httparty (~> 0.11.0)

data/README.md

@@ -2,18 +2,18 @@
 
 Manage GitHub repository [hooks](http://developer.github.com/v3/repos/hooks/) easily on the command line.
 
-# Installation
+## Installation
 
 Install the ruby gem:
 
-```
+``` sh
 $ gem install ghrh
 ```
 
-# Usage
+## Usage
 
-## General help
-```
+### General help
+``` sh
 $ ghrh --help
 Usage:
     ghrh [OPTIONS] SUBCOMMAND [ARG] ...
@@ -37,23 +37,23 @@ Options:
 ```
 Pass `--help` to each sub command for its usage.
 
-## Setting up
+### Setting up
 The Github token (`ghrh.token`), repository (`github.repo`), user (`github.user`) and host (`github.host`) are set and picked up from
 the local or global git config. Environment variables work too `GITHUB_REPO`, `GITHUB_USER`, etc.
 
-```
+``` sh
 # fetch and set GitHub token, also can be set repository specific (pass --local)
 $ ghrh auth r4um
 Enter password for user r4um (never stored):
 ghrh.token set to xyz012345 in global git config
 ```
 
-## Managing hooks
+### Managing hooks
 
 ghrh caches the hooks metadata from GitHub host in `~/.ghrh`.
 
-To see a list of hooks available
-```
+List available hooks
+``` sh
 $ ghrh hooks
 activecollab
 acunote
@@ -68,8 +68,8 @@ backlog
 ---cut---
 ```
 
-To see what paramaters (the schema ) a hook expects
-```
+View what paramaters (the schema) hook expects
+``` sh
 $ ghrh hooks email
 {"name"=>"email",
  "events"=>["push"],
@@ -80,8 +80,8 @@ $ ghrh hooks email
    ["boolean", "send_from_author"]]}
 ```
 
-The parameters are passed as key=value pairs, for example create an email and web hook
-```
+The parameters are passed as `key=value` pairs, for example create an email and a web hook
+``` sh
 $ ghrh create -r r4um/dotfiles email address=pranay.kanwar@gmail.com send_from_author=1
 201 Created
 $ ghrh create -r r4um/dotfiles web url=http://foo.com content_type=text/json
@@ -93,7 +93,7 @@ If no repository is provided its picked up from `github.repo` git config setting
 
 Too see a list of hooks
 
-```
+``` sh
 $ ghrh list r4um/dotfiles
 -------------------------------
  id      name   active  events
@@ -103,9 +103,9 @@ $ ghrh list r4um/dotfiles
 -------------------------------
 ```
 
-Hooks can be viewed, edited or deleted by their id from the list above.
+Hooks can be viewed, edited, tested or deleted by their id from the list above.
 
-```
+``` sh
 $ ghrh edit -r r4um/dotfiles 954777 address=nobody@localhost
 200 OK
 $ ghrh get -r r4um/dotfiles 954777
@@ -120,6 +120,9 @@ $ ghrh get -r r4um/dotfiles 954777
  "last_response"=>{"code"=>200, "status"=>"ok", "message"=>"OK"},
  "updated_at"=>"2013-05-14T12:19:30Z",
  "created_at"=>"2013-05-13T19:52:50Z"}
+$ ghrh test -t r4um/dotfiles 954777
+204 No Content
+nil
 $ ghrh delete -r r4um/dotfiles 954777
 204 No Content
 
@@ -127,10 +130,10 @@ Deleted
 ```
 
 To refresh the hooks cache
-```
+``` sh
 $ ghrh hooks --refresh
 Wrote hooks cache to /Users/pranay.kanwar/.ghrh/hooks_api.github.com.json
 ```
 
-# LICENSE
+### LICENSE
 [MIT](LICENSE)

data/lib/ghrh/command/create.rb

@@ -33,7 +33,7 @@ module GHRH
         # make sure config settings given exist in the schema
         config_list.each do |arg|
           k,v = arg.split(/=/,2)
-          raise "Invalid setting #{k} for hook #{name}" if not schema[k]
+          raise "Invalid setting #{k} for hook #{name}" if not schema.include? k
           config[k]=v
         end
 
@@ -42,7 +42,7 @@ module GHRH
         if events
           events_list = events.split(/,/)
           events_list.each do |event|
-            raise "Invalid event #{event} for hook #{name}" if not supported_events.index(event)
+            raise "Invalid event #{event} for hook #{name}" if not supported_events.include? event
           end
         end
 

data/lib/ghrh/command/edit.rb

@@ -15,11 +15,7 @@ module GHRH
 
         res = GHRH::Client.get("/repos/#{repo}/hooks/#{id}")
 
-        if not res['name']
-          puts "Invalid hook ID #{id}"
-          puts res
-          exit 1
-        end
+        raise "Invalid hook ID #{id}" if not res['name']
 
         name = res['name']
         hook = hooks[name]
@@ -39,7 +35,7 @@ module GHRH
         # make sure config settings given exist in the schema
         config_list.each do |arg|
           k,v = arg.split(/=/,2)
-          raise "Invalid setting #{k} for hook #{name}" if not schema[k]
+          raise "Invalid setting #{k} for hook #{id} (#{name})" if not schema.include? k
           config[k]=v
         end
 
@@ -48,7 +44,7 @@ module GHRH
         if events
           events_list = events.split(/,/)
           events_list.each do |event|
-            raise "Invalid event #{event} for hook #{id}" if not supported_events.index(event)
+            raise "Invalid event #{event} for hook #{id} (#{name})" if not supported_events.include? event
           end
         end
 

data/lib/ghrh/command/hooks.rb

@@ -5,10 +5,7 @@ module GHRH
       option "--refresh", :flag, "Refresh hooks cache"
 
       def execute
-        if refresh?
-          GHRH::Config.fetch_hooks
-          exit 0
-        end
+        GHRH::Config.fetch_hooks if refresh?
 
         hooks = GHRH::Config.hooks
 

data/lib/ghrh/command/list.rb

@@ -4,7 +4,12 @@ module GHRH
       parameter "[REPO]", "repo", :default => GHRH::Config.get('github.repo')
 
       def execute
+        raise "No repo specified or set (github.repo)" if not repo
+
         resp = GHRH::Client.get("/repos/#{repo}/hooks")
+
+        raise "Unexpected response #{resp.code} #{resp.message}" if resp.code != 200
+
         tbl = Tabularize.new :vborder => '', :iborder => ''
         tbl << %w(id name active events)
         tbl.separator!

data/lib/ghrh/version.rb

@@ -1,3 +1,3 @@
 module GHRH
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ghrh
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-14 00:00:00.000000000 Z
+date: 2013-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: clamp