ghreview 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ce2de0113e8615ab9b75756cbcd625d46aba35bca5c45115611169b72164d69d
-  data.tar.gz: a0db5223db97769709d44e0363d0cbb8d89222d59e3f18b4c6cc3cec438b694e
+  metadata.gz: d1337d11f3c8935e886f3970d5b22a95d9098088431e710de5a0ab0a5a51e059
+  data.tar.gz: cb4497a211ab18d5b3bfd26ae07460e2b3448d09e585266962cc9bc6d1557068
 SHA512:
-  metadata.gz: 29b8d6676cf2f720d7103795535d3897ccf604f5feee5a8b52a62e09e7c12456cd1b3834da10f695167994c7f4f319a5b17bf805bd421110ec92c1a01c1acb78
-  data.tar.gz: de5dfb542e5fb7ad3ae63cbae85f80ef6984b71eadbe1c308d88d7d89c7ad8dc51af3a852fd1531dede1a65b7cfcfa8a6ee45bca96c9b15ca121a194b9b6f11c
+  metadata.gz: f3f0c9e37a817d21a7b22eb46cc38e8fba5c9f6e1a0e3621200dcca3533d2ff17578c24e6dc33b2a889ee8841a895e46cff8afc7d50dba3e925bb7db5bcfe747
+  data.tar.gz: 294d7edf99cb7ffa843148b81df46b1322005653ab137caa1631307ae257650b0bbbe5dfae19333c3e68964dd962623b06a8eacd414445ee8027730b9d77b9b4

data/README.md

@@ -1,8 +1,11 @@
 # `ghreview` - Mass GitHub Review from Command Line
 
+[![Gem Version](https://badge.fury.io/rb/ghreview.svg)](https://badge.fury.io/rb/ghreview)
+
+
 Sometimes you need to review a lot of pull requests with the same or very similar
 small change. Using the GitHub web UI is not convenient for approving many pull
-requests, for that purpose we have this `review.rb` helper script which can be
+requests. That's the reason for creating the `ghreview` script which can be
 used from command line.
 
 ## Features
@@ -13,6 +16,7 @@ used from command line.
 - It can approve each pull request with the default "LGTM" message (Looks Good
   To Me), but you can use a custom message, see the [options](#options) below
 - Optionally can merge the pull requests and delete the source branch
+- The pull requests can be passed as arguments or they can be read from a file
 
 If a pull request is not approved then it is skipped and not touched at all.
 You need to comment at the GitHub pull request page manually in that case.
@@ -30,6 +34,8 @@ ghreview --merge https://github.com/yast/yast-users/pull/218 \
   https://github.com/yast/yast-sound/pull/35
 ```
 
+Or use the `--file` option to read them from a file.
+
 ## Installation
 
 The script is packaged as a Ruby gem, to install it run:
@@ -66,7 +72,7 @@ Just make sure the `.netrc` file is not readable for the other users
 Alternatively the access token can be passed via environment variable `GH_TOKEN`:
 
 ```shell
-␣GH_TOKEN=... ./review ...
+␣GH_TOKEN=... ghreview ...
 ```
 
 :warning: *Note the extra space at the beginning of the line, that is
@@ -81,5 +87,7 @@ The script accepts these optional command line options:
 - `--delete` (or `-d`) - Delete the source branch after merging (the YaST
   GitHub repositories have now enabled the auto-removal of the merged branches
   so this option is usually not needed)
-- `--message` (or `-m`) - The text used in the, the default is `LGTM`
-  (Looks Good To Me)
+- `--message <message>` (or `-m <message>`) - The text used in the review
+  comment, the default is `LGTM` (Looks Good To Me)
+- `--file <file>` (or `-f <file>`) - Read the list of pull requests from a file
+  (one pull request per line)

data/bin/ghreview

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 # This script is intended for mass review of the same (or very similar)
 # GitHub pull requests.
@@ -22,11 +23,16 @@ require "rainbow"
 merge_pr = false
 delete_branch = false
 message = "LGTM"
+file = nil
 
 # parse the command line options
 OptionParser.new do |parser|
   parser.banner = "Usage: #{$PROGRAM_NAME} [options] PR_URL1 PR_URL2 ..."
 
+  parser.on("-f", "--file FILE", "Read the list of pull requests from file") do |f|
+    file = f
+  end
+
   parser.on("-g", "--merge", "Merge the approved pull requests") do |m|
     merge_pr = m
   end
@@ -35,7 +41,7 @@ OptionParser.new do |parser|
     delete_branch = d
   end
 
-  parser.on("-m", "--message", "Approving message (default: \"#{message}\")") do |m|
+  parser.on("-m", "--message MESSAGE", "Approving message (default: \"#{message}\")") do |m|
     message = m
   end
 end.parse!
@@ -99,7 +105,7 @@ def print_pull_status(client, status_url, repo, pr)
 
     status = client.status(repo, sha)
     color = (status[:state] == "success") ? :green : :red
-    puts "Overall Status: " + Rainbow("#{status[:state]}").color(color)
+    puts "Overall Status: " + Rainbow((status[:state]).to_s).color(color)
 
     if status[:state] != "success"
       status[:statuses].each do |st|
@@ -161,18 +167,28 @@ def process_pull(client, pr_url, repo, pr, message, delete_branch, merge_pr)
 
   if pull[:merged]
     puts Rainbow("Already merged").bright.yellow
-  else
-    approve_pull(client, pull, message, repo, pr, delete_branch, merge_pr) if ask_for_approval
+  elsif ask_for_approval
+    approve_pull(client, pull, message, repo, pr, delete_branch, merge_pr)
   end
 end
 
-client = create_github_client
-ARGV.each do |p|
-  if p =~ /^https:\/\/github.com\/(\S+)\/pull\/(\d+)/
+def process_url(client, url, message, delete_branch, merge_pr)
+  if url =~ /^https:\/\/github.com\/(\S+)\/pull\/(\d+)/
     repo = Regexp.last_match[1]
     pr = Regexp.last_match[2]
-    process_pull(client, p, repo, pr, message, delete_branch, merge_pr)
+    process_pull(client, url, repo, pr, message, delete_branch, merge_pr)
   else
-    puts "Argument #{p.inspect} is not a GitHub pull request URL, skipping"
+    puts "#{url.inspect} is not a GitHub pull request URL, skipping"
   end
 end
+
+client = create_github_client
+ARGV.each do |url|
+  process_url(client, url, message, delete_branch, merge_pr)
+end
+
+return unless file
+
+File.open(file, "r").each_line do |line|
+  process_url(client, line, message, delete_branch, merge_pr)
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ghreview
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Ladislav Slezák
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-30 00:00:00.000000000 Z
+date: 2020-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: netrc
@@ -90,9 +90,37 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '13'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '13'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.71.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.71.0
 description: |2
-      The 'ghreview' tools allows doing mass GitHub pull request reviews from
-      command line. It is indented for approving simple changes is several
+      The 'ghreview' tool allows doing mass GitHub pull request reviews from
+      command line. It is intended for approving simple changes is several
       pull requests even across several repositories.
 email: 
 executables: