ghn 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7b93cf1ccda9576a2bfc0e29b6a8a8049f5c40f0
-  data.tar.gz: c410e0b9c368e80f6f455393d2e2a81b87ca2d25
+  metadata.gz: bc3b7051906643d8a41a23a0d870b1a3aa398711
+  data.tar.gz: 28946552fecd43795a28bcb8f1b8a96d8246cf0c
 SHA512:
-  metadata.gz: 113f7e9856ec04f81446a581233aa2f6c421a65b35725a33d1d067266e9f1566238f49c6aa07e013c7dc86ba361226429ab016d1da1ad50b9c75d7503e6868be
-  data.tar.gz: 1b5e77e6973b1a7d17ce11b8ac2b8b990053b10a829a1f3ef9ee49416b7f433042537974bce4add5ea879bc64e7337964069114a96bf9b0f4251f215a7c6038f
+  metadata.gz: 4cfba176f4db94be5cda8b7ee7c309f0271b8c686598b4299493d4f8c90dacf10d5ffda16f185f94e1fac5096b1be9c6f4b6a2303b7bdb8b08570da6a11e0e2b
+  data.tar.gz: a2f5c8ef56b473919dcd932f1e50ca47eb23729a9d09796a84f0c8396da451e11b791369f8fd41f8a5030a7b4d2f2a6ef4a27487bcc1d438a30431714a1ca419

data/.coveralls.yml

@@ -0,0 +1 @@
+service_name: travis-ci

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+rvm:
+- 1.9.3
+- 2.0.0

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+# Changelog
+
+## v0.0.1
+
+* Initial release; Implement basic feature
+  * `ghi list`
+  * `ghi list user/repo`
+  * `ghi --open list` open notifications in browser
+  * `ghi --mark-as-read` mark notifications as read
+  * `ghi --help` show help message
+* Create project page

data/README.md

@@ -1,5 +1,7 @@
 # Ghn
 
+[![Build Status](https://travis-ci.org/kyanny/ghn.png?branch=master)](https://travis-ci.org/kyanny/ghn) [![Coverage Status](https://coveralls.io/repos/kyanny/ghn/badge.png?branch=master)](https://coveralls.io/r/kyanny/ghn?branch=master) [![Code Climate](https://codeclimate.com/github/kyanny/ghn.png)](https://codeclimate.com/github/kyanny/ghn)
+
 Commandline tool for GitHub notifications.
 
 ## Installation

data/Rakefile

@@ -1 +1,5 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new("spec")
+task :default => :spec

data/bin/ghn

@@ -3,50 +3,21 @@ $LOAD_PATH << File.join(__dir__, '..', 'lib')
 require 'ghn'
 require 'optparse'
 
-auth_error_message = <<EOM
-Authorization required.
-
-Please set ghn.token to your .gitconfig.
-    $ git config --global ghn.token [Your GitHub access token]
-EOM
-
-usage = <<USAGE
-Usage: #{File.basename $0} [options] [command] [user/repo]
-    options:   --open           Open notifications in browser
-               --mark-as-read   Mark as read listed notifications
-
-    command:   list             List unread notifications
-
-    user/repo: GitHub user and repository (e.g. github/hubot)
-               You can specify it to narrow down target notifications
-
-USAGE
-
-access_token = ENV['ACCESS_TOKEN'] || `git config ghn.token`.chomp
-if access_token.nil? || access_token.empty?
-  puts auth_error_message; exit!
+token = Ghn::Token.new
+unless token.valid?
+  token.print_no_access_token_exit!
 end
-ghn = Ghn.new(access_token)
 
-opts = OptionParser.new
-opts.on('--open', 'Open notifications in browser') { |v| ghn.open_browser = true }
-opts.on('--mark-as-read', 'Mark as read notifications') { |v| ghn.mark_as_read = true }
-opts.on('-h', '--help') { puts usage; exit }
-opts.on('--usage') { puts usage; exit}
-opts.parse!
-
-if ghn.open_browser?
-  ghn.mark_as_read = false
+options = Ghn::Options.new(ARGV.getopts(Ghn::Options.short_options, *Ghn::Options.long_options))
+if options.open_browser?
+  options.mark_as_read = false
 end
 
-if ARGV.first != 'list'
-  puts usage; exit
+command = Ghn::Command.new(ARGV)
+unless command.valid?
+  command.print_invalid
+  Ghn::Options.print_usage_exit
 end
 
-ghn.send(*ARGV).each do |notification|
-  if ghn.open_browser?
-    system "open #{notification}"
-  else
-    puts notification
-  end
-end
+ghn = Ghn.new(token, command, options)
+ghn.run_print

data/ghn.gemspec

@@ -22,4 +22,6 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "coveralls"
 end

data/lib/ghn/command.rb

@@ -0,0 +1,46 @@
+class Ghn
+  class Command
+    def self.commands
+      ['list']
+    end
+
+    attr_reader :command
+    attr_reader :args
+
+    def initialize(argv)
+      @argv = argv
+      @valid = false
+      process!
+    end
+
+    def process!
+      @command = @argv.first
+      if self.class.commands.include?(@command)
+        @valid = true
+        @args = @argv.drop(1)
+      else
+        @valid = false
+      end
+    end
+
+    def valid?
+      !!@valid
+    end
+
+    def print_invalid
+      if @command.nil? || @command.empty?
+        print_empty_command
+      else
+        print_invalid_command
+      end
+    end
+
+    def print_empty_command
+      puts "** No command"
+    end
+
+    def print_invalid_command
+      puts "** Invalid command `#{@command}`"
+    end
+  end
+end

data/lib/ghn/options.rb

@@ -0,0 +1,58 @@
+require 'hashie/mash'
+
+class Ghn
+  class Options < Hashie::Mash
+    def open_browser=(bool)
+      @open_browser = bool
+    end
+
+    def open_browser?
+      !!(@open_browser || self['o'] || self['open'])
+    end
+
+    def mark_as_read=(bool)
+      @mark_as_read = bool
+    end
+
+    def mark_as_read?
+      !!(@mark_as_read || self['m'] || self['mark-as-read'])
+    end
+
+    def help?
+      !!(self['h'] || self['help'])
+    end
+
+    class << self
+      def short_options
+        'omnh'
+      end
+
+      def long_options
+        ['open', 'mark-as-read']
+      end
+
+      def usage
+        <<-USAGE
+Usage: #{File.basename $0} [options] [command] [user/repo]
+    options:   --open           Open notifications in browser
+               --mark-as-read   Mark as read listed notifications
+
+    command:   list             List unread notifications
+
+    user/repo: GitHub user and repository (e.g. github/hubot)
+               You can specify it to narrow down target notifications
+
+        USAGE
+      end
+
+      def print_usage
+        puts usage
+      end
+
+      def print_usage_exit
+        print_usage
+        exit
+      end
+    end
+  end
+end

data/lib/ghn/token.rb

@@ -0,0 +1,39 @@
+class Ghn
+  class Token
+    attr_reader :token
+
+    def initialize
+      @valid = false
+      process!
+    end
+
+    def process!
+      @token = ENV['ACCESS_TOKEN'] || `git config ghn.token`.chomp
+
+      if @token.nil? || @token.empty?
+        @valid = false
+      else
+        @valid = true
+      end
+    end
+
+    def valid?
+      !!@valid
+    end
+
+    def print_no_access_token
+      puts <<MESSAGE
+** Authorization required.
+
+Please set ghn.token to your .gitconfig.
+    $ git config --global ghn.token [Your GitHub access token]
+
+MESSAGE
+    end
+
+    def print_no_access_token_exit!
+      print_no_access_token
+      exit!
+    end
+  end
+end

data/lib/ghn/version.rb

@@ -1,3 +1,3 @@
 class Ghn
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/ghn.rb

@@ -1,17 +1,32 @@
-require "ghn/version"
+require 'ghn/version'
+require 'ghn/token'
+require 'ghn/options'
+require 'ghn/command'
 require 'github_api'
 
 class Ghn
-  attr_accessor :open_browser, :mark_as_read
-  alias_method :open_browser?, :open_browser
-  alias_method :mark_as_read?, :mark_as_read
+  def initialize(token, command, options)
+    @token = token
+    @command = command
+    @options = options
+  end
+
+  def run
+    send(@command.command, *@command.args)
+  end
 
-  def initialize(access_token)
-    @access_token = access_token
+  def run_print
+    run.each do |notification|
+      if @options.open_browser?
+        system "open #{notification}"
+      else
+        puts notification
+      end
+    end
   end
 
   def client
-    @client ||= Github.new(oauth_token: @access_token)
+    @client ||= Github.new(oauth_token: @token.token)
   end
 
   def list(target = nil)
@@ -27,7 +42,7 @@ class Ghn
                      else
                        ['issues', notification.subject.url.match(/[^\/]+\z/).to_a.first]
                      end
-      if mark_as_read?
+      if @options.mark_as_read?
         self.mark(notification.id)
         "[x] https://github.com/#{repo}/#{type}/#{number}"
       else

data/spec/lib/ghn_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Ghn do
+  let(:token) { double }
+  let(:command) { double }
+  let(:options) { double }
+
+  describe '#initialize' do
+    context 'if no arguments is passed' do
+      it 'should raise error' do
+        expect { described_class.new }.to raise_error
+      end
+    end
+
+    context 'if token, command and options argument is passed' do
+      it 'should not raise error' do
+        expect { described_class.new(token, command, options) }.to_not raise_error
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,19 @@
+require 'rspec'
+
+require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start do
+  add_filter '.bundle/'
+end
+
+require 'securerandom'
+
+require 'ghn'
+
+RSpec.configure do |config|
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ghn
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Kensuke Nagae
@@ -52,6 +52,34 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Commandline tool for GitHub notifications
 email:
 - kyanny@gmail.com
@@ -60,7 +88,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- .coveralls.yml
 - .gitignore
+- .travis.yml
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -68,7 +99,12 @@ files:
 - bin/ghn
 - ghn.gemspec
 - lib/ghn.rb
+- lib/ghn/command.rb
+- lib/ghn/options.rb
+- lib/ghn/token.rb
 - lib/ghn/version.rb
+- spec/lib/ghn_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/kyanny/ghn
 licenses:
 - MIT
@@ -94,4 +130,6 @@ signing_key:
 specification_version: 4
 summary: Ghn is a commandline tool for GitHub notifications. You can listup all unread
   notifications and mark them as read.
-test_files: []
+test_files:
+- spec/lib/ghn_spec.rb
+- spec/spec_helper.rb