gherkin_lint 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 55e2f43b28308b30833c2b07a91ae28e8074c6d6
-  data.tar.gz: 6a3c3f5df11ae6f61fc79a50c03a53a3838aeeb2
+  metadata.gz: 909ea2a079a8f31e840ca9c4dc10559e88e1f8bd
+  data.tar.gz: c343b5aa43e0c930b9080de3b4885080c00436ec
 SHA512:
-  metadata.gz: e4e3dd19a9559351279e7765618324381513d88e807e7e12f8de3ee8278190641833881432a50d20df19adc6d0358a2641beb874c085df8b24064f0aa5ea1c60
-  data.tar.gz: 94cbc13a038fefa351f0e18ca93fdd783135f2a15d31d1afdfc86c8f5368098c4395492450394fa2e284e59a2017c2492ac83f82914503abe87a99e5e4254ac4
+  metadata.gz: 5bb488ace7530e0174c56fac9f0a2417662d3f2046dd063aae55d90b3553ae383c032ade3276db80899a6bda369c2f998f64b55262482502ac788f117f1359cc
+  data.tar.gz: b32dfc103df0d73c7dfcec87c9fed96548c5d593261cad1146de8c48390b4a9806c166f1b35033f1a44c713516bf285f6855d0ea2f0258ca5eee34c3bc80de1d

data/README.md

@@ -36,6 +36,7 @@ Detailed usage within the [disable_tags](https://github.com/funkwerk/gherkin_lin
  - [missing test action](https://github.com/funkwerk/gherkin_lint/blob/master/features/missing_test_action.feature)
  - [missing verification](https://github.com/funkwerk/gherkin_lint/blob/master/features/missing_verification.feature)
  - [same tag for all scenarios](https://github.com/funkwerk/gherkin_lint/blob/master/features/same_tag_for_all_scenarios.feature)
+ - [tag used multiple times](https://github.com/funkwerk/gherkin_lint/blob/master/features/tag_used_multiple_times.feature)
  - [too clumsy](https://github.com/funkwerk/gherkin_lint/blob/master/features/too_clumsy.feature)
  - [too long step](https://github.com/funkwerk/gherkin_lint/blob/master/features/too_long_step.feature)
  - [too many different tags](https://github.com/funkwerk/gherkin_lint/blob/master/features/too_many_different_tags.feature)

data/Rakefile

@@ -11,7 +11,7 @@ end
 
 desc 'Publishes the Gem'
 task :push do
-  sh 'gem push gherkin_lint-0.5.0.gem'
+  sh 'gem push gherkin_lint-0.6.0.gem'
 end
 
 desc 'Checks ruby style'

data/features/tag_used_multiple_times.feature

@@ -0,0 +1,51 @@
+Feature: Tag Used Multiple Times
+  As a Business Analyst
+  I want to use tags just once
+  so that redundancy is minimized.
+
+  Background: Prepare Testee
+    Given a file named "lint.rb" with:
+      """
+      $LOAD_PATH << '../../lib'
+      require 'gherkin_lint'
+
+      linter = GherkinLint::GherkinLint.new
+      linter.enable %w(TagUsedMultipleTimes)
+      linter.analyze 'lint.feature'
+      exit linter.report
+
+      """
+
+  Scenario Outline: Tag used twice
+    Given a file named "lint.feature" with:
+      """
+      <feature tag>
+      Feature: Test
+        @tag <scenario tag>
+        Scenario: A
+      """
+    When I run `ruby lint.rb`
+    Then it should fail with exactly:
+      """
+      TagUsedMultipleTimes - Tag @tag used multiple times
+        lint.feature (4): Test.A
+
+      """
+     
+    Examples: Invalid Tag Combinations
+      | feature tag | scenario tag |
+      | @tag        |              |
+      |             | @tag         |
+
+  Scenario: Just unique tags
+    Given a file named "lint.feature" with:
+      """
+      Feature: Test
+        @tag_a @tag_b
+        Scenario: A
+      """
+    When I run `ruby lint.rb`
+    Then it should pass with exactly:
+      """
+
+      """

data/gherkin_lint.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name        = 'gherkin_lint'
-  s.version     = '0.5.0'
-  s.date        = '2016-08-31'
+  s.version     = '0.6.0'
+  s.date        = '2016-10-14'
   s.summary     = 'Gherkin Lint'
   s.description = 'Lint Gherkin Files'
   s.authors     = ['Stefan Rohe']

data/lib/gherkin_lint.rb

@@ -18,6 +18,7 @@ require 'gherkin_lint/linter/missing_scenario_name'
 require 'gherkin_lint/linter/missing_test_action'
 require 'gherkin_lint/linter/missing_verification'
 require 'gherkin_lint/linter/same_tag_for_all_scenarios'
+require 'gherkin_lint/linter/tag_used_multiple_times'
 require 'gherkin_lint/linter/too_clumsy'
 require 'gherkin_lint/linter/too_long_step'
 require 'gherkin_lint/linter/too_many_different_tags'
@@ -52,6 +53,7 @@ module GherkinLint
       InvalidFileName,
       InvalidStepFlow,
       SameTagForAllScenarios,
+      TagUsedMultipleTimes,
       TooClumsy,
       TooManyDifferentTags,
       TooManySteps,

data/lib/gherkin_lint/linter/tag_used_multiple_times.rb

@@ -0,0 +1,21 @@
+require 'gherkin_lint/linter'
+
+module GherkinLint
+  # service class to lint for tags used multiple times
+  class TagUsedMultipleTimes < Linter
+    def lint
+      scenarios do |file, feature, scenario|
+        references = [reference(file, feature, scenario)]
+        total_tags = tags(feature) + tags(scenario)
+        double_used_tags = total_tags.find_all { |a| total_tags.count(a) > 1 }.uniq!
+        next if double_used_tags.nil?
+        add_error(references, "Tag #{double_used_tags.join(' and ')} used multiple times")
+      end
+    end
+
+    def tags(element)
+      return [] unless element.include? :tags
+      element[:tags].map { |a| a[:name] }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gherkin_lint
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Stefan Rohe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-31 00:00:00.000000000 Z
+date: 2016-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
@@ -115,6 +115,7 @@ files:
 - features/missing_verification.feature
 - features/same_tag_for_all_scenarios.feature
 - features/support/env.rb
+- features/tag_used_multiple_times.feature
 - features/too_clumsy.feature
 - features/too_long_step.feature
 - features/too_many_different_tags.feature
@@ -146,6 +147,7 @@ files:
 - lib/gherkin_lint/linter/missing_test_action.rb
 - lib/gherkin_lint/linter/missing_verification.rb
 - lib/gherkin_lint/linter/same_tag_for_all_scenarios.rb
+- lib/gherkin_lint/linter/tag_used_multiple_times.rb
 - lib/gherkin_lint/linter/too_clumsy.rb
 - lib/gherkin_lint/linter/too_long_step.rb
 - lib/gherkin_lint/linter/too_many_different_tags.rb